PandacubeFr/BungeeCord
1
0
Fork 0
Code Releases Activity

#3186: Replace String.format calls in exceptions with simple string concats

Browse Source
This commit is contained in:
Janmm14 2021-09-17 18:14:21 +10:00 committed by md_5
parent 9953698a7c
commit 06bf088d27
No known key found for this signature in database
GPG Key ID: E8E901AC7C617C11
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
chat/src/main/java/net/md_5/bungee/api/chat/TextComponent.java
View File

@ -230,6 +230,6 @@ public final class TextComponent extends BaseComponent
@Override @Override
public String toString() public String toString()
{ {
return String.format( "TextComponent{text=%s, %s}", text, super.toString() ); return "TextComponent{text=" + text + ", " + super.toString() + '}';
} }
} }

10
protocol/src/main/java/net/md_5/bungee/protocol/DefinedPacket.java
View File

@ -23,7 +23,7 @@ public abstract class DefinedPacket
{ {
if ( s.length() > Short.MAX_VALUE ) if ( s.length() > Short.MAX_VALUE )
{ {
throw new OverflowPacketException( String.format( "Cannot send string longer than Short.MAX_VALUE (got %s characters)", s.length() ) ); throw new OverflowPacketException( "Cannot send string longer than Short.MAX_VALUE (got " + s.length() + " characters)" );
} }
byte[] b = s.getBytes( Charsets.UTF_8 ); byte[] b = s.getBytes( Charsets.UTF_8 );
@ -41,7 +41,7 @@ public abstract class DefinedPacket
int len = readVarInt( buf ); int len = readVarInt( buf );
if ( len > maxLen * 4 ) if ( len > maxLen * 4 )
{ {
throw new OverflowPacketException( String.format( "Cannot receive string longer than %d (got %d bytes)", maxLen * 4, len ) ); throw new OverflowPacketException( "Cannot receive string longer than " + maxLen * 4 + " (got " + len + " bytes)" );
} }
byte[] b = new byte[ len ]; byte[] b = new byte[ len ];
@ -50,7 +50,7 @@ public abstract class DefinedPacket
String s = new String( b, Charsets.UTF_8 ); String s = new String( b, Charsets.UTF_8 );
if ( s.length() > maxLen ) if ( s.length() > maxLen )
{ {
throw new OverflowPacketException( String.format( "Cannot receive string longer than %d (got %d characters)", maxLen, s.length() ) ); throw new OverflowPacketException( "Cannot receive string longer than " + maxLen + " (got " + s.length() + " characters)" );
} }
return s; return s;
@ -60,7 +60,7 @@ public abstract class DefinedPacket
{ {
if ( b.length > Short.MAX_VALUE ) if ( b.length > Short.MAX_VALUE )
{ {
throw new OverflowPacketException( String.format( "Cannot send byte array longer than Short.MAX_VALUE (got %s bytes)", b.length ) ); throw new OverflowPacketException( "Cannot send byte array longer than Short.MAX_VALUE (got " + b.length + " bytes)" );
} }
writeVarInt( b.length, buf ); writeVarInt( b.length, buf );
buf.writeBytes( b ); buf.writeBytes( b );
@ -84,7 +84,7 @@ public abstract class DefinedPacket
int len = readVarInt( buf ); int len = readVarInt( buf );
if ( len > limit ) if ( len > limit )
{ {
throw new OverflowPacketException( String.format( "Cannot receive byte array longer than %s (got %s bytes)", limit, len ) ); throw new OverflowPacketException( "Cannot receive byte array longer than " + limit + " (got " + len + " bytes)" );
} }
byte[] ret = new byte[ len ]; byte[] ret = new byte[ len ];
buf.readBytes( ret ); buf.readBytes( ret );

2
proxy/src/main/java/net/md_5/bungee/scheduler/BungeeTask.java
View File

@ -63,7 +63,7 @@ public class BungeeTask implements Runnable, ScheduledTask
task.run(); task.run();
} catch ( Throwable t ) } catch ( Throwable t )
{ {
ProxyServer.getInstance().getLogger().log( Level.SEVERE, String.format( "Task %s encountered an exception", this ), t ); ProxyServer.getInstance().getLogger().log( Level.SEVERE, "Task " + this + " encountered an exception", t );
} }
// If we have a period of 0 or less, only run once // If we have a period of 0 or less, only run once