Correct component loop detector

api/src/main/java/net/md_5/bungee/chat/BaseComponentSerializer.java

@@ -10,6 +10,7 @@ import net.md_5.bungee.api.chat.ClickEvent;
 import net.md_5.bungee.api.chat.HoverEvent;
 
 import java.util.Arrays;
+import java.util.HashSet;
 
 public class BaseComponentSerializer
 {
@@ -72,6 +73,13 @@ public class BaseComponentSerializer
     }
 
     protected void serialize(JsonObject object, BaseComponent component, JsonSerializationContext context)
+    {
+        boolean first = false;
+        if ( ComponentSerializer.serializedComponents.get() == null ) {
+            first = true;
+            ComponentSerializer.serializedComponents.set( new HashSet<BaseComponent>(  ) );
+        }
+        try
         {
             Preconditions.checkArgument( !ComponentSerializer.serializedComponents.get().contains( component ), "Component loop" );
             ComponentSerializer.serializedComponents.get().add( component );
@@ -120,5 +128,12 @@ public class BaseComponentSerializer
                 hoverEvent.add( "value", context.serialize( component.getHoverEvent().getValue() ) );
                 object.add( "hoverEvent", hoverEvent );
             }
+        } finally
+        {
+            ComponentSerializer.serializedComponents.get().remove( component );
+            if (first) {
+                ComponentSerializer.serializedComponents.set( null );
+            }
+        }
     }
 }

api/src/main/java/net/md_5/bungee/chat/ComponentSerializer.java

@@ -16,7 +16,7 @@ import net.md_5.bungee.api.chat.TranslatableComponent;
 import java.lang.reflect.Type;
 import java.util.HashSet;
 
-public class ComponentSerializer implements JsonSerializer<BaseComponent>, JsonDeserializer<BaseComponent>
+public class ComponentSerializer implements JsonDeserializer<BaseComponent>
 {
 
     private final static Gson gson = new GsonBuilder().
@@ -25,14 +25,7 @@ public class ComponentSerializer implements JsonSerializer<BaseComponent>, JsonD
             registerTypeAdapter( TranslatableComponent.class, new TranslatableComponentSerializer() ).
             create();
 
-    public final static ThreadLocal<HashSet<BaseComponent>> serializedComponents = new ThreadLocal<HashSet<BaseComponent>>()
+    public final static ThreadLocal<HashSet<BaseComponent>> serializedComponents = new ThreadLocal<>();
-    {
-        @Override
-        protected HashSet<BaseComponent> initialValue()
-        {
-            return new HashSet<>();
-        }
-    };
 
     public static BaseComponent[] parse(String json)
     {
@@ -70,15 +63,4 @@ public class ComponentSerializer implements JsonSerializer<BaseComponent>, JsonD
         }
         return context.deserialize( json, TextComponent.class );
     }
-
-    @Override
-    public JsonElement serialize(BaseComponent src, Type typeOfSrc, JsonSerializationContext context)
-    {
-        try {
-            return context.serialize( src, src.getClass() );
-        } finally
-        {
-            serializedComponents.get().clear();
-        }
-    }
 }

proxy/src/test/java/net/md_5/bungee/chat/ComponentsTest.java

@@ -81,21 +81,50 @@ public class ComponentsTest
     }
 
     @Test(expected = IllegalArgumentException.class)
-    public void testLoopSimple() {
+    public void testLoopSimple()
+    {
         TextComponent component = new TextComponent( "Testing" );
         component.addExtra( component );
         ComponentSerializer.toString( component );
     }
 
     @Test(expected = IllegalArgumentException.class)
-    public void testLoopComplex() {
+    public void testLoopComplex()
+    {
         TextComponent a = new TextComponent( "A" );
         TextComponent b = new TextComponent( "B" );
+        b.setColor( ChatColor.AQUA );
         TextComponent c = new TextComponent( "C" );
+        c.setColor( ChatColor.RED );
         a.addExtra( b );
         b.addExtra( c );
         c.addExtra( a );
         ComponentSerializer.toString( a );
     }
 
+    @Test
+    public void testRepeated()
+    {
+        TextComponent a = new TextComponent( "A" );
+        TextComponent b = new TextComponent( "B" );
+        b.setColor( ChatColor.AQUA );
+        a.addExtra( b );
+        a.addExtra( b );
+        ComponentSerializer.toString( a );
+    }
+
+    @Test(expected = IllegalArgumentException.class)
+    public void testRepeatedError()
+    {
+        TextComponent a = new TextComponent( "A" );
+        TextComponent b = new TextComponent( "B" );
+        b.setColor( ChatColor.AQUA );
+        TextComponent c = new TextComponent( "C" );
+        c.setColor( ChatColor.RED );
+        a.addExtra( b );
+        a.addExtra( c );
+        c.addExtra( a );
+        a.addExtra( b );
+        ComponentSerializer.toString( a );
+    }
 }