PandacubeFr/BungeeCord
1
0
Fork 0
Code Releases Activity

#3268: Correct plugin message size check

Browse Source
This commit is contained in:
Outfluencer 2022-03-19 10:03:29 +11:00 committed by md_5
parent 978e68fc74
commit 410f64bc9f
No known key found for this signature in database
GPG Key ID: E8E901AC7C617C11
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
protocol/src/main/java/net/md_5/bungee/protocol/packet/PluginMessage.java
View File

@ -60,8 +60,8 @@ public class PluginMessage extends DefinedPacket
public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion) public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
{ {
tag = ( protocolVersion >= ProtocolConstants.MINECRAFT_1_13 ) ? MODERNISE.apply( readString( buf ) ) : readString( buf, 20 ); tag = ( protocolVersion >= ProtocolConstants.MINECRAFT_1_13 ) ? MODERNISE.apply( readString( buf ) ) : readString( buf, 20 );
int maxSize = direction == ProtocolConstants.Direction.TO_SERVER ? Short.MAX_VALUE : 0x100000; int maxSize = ( direction == ProtocolConstants.Direction.TO_SERVER ) ? Short.MAX_VALUE : 0x100000;
Preconditions.checkArgument( buf.readableBytes() < maxSize ); Preconditions.checkArgument( buf.readableBytes() <= maxSize, "Payload too large" );
data = new byte[ buf.readableBytes() ]; data = new byte[ buf.readableBytes() ];
buf.readBytes( data ); buf.readBytes( data );
} }