PandacubeFr/BungeeCord
1
0
Fork 0
Code Releases Activity

#2740: Fix BaseComponent#equals() stack overflow

Browse Source
This commit is contained in:
CertainLach 2020-01-05 10:44:16 +11:00 committed by md_5
parent d2ceccd646
commit 465215686b
2 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
chat/src/main/java/net/md_5/bungee/api/chat/BaseComponent.java
View File

@ -13,7 +13,7 @@ import net.md_5.bungee.api.chat.ComponentBuilder.FormatRetention;
@Setter @Setter
@ToString(exclude = "parent") @ToString(exclude = "parent")
@EqualsAndHashCode @EqualsAndHashCode(exclude = "parent")
@NoArgsConstructor @NoArgsConstructor
public abstract class BaseComponent public abstract class BaseComponent
{ {

24
chat/src/test/java/net/md_5/bungee/api/chat/ComponentsTest.java
View File

@ -409,6 +409,30 @@ public class ComponentsTest
Assert.assertEquals( text, roundtripLegacyText ); Assert.assertEquals( text, roundtripLegacyText );
} }
@Test
public void testEquals()
{
TextComponent first = new TextComponent( "Hello, " );
first.addExtra( new TextComponent( "World!" ) );
TextComponent second = new TextComponent( "Hello, " );
second.addExtra( new TextComponent( "World!" ) );
Assert.assertEquals( first, second );
}
@Test
public void testNotEquals()
{
TextComponent first = new TextComponent( "Hello, " );
first.addExtra( new TextComponent( "World." ) );
TextComponent second = new TextComponent( "Hello, " );
second.addExtra( new TextComponent( "World!" ) );
Assert.assertNotEquals( first, second );
}
private String fromAndToLegacyText(String legacyText) private String fromAndToLegacyText(String legacyText)
{ {
return BaseComponent.toLegacyText( TextComponent.fromLegacyText( legacyText ) ); return BaseComponent.toLegacyText( TextComponent.fromLegacyText( legacyText ) );