From 70038c91442eeba7b96ec065491f57201805beac Mon Sep 17 00:00:00 2001 From: md_5 Date: Thu, 5 Dec 2019 12:28:12 +1100 Subject: [PATCH] Revert "#2714: Remove unnecessary throws in ServerConnector" This reverts commit 74a6aa32a2afb9f7fbf9d8626a7622c467cf47ce. Completely breaks Bungee --- .../main/java/net/md_5/bungee/ServerConnector.java | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/proxy/src/main/java/net/md_5/bungee/ServerConnector.java b/proxy/src/main/java/net/md_5/bungee/ServerConnector.java index 78b60589..552af4fc 100644 --- a/proxy/src/main/java/net/md_5/bungee/ServerConnector.java +++ b/proxy/src/main/java/net/md_5/bungee/ServerConnector.java @@ -21,6 +21,7 @@ import net.md_5.bungee.api.score.Score; import net.md_5.bungee.api.score.Scoreboard; import net.md_5.bungee.api.score.Team; import net.md_5.bungee.chat.ComponentSerializer; +import net.md_5.bungee.connection.CancelSendSignal; import net.md_5.bungee.connection.DownstreamBridge; import net.md_5.bungee.connection.LoginResult; import net.md_5.bungee.forge.ForgeConstants; @@ -158,6 +159,8 @@ public class ServerConnector extends PacketHandler { user.getForgeClientHandler().resetHandshake(); } + + throw CancelSendSignal.INSTANCE; } @Override @@ -288,6 +291,8 @@ public class ServerConnector extends PacketHandler bungee.getPluginManager().callEvent( new ServerSwitchEvent( user ) ); thisState = State.FINISHED; + + throw CancelSendSignal.INSTANCE; } @Override @@ -311,7 +316,7 @@ public class ServerConnector extends PacketHandler { obsolete = true; user.connect( event.getCancelServer(), ServerConnectEvent.Reason.KICK_REDIRECT ); - return; + throw CancelSendSignal.INSTANCE; } String message = bungee.getTranslation( "connect_kick", target.getName(), event.getKickReason() ); @@ -322,6 +327,8 @@ public class ServerConnector extends PacketHandler { user.sendMessage( message ); } + + throw CancelSendSignal.INSTANCE; } @Override @@ -363,7 +370,7 @@ public class ServerConnector extends PacketHandler this.handshakeHandler.handle( pluginMessage ); // We send the message as part of the handler, so don't send it here. - return; + throw CancelSendSignal.INSTANCE; } }