From 83e3f998c6ec5c2c72cf62b3a86ba8d3dfe50c93 Mon Sep 17 00:00:00 2001 From: Shevchik Date: Mon, 16 Dec 2013 23:02:31 +0400 Subject: [PATCH] Move player sit operations to its own class --- src/com/cnaude/chairs/ChairEffects.java | 3 +- src/com/cnaude/chairs/Chairs.java | 146 ++-------------- src/com/cnaude/chairs/CommandRestrict.java | 2 +- src/com/cnaude/chairs/PlayerSitData.java | 159 ++++++++++++++++++ .../cnaude/chairs/TrySitEventListener.java | 8 +- .../cnaude/chairs/TryUnsitEventListener.java | 20 +-- 6 files changed, 187 insertions(+), 151 deletions(-) create mode 100644 src/com/cnaude/chairs/PlayerSitData.java diff --git a/src/com/cnaude/chairs/ChairEffects.java b/src/com/cnaude/chairs/ChairEffects.java index dad6a22..66ec1e3 100644 --- a/src/com/cnaude/chairs/ChairEffects.java +++ b/src/com/cnaude/chairs/ChairEffects.java @@ -36,8 +36,7 @@ public class ChairEffects { @Override public void run() { for (Player p : Bukkit.getOnlinePlayers()) { - String pName = p.getName(); - if (plugin.sit.containsKey(pName)) { + if (plugin.getPlayerSitData().isSitting(p)) { if (p.hasPermission("chairs.sit.health")) { double pHealthPcnt = ((double) p.getHealth()) / (double) p.getMaxHealth() * 100d; if ((pHealthPcnt < plugin.sitMaxHealth) && (p.getHealth() < p.getMaxHealth())) { diff --git a/src/com/cnaude/chairs/Chairs.java b/src/com/cnaude/chairs/Chairs.java index 06eefa2..21ad730 100644 --- a/src/com/cnaude/chairs/Chairs.java +++ b/src/com/cnaude/chairs/Chairs.java @@ -1,27 +1,20 @@ package com.cnaude.chairs; import java.io.File; -import java.lang.reflect.Constructor; -import java.lang.reflect.Field; -import java.lang.reflect.InvocationTargetException; import java.lang.reflect.Method; import java.util.ArrayList; -import java.util.HashMap; import java.util.HashSet; import java.util.List; import java.util.logging.Level; import java.util.logging.Logger; -import org.bukkit.Bukkit; import org.bukkit.ChatColor; import org.bukkit.Location; import org.bukkit.Material; import org.bukkit.World; -import org.bukkit.block.Block; import org.bukkit.configuration.file.FileConfiguration; import org.bukkit.configuration.file.YamlConfiguration; import org.bukkit.entity.Arrow; -import org.bukkit.entity.Entity; import org.bukkit.entity.Player; import org.bukkit.plugin.java.JavaPlugin; import org.bukkit.util.Vector; @@ -45,7 +38,14 @@ public class Chairs extends JavaPlugin { public ChairsIgnoreList ignoreList; public String msgSitting, msgStanding, msgOccupied, msgNoPerm, msgReloaded, msgDisabled, msgEnabled, msgCommandRestricted; - private Class vehiclearrowclass; + + + private PlayerSitData psitdata; + protected PlayerSitData getPlayerSitData() + { + return psitdata; + } + protected Class vehiclearrowclass; @Override public void onEnable() { @@ -71,6 +71,7 @@ public class Chairs extends JavaPlugin { getConfig().options().copyDefaults(true); saveConfig(); loadConfig(); + psitdata = new PlayerSitData(this); getServer().getPluginManager().registerEvents(new TrySitEventListener(this, ignoreList), this); getServer().getPluginManager().registerEvents(new TryUnsitEventListener(this), this); getServer().getPluginManager().registerEvents(new CommandRestrict(this), this); @@ -80,8 +81,8 @@ public class Chairs extends JavaPlugin { @Override public void onDisable() { for (Player player : getServer().getOnlinePlayers()) { - if (sit.containsKey(player.getName())) { - unSitPlayer(player, false, true); + if (psitdata.isSitting(player)) { + psitdata.unSitPlayer(player, false, true); } } if (ignoreList != null) { @@ -100,130 +101,7 @@ public class Chairs extends JavaPlugin { } } - protected HashMap sit = new HashMap(); - protected HashMap sitblock = new HashMap(); - protected HashMap sitblockbr = new HashMap(); - protected HashMap sitstopteleportloc = new HashMap(); - protected HashMap sittask = new HashMap(); - protected void sitPlayer(Player player, Location sitlocation) - { - try { - if (notifyplayer && !msgSitting.isEmpty()) - { - player.sendMessage(msgSitting); - } - Block block = sitlocation.getBlock(); - sitstopteleportloc.put(player.getName(), player.getLocation()); - player.teleport(sitlocation); - Location arrowloc = block.getLocation().add(0.5, 0 , 0.5); - Entity arrow = sitPlayerOnArrow(player, arrowloc); - sit.put(player.getName(), arrow); - sitblock.put(block, player.getName()); - sitblockbr.put(player.getName(), block); - startReSitTask(player); - } catch (Exception e) { - e.printStackTrace(); - } - } - protected void startReSitTask(final Player player) - { - int task = - Bukkit.getScheduler().scheduleSyncRepeatingTask(this, new Runnable() - { - public void run() - { - reSitPlayer(player); - } - },1000,1000); - sittask.put(player.getName(), task); - } - protected void reSitPlayer(final Player player) - { - try { - final Entity prevarrow = sit.get(player.getName()); - sit.remove(player.getName()); - player.eject(); - Block block = sitblockbr.get(player.getName()); - Location arrowloc = block.getLocation().add(0.5, 0 , 0.5); - Entity arrow = sitPlayerOnArrow(player, arrowloc); - sit.put(player.getName(), arrow); - Bukkit.getScheduler().scheduleSyncDelayedTask(this, new Runnable() - { - public void run() - { - prevarrow.remove(); - } - },100); - } catch (Exception e) { - e.printStackTrace(); - } - } - private Entity sitPlayerOnArrow(Player player, Location arrowloc) throws NoSuchMethodException, SecurityException, NoSuchFieldException, IllegalArgumentException, IllegalAccessException, InstantiationException, InvocationTargetException - { - Entity arrow = player.getWorld().spawnArrow(arrowloc, new Vector(0, 0.1 ,0), 0, 0); - Method getHandleMethod = arrow.getClass().getDeclaredMethod("getHandle"); - getHandleMethod.setAccessible(true); - Object nmsarrow = getHandleMethod.invoke(arrow); - Field bukkitEntityField = nmsarrow.getClass().getSuperclass().getDeclaredField("bukkitEntity"); - bukkitEntityField.setAccessible(true); - Constructor ctor = vehiclearrowclass.getDeclaredConstructor(this.getServer().getClass(), nmsarrow.getClass()); - ctor.setAccessible(true); - Object vehiclearrow = ctor.newInstance(this.getServer(), nmsarrow); - bukkitEntityField.set(nmsarrow, vehiclearrow); - arrow.setPassenger(player); - return arrow; - } - protected void unSitPlayer(final Player player, boolean restoreposition, boolean correctnmspostion) - { - final Entity arrow = sit.get(player.getName()); - sit.remove(player.getName()); - player.eject(); - arrow.remove(); - final Location tploc = sitstopteleportloc.get(player.getName()); - if (restoreposition) - { - Bukkit.getScheduler().scheduleSyncDelayedTask(this, new Runnable() - { - public void run() - { - player.teleport(tploc); - player.setSneaking(false); - } - },1); - } else - { - if (correctnmspostion) - { - try { - Method getHandleMethod = player.getClass().getDeclaredMethod("getHandle"); - getHandleMethod.setAccessible(true); - Object nmsPlayer = getHandleMethod.invoke(player); - Class entityClass = nmsPlayer.getClass().getSuperclass().getSuperclass().getSuperclass(); - Field locXField = entityClass.getDeclaredField("locX"); - locXField.setAccessible(true); - locXField.set(nmsPlayer, tploc.getX()); - Field locYField = entityClass.getDeclaredField("locY"); - locYField.setAccessible(true); - locYField.set(nmsPlayer, tploc.getY()); - Field locZField = entityClass.getDeclaredField("locZ"); - locZField.setAccessible(true); - locZField.set(nmsPlayer, tploc.getZ()); - } catch (Exception e) { - e.printStackTrace(); - } - } - } - sitblock.remove(sitblockbr.get(player.getName())); - sitblockbr.remove(player.getName()); - sitstopteleportloc.remove(player.getName()); - Bukkit.getScheduler().cancelTask(sittask.get(player.getName())); - sittask.remove(player.getName()); - if (notifyplayer && !msgStanding.isEmpty()) - { - player.sendMessage(msgStanding); - } - } - + public void loadConfig() { FileConfiguration config = YamlConfiguration.loadConfiguration(new File(this.getDataFolder(),"config.yml")); autoRotate = config.getBoolean("auto-rotate"); diff --git a/src/com/cnaude/chairs/CommandRestrict.java b/src/com/cnaude/chairs/CommandRestrict.java index 7f0d698..acf6b42 100644 --- a/src/com/cnaude/chairs/CommandRestrict.java +++ b/src/com/cnaude/chairs/CommandRestrict.java @@ -18,7 +18,7 @@ public class CommandRestrict implements Listener { { Player player = event.getPlayer(); String playercommand = event.getMessage().toLowerCase(); - if (plugin.sit.containsKey(player.getName())) + if (plugin.getPlayerSitData().isSitting(player)) { if (plugin.sitDisableAllCommands) { diff --git a/src/com/cnaude/chairs/PlayerSitData.java b/src/com/cnaude/chairs/PlayerSitData.java new file mode 100644 index 0000000..c6a9512 --- /dev/null +++ b/src/com/cnaude/chairs/PlayerSitData.java @@ -0,0 +1,159 @@ +package com.cnaude.chairs; + +import java.lang.reflect.Constructor; +import java.lang.reflect.Field; +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Method; +import java.util.HashMap; + +import org.bukkit.Bukkit; +import org.bukkit.Location; +import org.bukkit.block.Block; +import org.bukkit.entity.Entity; +import org.bukkit.entity.Player; +import org.bukkit.util.Vector; + +public class PlayerSitData { + + private Chairs plugin; + public PlayerSitData(Chairs plugin) { + this.plugin = plugin; + } + + private HashMap sit = new HashMap(); + private HashMap sitblock = new HashMap(); + private HashMap sitblockbr = new HashMap(); + private HashMap sitstopteleportloc = new HashMap(); + private HashMap sittask = new HashMap(); + protected boolean isSitting(Player player) + { + return sit.containsKey(player.getName()); + } + protected boolean isBlockOccupied(Block block) + { + return sitblock.containsKey(block); + } + protected Player getPlayerOnChair(Block chair) + { + return Bukkit.getPlayerExact(sitblock.get(chair)); + } + protected void sitPlayer(Player player, Location sitlocation) + { + try { + if (plugin.notifyplayer) + { + player.sendMessage(plugin.msgSitting); + } + Block block = sitlocation.getBlock(); + sitstopteleportloc.put(player.getName(), player.getLocation()); + player.teleport(sitlocation); + Location arrowloc = block.getLocation().add(0.5, 0 , 0.5); + Entity arrow = sitPlayerOnArrow(player, arrowloc); + sit.put(player.getName(), arrow); + sitblock.put(block, player.getName()); + sitblockbr.put(player.getName(), block); + startReSitTask(player); + } catch (Exception e) { + e.printStackTrace(); + } + } + protected void startReSitTask(final Player player) + { + int task = + Bukkit.getScheduler().scheduleSyncRepeatingTask(plugin, new Runnable() + { + public void run() + { + reSitPlayer(player); + } + },1000,1000); + sittask.put(player.getName(), task); + } + protected void reSitPlayer(final Player player) + { + try { + final Entity prevarrow = sit.get(player.getName()); + sit.remove(player.getName()); + player.eject(); + Block block = sitblockbr.get(player.getName()); + Location arrowloc = block.getLocation().add(0.5, 0 , 0.5); + Entity arrow = sitPlayerOnArrow(player, arrowloc); + sit.put(player.getName(), arrow); + Bukkit.getScheduler().scheduleSyncDelayedTask(plugin, new Runnable() + { + public void run() + { + prevarrow.remove(); + } + },100); + } catch (Exception e) { + e.printStackTrace(); + } + } + private Entity sitPlayerOnArrow(Player player, Location arrowloc) throws NoSuchMethodException, SecurityException, NoSuchFieldException, IllegalArgumentException, IllegalAccessException, InstantiationException, InvocationTargetException + { + Entity arrow = player.getWorld().spawnArrow(arrowloc, new Vector(0, 0.1 ,0), 0, 0); + Method getHandleMethod = arrow.getClass().getDeclaredMethod("getHandle"); + getHandleMethod.setAccessible(true); + Object nmsarrow = getHandleMethod.invoke(arrow); + Field bukkitEntityField = nmsarrow.getClass().getSuperclass().getDeclaredField("bukkitEntity"); + bukkitEntityField.setAccessible(true); + Constructor ctor = plugin.vehiclearrowclass.getDeclaredConstructor(Bukkit.getServer().getClass(), nmsarrow.getClass()); + ctor.setAccessible(true); + Object vehiclearrow = ctor.newInstance(Bukkit.getServer(), nmsarrow); + bukkitEntityField.set(nmsarrow, vehiclearrow); + arrow.setPassenger(player); + return arrow; + } + protected void unSitPlayer(final Player player, boolean restoreposition, boolean correctnmspostion) + { + final Entity arrow = sit.get(player.getName()); + sit.remove(player.getName()); + player.eject(); + arrow.remove(); + final Location tploc = sitstopteleportloc.get(player.getName()); + if (restoreposition) + { + Bukkit.getScheduler().scheduleSyncDelayedTask(plugin, new Runnable() + { + public void run() + { + player.teleport(tploc); + player.setSneaking(false); + } + },1); + } else + { + if (correctnmspostion) + { + try { + Method getHandleMethod = player.getClass().getDeclaredMethod("getHandle"); + getHandleMethod.setAccessible(true); + Object nmsPlayer = getHandleMethod.invoke(player); + Class entityClass = nmsPlayer.getClass().getSuperclass().getSuperclass().getSuperclass(); + Field locXField = entityClass.getDeclaredField("locX"); + locXField.setAccessible(true); + locXField.set(nmsPlayer, tploc.getX()); + Field locYField = entityClass.getDeclaredField("locY"); + locYField.setAccessible(true); + locYField.set(nmsPlayer, tploc.getY()); + Field locZField = entityClass.getDeclaredField("locZ"); + locZField.setAccessible(true); + locZField.set(nmsPlayer, tploc.getZ()); + } catch (Exception e) { + e.printStackTrace(); + } + } + } + sitblock.remove(sitblockbr.get(player.getName())); + sitblockbr.remove(player.getName()); + sitstopteleportloc.remove(player.getName()); + Bukkit.getScheduler().cancelTask(sittask.get(player.getName())); + sittask.remove(player.getName()); + if (plugin.notifyplayer) + { + player.sendMessage(plugin.msgStanding); + } + } + +} diff --git a/src/com/cnaude/chairs/TrySitEventListener.java b/src/com/cnaude/chairs/TrySitEventListener.java index 8dc1160..f061a4c 100644 --- a/src/com/cnaude/chairs/TrySitEventListener.java +++ b/src/com/cnaude/chairs/TrySitEventListener.java @@ -34,7 +34,7 @@ public class TrySitEventListener implements Listener { if (sitAllowed(player, block)) { event.setCancelled(true); Location sitLocation = getSitLocation(block, player.getLocation().getYaw()); - plugin.sitPlayer(player, sitLocation); + plugin.getPlayerSitData().sitPlayer(player, sitLocation); } } } @@ -67,8 +67,8 @@ public class TrySitEventListener implements Listener { } // Sit occupied check - if (plugin.sitblock.containsKey(block)) { - player.sendMessage(plugin.msgOccupied.replace("%PLAYER%", plugin.sitblock.get(block))); + if (plugin.getPlayerSitData().isBlockOccupied(block)) { + player.sendMessage(plugin.msgOccupied.replace("%PLAYER%", plugin.getPlayerSitData().getPlayerOnChair(block).getName())); return false; } @@ -227,7 +227,7 @@ public class TrySitEventListener implements Listener { } private boolean isSitting(Player player) { - return plugin.sit.containsKey(player.getName()); + return plugin.getPlayerSitData().isSitting(player); } private int getChairWidth(Block block, BlockFace face) { diff --git a/src/com/cnaude/chairs/TryUnsitEventListener.java b/src/com/cnaude/chairs/TryUnsitEventListener.java index 016d3eb..3867688 100644 --- a/src/com/cnaude/chairs/TryUnsitEventListener.java +++ b/src/com/cnaude/chairs/TryUnsitEventListener.java @@ -26,9 +26,9 @@ public class TryUnsitEventListener implements Listener { public void onPlayerQuit(PlayerQuitEvent event) { Player player = event.getPlayer(); - if (plugin.sit.containsKey(player.getName())) + if (plugin.getPlayerSitData().isSitting(player)) { - plugin.unSitPlayer(player, false, true); + plugin.getPlayerSitData().unSitPlayer(player, false, true); } } @@ -36,7 +36,7 @@ public class TryUnsitEventListener implements Listener { public void onPlayerTeleport(PlayerTeleportEvent event) { final Player player = event.getPlayer(); - if (plugin.sit.containsKey(player.getName())) + if (plugin.getPlayerSitData().isSitting(player)) { event.setCancelled(true); } @@ -46,9 +46,9 @@ public class TryUnsitEventListener implements Listener { public void onPlayerDeath(PlayerDeathEvent event) { Player player = event.getEntity(); - if (plugin.sit.containsKey(player.getName())) + if (plugin.getPlayerSitData().isSitting(player)) { - plugin.unSitPlayer(player, false, false); + plugin.getPlayerSitData().unSitPlayer(player, false, false); } } @@ -59,7 +59,7 @@ public class TryUnsitEventListener implements Listener { if (e.getVehicle().getPassenger() instanceof Player) { final Player player = (Player) e.getVehicle().getPassenger(); - if (plugin.sit.containsKey(player.getName())) + if (plugin.getPlayerSitData().isSitting(player)) { e.setCancelled(true); if (!queueUnsit.contains(player.getName())) @@ -70,7 +70,7 @@ public class TryUnsitEventListener implements Listener { public void run() { queueUnsit.remove(player.getName()); - plugin.unSitPlayer(player, true, false); + plugin.getPlayerSitData().unSitPlayer(player, true, false); } }); } @@ -82,10 +82,10 @@ public class TryUnsitEventListener implements Listener { public void onBlockBreak(BlockBreakEvent event) { Block b = event.getBlock(); - if (plugin.sitblock.containsKey(b)) + if (plugin.getPlayerSitData().isBlockOccupied(b)) { - Player player = Bukkit.getPlayerExact(plugin.sitblock.get(b)); - plugin.unSitPlayer(player, true, false); + Player player = plugin.getPlayerSitData().getPlayerOnChair(b); + plugin.getPlayerSitData().unSitPlayer(player, true, false); } }