Add CommandsDeclareEvent to declare commands with brigadier API

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -1,63 +0,0 @@
-name: Bug inside BungeeCord
-description: Create a bug report about a problem inside BungeeCord.
-body:
-  - type: markdown
-    attributes:
-      value: |
-        #### Report a bug inside bungeecord
-        Issues happening with forks of BungeeCord should **not** be reported here.
-  - type: input
-    id: bungee-version
-    attributes:
-      label: Bungeecord version
-      description: The output of the /bungee command (or just the bungee build number) (execute in bungeecord console for easy text copy)
-      placeholder: e.g. git:BungeeCord-Bootstrap:1.xx-SNAPSHOT:xxxxxxx:xxxx
-    validations:
-      required: true
-  - type: input
-    id: server-version
-    attributes:
-      label: Server version
-      description: The output of the /version command (execute in server console for easy text copy)
-      placeholder: "e.g. git-Spigot-xxxxxxx-xxxxxxx (MC: 1.x.x)"
-  - type: input
-    id: client-version
-    attributes:
-      label: Client version
-      description: Minecraft Client Version
-      placeholder: e.g. 1.18.2
-  - type: textarea
-    id: bungee-plugins
-    attributes:
-      label: Bungeecord plugins
-      description: Please list all BungeeCord plugins you are using.
-    validations:
-      required: true
-  - type: textarea
-    id: the-bug
-    attributes:
-      label: The bug
-      description: Please describe the bug. Include **details** you find neccessary. If you just have a question, please ask it in [SpigotMC Forums](https://www.spigotmc.org) and not here.
-    validations:
-      required: true
-  - type: textarea
-    id: logs
-    attributes:
-      label: Log output (links)
-      description: Please put your log output inbetween three backticks (```` ``` ````). Upload your log files to [gist.github.com](https://gist.github.com) and put them in here.
-      placeholder: |
-        ```
-        log output
-        ```
-  - type: checkboxes
-    id: checkboxes
-    attributes:
-      label: Checking
-      options:
-        - label: I am using BungeeCord and **not a fork**. Issues with forks should not be reported here.
-          required: true
-        - label: I think this is **not** an issue with a bungeecord plugin.
-          required: true
-        - label: I have not read these checkboxes and therefore I just ticked them all.
-        - label: This is not a question or plugin creation help request.
-          required: true

.github/ISSUE_TEMPLATE/config.yml

@@ -1,14 +0,0 @@
-blank_issues_enabled: false
-contact_links:
-  - name: Configuration help
-    url: https://www.spigotmc.org/forums/bungeecord-help.70/create-thread
-    about: Help for configuring bungeecord will only be answered in spigotmc.org forums.
-  - name: I have a problem with a bungee plugin
-    url: https://www.spigotmc.org/forums/bungeecord-plugin-help.71/create-thread
-    about: Help about plugins can be recieved in spigotmc.org forums.
-  - name: Questions and discussions
-    url: https://www.spigotmc.org/forums/bungeecord-discussion.21/create-thread
-    about: spigotmc.org forums are the best place to ask your questions regarding bungeecord.
-  - name: Plugin creation help
-    url: https://www.spigotmc.org/forums/bungeecord-plugin-development.23/create-thread
-    about: Plugin creation help for bungee plugins can be recieved in spigotmc.org forums.

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -1,36 +0,0 @@
-name: Feature request
-description: Suggest a feature which bungeecord should include.
-body:
-  - type: textarea
-    id: the-feature
-    attributes:
-      label: Feature description
-      description: Please describe your feature or improvement. Please include **details**.
-    validations:
-      required: true
-  - type: textarea
-    id: goal
-    attributes:
-      label: Goal of the feature
-      description: What is the goal of your feature?
-    validations:
-      required: true
-  - type: textarea
-    id: alternatives
-    attributes:
-      label: Unfitting alternatives
-      description: What alternatives have you considered and why are they not sufficient for your use case?
-    validations:
-      required: true
-  - type: checkboxes
-    id: checkboxes
-    attributes:
-      label: Checking
-      options:
-        - label: This is not a question or plugin creation help request.
-          required: true
-        - label: This is a **feature or improvement request**.
-          required: true
-        - label: I have not read these checkboxes and therefore I just ticked them all.
-        - label: I did not use this form to report a bug.
-          required: true

.github/dependabot.yml

@@ -1,28 +0,0 @@
-version: 2
-
-updates:
-  - package-ecosystem: "maven"
-    directory: "/"
-    schedule:
-      interval: "daily"
-    open-pull-requests-limit: 50
-    ignore:
-        # Synchronised with Minecraft
-      - dependency-name: "com.google.code.gson:gson"
-        # 9.x has performance issues (see, eg, checkstyle/checkstyle#10934) and 10.x is incompatible
-      - dependency-name: "com.puppycrawl.tools:checkstyle"
-        # Newer versions have issues, see #1909 and #2050
-      - dependency-name: "jline:jline"
-        # Later versions of these Maven dependencies are incompatible and require careful management - see SPIGOT-7400
-      - dependency-name: "org.apache.maven.resolver:maven-resolver-connector-basic"
-      - dependency-name: "org.apache.maven.resolver:maven-resolver-transport-http"
-      - dependency-name: "org.apache.maven:maven-resolver-provider"
-        # Used with maven-resolver dependencies; 2.0 update breaks other providers
-      - dependency-name: "org.slf4j:slf4j-api"
-        update-types: ["version-update:semver-major"]
-
-  - package-ecosystem: "github-actions"
-    directory: "/"
-    schedule:
-      interval: "daily"
-    open-pull-requests-limit: 50

.github/workflows/maven.yml

@@ -4,20 +4,18 @@ on: [push, pull_request]
 
 jobs:
   build:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
 
     strategy:
-      fail-fast: false
       matrix:
-        java: [8, 11, 17, 21]
+        java: [8, 11]
 
     name: Java ${{ matrix.java }}
 
     steps:
-    - uses: actions/checkout@v4
-    - uses: actions/setup-java@v3
+    - uses: actions/checkout@v2
+    - uses: actions/setup-java@v1
       with:
-        distribution: zulu
         java-version: ${{ matrix.java }}
     - run: java -version && mvn --version
     - run: mvn --activate-profiles dist --no-transfer-progress package

.gitmodules

@@ -1,6 +0,0 @@
-[submodule "native/mbedtls"]
-	path = native/mbedtls
-	url = https://github.com/ARMmbed/mbedtls.git
-[submodule "native/zlib"]
-	path = native/zlib
-	url = https://github.com/cloudflare/zlib.git

README.md

@@ -23,4 +23,4 @@ Binaries
 --------
 Precompiled binaries are available for end users on [Jenkins](https://www.spigotmc.org/go/bungeecord-dl).
 
-(c) 2012-2023 SpigotMC Pty. Ltd.
+(c) 2012-2020 SpigotMC Pty. Ltd.

api/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-parent</artifactId>
-        <version>1.20-R0.2-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-api</artifactId>
-    <version>1.20-R0.2-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>BungeeCord-API</name>
@@ -46,33 +46,13 @@
         <dependency>
             <groupId>io.netty</groupId>
             <artifactId>netty-transport-native-unix-common</artifactId>
+            <version>${netty.version}</version>
             <scope>compile</scope>
         </dependency>
-        <dependency>
-            <groupId>org.apache.maven</groupId>
-            <artifactId>maven-resolver-provider</artifactId>
-            <version>3.8.5</version>
-            <!-- not part of the API proper -->
-            <scope>provided</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.apache.maven.resolver</groupId>
-            <artifactId>maven-resolver-connector-basic</artifactId>
-            <version>1.7.3</version>
-            <!-- not part of the API proper -->
-            <scope>provided</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.apache.maven.resolver</groupId>
-            <artifactId>maven-resolver-transport-http</artifactId>
-            <version>1.7.3</version>
-            <!-- not part of the API proper -->
-            <scope>provided</scope>
-        </dependency>
         <dependency>
             <groupId>org.yaml</groupId>
             <artifactId>snakeyaml</artifactId>
-            <version>2.2</version>
+            <version>1.26</version>
             <scope>compile</scope>
         </dependency>
     </dependencies>

api/src/main/java/net/md_5/bungee/Util.java

@@ -7,7 +7,6 @@ import java.net.InetSocketAddress;
 import java.net.SocketAddress;
 import java.net.URI;
 import java.net.URISyntaxException;
-import java.util.Locale;
 import java.util.UUID;
 
 /**
@@ -69,17 +68,6 @@ public class Util
         return String.format( "0x%02X", i );
     }
 
-    /**
-     * Formats an char as a unicode value.
-     *
-     * @param c the character to format
-     * @return the unicode representation of the character
-     */
-    public static String unicode(char c)
-    {
-        return "\\u" + String.format( "%04x", (int) c ).toUpperCase( Locale.ROOT );
-    }
-
     /**
      * Constructs a pretty one line version of a {@link Throwable}. Useful for
      * debugging.
@@ -88,24 +76,11 @@ public class Util
      * @return a string representing information about the {@link Throwable}
      */
     public static String exception(Throwable t)
-    {
-        return exception( t, true );
-    }
-
-    /**
-     * Constructs a pretty one line version of a {@link Throwable}. Useful for
-     * debugging.
-     *
-     * @param t the {@link Throwable} to format.
-     * @param includeLineNumbers whether to include line numbers
-     * @return a string representing information about the {@link Throwable}
-     */
-    public static String exception(Throwable t, boolean includeLineNumbers)
     {
         // TODO: We should use clear manually written exceptions
         StackTraceElement[] trace = t.getStackTrace();
         return t.getClass().getSimpleName() + " : " + t.getMessage()
-                + ( ( includeLineNumbers && trace.length > 0 ) ? " @ " + t.getStackTrace()[0].getClassName() + ":" + t.getStackTrace()[0].getLineNumber() : "" );
+                + ( ( trace.length > 0 ) ? " @ " + t.getStackTrace()[0].getClassName() + ":" + t.getStackTrace()[0].getLineNumber() : "" );
     }
 
     public static String csv(Iterable<?> objects)
@@ -113,16 +88,6 @@ public class Util
         return format( objects, ", " );
     }
 
-    /**
-     * Returns a string of objects, each separated by a separator.
-     *
-     * @param objects the objects to join
-     * @param separators the separator
-     * @return joined string
-     * @see String#join(java.lang.CharSequence, java.lang.Iterable)
-     * @deprecated use {@link String} join methods
-     */
-    @Deprecated
     public static String format(Iterable<?> objects, String separators)
     {
         return Joiner.on( separators ).join( objects );

api/src/main/java/net/md_5/bungee/api/AbstractReconnectHandler.java

@@ -28,13 +28,18 @@ public abstract class AbstractReconnectHandler implements ReconnectHandler
 
     public static ServerInfo getForcedHost(PendingConnection con)
     {
-        String forced = ( con.getVirtualHost() == null ) ? null : con.getListener().getForcedHosts().get( con.getVirtualHost().getHostString() );
+        if ( con.getVirtualHost() == null )
+        {
+            return null;
+        }
+
+        String forced = con.getListener().getForcedHosts().get( con.getVirtualHost().getHostString() );
 
         if ( forced == null && con.getListener().isForceDefault() )
         {
             forced = con.getListener().getDefaultServer();
         }
-        return ( forced == null ) ? null : ProxyServer.getInstance().getServerInfo( forced );
+        return ProxyServer.getInstance().getServerInfo( forced );
     }
 
     protected abstract ServerInfo getStoredServer(ProxiedPlayer player);

api/src/main/java/net/md_5/bungee/api/Favicon.java

@@ -1,10 +1,9 @@
 package net.md_5.bungee.api;
 
-import com.google.common.base.Preconditions;
 import com.google.common.io.BaseEncoding;
 import com.google.gson.TypeAdapter;
+import com.google.gson.internal.bind.TypeAdapters;
 import com.google.gson.stream.JsonReader;
-import com.google.gson.stream.JsonToken;
 import com.google.gson.stream.JsonWriter;
 import java.awt.image.BufferedImage;
 import java.io.ByteArrayOutputStream;
@@ -27,26 +26,13 @@ public class Favicon
         @Override
         public void write(JsonWriter out, Favicon value) throws IOException
         {
-            if ( value == null )
-            {
-                out.nullValue();
-            } else
-            {
-                out.value( value.getEncoded() );
-            }
+            TypeAdapters.STRING.write( out, value == null ? null : value.getEncoded() );
         }
 
         @Override
         public Favicon read(JsonReader in) throws IOException
         {
-            JsonToken peek = in.peek();
-            if ( peek == JsonToken.NULL )
-            {
-                in.nextNull();
-                return null;
-            }
-
-            String enc = in.nextString();
+            String enc = TypeAdapters.STRING.read( in );
             return enc == null ? null : create( enc );
         }
     };
@@ -73,7 +59,6 @@ public class Favicon
      */
     public static Favicon create(BufferedImage image)
     {
-        Preconditions.checkArgument( image != null, "image is null" );
         // check size
         if ( image.getWidth() != 64 || image.getHeight() != 64 )
         {

api/src/main/java/net/md_5/bungee/api/connection/ProxiedPlayer.java

@@ -15,7 +15,7 @@ import net.md_5.bungee.api.event.ServerConnectEvent;
 import net.md_5.bungee.api.score.Scoreboard;
 
 /**
- * Represents a player whose connection is being connected to somewhere else,
+ * Represents a player who's connection is being connected to somewhere else,
  * whether it be a remote or embedded server.
  */
 public interface ProxiedPlayer extends Connection, CommandSender
@@ -57,7 +57,8 @@ public interface ProxiedPlayer extends Connection, CommandSender
     String getDisplayName();
 
     /**
-     * Sets this player's display name to be used by proxy commands and plugins.
+     * Sets this players display name to be used as their nametag and tab list
+     * name.
      *
      * @param name the name to set
      */

api/src/main/java/net/md_5/bungee/api/event/CommandsDeclareEvent.java

@@ -0,0 +1,157 @@
+package net.md_5.bungee.api.event;
+
+import com.mojang.brigadier.arguments.ArgumentType;
+import com.mojang.brigadier.arguments.IntegerArgumentType;
+import com.mojang.brigadier.arguments.StringArgumentType;
+import com.mojang.brigadier.builder.ArgumentBuilder;
+import com.mojang.brigadier.builder.RequiredArgumentBuilder;
+import com.mojang.brigadier.suggestion.SuggestionProvider;
+import com.mojang.brigadier.tree.CommandNode;
+import com.mojang.brigadier.tree.RootCommandNode;
+import lombok.AccessLevel;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+import lombok.Setter;
+import lombok.ToString;
+import net.md_5.bungee.api.CommandSender;
+import net.md_5.bungee.api.connection.Connection;
+import net.md_5.bungee.api.plugin.Command;
+import net.md_5.bungee.api.plugin.Plugin;
+import net.md_5.bungee.api.plugin.PluginManager;
+import net.md_5.bungee.api.plugin.TabExecutor;
+
+/**
+ * Event called when a downstream server (on 1.13+) sends the command structure
+ * to a player, but before BungeeCord adds the dummy command nodes of
+ * registered commands.
+ * <p>
+ * BungeeCord will not overwrite the modifications made by the listeners.
+ *
+ * <h2>Usage example</h2>
+ * Here is a usage example of this event, to declare a command structure.
+ * This illustrates the commands /server and /send of Bungee.
+ * <pre>
+ * event.getRoot().addChild( LiteralArgumentBuilder.&lt;CommandSender&gt;literal( "server" )
+ *         .requires( sender -&gt; sender.hasPermission( "bungeecord.command.server" ) )
+ *         .executes( a -&gt; 0 )
+ *         .then( RequiredArgumentBuilder.argument( "serverName", StringArgumentType.greedyString() )
+ *                 .suggests( SuggestionRegistry.ASK_SERVER )
+ *         )
+ *         .build()
+ * );
+ * event.getRoot().addChild( LiteralArgumentBuilder.&lt;CommandSender&gt;literal( "send" )
+ *         .requires( sender -&gt; sender.hasPermission( "bungeecord.command.send" ) )
+ *         .then( RequiredArgumentBuilder.argument( "playerName", StringArgumentType.word() )
+ *                 .suggests( SuggestionRegistry.ASK_SERVER )
+ *                 .then( RequiredArgumentBuilder.argument( "serverName", StringArgumentType.greedyString() )
+ *                         .suggests( SuggestionRegistry.ASK_SERVER )
+ *                 )
+ *         )
+ *         .build()
+ * );
+ * </pre>
+ *
+ * <h2>Flag a {@link CommandNode} as executable or not</h2>
+ * The implementation of a {@link com.mojang.brigadier.Command Command} used in
+ * {@link ArgumentBuilder#executes(com.mojang.brigadier.Command)} will never be
+ * executed. This will only tell to the client if the current node is
+ * executable or not.
+ * <ul>
+ *     <li>
+ *         {@code builder.executes(null)} (default) to mark the node as not
+ *         executable.
+ *     </li>
+ *     <li>
+ *         {@code builder.executes(a -> 0)}, or any non null argument, to mark
+ *         the node as executable (the child arguments are displayed as
+ *         optional).
+ *     </li>
+ * </ul>
+ *
+ * <h2>{@link CommandNode}’s suggestions management</h2>
+ * The implementation of a SuggestionProvider used in
+ * {@link RequiredArgumentBuilder#suggests(SuggestionProvider)} will never be
+ * executed. This will only tell to the client how to deal with the
+ * auto-completion of the argument.
+ * <ul>
+ *     <li>
+ *         {@code builder.suggests(null)} (default) to disable auto-completion
+ *         for this argument.
+ *     </li>
+ *     <li>
+ *         {@code builder.suggests(SuggestionRegistry.ALL_RECIPES)} to suggest
+ *         Minecraft’s recipes.
+ *     </li>
+ *     <li>
+ *         {@code builder.suggests(SuggestionRegistry.AVAILABLE_SOUNDS)} to
+ *         suggest Minecraft’s default sound identifiers.
+ *     </li>
+ *     <li>
+ *         {@code builder.suggests(SuggestionRegistry.SUMMONABLE_ENTITIES)} to
+ *         suggest Minecraft’s default summonable entities identifiers.
+ *     </li>
+ *     <li>
+ *         {@code builder.suggests(SuggestionRegistry.ASK_SERVER)}, or any
+ *         other non null argument, to make the Minecraft client ask
+ *         auto-completion to the server. Any specified implementation of
+ *         {@link SuggestionProvider} will never be executed.
+ *     </li>
+ * </ul>
+ *
+ * <h2>Argument types</h2>
+ * When building a new argument command node using
+ * {@link RequiredArgumentBuilder#argument(String, ArgumentType)}, you have to
+ * specify an {@link ArgumentType}. You can use all subclasses of
+ * {@link ArgumentType} provided with brigadier (for instance,
+ * {@link StringArgumentType} or {@link IntegerArgumentType}), or call any
+ * {@code ArgumentRegistry.minecraft*()} methods to use a {@code minecraft:*}
+ * argument type.
+ *
+ * <h2>Limitations with brigadier API</h2>
+ * This event is only used for the client to show command syntax, suggest
+ * sub-commands and color the arguments in the chat box. The command execution
+ * needs to be implemented using {@link PluginManager#registerCommand(Plugin,
+ * Command)} and the server-side tab-completion using {@link TabCompleteEvent}
+ * or {@link TabExecutor}.
+ */
+@Data
+@ToString(callSuper = true)
+@EqualsAndHashCode(callSuper = true)
+public class CommandsDeclareEvent extends TargetedEvent
+{
+    /**
+     * Wether or not the command tree is modified by this event.
+     *
+     * If this value is set to true, BungeeCord will ensure that the
+     * modifications made in the command tree, will be sent to the player.
+     * If this is false, the modifications may not be taken into account.
+     *
+     * When calling {@link #getRoot()}, this value is automatically set
+     * to true.
+     */
+    @Setter(value = AccessLevel.NONE)
+    private boolean modified = false;
+
+    /**
+     * The root command node of the command structure that will be send to the
+     * player.
+     */
+    private final RootCommandNode<CommandSender> root;
+
+    public CommandsDeclareEvent(Connection sender, Connection receiver, RootCommandNode<CommandSender> root)
+    {
+        super( sender, receiver );
+        this.root = root;
+    }
+
+    /**
+     * The root command node of the command structure that will be send to the
+     * player.
+     * @return The root command node
+     */
+    public RootCommandNode<CommandSender> getRoot()
+    {
+        modified = true;
+        return root;
+    }
+}

api/src/main/java/net/md_5/bungee/api/event/ProxyPingEvent.java

@@ -8,7 +8,7 @@ import net.md_5.bungee.api.ServerPing;
 import net.md_5.bungee.api.connection.PendingConnection;
 
 /**
- * Called when the proxy is queried for status from the server list.
+ * Called when the proxy is pinged with packet 0xFE from the server list.
  */
 @Data
 @ToString(callSuper = false)

api/src/main/java/net/md_5/bungee/api/event/ServerDisconnectEvent.java

@@ -9,13 +9,6 @@ import net.md_5.bungee.api.config.ServerInfo;
 import net.md_5.bungee.api.connection.ProxiedPlayer;
 import net.md_5.bungee.api.plugin.Event;
 
-/**
- * Called when the player is disconnected from a server, for example during
- * server switching.
- *
- * If the player is kicked from a server, {@link ServerKickEvent} will be called
- * instead.
- */
 @Data
 @AllArgsConstructor
 @ToString(callSuper = false)

api/src/main/java/net/md_5/bungee/api/plugin/LibraryLoader.java

@@ -1,123 +0,0 @@
-package net.md_5.bungee.api.plugin;
-
-import java.io.File;
-import java.net.MalformedURLException;
-import java.net.URL;
-import java.net.URLClassLoader;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.List;
-import java.util.logging.Level;
-import java.util.logging.Logger;
-import org.apache.maven.repository.internal.MavenRepositorySystemUtils;
-import org.eclipse.aether.DefaultRepositorySystemSession;
-import org.eclipse.aether.RepositorySystem;
-import org.eclipse.aether.artifact.Artifact;
-import org.eclipse.aether.artifact.DefaultArtifact;
-import org.eclipse.aether.collection.CollectRequest;
-import org.eclipse.aether.connector.basic.BasicRepositoryConnectorFactory;
-import org.eclipse.aether.graph.Dependency;
-import org.eclipse.aether.impl.DefaultServiceLocator;
-import org.eclipse.aether.repository.LocalRepository;
-import org.eclipse.aether.repository.RemoteRepository;
-import org.eclipse.aether.repository.RepositoryPolicy;
-import org.eclipse.aether.resolution.ArtifactResult;
-import org.eclipse.aether.resolution.DependencyRequest;
-import org.eclipse.aether.resolution.DependencyResolutionException;
-import org.eclipse.aether.resolution.DependencyResult;
-import org.eclipse.aether.spi.connector.RepositoryConnectorFactory;
-import org.eclipse.aether.spi.connector.transport.TransporterFactory;
-import org.eclipse.aether.transfer.AbstractTransferListener;
-import org.eclipse.aether.transfer.TransferCancelledException;
-import org.eclipse.aether.transfer.TransferEvent;
-import org.eclipse.aether.transport.http.HttpTransporterFactory;
-
-class LibraryLoader
-{
-
-    private final Logger logger;
-    private final RepositorySystem repository;
-    private final DefaultRepositorySystemSession session;
-    private final List<RemoteRepository> repositories;
-
-    public LibraryLoader(Logger logger)
-    {
-        this.logger = logger;
-
-        DefaultServiceLocator locator = MavenRepositorySystemUtils.newServiceLocator();
-        locator.addService( RepositoryConnectorFactory.class, BasicRepositoryConnectorFactory.class );
-        locator.addService( TransporterFactory.class, HttpTransporterFactory.class );
-
-        this.repository = locator.getService( RepositorySystem.class );
-        this.session = MavenRepositorySystemUtils.newSession();
-
-        session.setChecksumPolicy( RepositoryPolicy.CHECKSUM_POLICY_FAIL );
-        session.setLocalRepositoryManager( repository.newLocalRepositoryManager( session, new LocalRepository( "libraries" ) ) );
-        session.setTransferListener( new AbstractTransferListener()
-        {
-            @Override
-            public void transferStarted(TransferEvent event) throws TransferCancelledException
-            {
-                logger.log( Level.INFO, "Downloading {0}", event.getResource().getRepositoryUrl() + event.getResource().getResourceName() );
-            }
-        } );
-        session.setReadOnly();
-
-        this.repositories = repository.newResolutionRepositories( session, Arrays.asList( new RemoteRepository.Builder( "central", "default", "https://repo.maven.apache.org/maven2" ).build() ) );
-    }
-
-    public ClassLoader createLoader(PluginDescription desc)
-    {
-        if ( desc.getLibraries().isEmpty() )
-        {
-            return null;
-        }
-        logger.log( Level.INFO, "[{0}] Loading {1} libraries... please wait", new Object[]
-        {
-            desc.getName(), desc.getLibraries().size()
-        } );
-
-        List<Dependency> dependencies = new ArrayList<>();
-        for ( String library : desc.getLibraries() )
-        {
-            Artifact artifact = new DefaultArtifact( library );
-            Dependency dependency = new Dependency( artifact, null );
-
-            dependencies.add( dependency );
-        }
-
-        DependencyResult result;
-        try
-        {
-            result = repository.resolveDependencies( session, new DependencyRequest( new CollectRequest( (Dependency) null, dependencies, repositories ), null ) );
-        } catch ( DependencyResolutionException ex )
-        {
-            throw new RuntimeException( "Error resolving libraries", ex );
-        }
-
-        List<URL> jarFiles = new ArrayList<>();
-        for ( ArtifactResult artifact : result.getArtifactResults() )
-        {
-            File file = artifact.getArtifact().getFile();
-
-            URL url;
-            try
-            {
-                url = file.toURI().toURL();
-            } catch ( MalformedURLException ex )
-            {
-                throw new AssertionError( ex );
-            }
-
-            jarFiles.add( url );
-            logger.log( Level.INFO, "[{0}] Loaded library {1}", new Object[]
-            {
-                desc.getName(), file
-            } );
-        }
-
-        URLClassLoader loader = new URLClassLoader( jarFiles.toArray( new URL[ 0 ] ) );
-
-        return loader;
-    }
-}

api/src/main/java/net/md_5/bungee/api/plugin/PluginClassloader.java

@@ -1,23 +1,12 @@
 package net.md_5.bungee.api.plugin;
 
 import com.google.common.base.Preconditions;
-import com.google.common.io.ByteStreams;
-import java.io.File;
-import java.io.IOException;
-import java.io.InputStream;
 import java.net.URL;
 import java.net.URLClassLoader;
-import java.security.CodeSigner;
-import java.security.CodeSource;
 import java.util.Set;
 import java.util.concurrent.CopyOnWriteArraySet;
-import java.util.jar.JarEntry;
-import java.util.jar.JarFile;
-import java.util.jar.Manifest;
-import lombok.ToString;
 import net.md_5.bungee.api.ProxyServer;
 
-@ToString(of = "desc")
 final class PluginClassloader extends URLClassLoader
 {
 
@@ -25,10 +14,6 @@ final class PluginClassloader extends URLClassLoader
     //
     private final ProxyServer proxy;
     private final PluginDescription desc;
-    private final JarFile jar;
-    private final Manifest manifest;
-    private final URL url;
-    private final ClassLoader libraryLoader;
     //
     private Plugin plugin;
 
@@ -37,18 +22,11 @@ final class PluginClassloader extends URLClassLoader
         ClassLoader.registerAsParallelCapable();
     }
 
-    public PluginClassloader(ProxyServer proxy, PluginDescription desc, File file, ClassLoader libraryLoader) throws IOException
+    public PluginClassloader(ProxyServer proxy, PluginDescription desc, URL[] urls)
     {
-        super( new URL[]
-        {
-            file.toURI().toURL()
-        } );
+        super( urls );
         this.proxy = proxy;
         this.desc = desc;
-        this.jar = new JarFile( file );
-        this.manifest = jar.getManifest();
-        this.url = file.toURI().toURL();
-        this.libraryLoader = libraryLoader;
 
         allLoaders.add( this );
     }
@@ -56,34 +34,17 @@ final class PluginClassloader extends URLClassLoader
     @Override
     protected Class<?> loadClass(String name, boolean resolve) throws ClassNotFoundException
     {
-        return loadClass0( name, resolve, true, true );
+        return loadClass0( name, resolve, true );
     }
 
-    private Class<?> loadClass0(String name, boolean resolve, boolean checkOther, boolean checkLibraries) throws ClassNotFoundException
+    private Class<?> loadClass0(String name, boolean resolve, boolean checkOther) throws ClassNotFoundException
     {
         try
         {
-            Class<?> result = super.loadClass( name, resolve );
-
-            // SPIGOT-6749: Library classes will appear in the above, but we don't want to return them to other plugins
-            if ( checkOther || result.getClassLoader() == this )
-            {
-                return result;
-            }
+            return super.loadClass( name, resolve );
         } catch ( ClassNotFoundException ex )
         {
         }
-
-        if ( checkLibraries && libraryLoader != null )
-        {
-            try
-            {
-                return libraryLoader.loadClass( name );
-            } catch ( ClassNotFoundException ex )
-            {
-            }
-        }
-
         if ( checkOther )
         {
             for ( PluginClassloader loader : allLoaders )
@@ -92,81 +53,16 @@ final class PluginClassloader extends URLClassLoader
                 {
                     try
                     {
-                        return loader.loadClass0( name, resolve, false, proxy.getPluginManager().isTransitiveDepend( desc, loader.desc ) );
+                        return loader.loadClass0( name, resolve, false );
                     } catch ( ClassNotFoundException ex )
                     {
                     }
                 }
             }
         }
-
         throw new ClassNotFoundException( name );
     }
 
-    @Override
-    protected Class<?> findClass(String name) throws ClassNotFoundException
-    {
-        String path = name.replace( '.', '/' ).concat( ".class" );
-        JarEntry entry = jar.getJarEntry( path );
-
-        if ( entry != null )
-        {
-            byte[] classBytes;
-
-            try ( InputStream is = jar.getInputStream( entry ) )
-            {
-                classBytes = ByteStreams.toByteArray( is );
-            } catch ( IOException ex )
-            {
-                throw new ClassNotFoundException( name, ex );
-            }
-
-            int dot = name.lastIndexOf( '.' );
-            if ( dot != -1 )
-            {
-                String pkgName = name.substring( 0, dot );
-                if ( getPackage( pkgName ) == null )
-                {
-                    try
-                    {
-                        if ( manifest != null )
-                        {
-                            definePackage( pkgName, manifest, url );
-                        } else
-                        {
-                            definePackage( pkgName, null, null, null, null, null, null, null );
-                        }
-                    } catch ( IllegalArgumentException ex )
-                    {
-                        if ( getPackage( pkgName ) == null )
-                        {
-                            throw new IllegalStateException( "Cannot find package " + pkgName );
-                        }
-                    }
-                }
-            }
-
-            CodeSigner[] signers = entry.getCodeSigners();
-            CodeSource source = new CodeSource( url, signers );
-
-            return defineClass( name, classBytes, 0, classBytes.length, source );
-        }
-
-        return super.findClass( name );
-    }
-
-    @Override
-    public void close() throws IOException
-    {
-        try
-        {
-            super.close();
-        } finally
-        {
-            jar.close();
-        }
-    }
-
     void init(Plugin plugin)
     {
         Preconditions.checkArgument( plugin != null, "plugin" );

api/src/main/java/net/md_5/bungee/api/plugin/PluginDescription.java

@@ -2,8 +2,6 @@ package net.md_5.bungee.api.plugin;
 
 import java.io.File;
 import java.util.HashSet;
-import java.util.LinkedList;
-import java.util.List;
 import java.util.Set;
 import lombok.AllArgsConstructor;
 import lombok.Data;
@@ -50,8 +48,4 @@ public class PluginDescription
      * Optional description.
      */
     private String description = null;
-    /**
-     * Optional libraries.
-     */
-    private List<String> libraries = new LinkedList<>();
 }

api/src/main/java/net/md_5/bungee/api/plugin/PluginManager.java

@@ -4,12 +4,10 @@ import com.google.common.base.Preconditions;
 import com.google.common.collect.ArrayListMultimap;
 import com.google.common.collect.Multimap;
 import com.google.common.eventbus.Subscribe;
-import com.google.common.graph.GraphBuilder;
-import com.google.common.graph.Graphs;
-import com.google.common.graph.MutableGraph;
 import java.io.File;
 import java.io.InputStream;
 import java.lang.reflect.Method;
+import java.net.URL;
 import java.net.URLClassLoader;
 import java.util.Arrays;
 import java.util.Collection;
@@ -33,7 +31,6 @@ import net.md_5.bungee.api.ProxyServer;
 import net.md_5.bungee.api.connection.ProxiedPlayer;
 import net.md_5.bungee.event.EventBus;
 import net.md_5.bungee.event.EventHandler;
-import org.yaml.snakeyaml.LoaderOptions;
 import org.yaml.snakeyaml.Yaml;
 import org.yaml.snakeyaml.constructor.Constructor;
 import org.yaml.snakeyaml.introspector.PropertyUtils;
@@ -52,8 +49,6 @@ public final class PluginManager
     private final Yaml yaml;
     private final EventBus eventBus;
     private final Map<String, Plugin> plugins = new LinkedHashMap<>();
-    private final MutableGraph<String> dependencyGraph = GraphBuilder.directed().build();
-    private final LibraryLoader libraryLoader;
     private final Map<String, Command> commandMap = new HashMap<>();
     private Map<String, PluginDescription> toLoad = new HashMap<>();
     private final Multimap<Plugin, Command> commandsByPlugin = ArrayListMultimap.create();
@@ -65,24 +60,13 @@ public final class PluginManager
         this.proxy = proxy;
 
         // Ignore unknown entries in the plugin descriptions
-        Constructor yamlConstructor = new Constructor( new LoaderOptions() );
+        Constructor yamlConstructor = new Constructor();
         PropertyUtils propertyUtils = yamlConstructor.getPropertyUtils();
         propertyUtils.setSkipMissingProperties( true );
         yamlConstructor.setPropertyUtils( propertyUtils );
         yaml = new Yaml( yamlConstructor );
 
         eventBus = new EventBus( proxy.getLogger() );
-
-        LibraryLoader libraryLoader = null;
-        try
-        {
-            libraryLoader = new LibraryLoader( proxy.getLogger() );
-        } catch ( NoClassDefFoundError ex )
-        {
-            // Provided depends were not added back
-            proxy.getLogger().warning( "Could not initialize LibraryLoader (missing dependencies?)" );
-        }
-        this.libraryLoader = libraryLoader;
     }
 
     /**
@@ -325,7 +309,6 @@ public final class PluginManager
                 status = false;
             }
 
-            dependencyGraph.putEdge( plugin.getName(), dependName );
             if ( !status )
             {
                 break;
@@ -337,7 +320,10 @@ public final class PluginManager
         {
             try
             {
-                URLClassLoader loader = new PluginClassloader( proxy, plugin, plugin.getFile(), ( libraryLoader != null ) ? libraryLoader.createLoader( plugin ) : null );
+                URLClassLoader loader = new PluginClassloader( proxy, plugin, new URL[]
+                {
+                    plugin.getFile().toURI().toURL()
+                } );
                 Class<?> main = loader.loadClass( plugin.getMain() );
                 Plugin clazz = (Plugin) main.getDeclaredConstructor().newInstance();
 
@@ -349,7 +335,7 @@ public final class PluginManager
                 } );
             } catch ( Throwable t )
             {
-                proxy.getLogger().log( Level.WARNING, "Error loading plugin " + plugin.getName(), t );
+                proxy.getLogger().log( Level.WARNING, "Error enabling plugin " + plugin.getName(), t );
             }
         }
 
@@ -477,19 +463,4 @@ public final class PluginManager
     {
         return Collections.unmodifiableCollection( commandMap.entrySet() );
     }
-
-    boolean isTransitiveDepend(PluginDescription plugin, PluginDescription depend)
-    {
-        Preconditions.checkArgument( plugin != null, "plugin" );
-        Preconditions.checkArgument( depend != null, "depend" );
-
-        if ( dependencyGraph.nodes().contains( plugin.getName() ) )
-        {
-            if ( Graphs.reachableNodes( dependencyGraph, plugin.getName() ).contains( depend.getName() ) )
-            {
-                return true;
-            }
-        }
-        return false;
-    }
 }

api/src/test/java/net/md_5/bungee/api/ServerConnectRequestTest.java

@@ -1,13 +1,12 @@
 package net.md_5.bungee.api;
 
-import static org.junit.jupiter.api.Assertions.*;
 import java.net.InetSocketAddress;
 import java.net.SocketAddress;
 import java.util.Collection;
 import net.md_5.bungee.api.config.ServerInfo;
 import net.md_5.bungee.api.connection.ProxiedPlayer;
 import net.md_5.bungee.api.event.ServerConnectEvent;
-import org.junit.jupiter.api.Test;
+import org.junit.Test;
 
 public class ServerConnectRequestTest
 {
@@ -79,15 +78,15 @@ public class ServerConnectRequestTest
         }
     };
 
-    @Test
+    @Test(expected = NullPointerException.class)
     public void testNullTarget()
     {
-        assertThrows( NullPointerException.class, () -> ServerConnectRequest.builder().target( null ).reason( ServerConnectEvent.Reason.JOIN_PROXY ).build() );
+        ServerConnectRequest.builder().target( null ).reason( ServerConnectEvent.Reason.JOIN_PROXY ).build();
     }
 
-    @Test
+    @Test(expected = NullPointerException.class)
     public void testNullReason()
     {
-        assertThrows( NullPointerException.class, () -> ServerConnectRequest.builder().target( DUMMY_INFO ).reason( null ).build() );
+        ServerConnectRequest.builder().target( DUMMY_INFO ).reason( null ).build();
     }
 }

api/src/test/java/net/md_5/bungee/util/AddressParseTest.java

@@ -1,38 +1,63 @@
 package net.md_5.bungee.util;
 
-import static org.junit.jupiter.api.Assertions.*;
 import io.netty.channel.unix.DomainSocketAddress;
 import java.net.InetSocketAddress;
 import java.net.SocketAddress;
-import java.util.stream.Stream;
+import java.util.Arrays;
+import java.util.Collection;
 import lombok.RequiredArgsConstructor;
 import net.md_5.bungee.Util;
-import org.junit.jupiter.params.ParameterizedTest;
-import org.junit.jupiter.params.provider.Arguments;
-import org.junit.jupiter.params.provider.MethodSource;
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.junit.runners.Parameterized.Parameters;
 
 @RequiredArgsConstructor
+@RunWith(Parameterized.class)
 public class AddressParseTest
 {
 
-    public static Stream<Arguments> data()
+    @Parameters
+    public static Collection<Object[]> data()
     {
-        return Stream.of(
-                Arguments.of( "127.0.0.1", "127.0.0.1", Util.DEFAULT_PORT ),
-                Arguments.of( "127.0.0.1:1337", "127.0.0.1", 1337 ),
-                Arguments.of( "[::1]", "0:0:0:0:0:0:0:1", Util.DEFAULT_PORT ),
-                Arguments.of( "[0:0:0:0::1]", "0:0:0:0:0:0:0:1", Util.DEFAULT_PORT ),
-                Arguments.of( "[0:0:0:0:0:0:0:1]", "0:0:0:0:0:0:0:1", Util.DEFAULT_PORT ),
-                Arguments.of( "[::1]:1337", "0:0:0:0:0:0:0:1", 1337 ),
-                Arguments.of( "[0:0:0:0::1]:1337", "0:0:0:0:0:0:0:1", 1337 ),
-                Arguments.of( "[0:0:0:0:0:0:0:1]:1337", "0:0:0:0:0:0:0:1", 1337 ),
-                Arguments.of( "unix:///var/run/bungee.sock", "/var/run/bungee.sock", -1 )
-        );
+        return Arrays.asList( new Object[][]
+        {
+            {
+                "127.0.0.1", "127.0.0.1", Util.DEFAULT_PORT
+            },
+            {
+                "127.0.0.1:1337", "127.0.0.1", 1337
+            },
+            {
+                "[::1]", "0:0:0:0:0:0:0:1", Util.DEFAULT_PORT
+            },
+            {
+                "[0:0:0:0::1]", "0:0:0:0:0:0:0:1", Util.DEFAULT_PORT
+            },
+            {
+                "[0:0:0:0:0:0:0:1]", "0:0:0:0:0:0:0:1", Util.DEFAULT_PORT
+            },
+            {
+                "[::1]:1337", "0:0:0:0:0:0:0:1", 1337
+            },
+            {
+                "[0:0:0:0::1]:1337", "0:0:0:0:0:0:0:1", 1337
+            },
+            {
+                "[0:0:0:0:0:0:0:1]:1337", "0:0:0:0:0:0:0:1", 1337
+            },
+            {
+                "unix:///var/run/bungee.sock", "/var/run/bungee.sock", -1
+            }
+        } );
     }
+    private final String line;
+    private final String host;
+    private final int port;
 
-    @ParameterizedTest
-    @MethodSource("data")
-    public void test(String line, String host, int port)
+    @Test
+    public void test()
     {
         SocketAddress parsed = Util.getAddr( line );
 
@@ -40,14 +65,14 @@ public class AddressParseTest
         {
             InetSocketAddress tcp = (InetSocketAddress) parsed;
 
-            assertEquals( host, tcp.getHostString() );
-            assertEquals( port, tcp.getPort() );
+            Assert.assertEquals( host, tcp.getHostString() );
+            Assert.assertEquals( port, tcp.getPort() );
         } else if ( parsed instanceof DomainSocketAddress )
         {
             DomainSocketAddress unix = (DomainSocketAddress) parsed;
 
-            assertEquals( host, unix.path() );
-            assertEquals( -1, port );
+            Assert.assertEquals( host, unix.path() );
+            Assert.assertEquals( -1, port );
         } else
         {
             throw new AssertionError( "Unknown socket " + parsed );

api/src/test/java/net/md_5/bungee/util/CaseInsensitiveTest.java

@@ -1,7 +1,7 @@
 package net.md_5.bungee.util;
 
-import static org.junit.jupiter.api.Assertions.*;
-import org.junit.jupiter.api.Test;
+import org.junit.Assert;
+import org.junit.Test;
 
 public class CaseInsensitiveTest
 {
@@ -13,12 +13,12 @@ public class CaseInsensitiveTest
         CaseInsensitiveMap<Object> map = new CaseInsensitiveMap<>();
 
         map.put( "FOO", obj );
-        assertTrue( map.contains( "foo" ) ); // Assert that contains is case insensitive
-        assertTrue( map.entrySet().iterator().next().getKey().equals( "FOO" ) ); // Assert that case is preserved
+        Assert.assertTrue( map.contains( "foo" ) ); // Assert that contains is case insensitive
+        Assert.assertTrue( map.entrySet().iterator().next().getKey().equals( "FOO" ) ); // Assert that case is preserved
 
         // Assert that remove is case insensitive
         map.remove( "FoO" );
-        assertFalse( map.contains( "foo" ) );
+        Assert.assertFalse( map.contains( "foo" ) );
     }
 
     @Test
@@ -27,8 +27,8 @@ public class CaseInsensitiveTest
         CaseInsensitiveSet set = new CaseInsensitiveSet();
 
         set.add( "FOO" );
-        assertTrue( set.contains( "foo" ) ); // Assert that contains is case insensitive
+        Assert.assertTrue( set.contains( "foo" ) ); // Assert that contains is case insensitive
         set.remove( "FoO" );
-        assertFalse( set.contains( "foo" ) ); // Assert that remove is case insensitive
+        Assert.assertFalse( set.contains( "foo" ) ); // Assert that remove is case insensitive
     }
 }

api/src/test/java/net/md_5/bungee/util/UUIDTest.java

@@ -1,9 +1,9 @@
 package net.md_5.bungee.util;
 
-import static org.junit.jupiter.api.Assertions.*;
 import java.util.UUID;
 import net.md_5.bungee.Util;
-import org.junit.jupiter.api.Test;
+import org.junit.Assert;
+import org.junit.Test;
 
 public class UUIDTest
 {
@@ -13,7 +13,7 @@ public class UUIDTest
     {
         UUID uuid = UUID.fromString( "af74a02d-19cb-445b-b07f-6866a861f783" );
         UUID uuid1 = Util.getUUID( "af74a02d19cb445bb07f6866a861f783" );
-        assertEquals( uuid, uuid1 );
+        Assert.assertEquals( uuid, uuid1 );
     }
 
     @Test
@@ -23,7 +23,7 @@ public class UUIDTest
         {
             UUID expected = UUID.randomUUID();
             UUID actual = Util.getUUID( expected.toString().replace( "-", "" ) );
-            assertEquals( expected, actual, "Could not parse UUID " + expected );
+            Assert.assertEquals( "Could not parse UUID " + expected, expected, actual );
         }
     }
 }

bootstrap/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-parent</artifactId>
-        <version>1.20-R0.2-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-bootstrap</artifactId>
-    <version>1.20-R0.2-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>BungeeCord-Bootstrap</name>
@@ -41,7 +41,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>
-                <version>3.3.0</version>
+                <version>3.2.0</version>
                 <configuration>
                     <archive>
                         <manifestEntries>
@@ -55,7 +55,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-shade-plugin</artifactId>
-                <version>3.5.0</version>
+                <version>3.2.3</version>
                 <executions>
                     <execution>
                         <phase>package</phase>
@@ -79,34 +79,4 @@
             </plugin>
         </plugins>
     </build>
-
-    <profiles>
-        <profile>
-            <id>jdk-9-release</id>
-            <activation>
-                <jdk>[9,)</jdk>
-            </activation>
-            <properties>
-                <maven.compiler.release>6</maven.compiler.release>
-            </properties>
-        </profile>
-        <profile>
-            <id>jdk-12-release</id>
-            <activation>
-                <jdk>[12,)</jdk>
-            </activation>
-            <properties>
-                <maven.compiler.release>7</maven.compiler.release>
-            </properties>
-        </profile>
-        <profile>
-            <id>jdk-20-release</id>
-            <activation>
-                <jdk>[20,)</jdk>
-            </activation>
-            <properties>
-                <maven.compiler.release>8</maven.compiler.release>
-            </properties>
-        </profile>
-    </profiles>
 </project>

chat/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-parent</artifactId>
-        <version>1.20-R0.2-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-chat</artifactId>
-    <version>1.20-R0.2-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>BungeeCord-Chat</name>
@@ -22,7 +22,7 @@
         <dependency>
             <groupId>com.google.code.gson</groupId>
             <artifactId>gson</artifactId>
-            <version>2.10.1</version>
+            <version>2.8.0</version>
             <scope>compile</scope>
         </dependency>
     </dependencies>

chat/src/main/java/net/md_5/bungee/api/ChatColor.java

@@ -300,7 +300,7 @@ public final class ChatColor
     @Deprecated
     public static ChatColor[] values()
     {
-        return BY_CHAR.values().toArray( new ChatColor[ 0 ] );
+        return BY_CHAR.values().toArray( new ChatColor[ BY_CHAR.values().size() ] );
     }
 
     /**

chat/src/main/java/net/md_5/bungee/api/chat/BaseComponent.java

@@ -78,12 +78,6 @@ public abstract class BaseComponent
     @Getter
     private HoverEvent hoverEvent;
 
-    /**
-     * Whether this component rejects previous formatting
-     */
-    @Getter
-    private transient boolean reset;
-
     /**
      * Default constructor.
      *

chat/src/main/java/net/md_5/bungee/api/chat/ComponentBuilder.java

@@ -57,7 +57,7 @@ public final class ComponentBuilder
      */
     public ComponentBuilder(ComponentBuilder original)
     {
-        this( original.parts.toArray( new BaseComponent[ 0 ] ) );
+        this( original.parts.toArray( new BaseComponent[ original.parts.size() ] ) );
     }
 
     /**
@@ -161,7 +161,7 @@ public final class ComponentBuilder
             previous = dummy;
             dummy = null;
         }
-        if ( previous != null && !component.isReset() )
+        if ( previous != null )
         {
             component.copyFormatting( previous, retention, false );
         }
@@ -454,32 +454,9 @@ public final class ComponentBuilder
         return this;
     }
 
-    /**
-     * Returns the component built by this builder. If this builder is
-     * empty, an empty text component will be returned.
-     *
-     * @return the component
-     */
-    public BaseComponent build()
-    {
-        TextComponent base = new TextComponent();
-        if ( !parts.isEmpty() )
-        {
-            List<BaseComponent> cloned = new ArrayList<>( parts );
-            cloned.replaceAll( BaseComponent::duplicate );
-            base.setExtra( cloned );
-        }
-        return base;
-    }
-
     /**
      * Returns the components needed to display the message created by this
      * builder.git
-     * <p>
-     * <strong>NOTE:</strong> {@link #build()} is preferred as it will
-     * consolidate all components into a single BaseComponent with extra
-     * contents as opposed to an array of components which is non-standard
-     * and may result in unexpected behavior.
      *
      * @return the created components
      */

chat/src/main/java/net/md_5/bungee/api/chat/TextComponent.java

@@ -44,7 +44,7 @@ public final class TextComponent extends BaseComponent
      */
     public static BaseComponent[] fromLegacyText(String message, ChatColor defaultColor)
     {
-        ArrayList<BaseComponent> components = new ArrayList<>();
+        ArrayList<BaseComponent> components = new ArrayList<BaseComponent>();
         StringBuilder builder = new StringBuilder();
         TextComponent component = new TextComponent();
         Matcher matcher = url.matcher( message );
@@ -111,15 +111,15 @@ public final class TextComponent extends BaseComponent
                 } else if ( format == ChatColor.MAGIC )
                 {
                     component.setObfuscated( true );
-                } else
+                } else if ( format == ChatColor.RESET )
+                {
+                    format = defaultColor;
+                    component = new TextComponent();
+                    component.setColor( format );
+                } else
                 {
-                    if ( format == ChatColor.RESET )
-                    {
-                        format = defaultColor;
-                    }
                     component = new TextComponent();
                     component.setColor( format );
-                    component.setReset( true );
                 }
                 continue;
             }
@@ -157,7 +157,7 @@ public final class TextComponent extends BaseComponent
         component.setText( builder.toString() );
         components.add( component );
 
-        return components.toArray( new BaseComponent[ 0 ] );
+        return components.toArray( new BaseComponent[ components.size() ] );
     }
 
     /**
@@ -230,6 +230,6 @@ public final class TextComponent extends BaseComponent
     @Override
     public String toString()
     {
-        return "TextComponent{text=" + text + ", " + super.toString() + '}';
+        return String.format( "TextComponent{text=%s, %s}", text, super.toString() );
     }
 }

chat/src/main/java/net/md_5/bungee/api/chat/TranslatableComponent.java

@@ -30,10 +30,6 @@ public final class TranslatableComponent extends BaseComponent
      * The components to substitute into the translation
      */
     private List<BaseComponent> with;
-    /**
-     * The fallback, if the translation is not found
-     */
-    private String fallback;
 
     /**
      * Creates a translatable component from the original to clone it.
@@ -157,11 +153,6 @@ public final class TranslatableComponent extends BaseComponent
     {
         String trans = TranslationRegistry.INSTANCE.translate( translate );
 
-        if ( trans.equals( translate ) && fallback != null )
-        {
-            trans = fallback;
-        }
-
         Matcher matcher = format.matcher( trans );
         int position = 0;
         int i = 0;

chat/src/main/java/net/md_5/bungee/api/chat/hover/content/Text.java

@@ -23,12 +23,6 @@ public class Text extends Content
         this.value = value;
     }
 
-    public Text(BaseComponent value)
-    {
-        // For legacy serialization reasons, this has to be an array of components
-        this( new BaseComponent[]{value} );
-    }
-
     public Text(String value)
     {
         this.value = value;

chat/src/main/java/net/md_5/bungee/chat/BaseComponentSerializer.java

@@ -22,6 +22,14 @@ public class BaseComponentSerializer
 
     protected void deserialize(JsonObject object, BaseComponent component, JsonDeserializationContext context)
     {
+        if ( object.has( "color" ) )
+        {
+            component.setColor( ChatColor.of( object.get( "color" ).getAsString() ) );
+        }
+        if ( object.has( "font" ) )
+        {
+            component.setFont( object.get( "font" ).getAsString() );
+        }
         if ( object.has( "bold" ) )
         {
             component.setBold( object.get( "bold" ).getAsBoolean() );
@@ -42,14 +50,14 @@ public class BaseComponentSerializer
         {
             component.setObfuscated( object.get( "obfuscated" ).getAsBoolean() );
         }
-        if ( object.has( "color" ) )
-        {
-            component.setColor( ChatColor.of( object.get( "color" ).getAsString() ) );
-        }
         if ( object.has( "insertion" ) )
         {
             component.setInsertion( object.get( "insertion" ).getAsString() );
         }
+        if ( object.has( "extra" ) )
+        {
+            component.setExtra( Arrays.asList( context.<BaseComponent[]>deserialize( object.get( "extra" ), BaseComponent[].class ) ) );
+        }
 
         //Events
         if ( object.has( "clickEvent" ) )
@@ -85,7 +93,7 @@ public class BaseComponentSerializer
                     {
                         components = new BaseComponent[]
                         {
-                            context.deserialize( contents, BaseComponent.class )
+                                context.deserialize( contents, BaseComponent.class )
                         };
                     }
                     hoverEvent = new HoverEvent( action, components );
@@ -113,15 +121,6 @@ public class BaseComponentSerializer
                 component.setHoverEvent( hoverEvent );
             }
         }
-
-        if ( object.has( "font" ) )
-        {
-            component.setFont( object.get( "font" ).getAsString() );
-        }
-        if ( object.has( "extra" ) )
-        {
-            component.setExtra( Arrays.asList( context.<BaseComponent[]>deserialize( object.get( "extra" ), BaseComponent[].class ) ) );
-        }
     }
 
     protected void serialize(JsonObject object, BaseComponent component, JsonSerializationContext context)
@@ -136,6 +135,14 @@ public class BaseComponentSerializer
         {
             Preconditions.checkArgument( !ComponentSerializer.serializedComponents.get().contains( component ), "Component loop" );
             ComponentSerializer.serializedComponents.get().add( component );
+            if ( component.getColorRaw() != null )
+            {
+                object.addProperty( "color", component.getColorRaw().getName() );
+            }
+            if ( component.getFontRaw() != null )
+            {
+                object.addProperty( "font", component.getFontRaw() );
+            }
             if ( component.isBoldRaw() != null )
             {
                 object.addProperty( "bold", component.isBoldRaw() );
@@ -156,15 +163,16 @@ public class BaseComponentSerializer
             {
                 object.addProperty( "obfuscated", component.isObfuscatedRaw() );
             }
-            if ( component.getColorRaw() != null )
-            {
-                object.addProperty( "color", component.getColorRaw().getName() );
-            }
             if ( component.getInsertion() != null )
             {
                 object.addProperty( "insertion", component.getInsertion() );
             }
 
+            if ( component.getExtra() != null )
+            {
+                object.add( "extra", context.serialize( component.getExtra() ) );
+            }
+
             //Events
             if ( component.getClickEvent() != null )
             {
@@ -187,15 +195,6 @@ public class BaseComponentSerializer
                 }
                 object.add( "hoverEvent", hoverEvent );
             }
-
-            if ( component.getFontRaw() != null )
-            {
-                object.addProperty( "font", component.getFontRaw() );
-            }
-            if ( component.getExtra() != null )
-            {
-                object.add( "extra", context.serialize( component.getExtra() ) );
-            }
         } finally
         {
             ComponentSerializer.serializedComponents.get().remove( component );

chat/src/main/java/net/md_5/bungee/chat/ComponentSerializer.java

@@ -27,6 +27,7 @@ import net.md_5.bungee.api.chat.hover.content.TextSerializer;
 public class ComponentSerializer implements JsonDeserializer<BaseComponent>
 {
 
+    private static final JsonParser JSON_PARSER = new JsonParser();
     private static final Gson gson = new GsonBuilder().
             registerTypeAdapter( BaseComponent.class, new ComponentSerializer() ).
             registerTypeAdapter( TextComponent.class, new TextComponentSerializer() ).
@@ -42,25 +43,9 @@ public class ComponentSerializer implements JsonDeserializer<BaseComponent>
 
     public static final ThreadLocal<Set<BaseComponent>> serializedComponents = new ThreadLocal<Set<BaseComponent>>();
 
-    /**
-     * Parse a JSON-compliant String as an array of base components. The input
-     * can be one of either an array of components, or a single component object.
-     * If the input is an array, each component will be parsed individually and
-     * returned in the order that they were parsed. If the input is a single
-     * component object, a single-valued array with the component will be returned.
-     * <p>
-     * <strong>NOTE:</strong> {@link #deserialize(String)} is preferred as it will
-     * parse only one component as opposed to an array of components which is non-
-     * standard behavior. This method is still appropriate for parsing multiple
-     * components at once, although such use case is rarely (if at all) exhibited
-     * in vanilla Minecraft.
-     *
-     * @param json the component json to parse
-     * @return an array of all parsed components
-     */
     public static BaseComponent[] parse(String json)
     {
-        JsonElement jsonElement = JsonParser.parseString( json );
+        JsonElement jsonElement = JSON_PARSER.parse( json );
 
         if ( jsonElement.isJsonArray() )
         {
@@ -74,26 +59,6 @@ public class ComponentSerializer implements JsonDeserializer<BaseComponent>
         }
     }
 
-    /**
-     * Deserialize a JSON-compliant String as a single component. The input is
-     * expected to be a JSON object that represents only one component.
-     *
-     * @param json the component json to parse
-     * @return the deserialized component
-     * @throws IllegalArgumentException if anything other than a JSON object is
-     * passed as input
-     */
-    public static BaseComponent deserialize(String json)
-    {
-        JsonElement jsonElement = JsonParser.parseString( json );
-        if ( !jsonElement.isJsonObject() )
-        {
-            throw new IllegalArgumentException( "Malformatted JSON. Expected object, got array for input \"" + json + "\"." );
-        }
-
-        return gson.fromJson( jsonElement, BaseComponent.class );
-    }
-
     public static String toString(Object object)
     {
         return gson.toJson( object );

chat/src/main/java/net/md_5/bungee/chat/TextComponentSerializer.java

@@ -8,6 +8,8 @@ import com.google.gson.JsonParseException;
 import com.google.gson.JsonSerializationContext;
 import com.google.gson.JsonSerializer;
 import java.lang.reflect.Type;
+import java.util.List;
+import net.md_5.bungee.api.chat.BaseComponent;
 import net.md_5.bungee.api.chat.TextComponent;
 
 public class TextComponentSerializer extends BaseComponentSerializer implements JsonSerializer<TextComponent>, JsonDeserializer<TextComponent>
@@ -30,9 +32,13 @@ public class TextComponentSerializer extends BaseComponentSerializer implements
     @Override
     public JsonElement serialize(TextComponent src, Type typeOfSrc, JsonSerializationContext context)
     {
+        List<BaseComponent> extra = src.getExtra();
         JsonObject object = new JsonObject();
-        serialize( object, src, context );
         object.addProperty( "text", src.getText() );
+        if ( src.hasFormatting() || ( extra != null && !extra.isEmpty() ) )
+        {
+            serialize( object, src, context );
+        }
         return object;
     }
 }

chat/src/main/java/net/md_5/bungee/chat/TranslatableComponentSerializer.java

@@ -28,11 +28,7 @@ public class TranslatableComponentSerializer extends BaseComponentSerializer imp
         component.setTranslate( object.get( "translate" ).getAsString() );
         if ( object.has( "with" ) )
         {
-            component.setWith( Arrays.asList( context.deserialize( object.get( "with" ), BaseComponent[].class ) ) );
-        }
-        if ( object.has( "fallback" ) )
-        {
-            component.setFallback( object.get( "fallback" ).getAsString() );
+            component.setWith( Arrays.asList( context.<BaseComponent[]>deserialize( object.get( "with" ), BaseComponent[].class ) ) );
         }
         return component;
     }
@@ -47,10 +43,6 @@ public class TranslatableComponentSerializer extends BaseComponentSerializer imp
         {
             object.add( "with", context.serialize( src.getWith() ) );
         }
-        if ( src.getFallback() != null )
-        {
-            object.addProperty( "fallback", src.getFallback() );
-        }
         return object;
     }
 }

chat/src/test/java/net/md_5/bungee/api/chat/ComponentsTest.java

@@ -1,17 +1,12 @@
 package net.md_5.bungee.api.chat;
 
-import static org.junit.jupiter.api.Assertions.*;
 import java.awt.Color;
-import java.util.function.BiFunction;
-import java.util.function.Consumer;
-import java.util.function.Function;
-import java.util.function.ObjIntConsumer;
-import java.util.function.Supplier;
 import net.md_5.bungee.api.ChatColor;
 import net.md_5.bungee.api.chat.hover.content.Item;
 import net.md_5.bungee.api.chat.hover.content.Text;
 import net.md_5.bungee.chat.ComponentSerializer;
-import org.junit.jupiter.api.Test;
+import org.junit.Assert;
+import org.junit.Test;
 
 public class ComponentsTest
 {
@@ -20,27 +15,13 @@ public class ComponentsTest
     {
         String json = ComponentSerializer.toString( components );
         BaseComponent[] parsed = ComponentSerializer.parse( json );
-        assertEquals( TextComponent.toLegacyText( parsed ), TextComponent.toLegacyText( components ) );
+        Assert.assertEquals( TextComponent.toLegacyText( parsed ), TextComponent.toLegacyText( components ) );
     }
 
-    public static void testDissembleReassemble(BaseComponent component)
+    public static void testDissembleReassemble(String json)
     {
-        String json = ComponentSerializer.toString( component );
         BaseComponent[] parsed = ComponentSerializer.parse( json );
-        assertEquals( TextComponent.toLegacyText( parsed ), TextComponent.toLegacyText( component ) );
-    }
-
-    public static void testAssembleDissemble(String json, boolean modern)
-    {
-        if ( modern )
-        {
-            BaseComponent deserialized = ComponentSerializer.deserialize( json );
-            assertEquals( json, ComponentSerializer.toString( deserialized ) );
-        } else
-        {
-            BaseComponent[] parsed = ComponentSerializer.parse( json );
-            assertEquals( json, ComponentSerializer.toString( parsed ) );
-        }
+        Assert.assertEquals( json, ComponentSerializer.toString( parsed ) );
     }
 
     @Test
@@ -60,16 +41,14 @@ public class ComponentsTest
         {
             textComponent
         } );
-        testDissembleReassemble( textComponent );
-        json = "{\"hoverEvent\":{\"action\":\"show_item\",\"value\":[{\"text\":\"{id:\\\"minecraft:netherrack\\\",Count:47b}\"}]},\"text\":\"Test\"}";
-        testAssembleDissemble( json, false );
-        testAssembleDissemble( json, true );
+        json = "{\"text\":\"Test\",\"hoverEvent\":{\"action\":\"show_item\",\"value\":[{\"text\":\"{id:\\\"minecraft:netherrack\\\",Count:47b}\"}]}}";
+        testDissembleReassemble( json );
         //////////
         String hoverVal = "{\"text\":\"{id:\\\"minecraft:dirt\\\",Count:1b}\"}";
         json = "{\"extra\":[{\"text\":\"[\"},{\"extra\":[{\"translate\":\"block.minecraft.dirt\"}],\"text\":\"\"},{\"text\":\"]\"}],\"hoverEvent\":{\"action\":\"show_item\",\"value\":[" + hoverVal + "]},\"text\":\"\"}";
         components = ComponentSerializer.parse( json );
         Text contentText = ( (Text) components[0].getHoverEvent().getContents().get( 0 ) );
-        assertEquals( hoverVal, ComponentSerializer.toString( (BaseComponent[]) contentText.getValue() ) );
+        Assert.assertEquals( hoverVal, ComponentSerializer.toString( (BaseComponent[]) contentText.getValue() ) );
         testDissembleReassemble( components );
         //////////
         TextComponent component1 = new TextComponent( "HoverableText" );
@@ -80,44 +59,25 @@ public class ComponentsTest
         json = ComponentSerializer.toString( component1 );
         components = ComponentSerializer.parse( json );
         Item parsedContentItem = ( (Item) components[0].getHoverEvent().getContents().get( 0 ) );
-        assertEquals( contentItem, parsedContentItem );
-        assertEquals( contentItem.getCount(), parsedContentItem.getCount() );
-        assertEquals( contentItem.getId(), parsedContentItem.getId() );
-        assertEquals( nbt, parsedContentItem.getTag().getNbt() );
+        Assert.assertEquals( contentItem, parsedContentItem );
+        Assert.assertEquals( contentItem.getCount(), parsedContentItem.getCount() );
+        Assert.assertEquals( contentItem.getId(), parsedContentItem.getId() );
+        Assert.assertEquals( nbt, parsedContentItem.getTag().getNbt() );
     }
 
     @Test
-    public void testEmptyComponentBuilderCreate()
-    {
-        this.testEmptyComponentBuilder(
-                ComponentBuilder::create,
-                (components) -> assertEquals( components.length, 0 ),
-                (components, size) -> assertEquals( size, components.length )
-        );
-    }
-
-    @Test
-    public void testEmptyComponentBuilderBuild()
-    {
-        this.testEmptyComponentBuilder(
-                ComponentBuilder::build,
-                (component) -> assertNull( component.getExtra() ),
-                (component, size) -> assertEquals( component.getExtra().size(), size )
-        );
-    }
-
-    private <T> void testEmptyComponentBuilder(Function<ComponentBuilder, T> componentBuilder, Consumer<T> emptyAssertion, ObjIntConsumer<T> sizedAssertion)
+    public void testEmptyComponentBuilder()
     {
         ComponentBuilder builder = new ComponentBuilder();
 
-        T component = componentBuilder.apply( builder );
-        emptyAssertion.accept( component );
+        BaseComponent[] parts = builder.create();
+        Assert.assertEquals( parts.length, 0 );
 
         for ( int i = 0; i < 3; i++ )
         {
             builder.append( "part:" + i );
-            component = componentBuilder.apply( builder );
-            sizedAssertion.accept( component, i + 1 );
+            parts = builder.create();
+            Assert.assertEquals( parts.length, i + 1 );
         }
     }
 
@@ -125,23 +85,23 @@ public class ComponentsTest
     public void testDummyRetaining()
     {
         ComponentBuilder builder = new ComponentBuilder();
-        assertNotNull( builder.getCurrentComponent() );
+        Assert.assertNotNull( builder.getCurrentComponent() );
         builder.color( ChatColor.GREEN );
         builder.append( "test ", ComponentBuilder.FormatRetention.ALL );
-        assertEquals( builder.getCurrentComponent().getColor(), ChatColor.GREEN );
+        Assert.assertEquals( builder.getCurrentComponent().getColor(), ChatColor.GREEN );
     }
 
-    @Test
+    @Test(expected = IndexOutOfBoundsException.class)
     public void testComponentGettingExceptions()
     {
         ComponentBuilder builder = new ComponentBuilder();
-        assertThrows( IndexOutOfBoundsException.class, () -> builder.getComponent( -1 ) );
-        assertThrows( IndexOutOfBoundsException.class, () -> builder.getComponent( 0 ) );
-        assertThrows( IndexOutOfBoundsException.class, () -> builder.getComponent( 1 ) );
+        builder.getComponent( -1 );
+        builder.getComponent( 0 );
+        builder.getComponent( 1 );
         BaseComponent component = new TextComponent( "Hello" );
         builder.append( component );
-        assertEquals( builder.getComponent( 0 ), component );
-        assertThrows( IndexOutOfBoundsException.class, () -> builder.getComponent( 1 ) );
+        Assert.assertEquals( builder.getComponent( 0 ), component );
+        builder.getComponent( 1 );
     }
 
     @Test
@@ -150,33 +110,33 @@ public class ComponentsTest
         ComponentBuilder builder = new ComponentBuilder();
         TextComponent apple = new TextComponent( "apple" );
         builder.append( apple );
-        assertEquals( builder.getCurrentComponent(), apple );
-        assertEquals( builder.getComponent( 0 ), apple );
+        Assert.assertEquals( builder.getCurrentComponent(), apple );
+        Assert.assertEquals( builder.getComponent( 0 ), apple );
 
         TextComponent mango = new TextComponent( "mango" );
         TextComponent orange = new TextComponent( "orange" );
         builder.append( mango );
         builder.append( orange );
         builder.removeComponent( 1 ); // Removing mango
-        assertEquals( builder.getComponent( 0 ), apple );
-        assertEquals( builder.getComponent( 1 ), orange );
+        Assert.assertEquals( builder.getComponent( 0 ), apple );
+        Assert.assertEquals( builder.getComponent( 1 ), orange );
     }
 
     @Test
     public void testToLegacyFromLegacy()
     {
         String text = "§a§lHello §f§kworld§7!";
-        assertEquals( text, TextComponent.toLegacyText( TextComponent.fromLegacyText( text ) ) );
+        Assert.assertEquals( text, TextComponent.toLegacyText( TextComponent.fromLegacyText( text ) ) );
     }
 
-    @Test
+    @Test(expected = IndexOutOfBoundsException.class)
     public void testComponentBuilderCursorInvalidPos()
     {
         ComponentBuilder builder = new ComponentBuilder();
         builder.append( new TextComponent( "Apple, " ) );
         builder.append( new TextComponent( "Orange, " ) );
-        assertThrows( IndexOutOfBoundsException.class, () -> builder.setCursor( -1 ) );
-        assertThrows( IndexOutOfBoundsException.class, () -> builder.setCursor( 2 ) );
+        builder.setCursor( -1 );
+        builder.setCursor( 2 );
     }
 
     @Test
@@ -184,24 +144,24 @@ public class ComponentsTest
     {
         TextComponent t1, t2, t3;
         ComponentBuilder builder = new ComponentBuilder();
-        assertEquals( builder.getCursor(), -1 );
+        Assert.assertEquals( builder.getCursor(), -1 );
         builder.append( t1 = new TextComponent( "Apple, " ) );
-        assertEquals( builder.getCursor(), 0 );
+        Assert.assertEquals( builder.getCursor(), 0 );
         builder.append( t2 = new TextComponent( "Orange, " ) );
         builder.append( t3 = new TextComponent( "Mango, " ) );
-        assertEquals( builder.getCursor(), 2 );
+        Assert.assertEquals( builder.getCursor(), 2 );
 
         builder.setCursor( 0 );
-        assertEquals( builder.getCurrentComponent(), t1 );
+        Assert.assertEquals( builder.getCurrentComponent(), t1 );
 
         // Test that appending new components updates the position to the new list size
         // after having previously set it to 0 (first component)
         builder.append( new TextComponent( "and Grapefruit" ) );
-        assertEquals( builder.getCursor(), 3 );
+        Assert.assertEquals( builder.getCursor(), 3 );
 
         builder.setCursor( 0 );
         builder.resetCursor();
-        assertEquals( builder.getCursor(), 3 );
+        Assert.assertEquals( builder.getCursor(), 3 );
     }
 
     @Test
@@ -210,7 +170,7 @@ public class ComponentsTest
         String text = "§a§lHello §r§kworld§7!";
         BaseComponent[] components = TextComponent.fromLegacyText( text );
         BaseComponent[] builderComponents = new ComponentBuilder().append( components ).create();
-        assertArrayEquals( components, builderComponents );
+        Assert.assertArrayEquals( components, builderComponents );
     }
 
     /*
@@ -232,7 +192,7 @@ public class ComponentsTest
         component.setHoverEvent( event );
         String serialised = ComponentSerializer.toString( component );
         BaseComponent[] deserialised = ComponentSerializer.parse( serialised );
-        assertEquals( TextComponent.toLegacyText( deserialised ), TextComponent.toLegacyText( component ) );
+        Assert.assertEquals( TextComponent.toLegacyText( deserialised ), TextComponent.toLegacyText( component ) );
     }
      */
 
@@ -247,13 +207,13 @@ public class ComponentsTest
         );
         TextComponent component = new TextComponent( "test" );
         component.setHoverEvent( hoverEvent );
-        assertEquals( component.getHoverEvent().getContents().size(), 1 );
-        assertTrue( component.getHoverEvent().getContents().get( 0 ) instanceof Text );
-        assertEquals( ( (Text) component.getHoverEvent().getContents().get( 0 ) ).getValue(), advancement );
+        Assert.assertEquals( component.getHoverEvent().getContents().size(), 1 );
+        Assert.assertTrue( component.getHoverEvent().getContents().get( 0 ) instanceof Text );
+        Assert.assertEquals( ( (Text) component.getHoverEvent().getContents().get( 0 ) ).getValue(), advancement );
     }
 
     @Test
-    public void testHoverEventContentsCreate()
+    public void testHoverEventContents()
     {
         // First do the text using the newer contents system
         HoverEvent hoverEvent = new HoverEvent(
@@ -262,53 +222,21 @@ public class ComponentsTest
                 new Text( new ComponentBuilder( "Second" ).create() )
         );
 
-        this.testHoverEventContents(
-                hoverEvent,
-                ComponentSerializer::parse,
-                (components) -> components[0].getHoverEvent(),
-                ComponentsTest::testDissembleReassemble // BaseComponent
-        );
+        TextComponent component = new TextComponent( "Sample text" );
+        component.setHoverEvent( hoverEvent );
+        Assert.assertEquals( hoverEvent.getContents().size(), 2 );
+        Assert.assertFalse( hoverEvent.isLegacy() );
+        String serialized = ComponentSerializer.toString( component );
+        BaseComponent[] deserialized = ComponentSerializer.parse( serialized );
+        Assert.assertEquals( component.getHoverEvent(), deserialized[0].getHoverEvent() );
 
         // check the test still works with the value method
         hoverEvent = new HoverEvent( HoverEvent.Action.SHOW_TEXT, new ComponentBuilder( "Sample text" ).create() );
-        TextComponent component = new TextComponent( "Sample text" );
-        component.setHoverEvent( hoverEvent );
-
-        assertEquals( hoverEvent.getContents().size(), 1 );
-        assertTrue( hoverEvent.isLegacy() );
-        String serialized = ComponentSerializer.toString( component );
-        BaseComponent[] deserialized = ComponentSerializer.parse( serialized );
-        assertEquals( component.getHoverEvent(), deserialized[0].getHoverEvent() );
-    }
-
-    @Test
-    public void testHoverEventContentsBuild()
-    {
-        // First do the text using the newer contents system
-        HoverEvent hoverEvent = new HoverEvent(
-                HoverEvent.Action.SHOW_TEXT,
-                new Text( new ComponentBuilder( "First" ).build() ),
-                new Text( new ComponentBuilder( "Second" ).build() )
-        );
-
-        this.testHoverEventContents(
-                hoverEvent,
-                ComponentSerializer::deserialize,
-                BaseComponent::getHoverEvent,
-                ComponentsTest::testDissembleReassemble // BaseComponent
-        );
-    }
-
-    private <T> void testHoverEventContents(HoverEvent hoverEvent, Function<String, T> deserializer, Function<T, HoverEvent> hoverEventGetter, Consumer<T> dissembleReassembleTest)
-    {
-        TextComponent component = new TextComponent( "Sample text" );
-        component.setHoverEvent( hoverEvent );
-        assertEquals( hoverEvent.getContents().size(), 2 );
-        assertFalse( hoverEvent.isLegacy() );
-
-        String serialized = ComponentSerializer.toString( component );
-        T deserialized = deserializer.apply( serialized );
-        assertEquals( component.getHoverEvent(), hoverEventGetter.apply( deserialized ) );
+        Assert.assertEquals( hoverEvent.getContents().size(), 1 );
+        Assert.assertTrue( hoverEvent.isLegacy() );
+        serialized = ComponentSerializer.toString( component );
+        deserialized = ComponentSerializer.parse( serialized );
+        Assert.assertEquals( component.getHoverEvent(), deserialized[0].getHoverEvent() );
 
         // Test single content:
         String json = "{\"italic\":true,\"color\":\"gray\",\"translate\":\"chat.type.admin\",\"with\":[{\"text\":\"@\"}"
@@ -320,76 +248,37 @@ public class ComponentsTest
                 + "\"/tell Name \"},\"hoverEvent\":{\"action\":\"show_entity\",\"contents\":"
                 + "{\"type\":\"minecraft:player\",\"id\":\"00000000-0000-0000-0000-00000000000000\",\"name\":"
                 + "{\"text\":\"Name\"}}},\"text\":\"Name\"}]}]}";
-        dissembleReassembleTest.accept( deserializer.apply( json ) );
+        testDissembleReassemble( ComponentSerializer.parse( json ) );
     }
 
     @Test
-    public void testFormatRetentionCopyFormattingCreate()
-    {
-        this.testFormatRetentionCopyFormatting( () -> new HoverEvent( HoverEvent.Action.SHOW_TEXT, new ComponentBuilder( "Test" ).create() ) );
-    }
-
-    @Test
-    public void testFormatRetentionCopyFormattingBuild()
-    {
-        this.testFormatRetentionCopyFormatting( () -> new HoverEvent( HoverEvent.Action.SHOW_TEXT, new Text( new ComponentBuilder( "Test" ).build() ) ) );
-    }
-
-    private void testFormatRetentionCopyFormatting(Supplier<HoverEvent> hoverEventSupplier)
+    public void testFormatRetentionCopyFormatting()
     {
         TextComponent first = new TextComponent( "Hello" );
         first.setBold( true );
         first.setColor( ChatColor.RED );
         first.setClickEvent( new ClickEvent( ClickEvent.Action.RUN_COMMAND, "test" ) );
-        first.setHoverEvent( hoverEventSupplier.get() );
+        first.setHoverEvent( new HoverEvent( HoverEvent.Action.SHOW_TEXT, new ComponentBuilder( "Test" ).create() ) );
 
         TextComponent second = new TextComponent( " world" );
         second.copyFormatting( first, ComponentBuilder.FormatRetention.ALL, true );
-        assertEquals( first.isBold(), second.isBold() );
-        assertEquals( first.getColor(), second.getColor() );
-        assertEquals( first.getClickEvent(), second.getClickEvent() );
-        assertEquals( first.getHoverEvent(), second.getHoverEvent() );
+        Assert.assertEquals( first.isBold(), second.isBold() );
+        Assert.assertEquals( first.getColor(), second.getColor() );
+        Assert.assertEquals( first.getClickEvent(), second.getClickEvent() );
+        Assert.assertEquals( first.getHoverEvent(), second.getHoverEvent() );
     }
 
     @Test
-    public void testBuilderCloneCreate()
-    {
-        this.testBuilderClone( (builder) -> TextComponent.toLegacyText( builder.create() ) );
-    }
-
-    @Test
-    public void testBuilderCloneBuild()
-    {
-        this.testBuilderClone( (builder) -> TextComponent.toLegacyText( builder.build() ) );
-    }
-
-    private void testBuilderClone(Function<ComponentBuilder, String> legacyTextFunction)
+    public void testBuilderClone()
     {
         ComponentBuilder builder = new ComponentBuilder( "Hello " ).color( ChatColor.RED ).append( "world" ).color( ChatColor.DARK_RED );
         ComponentBuilder cloned = new ComponentBuilder( builder );
 
-        assertEquals( legacyTextFunction.apply( builder ), legacyTextFunction.apply( cloned ) );
+        Assert.assertEquals( TextComponent.toLegacyText( builder.create() ), TextComponent.toLegacyText( cloned.create() ) );
     }
 
     @Test
-    public void testBuilderAppendCreateMixedComponents()
-    {
-        this.testBuilderAppendMixedComponents(
-                ComponentBuilder::create,
-                (components, index) -> components[index]
-        );
-    }
-
-    @Test
-    public void testBuilderAppendBuildMixedComponents()
-    {
-        this.testBuilderAppendMixedComponents(
-                ComponentBuilder::build,
-                (component, index) -> component.getExtra().get( index )
-        );
-    }
-
-    private <T> void testBuilderAppendMixedComponents(Function<ComponentBuilder, T> componentBuilder, BiFunction<T, Integer, BaseComponent> extraGetter)
+    public void testBuilderAppendMixedComponents()
     {
         ComponentBuilder builder = new ComponentBuilder( "Hello " );
         TextComponent textComponent = new TextComponent( "world " );
@@ -402,11 +291,11 @@ public class ComponentsTest
         } );
         ScoreComponent scoreComponent = new ScoreComponent( "myscore", "myobjective" );
         builder.append( scoreComponent ); // non array based BaseComponent append
-        T component = componentBuilder.apply( builder );
-        assertEquals( "Hello ", extraGetter.apply( component, 0 ).toPlainText() );
-        assertEquals( textComponent.toPlainText(), extraGetter.apply( component, 1 ).toPlainText() );
-        assertEquals( translatableComponent.toPlainText(), extraGetter.apply( component, 2 ).toPlainText() );
-        assertEquals( scoreComponent.toPlainText(), extraGetter.apply( component, 3 ).toPlainText() );
+        BaseComponent[] components = builder.create();
+        Assert.assertEquals( "Hello ", components[0].toPlainText() );
+        Assert.assertEquals( textComponent.toPlainText(), components[1].toPlainText() );
+        Assert.assertEquals( translatableComponent.toPlainText(), components[2].toPlainText() );
+        Assert.assertEquals( scoreComponent.toPlainText(), components[3].toPlainText() );
     }
 
     @Test
@@ -416,84 +305,36 @@ public class ComponentsTest
         String text = ComponentSerializer.toString( component );
         BaseComponent[] reparsed = ComponentSerializer.parse( text );
 
-        assertArrayEquals( component, reparsed );
+        Assert.assertArrayEquals( component, reparsed );
     }
 
     @Test
-    public void testBuilderAppendCreate()
-    {
-        this.testBuilderAppend(
-                () -> new HoverEvent( HoverEvent.Action.SHOW_TEXT, new ComponentBuilder( "Hello world" ).create() ),
-                ComponentBuilder::create,
-                (components, index) -> components[index],
-                BaseComponent::toPlainText,
-                ChatColor.YELLOW + "Hello " + ChatColor.GREEN + "world!",
-                BaseComponent::toLegacyText
-        );
-    }
-
-    @Test
-    public void testBuilderAppendBuild()
-    {
-        this.testBuilderAppend(
-                () -> new HoverEvent( HoverEvent.Action.SHOW_TEXT, new Text( new ComponentBuilder( "Hello world" ).build() ) ),
-                ComponentBuilder::build,
-                (component, index) -> component.getExtra().get( index ),
-                (component) -> BaseComponent.toPlainText( component ),
-                // An extra format code is appended to the beginning because there is an empty TextComponent at the start of every component
-                ChatColor.WHITE.toString() + ChatColor.YELLOW + "Hello " + ChatColor.GREEN + "world!",
-                (component) -> BaseComponent.toLegacyText( component )
-        );
-    }
-
-    private <T> void testBuilderAppend(Supplier<HoverEvent> hoverEventSupplier, Function<ComponentBuilder, T> componentBuilder, BiFunction<T, Integer, BaseComponent> extraGetter, Function<T, String> toPlainTextFunction, String expectedLegacyText, Function<T, String> toLegacyTextFunction)
+    public void testBuilderAppend()
     {
         ClickEvent clickEvent = new ClickEvent( ClickEvent.Action.RUN_COMMAND, "/help " );
-        HoverEvent hoverEvent = hoverEventSupplier.get();
+        HoverEvent hoverEvent = new HoverEvent( HoverEvent.Action.SHOW_TEXT, new ComponentBuilder( "Hello world" ).create() );
 
         ComponentBuilder builder = new ComponentBuilder( "Hello " ).color( ChatColor.YELLOW );
-        builder.append( new ComponentBuilder( "world!" ).color( ChatColor.GREEN ).event( hoverEvent ).event( clickEvent ).create() ); // Intentionally using create() to append multiple individual components
+        builder.append( new ComponentBuilder( "world!" ).color( ChatColor.GREEN ).event( hoverEvent ).event( clickEvent ).create() );
 
-        T component = componentBuilder.apply( builder );
+        BaseComponent[] components = builder.create();
 
-        assertEquals( extraGetter.apply( component, 1 ).getHoverEvent(), hoverEvent );
-        assertEquals( extraGetter.apply( component, 1 ).getClickEvent(), clickEvent );
-        assertEquals( "Hello world!", toPlainTextFunction.apply( component ) );
-        assertEquals( expectedLegacyText, toLegacyTextFunction.apply( component ) );
+        Assert.assertEquals( components[1].getHoverEvent(), hoverEvent );
+        Assert.assertEquals( components[1].getClickEvent(), clickEvent );
+        Assert.assertEquals( "Hello world!", BaseComponent.toPlainText( components ) );
+        Assert.assertEquals( ChatColor.YELLOW + "Hello " + ChatColor.GREEN + "world!", BaseComponent.toLegacyText( components ) );
     }
 
     @Test
-    public void testBuilderAppendLegacyCreate()
-    {
-        this.testBuilderAppendLegacy(
-                ComponentBuilder::create,
-                BaseComponent::toPlainText,
-                ChatColor.YELLOW + "Hello " + ChatColor.GREEN + "world!",
-                BaseComponent::toLegacyText
-        );
-    }
-
-    @Test
-    public void testBuilderAppendLegacyBuild()
-    {
-        this.testBuilderAppendLegacy(
-                ComponentBuilder::build,
-                (component) -> BaseComponent.toPlainText( component ),
-                // An extra format code is appended to the beginning because there is an empty TextComponent at the start of every component
-                ChatColor.WHITE.toString() + ChatColor.YELLOW + "Hello " + ChatColor.GREEN + "world!",
-                (component) -> BaseComponent.toLegacyText( component )
-        );
-    }
-
-    private <T> void testBuilderAppendLegacy(Function<ComponentBuilder, T> componentBuilder, Function<T, String> toPlainTextFunction, String expectedLegacyString, Function<T, String> toLegacyTextFunction)
+    public void testBuilderAppendLegacy()
     {
         ComponentBuilder builder = new ComponentBuilder( "Hello " ).color( ChatColor.YELLOW );
         builder.appendLegacy( "§aworld!" );
 
-        T component = componentBuilder.apply( builder );
+        BaseComponent[] components = builder.create();
 
-        assertEquals( "Hello world!", toPlainTextFunction.apply( component ) );
-        assertEquals( expectedLegacyString, toLegacyTextFunction.apply( component ) );
+        Assert.assertEquals( "Hello world!", BaseComponent.toPlainText( components ) );
+        Assert.assertEquals( ChatColor.YELLOW + "Hello " + ChatColor.GREEN + "world!", BaseComponent.toLegacyText( components ) );
     }
 
     @Test
@@ -502,8 +343,8 @@ public class ComponentsTest
         TextComponent textComponent = new TextComponent( "Hello world" );
         textComponent.setColor( ChatColor.RED );
 
-        assertEquals( "Hello world", textComponent.toPlainText() );
-        assertEquals( ChatColor.RED + "Hello world", textComponent.toLegacyText() );
+        Assert.assertEquals( "Hello world", textComponent.toPlainText() );
+        Assert.assertEquals( ChatColor.RED + "Hello world", textComponent.toLegacyText() );
     }
 
     @Test
@@ -511,25 +352,25 @@ public class ComponentsTest
     {
         BaseComponent[] test1 = TextComponent.fromLegacyText( ChatColor.AQUA + "Aqua " + ChatColor.RED + ChatColor.BOLD + "RedBold" );
 
-        assertEquals( "Aqua RedBold", BaseComponent.toPlainText( test1 ) );
-        assertEquals( ChatColor.AQUA + "Aqua " + ChatColor.RED + ChatColor.BOLD + "RedBold", BaseComponent.toLegacyText( test1 ) );
+        Assert.assertEquals( "Aqua RedBold", BaseComponent.toPlainText( test1 ) );
+        Assert.assertEquals( ChatColor.AQUA + "Aqua " + ChatColor.RED + ChatColor.BOLD + "RedBold", BaseComponent.toLegacyText( test1 ) );
 
         BaseComponent[] test2 = TextComponent.fromLegacyText( "Text http://spigotmc.org " + ChatColor.GREEN + "google.com/test" );
 
-        assertEquals( "Text http://spigotmc.org google.com/test", BaseComponent.toPlainText( test2 ) );
+        Assert.assertEquals( "Text http://spigotmc.org google.com/test", BaseComponent.toPlainText( test2 ) );
         //The extra ChatColor instances are sometimes inserted when not needed but it doesn't change the result
-        assertEquals( ChatColor.WHITE + "Text " + ChatColor.WHITE + "http://spigotmc.org" + ChatColor.WHITE
+        Assert.assertEquals( ChatColor.WHITE + "Text " + ChatColor.WHITE + "http://spigotmc.org" + ChatColor.WHITE
                 + " " + ChatColor.GREEN + "google.com/test" + ChatColor.GREEN, BaseComponent.toLegacyText( test2 ) );
 
         ClickEvent url1 = test2[1].getClickEvent();
-        assertNotNull( url1 );
-        assertTrue( url1.getAction() == ClickEvent.Action.OPEN_URL );
-        assertEquals( "http://spigotmc.org", url1.getValue() );
+        Assert.assertNotNull( url1 );
+        Assert.assertTrue( url1.getAction() == ClickEvent.Action.OPEN_URL );
+        Assert.assertEquals( "http://spigotmc.org", url1.getValue() );
 
         ClickEvent url2 = test2[3].getClickEvent();
-        assertNotNull( url2 );
-        assertTrue( url2.getAction() == ClickEvent.Action.OPEN_URL );
-        assertEquals( "http://google.com/test", url2.getValue() );
+        Assert.assertNotNull( url2 );
+        Assert.assertTrue( url2.getAction() == ClickEvent.Action.OPEN_URL );
+        Assert.assertEquals( "http://google.com/test", url2.getValue() );
     }
 
     @Test
@@ -541,140 +382,83 @@ public class ComponentsTest
                 item, "5",
                 "thinkofdeath" );
 
-        assertEquals( "Given Golden Sword * 5 to thinkofdeath", translatableComponent.toPlainText() );
-        assertEquals( ChatColor.WHITE + "Given " + ChatColor.AQUA + "Golden Sword" + ChatColor.WHITE
+        Assert.assertEquals( "Given Golden Sword * 5 to thinkofdeath", translatableComponent.toPlainText() );
+        Assert.assertEquals( ChatColor.WHITE + "Given " + ChatColor.AQUA + "Golden Sword" + ChatColor.WHITE
                 + " * " + ChatColor.WHITE + "5" + ChatColor.WHITE + " to " + ChatColor.WHITE + "thinkofdeath",
                 translatableComponent.toLegacyText() );
 
         TranslatableComponent positional = new TranslatableComponent( "book.pageIndicator", "5", "50" );
 
-        assertEquals( "Page 5 of 50", positional.toPlainText() );
-        assertEquals( ChatColor.WHITE + "Page " + ChatColor.WHITE + "5" + ChatColor.WHITE + " of " + ChatColor.WHITE + "50", positional.toLegacyText() );
+        Assert.assertEquals( "Page 5 of 50", positional.toPlainText() );
+        Assert.assertEquals( ChatColor.WHITE + "Page " + ChatColor.WHITE + "5" + ChatColor.WHITE + " of " + ChatColor.WHITE + "50", positional.toLegacyText() );
 
         TranslatableComponent one_four_two = new TranslatableComponent( "filled_map.buried_treasure" );
-        assertEquals( "Buried Treasure Map", one_four_two.toPlainText() );
+        Assert.assertEquals( "Buried Treasure Map", one_four_two.toPlainText() );
     }
 
     @Test
-    public void testBuilderCreate()
+    public void testBuilder()
     {
-        this.testBuilder(
-                ComponentBuilder::create,
-                BaseComponent::toPlainText,
-                ChatColor.RED + "Hello " + ChatColor.BLUE + ChatColor.BOLD
-                    + "World" + ChatColor.YELLOW + ChatColor.BOLD + "!",
-                BaseComponent::toLegacyText
-        );
-    }
-
-    @Test
-    public void testBuilderBuild()
-    {
-        this.testBuilder(
-                ComponentBuilder::build,
-                (component) -> BaseComponent.toPlainText( component ),
-                // An extra format code is appended to the beginning because there is an empty TextComponent at the start of every component
-                ChatColor.WHITE.toString() + ChatColor.RED + "Hello " + ChatColor.BLUE + ChatColor.BOLD
-                    + "World" + ChatColor.YELLOW + ChatColor.BOLD + "!",
-                (component) -> BaseComponent.toLegacyText( component )
-        );
-    }
-
-    private <T> void testBuilder(Function<ComponentBuilder, T> componentBuilder, Function<T, String> toPlainTextFunction, String expectedLegacyString, Function<T, String> toLegacyTextFunction)
-    {
-        T component = componentBuilder.apply( new ComponentBuilder( "Hello " ).color( ChatColor.RED ).
+        BaseComponent[] components = new ComponentBuilder( "Hello " ).color( ChatColor.RED ).
                 append( "World" ).bold( true ).color( ChatColor.BLUE ).
-                append( "!" ).color( ChatColor.YELLOW ) );
+                append( "!" ).color( ChatColor.YELLOW ).create();
 
-        assertEquals( "Hello World!", toPlainTextFunction.apply( component ) );
-        assertEquals( expectedLegacyString, toLegacyTextFunction.apply( component ) );
+        Assert.assertEquals( "Hello World!", BaseComponent.toPlainText( components ) );
+        Assert.assertEquals( ChatColor.RED + "Hello " + ChatColor.BLUE + ChatColor.BOLD
+                + "World" + ChatColor.YELLOW + ChatColor.BOLD + "!", BaseComponent.toLegacyText( components ) );
     }
 
     @Test
-    public void testBuilderCreateReset()
+    public void testBuilderReset()
     {
-        this.testBuilderReset(
-                ComponentBuilder::create,
-                (components, index) -> components[index]
-        );
+        BaseComponent[] components = new ComponentBuilder( "Hello " ).color( ChatColor.RED )
+                .append( "World" ).reset().create();
+
+        Assert.assertEquals( components[0].getColor(), ChatColor.RED );
+        Assert.assertEquals( components[1].getColor(), ChatColor.WHITE );
     }
 
     @Test
-    public void testBuilderBuildReset()
+    public void testBuilderFormatRetention()
     {
-        this.testBuilderReset(
-                ComponentBuilder::build,
-                (component, index) -> component.getExtra().get( index )
-        );
-    }
+        BaseComponent[] noneRetention = new ComponentBuilder( "Hello " ).color( ChatColor.RED )
+                .append( "World", ComponentBuilder.FormatRetention.NONE ).create();
 
-    private <T> void testBuilderReset(Function<ComponentBuilder, T> componentBuilder, BiFunction<T, Integer, BaseComponent> extraGetter)
-    {
-        T component = componentBuilder.apply( new ComponentBuilder( "Hello " ).color( ChatColor.RED )
-                .append( "World" ).reset() );
+        Assert.assertEquals( noneRetention[0].getColor(), ChatColor.RED );
+        Assert.assertEquals( noneRetention[1].getColor(), ChatColor.WHITE );
 
-        assertEquals( ChatColor.RED, extraGetter.apply( component, 0 ).getColor() );
-        assertEquals( ChatColor.WHITE, extraGetter.apply( component, 1 ).getColor() );
-    }
+        HoverEvent testEvent = new HoverEvent( HoverEvent.Action.SHOW_TEXT, new ComponentBuilder( "test" ).create() );
 
-    @Test
-    public void testBuilderCreateFormatRetention()
-    {
-        this.testBuilderFormatRetention(
-                ComponentBuilder::create,
-                (components, index) -> components[index]
-        );
-    }
+        BaseComponent[] formattingRetention = new ComponentBuilder( "Hello " ).color( ChatColor.RED )
+                .event( testEvent ).append( "World", ComponentBuilder.FormatRetention.FORMATTING ).create();
 
-    @Test
-    public void testBuilderBuildFormatRetention()
-    {
-        this.testBuilderFormatRetention(
-                ComponentBuilder::build,
-                (component, index) -> component.getExtra().get( index )
-        );
-    }
-
-    private <T> void testBuilderFormatRetention(Function<ComponentBuilder, T> componentBuilder, BiFunction<T, Integer, BaseComponent> extraGetter)
-    {
-        T noneRetention = componentBuilder.apply( new ComponentBuilder( "Hello " ).color( ChatColor.RED )
-                .append( "World", ComponentBuilder.FormatRetention.NONE ) );
-
-        assertEquals( ChatColor.RED, extraGetter.apply( noneRetention, 0 ).getColor() );
-        assertEquals( ChatColor.WHITE, extraGetter.apply( noneRetention, 1 ).getColor() );
-
-        HoverEvent testEvent = new HoverEvent( HoverEvent.Action.SHOW_TEXT, new Text( new ComponentBuilder( "test" ).build() ) );
-
-        T formattingRetention = componentBuilder.apply( new ComponentBuilder( "Hello " ).color( ChatColor.RED )
-                .event( testEvent ).append( "World", ComponentBuilder.FormatRetention.FORMATTING ) );
-
-        assertEquals( ChatColor.RED, extraGetter.apply( formattingRetention, 0 ).getColor() );
-        assertEquals( testEvent, extraGetter.apply( formattingRetention, 0 ).getHoverEvent() );
-        assertEquals( ChatColor.RED, extraGetter.apply( formattingRetention, 1 ).getColor() );
-        assertNull( extraGetter.apply( formattingRetention, 1 ).getHoverEvent() );
+        Assert.assertEquals( formattingRetention[0].getColor(), ChatColor.RED );
+        Assert.assertEquals( formattingRetention[0].getHoverEvent(), testEvent );
+        Assert.assertEquals( formattingRetention[1].getColor(), ChatColor.RED );
+        Assert.assertNull( formattingRetention[1].getHoverEvent() );
 
         ClickEvent testClickEvent = new ClickEvent( ClickEvent.Action.OPEN_URL, "http://www.example.com" );
 
-        T eventRetention = componentBuilder.apply( new ComponentBuilder( "Hello " ).color( ChatColor.RED )
-                .event( testEvent ).event( testClickEvent ).append( "World", ComponentBuilder.FormatRetention.EVENTS ) );
+        BaseComponent[] eventRetention = new ComponentBuilder( "Hello " ).color( ChatColor.RED )
+                .event( testEvent ).event( testClickEvent ).append( "World", ComponentBuilder.FormatRetention.EVENTS ).create();
 
-        assertEquals( ChatColor.RED, extraGetter.apply( eventRetention, 0 ).getColor() );
-        assertEquals( testEvent, extraGetter.apply( eventRetention, 0 ).getHoverEvent() );
-        assertEquals( testClickEvent, extraGetter.apply( eventRetention, 0 ).getClickEvent() );
-        assertEquals( ChatColor.WHITE, extraGetter.apply( eventRetention, 1 ).getColor() );
-        assertEquals( testEvent, extraGetter.apply( eventRetention, 1 ).getHoverEvent() );
-        assertEquals( testClickEvent, extraGetter.apply( eventRetention, 1 ).getClickEvent() );
+        Assert.assertEquals( eventRetention[0].getColor(), ChatColor.RED );
+        Assert.assertEquals( eventRetention[0].getHoverEvent(), testEvent );
+        Assert.assertEquals( eventRetention[0].getClickEvent(), testClickEvent );
+        Assert.assertEquals( eventRetention[1].getColor(), ChatColor.WHITE );
+        Assert.assertEquals( eventRetention[1].getHoverEvent(), testEvent );
+        Assert.assertEquals( eventRetention[1].getClickEvent(), testClickEvent );
     }
 
-    @Test
+    @Test(expected = IllegalArgumentException.class)
     public void testLoopSimple()
     {
         TextComponent component = new TextComponent( "Testing" );
         component.addExtra( component );
-        assertThrows( IllegalArgumentException.class, () -> ComponentSerializer.toString( component ) );
+        ComponentSerializer.toString( component );
     }
 
-    @Test
+    @Test(expected = IllegalArgumentException.class)
     public void testLoopComplex()
     {
         TextComponent a = new TextComponent( "A" );
@@ -685,7 +469,7 @@ public class ComponentsTest
         a.addExtra( b );
         b.addExtra( c );
         c.addExtra( a );
-        assertThrows( IllegalArgumentException.class, () -> ComponentSerializer.toString( a ) );
+        ComponentSerializer.toString( a );
     }
 
     @Test
@@ -699,7 +483,7 @@ public class ComponentsTest
         ComponentSerializer.toString( a );
     }
 
-    @Test
+    @Test(expected = IllegalArgumentException.class)
     public void testRepeatedError()
     {
         TextComponent a = new TextComponent( "A" );
@@ -711,7 +495,7 @@ public class ComponentsTest
         a.addExtra( c );
         c.addExtra( a );
         a.addExtra( b );
-        assertThrows( IllegalArgumentException.class, () -> ComponentSerializer.toString( a ) );
+        ComponentSerializer.toString( a );
     }
 
     @Test
@@ -736,7 +520,7 @@ public class ComponentsTest
         String emptyLegacyText = fromAndToLegacyText( "" );
 
         // all invalid color codes and the trailing '§' should be ignored
-        assertEquals( emptyLegacyText, invalidColorCodesLegacyText );
+        Assert.assertEquals( emptyLegacyText, invalidColorCodesLegacyText );
     }
 
     @Test
@@ -745,12 +529,12 @@ public class ComponentsTest
         String text = "§a";
 
         BaseComponent[] converted = TextComponent.fromLegacyText( text );
-        assertEquals( ChatColor.GREEN, converted[0].getColor() );
+        Assert.assertEquals( ChatColor.GREEN, converted[0].getColor() );
 
         String roundtripLegacyText = BaseComponent.toLegacyText( converted );
 
         // color code should not be lost during conversion
-        assertEquals( text, roundtripLegacyText );
+        Assert.assertEquals( text, roundtripLegacyText );
     }
 
     @Test
@@ -762,7 +546,7 @@ public class ComponentsTest
         TextComponent second = new TextComponent( "Hello, " );
         second.addExtra( new TextComponent( "World!" ) );
 
-        assertEquals( first, second );
+        Assert.assertEquals( first, second );
     }
 
     @Test
@@ -774,7 +558,7 @@ public class ComponentsTest
         TextComponent second = new TextComponent( "Hello, " );
         second.addExtra( new TextComponent( "World!" ) );
 
-        assertNotEquals( first, second );
+        Assert.assertNotEquals( first, second );
     }
 
     @Test
@@ -785,57 +569,10 @@ public class ComponentsTest
 
         BaseComponent[] reColored = TextComponent.fromLegacyText( legacy );
 
-        assertArrayEquals( hexColored, reColored );
+        Assert.assertArrayEquals( hexColored, reColored );
     }
 
-    @Test
-    public void testLegacyResetInBuilderCreate()
-    {
-        this.testLegacyResetInBuilder(
-                ComponentBuilder::create,
-                ComponentSerializer::toString
-        );
-    }
-
-    @Test
-    public void testLegacyResetInBuilderBuild()
-    {
-        this.testLegacyResetInBuilder(
-                ComponentBuilder::build,
-                ComponentSerializer::toString
-        );
-    }
-
-    /*
-     * In legacy chat, colors and reset both reset all formatting.
-     * Make sure it works in combination with ComponentBuilder.
-     */
-    private <T> void testLegacyResetInBuilder(Function<ComponentBuilder, T> componentBuilder, Function<T, String> componentSerializer)
-    {
-        ComponentBuilder builder = new ComponentBuilder();
-        BaseComponent[] a = TextComponent.fromLegacyText( "§4§n44444§rdd§6§l6666" );
-
-        String expected = "{\"extra\":[{\"underlined\":true,\"color\":\"dark_red\",\"text\":\"44444\"},{\"color\":"
-                + "\"white\",\"text\":\"dd\"},{\"bold\":true,\"color\":\"gold\",\"text\":\"6666\"}],\"text\":\"\"}";
-        assertEquals( expected, ComponentSerializer.toString( a ) );
-
-        builder.append( a );
-
-        String test1 = componentSerializer.apply( componentBuilder.apply( builder ) );
-        assertEquals( expected, test1 );
-
-        BaseComponent[] b = TextComponent.fromLegacyText( "§rrrrr" );
-        builder.append( b );
-
-        String test2 = componentSerializer.apply( componentBuilder.apply( builder ) );
-        assertEquals(
-                "{\"extra\":[{\"underlined\":true,\"color\":\"dark_red\",\"text\":\"44444\"},"
-                        + "{\"color\":\"white\",\"text\":\"dd\"},{\"bold\":true,\"color\":\"gold\",\"text\":\"6666\"},"
-                        + "{\"color\":\"white\",\"text\":\"rrrr\"}],\"text\":\"\"}",
-                test2 );
-    }
-
-    private static String fromAndToLegacyText(String legacyText)
+    private String fromAndToLegacyText(String legacyText)
     {
         return BaseComponent.toLegacyText( TextComponent.fromLegacyText( legacyText ) );
     }

chat/src/test/java/net/md_5/bungee/api/chat/TranslatableComponentTest.java

@@ -1,8 +1,8 @@
 package net.md_5.bungee.api.chat;
 
-import static org.junit.jupiter.api.Assertions.*;
 import net.md_5.bungee.chat.ComponentSerializer;
-import org.junit.jupiter.api.Test;
+import org.junit.Assert;
+import org.junit.Test;
 
 public class TranslatableComponentTest
 {
@@ -11,8 +11,8 @@ public class TranslatableComponentTest
     public void testMissingPlaceholdersAdded()
     {
         TranslatableComponent testComponent = new TranslatableComponent( "Test string with %s placeholders: %s", 2, "aoeu" );
-        assertEquals( "Test string with 2 placeholders: aoeu", testComponent.toPlainText() );
-        assertEquals( "§fTest string with §f2§f placeholders: §faoeu", testComponent.toLegacyText() );
+        Assert.assertEquals( "Test string with 2 placeholders: aoeu", testComponent.toPlainText() );
+        Assert.assertEquals( "§fTest string with §f2§f placeholders: §faoeu", testComponent.toLegacyText() );
     }
 
     @Test
@@ -22,7 +22,7 @@ public class TranslatableComponentTest
         String jsonString = ComponentSerializer.toString( testComponent );
         BaseComponent[] baseComponents = ComponentSerializer.parse( jsonString );
 
-        assertEquals( "Test string with a placeholder", TextComponent.toPlainText( baseComponents ) );
-        assertEquals( "§fTest string with §fa§f placeholder", TextComponent.toLegacyText( baseComponents ) );
+        Assert.assertEquals( "Test string with a placeholder", TextComponent.toPlainText( baseComponents ) );
+        Assert.assertEquals( "§fTest string with §fa§f placeholder", TextComponent.toLegacyText( baseComponents ) );
     }
 }

checkstyle.xml

@@ -33,9 +33,9 @@
 
         <!-- See http://checkstyle.sourceforge.net/config_filters.html -->
         <module name="SuppressionCommentFilter"/>
-        <module name="SuppressWarningsHolder"/>
 
         <!-- See http://checkstyle.sourceforge.net/config_imports.html -->
+        <module name="AvoidStarImport"/>
         <module name="ImportOrder">
             <property name="option" value="above"/>
             <property name="ordered" value="true"/>
@@ -54,11 +54,11 @@
         <module name="OperatorWrap"/>
         <module name="ParenPad">
             <property name="option" value="nospace"/>
-            <property name="tokens" value="ANNOTATION, CTOR_DEF, METHOD_DEF, LAMBDA"/>
+            <property name="tokens" value="ANNOTATION, CTOR_DEF, METHOD_DEF"/>
         </module>
         <module name="ParenPad">
             <property name="option" value="space"/>
-            <property name="tokens" value="ANNOTATION_FIELD_DEF, CTOR_CALL, DOT, ENUM_CONSTANT_DEF, EXPR, LITERAL_CATCH, LITERAL_DO, LITERAL_FOR, LITERAL_IF, LITERAL_NEW, LITERAL_SWITCH, LITERAL_SYNCHRONIZED, LITERAL_WHILE, METHOD_CALL, QUESTION, RESOURCE_SPECIFICATION, SUPER_CTOR_CALL, RECORD_DEF"/>
+            <property name="tokens" value="ANNOTATION_FIELD_DEF, CTOR_CALL, DOT, ENUM_CONSTANT_DEF, EXPR, LITERAL_CATCH, LITERAL_DO, LITERAL_FOR, LITERAL_IF, LITERAL_NEW, LITERAL_SWITCH, LITERAL_SYNCHRONIZED, LITERAL_WHILE, METHOD_CALL, QUESTION, RESOURCE_SPECIFICATION, SUPER_CTOR_CALL, LAMBDA"/>
         </module>
         <module name="SingleSpaceSeparator"/>
         <module name="TypecastParenPad"/>
@@ -84,6 +84,4 @@
         <module name="Indentation"/>
         <module name="UpperEll"/>
     </module>
-
-    <module name="SuppressWarningsFilter"/>
 </module>

config/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-parent</artifactId>
-        <version>1.20-R0.2-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-config</artifactId>
-    <version>1.20-R0.2-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>BungeeCord-Config</name>
@@ -22,14 +22,14 @@
         <dependency>
             <groupId>com.google.code.gson</groupId>
             <artifactId>gson</artifactId>
-            <version>2.10.1</version>
+            <version>2.8.0</version>
             <scope>compile</scope>
             <optional>true</optional>
         </dependency>
         <dependency>
             <groupId>org.yaml</groupId>
             <artifactId>snakeyaml</artifactId>
-            <version>2.2</version>
+            <version>1.26</version>
             <scope>compile</scope>
             <optional>true</optional>
         </dependency>

config/src/main/java/net/md_5/bungee/config/YamlConfiguration.java

@@ -14,7 +14,6 @@ import java.util.Map;
 import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 import org.yaml.snakeyaml.DumperOptions;
-import org.yaml.snakeyaml.LoaderOptions;
 import org.yaml.snakeyaml.Yaml;
 import org.yaml.snakeyaml.constructor.Constructor;
 import org.yaml.snakeyaml.nodes.Node;
@@ -30,10 +29,7 @@ public class YamlConfiguration extends ConfigurationProvider
         @Override
         protected Yaml initialValue()
         {
-            DumperOptions options = new DumperOptions();
-            options.setDefaultFlowStyle( DumperOptions.FlowStyle.BLOCK );
-
-            Representer representer = new Representer( options )
+            Representer representer = new Representer()
             {
                 {
                     representers.put( Configuration.class, new Represent()
@@ -47,7 +43,10 @@ public class YamlConfiguration extends ConfigurationProvider
                 }
             };
 
-            return new Yaml( new Constructor( new LoaderOptions() ), representer, options );
+            DumperOptions options = new DumperOptions();
+            options.setDefaultFlowStyle( DumperOptions.FlowStyle.BLOCK );
+
+            return new Yaml( new Constructor(), representer, options );
         }
     };
 

config/src/test/java/net/md_5/bungee/config/CompoundConfigurationTest.java

@@ -1,138 +1,148 @@
 package net.md_5.bungee.config;
 
-import static org.junit.jupiter.api.Assertions.*;
 import java.io.StringReader;
 import java.io.StringWriter;
+import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
-import java.util.stream.Stream;
 import lombok.RequiredArgsConstructor;
-import org.junit.jupiter.params.ParameterizedTest;
-import org.junit.jupiter.params.provider.Arguments;
-import org.junit.jupiter.params.provider.MethodSource;
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.junit.runners.Parameterized.Parameters;
 
 @RequiredArgsConstructor
+@RunWith(Parameterized.class)
 public class CompoundConfigurationTest
 {
 
-    public static Stream<Arguments> data()
+    @Parameters(name = "{0}")
+    public static Iterable<Object[]> data()
     {
-        return Stream.of(
-                Arguments.of(
-                        // provider
-                        YamlConfiguration.class,
-                        // testDocument
-                        ""
-                        + "receipt:     Oz-Ware Purchase Invoice\n"
-                        + "date:        2012-08-06\n"
-                        + "customer:\n"
-                        + "    given:   Dorothy\n"
-                        + "    family:  Gale\n"
-                        + "\n"
-                        + "items:\n"
-                        + "    - part_no:   A4786\n"
-                        + "      descrip:   Water Bucket (Filled)\n"
-                        + "      price:     1.47\n"
-                        + "      quantity:  4\n"
-                        + "\n"
-                        + "    - part_no:   E1628\n"
-                        + "      descrip:   High Heeled \"Ruby\" Slippers\n"
-                        + "      size:      8\n"
-                        + "      price:     100.27\n"
-                        + "      quantity:  1\n"
-                        + "\n"
-                        + "bill-to:  &id001\n"
-                        + "    street: |\n"
-                        + "            123 Tornado Alley\n"
-                        + "            Suite 16\n"
-                        + "    city:   East Centerville\n"
-                        + "    state:  KS\n"
-                        + "\n"
-                        + "ship-to:  *id001\n"
-                        + "\n"
-                        + "specialDelivery:  >\n"
-                        + "    Follow the Yellow Brick\n"
-                        + "    Road to the Emerald City.\n"
-                        + "    Pay no attention to the\n"
-                        + "    man behind the curtain.",
-                        // numberTest
-                        ""
-                        + "someKey:\n"
-                        + "    1: 1\n"
-                        + "    2: 2\n"
-                        + "    3: 3\n"
-                        + "    4: 4",
-                        // nullTest
-                        ""
-                        + "null:\n"
-                        + "    null: object\n"
-                        + "    object: null\n"
-                ),
-                Arguments.of(
-                        // provider
-                        JsonConfiguration.class,
-                        // testDocument
-                        ""
-                        + "{\n"
-                        + "  \"customer\": {\n"
-                        + "    \"given\": \"Dorothy\", \n"
-                        + "    \"family\": \"Gale\"\n"
-                        + "  }, \n"
-                        + "  \"ship-to\": {\n"
-                        + "    \"city\": \"East Centerville\", \n"
-                        + "    \"state\": \"KS\", \n"
-                        + "    \"street\": \"123 Tornado Alley\\nSuite 16\\n\"\n"
-                        + "  }, \n"
-                        + "  \"bill-to\": {\n"
-                        + "    \"city\": \"East Centerville\", \n"
-                        + "    \"state\": \"KS\", \n"
-                        + "    \"street\": \"123 Tornado Alley\\nSuite 16\\n\"\n"
-                        + "  }, \n"
-                        + "  \"date\": \"2012-08-06\", \n"
-                        + "  \"items\": [\n"
-                        + "    {\n"
-                        + "      \"part_no\": \"A4786\", \n"
-                        + "      \"price\": 1.47, \n"
-                        + "      \"descrip\": \"Water Bucket (Filled)\", \n"
-                        + "      \"quantity\": 4\n"
-                        + "    }, \n"
-                        + "    {\n"
-                        + "      \"part_no\": \"E1628\", \n"
-                        + "      \"descrip\": \"High Heeled \\\"Ruby\\\" Slippers\", \n"
-                        + "      \"price\": 100.27, \n"
-                        + "      \"quantity\": 1, \n"
-                        + "      \"size\": 8\n"
-                        + "    }\n"
-                        + "  ], \n"
-                        + "  \"receipt\": \"Oz-Ware Purchase Invoice\", \n"
-                        + "  \"specialDelivery\": \"Follow the Yellow Brick Road to the Emerald City. Pay no attention to the man behind the curtain.\"\n"
-                        + "}",
-                        // numberTest
-                        ""
-                        + "{\n"
-                        + "  \"someKey\": {\n"
-                        + "    \"1\": 1, \n"
-                        + "    \"2\": 2, \n"
-                        + "    \"3\": 3, \n"
-                        + "    \"4\": 4\n"
-                        + "  }\n"
-                        + "}",
-                        // nullTest
-                        ""
-                        + "{\n"
-                        + "  \"null\": {\n"
-                        + "    \"null\": \"object\", \n"
-                        + "    \"object\": null\n"
-                        + "  }\n"
-                        + "}"
-                )
-        );
+        // CHECKSTYLE:OFF
+        return Arrays.asList( new Object[][]
+        {
+            {
+                // provider
+                YamlConfiguration.class,
+                // testDocument
+                ""
+                + "receipt:     Oz-Ware Purchase Invoice\n"
+                + "date:        2012-08-06\n"
+                + "customer:\n"
+                + "    given:   Dorothy\n"
+                + "    family:  Gale\n"
+                + "\n"
+                + "items:\n"
+                + "    - part_no:   A4786\n"
+                + "      descrip:   Water Bucket (Filled)\n"
+                + "      price:     1.47\n"
+                + "      quantity:  4\n"
+                + "\n"
+                + "    - part_no:   E1628\n"
+                + "      descrip:   High Heeled \"Ruby\" Slippers\n"
+                + "      size:      8\n"
+                + "      price:     100.27\n"
+                + "      quantity:  1\n"
+                + "\n"
+                + "bill-to:  &id001\n"
+                + "    street: |\n"
+                + "            123 Tornado Alley\n"
+                + "            Suite 16\n"
+                + "    city:   East Centerville\n"
+                + "    state:  KS\n"
+                + "\n"
+                + "ship-to:  *id001\n"
+                + "\n"
+                + "specialDelivery:  >\n"
+                + "    Follow the Yellow Brick\n"
+                + "    Road to the Emerald City.\n"
+                + "    Pay no attention to the\n"
+                + "    man behind the curtain.",
+                // numberTest
+                ""
+                + "someKey:\n"
+                + "    1: 1\n"
+                + "    2: 2\n"
+                + "    3: 3\n"
+                + "    4: 4",
+                // nullTest
+                ""
+                + "null:\n"
+                + "    null: object\n"
+                + "    object: null\n"
+            },
+            {
+                // provider
+                JsonConfiguration.class,
+                // testDocument
+                ""
+                + "{\n"
+                + "  \"customer\": {\n"
+                + "    \"given\": \"Dorothy\", \n"
+                + "    \"family\": \"Gale\"\n"
+                + "  }, \n"
+                + "  \"ship-to\": {\n"
+                + "    \"city\": \"East Centerville\", \n"
+                + "    \"state\": \"KS\", \n"
+                + "    \"street\": \"123 Tornado Alley\\nSuite 16\\n\"\n"
+                + "  }, \n"
+                + "  \"bill-to\": {\n"
+                + "    \"city\": \"East Centerville\", \n"
+                + "    \"state\": \"KS\", \n"
+                + "    \"street\": \"123 Tornado Alley\\nSuite 16\\n\"\n"
+                + "  }, \n"
+                + "  \"date\": \"2012-08-06\", \n"
+                + "  \"items\": [\n"
+                + "    {\n"
+                + "      \"part_no\": \"A4786\", \n"
+                + "      \"price\": 1.47, \n"
+                + "      \"descrip\": \"Water Bucket (Filled)\", \n"
+                + "      \"quantity\": 4\n"
+                + "    }, \n"
+                + "    {\n"
+                + "      \"part_no\": \"E1628\", \n"
+                + "      \"descrip\": \"High Heeled \\\"Ruby\\\" Slippers\", \n"
+                + "      \"price\": 100.27, \n"
+                + "      \"quantity\": 1, \n"
+                + "      \"size\": 8\n"
+                + "    }\n"
+                + "  ], \n"
+                + "  \"receipt\": \"Oz-Ware Purchase Invoice\", \n"
+                + "  \"specialDelivery\": \"Follow the Yellow Brick Road to the Emerald City. Pay no attention to the man behind the curtain.\"\n"
+                + "}",
+                // numberTest
+                ""
+                + "{\n"
+                + "  \"someKey\": {\n"
+                + "    \"1\": 1, \n"
+                + "    \"2\": 2, \n"
+                + "    \"3\": 3, \n"
+                + "    \"4\": 4\n"
+                + "  }\n"
+                + "}",
+                // nullTest
+                ""
+                + "{\n"
+                + "  \"null\": {\n"
+                + "    \"null\": \"object\", \n"
+                + "    \"object\": null\n"
+                + "  }\n"
+                + "}"
+            }
+        } );
+        // CHECKSTYLE:ON
     }
+    //
+    private final Class<? extends ConfigurationProvider> provider;
+    private final String testDocument;
+    private final String numberTest;
+    private final String nullTest;
 
-    @ParameterizedTest
-    @MethodSource("data")
-    public void testConfig(Class<? extends ConfigurationProvider> provider, String testDocument, String numberTest, String nullTest) throws Exception
+    @Test
+    public void testConfig() throws Exception
     {
         Configuration conf = ConfigurationProvider.getProvider( provider ).load( testDocument );
         testSection( conf );
@@ -141,7 +151,7 @@ public class CompoundConfigurationTest
         ConfigurationProvider.getProvider( provider ).save( conf, sw );
 
         // Check nulls were saved, see #1094
-        assertFalse( sw.toString().contains( "null" ), "Config contains null" );
+        Assert.assertFalse( "Config contains null", sw.toString().contains( "null" ) );
 
         conf = ConfigurationProvider.getProvider( provider ).load( new StringReader( sw.toString() ) );
         conf.set( "receipt", "Oz-Ware Purchase Invoice" ); // Add it back
@@ -150,38 +160,37 @@ public class CompoundConfigurationTest
 
     private void testSection(Configuration conf)
     {
-        assertEquals( "Oz-Ware Purchase Invoice", conf.getString( "receipt" ), "receipt" );
-        // assertEquals( "2012-08-06", conf.get( "date" ).toString(), "date" );
+        Assert.assertEquals( "receipt", "Oz-Ware Purchase Invoice", conf.getString( "receipt" ) );
+        // Assert.assertEquals( "date", "2012-08-06", conf.get( "date" ).toString() );
 
         Configuration customer = conf.getSection( "customer" );
-        assertEquals( "Dorothy", customer.getString( "given" ), "customer.given" );
-        assertEquals( "Dorothy", conf.getString( "customer.given" ), "customer.given" );
+        Assert.assertEquals( "customer.given", "Dorothy", customer.getString( "given" ) );
+        Assert.assertEquals( "customer.given", "Dorothy", conf.getString( "customer.given" ) );
 
         List items = conf.getList( "items" );
         Map item = (Map) items.get( 0 );
-        assertEquals( "A4786", item.get( "part_no" ), "items[0].part_no" );
+        Assert.assertEquals( "items[0].part_no", "A4786", item.get( "part_no" ) );
 
         conf.set( "receipt", null );
-        assertEquals( null, conf.get( "receipt" ) );
-        assertEquals( "foo", conf.get( "receipt", "foo" ) );
+        Assert.assertEquals( null, conf.get( "receipt" ) );
+        Assert.assertEquals( "foo", conf.get( "receipt", "foo" ) );
 
         Configuration newSection = conf.getSection( "new.section" );
         newSection.set( "value", "foo" );
-        assertEquals( "foo", conf.get( "new.section.value" ) );
+        Assert.assertEquals( "foo", conf.get( "new.section.value" ) );
 
         conf.set( "other.new.section", "bar" );
-        assertEquals( "bar", conf.get( "other.new.section" ) );
+        Assert.assertEquals( "bar", conf.get( "other.new.section" ) );
 
-        assertTrue( conf.contains( "customer.given" ) );
-        assertTrue( customer.contains( "given" ) );
+        Assert.assertTrue( conf.contains( "customer.given" ) );
+        Assert.assertTrue( customer.contains( "given" ) );
 
-        assertFalse( conf.contains( "customer.foo" ) );
-        assertFalse( customer.contains( "foo" ) );
+        Assert.assertFalse( conf.contains( "customer.foo" ) );
+        Assert.assertFalse( customer.contains( "foo" ) );
     }
 
-    @ParameterizedTest
-    @MethodSource("data")
-    public void testNumberedKeys(Class<? extends ConfigurationProvider> provider, String testDocument, String numberTest, String nullTest)
+    @Test
+    public void testNumberedKeys()
     {
         Configuration conf = ConfigurationProvider.getProvider( provider ).load( numberTest );
 
@@ -192,31 +201,29 @@ public class CompoundConfigurationTest
         }
     }
 
-    @ParameterizedTest
-    @MethodSource("data")
-    public void testNull(Class<? extends ConfigurationProvider> provider, String testDocument, String numberTest, String nullTest)
+    @Test
+    public void testNull()
     {
         Configuration conf = ConfigurationProvider.getProvider( provider ).load( nullTest );
 
-        assertEquals( "object", conf.get( "null.null" ) );
-        assertEquals( "object", conf.getSection( "null" ).get( "null" ) );
+        Assert.assertEquals( "object", conf.get( "null.null" ) );
+        Assert.assertEquals( "object", conf.getSection( "null" ).get( "null" ) );
 
-        assertEquals( null, conf.get( "null.object" ) );
-        assertEquals( "", conf.getString( "null.object" ) );
+        Assert.assertEquals( null, conf.get( "null.object" ) );
+        Assert.assertEquals( "", conf.getString( "null.object" ) );
     }
 
-    @ParameterizedTest
-    @MethodSource("data")
-    public void testMapAddition(Class<? extends ConfigurationProvider> provider, String testDocument, String numberTest, String nullTest)
+    @Test
+    public void testMapAddition()
     {
         Configuration conf = ConfigurationProvider.getProvider( provider ).load( testDocument );
 
         conf.set( "addition", Collections.singletonMap( "foo", "bar" ) );
 
         // Order matters
-        assertEquals( "bar", conf.getSection( "addition" ).getString( "foo" ) );
-        assertEquals( "bar", conf.getString( "addition.foo" ) );
+        Assert.assertEquals( "bar", conf.getSection( "addition" ).getString( "foo" ) );
+        Assert.assertEquals( "bar", conf.getString( "addition.foo" ) );
 
-        assertTrue( conf.get( "addition" ) instanceof Configuration );
+        Assert.assertTrue( conf.get( "addition" ) instanceof Configuration );
     }
 }

config/src/test/java/net/md_5/bungee/config/DefaultConfigurationTest.java

@@ -1,7 +1,7 @@
 package net.md_5.bungee.config;
 
-import static org.junit.jupiter.api.Assertions.*;
-import org.junit.jupiter.api.Test;
+import org.junit.Assert;
+import org.junit.Test;
 
 public class DefaultConfigurationTest
 {
@@ -16,8 +16,8 @@ public class DefaultConfigurationTest
 
         Configuration actualConfig = new Configuration( defaultConfig );
 
-        assertEquals( 10, actualConfig.getInt( "setting" ) );
-        assertEquals( 11, actualConfig.getInt( "nested.setting" ) );
-        assertEquals( 12, actualConfig.getInt( "double.nested.setting" ) );
+        Assert.assertEquals( 10, actualConfig.getInt( "setting" ) );
+        Assert.assertEquals( 11, actualConfig.getInt( "nested.setting" ) );
+        Assert.assertEquals( 12, actualConfig.getInt( "double.nested.setting" ) );
     }
 }

event/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-parent</artifactId>
-        <version>1.20-R0.2-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-event</artifactId>
-    <version>1.20-R0.2-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>BungeeCord-Event</name>

event/src/main/java/net/md_5/bungee/event/EventBus.java

@@ -1,6 +1,5 @@
 package net.md_5.bungee.event;
 
-import com.google.common.collect.ImmutableSet;
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
 import java.text.MessageFormat;
@@ -42,8 +41,6 @@ public class EventBus
         {
             for ( EventHandlerMethod method : handlers )
             {
-                long start = System.nanoTime();
-
                 try
                 {
                     method.invoke( event );
@@ -57,15 +54,6 @@ public class EventBus
                 {
                     logger.log( Level.WARNING, MessageFormat.format( "Error dispatching event {0} to listener {1}", event, method.getListener() ), ex.getCause() );
                 }
-
-                long elapsed = System.nanoTime() - start;
-                if ( elapsed > 50000000 )
-                {
-                    logger.log( Level.WARNING, "Plugin listener {0} took {1}ms to process event {2}!", new Object[]
-                    {
-                        method.getListener().getClass().getName(), elapsed / 1000000, event
-                    } );
-                }
             }
         }
     }
@@ -73,8 +61,7 @@ public class EventBus
     private Map<Class<?>, Map<Byte, Set<Method>>> findHandlers(Object listener)
     {
         Map<Class<?>, Map<Byte, Set<Method>>> handler = new HashMap<>();
-        Set<Method> methods = ImmutableSet.<Method>builder().add( listener.getClass().getMethods() ).add( listener.getClass().getDeclaredMethods() ).build();
-        for ( final Method m : methods )
+        for ( Method m : listener.getClass().getDeclaredMethods() )
         {
             EventHandler annotation = m.getAnnotation( EventHandler.class );
             if ( annotation != null )
@@ -88,8 +75,18 @@ public class EventBus
                     } );
                     continue;
                 }
-                Map<Byte, Set<Method>> prioritiesMap = handler.computeIfAbsent( params[0], k -> new HashMap<>() );
-                Set<Method> priority = prioritiesMap.computeIfAbsent( annotation.priority(), k -> new HashSet<>() );
+                Map<Byte, Set<Method>> prioritiesMap = handler.get( params[0] );
+                if ( prioritiesMap == null )
+                {
+                    prioritiesMap = new HashMap<>();
+                    handler.put( params[0], prioritiesMap );
+                }
+                Set<Method> priority = prioritiesMap.get( annotation.priority() );
+                if ( priority == null )
+                {
+                    priority = new HashSet<>();
+                    prioritiesMap.put( annotation.priority(), priority );
+                }
                 priority.add( m );
             }
         }
@@ -104,11 +101,22 @@ public class EventBus
         {
             for ( Map.Entry<Class<?>, Map<Byte, Set<Method>>> e : handler.entrySet() )
             {
-                Map<Byte, Map<Object, Method[]>> prioritiesMap = byListenerAndPriority.computeIfAbsent( e.getKey(), k -> new HashMap<>() );
+                Map<Byte, Map<Object, Method[]>> prioritiesMap = byListenerAndPriority.get( e.getKey() );
+                if ( prioritiesMap == null )
+                {
+                    prioritiesMap = new HashMap<>();
+                    byListenerAndPriority.put( e.getKey(), prioritiesMap );
+                }
                 for ( Map.Entry<Byte, Set<Method>> entry : e.getValue().entrySet() )
                 {
-                    Map<Object, Method[]> currentPriorityMap = prioritiesMap.computeIfAbsent( entry.getKey(), k -> new HashMap<>() );
-                    currentPriorityMap.put( listener, entry.getValue().toArray( new Method[ 0 ] ) );
+                    Map<Object, Method[]> currentPriorityMap = prioritiesMap.get( entry.getKey() );
+                    if ( currentPriorityMap == null )
+                    {
+                        currentPriorityMap = new HashMap<>();
+                        prioritiesMap.put( entry.getKey(), currentPriorityMap );
+                    }
+                    Method[] baked = new Method[ entry.getValue().size() ];
+                    currentPriorityMap.put( listener, entry.getValue().toArray( baked ) );
                 }
                 bakeHandlers( e.getKey() );
             }
@@ -186,7 +194,7 @@ public class EventBus
                     }
                 }
             } while ( value++ < Byte.MAX_VALUE );
-            byEventBaked.put( eventClass, handlersList.toArray( new EventHandlerMethod[ 0 ] ) );
+            byEventBaked.put( eventClass, handlersList.toArray( new EventHandlerMethod[ handlersList.size() ] ) );
         } else
         {
             byEventBaked.remove( eventClass );

event/src/test/java/net/md_5/bungee/event/EventBusTest.java

@@ -1,8 +1,8 @@
 package net.md_5.bungee.event;
 
-import static org.junit.jupiter.api.Assertions.*;
 import java.util.concurrent.CountDownLatch;
-import org.junit.jupiter.api.Test;
+import org.junit.Assert;
+import org.junit.Test;
 
 public class EventBusTest
 {
@@ -15,14 +15,14 @@ public class EventBusTest
     {
         bus.register( this );
         bus.post( new FirstEvent() );
-        assertEquals( 0, latch.getCount() );
+        Assert.assertEquals( 0, latch.getCount() );
     }
 
     @EventHandler
     public void firstListener(FirstEvent event)
     {
         bus.post( new SecondEvent() );
-        assertEquals( 1, latch.getCount() );
+        Assert.assertEquals( 1, latch.getCount() );
         latch.countDown();
     }
 

event/src/test/java/net/md_5/bungee/event/EventPriorityTest.java

@@ -1,8 +1,8 @@
 package net.md_5.bungee.event;
 
-import static org.junit.jupiter.api.Assertions.*;
 import java.util.concurrent.CountDownLatch;
-import org.junit.jupiter.api.Test;
+import org.junit.Assert;
+import org.junit.Test;
 
 public class EventPriorityTest
 {
@@ -16,41 +16,41 @@ public class EventPriorityTest
         bus.register( this );
         bus.register( new EventPriorityListenerPartner() );
         bus.post( new PriorityTestEvent() );
-        assertEquals( 0, latch.getCount() );
+        Assert.assertEquals( 0, latch.getCount() );
     }
 
     @EventHandler(priority = Byte.MIN_VALUE)
     public void onMinPriority(PriorityTestEvent event)
     {
-        assertEquals( 7, latch.getCount() );
+        Assert.assertEquals( 7, latch.getCount() );
         latch.countDown();
     }
 
     @EventHandler(priority = EventPriority.LOWEST)
     public void onLowestPriority(PriorityTestEvent event)
     {
-        assertEquals( 6, latch.getCount() );
+        Assert.assertEquals( 6, latch.getCount() );
         latch.countDown();
     }
 
     @EventHandler
     public void onNormalPriority(PriorityTestEvent event)
     {
-        assertEquals( 4, latch.getCount() );
+        Assert.assertEquals( 4, latch.getCount() );
         latch.countDown();
     }
 
     @EventHandler(priority = EventPriority.HIGHEST)
     public void onHighestPriority(PriorityTestEvent event)
     {
-        assertEquals( 2, latch.getCount() );
+        Assert.assertEquals( 2, latch.getCount() );
         latch.countDown();
     }
 
     @EventHandler(priority = Byte.MAX_VALUE)
     public void onMaxPriority(PriorityTestEvent event)
     {
-        assertEquals( 1, latch.getCount() );
+        Assert.assertEquals( 1, latch.getCount() );
         latch.countDown();
     }
 
@@ -64,14 +64,14 @@ public class EventPriorityTest
         @EventHandler(priority = EventPriority.HIGH)
         public void onHighPriority(PriorityTestEvent event)
         {
-            assertEquals( 3, latch.getCount() );
+            Assert.assertEquals( 3, latch.getCount() );
             latch.countDown();
         }
 
         @EventHandler(priority = EventPriority.LOW)
         public void onLowPriority(PriorityTestEvent event)
         {
-            assertEquals( 5, latch.getCount() );
+            Assert.assertEquals( 5, latch.getCount() );
             latch.countDown();
         }
     }

event/src/test/java/net/md_5/bungee/event/SubclassTest.java

@@ -1,26 +0,0 @@
-package net.md_5.bungee.event;
-
-import static org.junit.jupiter.api.Assertions.*;
-import java.util.concurrent.CountDownLatch;
-import org.junit.jupiter.api.Test;
-
-public class SubclassTest extends EventBusTest
-{
-
-    private final CountDownLatch latch = new CountDownLatch( 1 );
-
-    @Test
-    @Override
-    public void testNestedEvents()
-    {
-        super.testNestedEvents();
-        assertEquals( 0, latch.getCount() );
-    }
-
-    @EventHandler
-    protected void extraListener(FirstEvent event)
-    {
-        assertEquals( 1, latch.getCount() );
-        latch.countDown();
-    }
-}

event/src/test/java/net/md_5/bungee/event/UnregisteringListenerTest.java

@@ -1,7 +1,7 @@
 package net.md_5.bungee.event;
 
-import static org.junit.jupiter.api.Assertions.fail;
-import org.junit.jupiter.api.Test;
+import org.junit.Assert;
+import org.junit.Test;
 
 public class UnregisteringListenerTest
 {
@@ -19,7 +19,7 @@ public class UnregisteringListenerTest
     @EventHandler
     public void onEvent(TestEvent evt)
     {
-        fail( "Event listener wasn't unregistered" );
+        Assert.fail( "Event listener wasn't unregistered" );
     }
 
     public static class TestEvent

log/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-parent</artifactId>
-        <version>1.20-R0.2-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-log</artifactId>
-    <version>1.20-R0.2-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>BungeeCord-Log</name>

log/src/main/java/net/md_5/bungee/log/BungeeLogger.java

@@ -13,23 +13,19 @@ public class BungeeLogger extends Logger
 
     private final LogDispatcher dispatcher = new LogDispatcher( this );
 
-    // CHECKSTYLE:OFF
     @SuppressWarnings(
             {
                 "CallToPrintStackTrace", "CallToThreadStartDuringObjectConstruction"
             })
-    // CHECKSTYLE:ON
     @SuppressFBWarnings("SC_START_IN_CTOR")
     public BungeeLogger(String loggerName, String filePattern, ConsoleReader reader)
     {
         super( loggerName, null );
         setLevel( Level.ALL );
-        setUseParentHandlers( false );
 
         try
         {
             FileHandler fileHandler = new FileHandler( filePattern, 1 << 24, 8, true );
-            fileHandler.setLevel( Level.parse( System.getProperty( "net.md_5.bungee.file-log-level", "INFO" ) ) );
             fileHandler.setFormatter( new ConciseFormatter( false ) );
             addHandler( fileHandler );
 

log/src/main/java/net/md_5/bungee/log/LoggingForwardHandler.java

@@ -1,29 +0,0 @@
-package net.md_5.bungee.log;
-
-import java.util.logging.Handler;
-import java.util.logging.LogRecord;
-import java.util.logging.Logger;
-import lombok.RequiredArgsConstructor;
-
-@RequiredArgsConstructor
-public class LoggingForwardHandler extends Handler
-{
-
-    private final Logger logger;
-
-    @Override
-    public void publish(LogRecord record)
-    {
-        logger.log( record );
-    }
-
-    @Override
-    public void flush()
-    {
-    }
-
-    @Override
-    public void close() throws SecurityException
-    {
-    }
-}

module/cmd-alert/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-module</artifactId>
-        <version>1.20-R0.2-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-module-cmd-alert</artifactId>
-    <version>1.20-R0.2-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>cmd_alert</name>

module/cmd-alert/src/main/java/net/md_5/bungee/module/cmd/alert/CommandAlert.java

@@ -1,6 +1,5 @@
 package net.md_5.bungee.module.cmd.alert;
 
-import java.util.Locale;
 import net.md_5.bungee.api.ChatColor;
 import net.md_5.bungee.api.CommandSender;
 import net.md_5.bungee.api.ProxyServer;
@@ -24,10 +23,10 @@ public class CommandAlert extends Command
         } else
         {
             StringBuilder builder = new StringBuilder();
-            if ( args[0].toLowerCase( Locale.ROOT ).startsWith( "&h" ) )
+            if ( args[0].startsWith( "&h" ) )
             {
                 // Remove &h
-                args[0] = args[0].substring( 2 );
+                args[0] = args[0].substring( 2, args[0].length() );
             } else
             {
                 builder.append( ProxyServer.getInstance().getTranslation( "alert" ) );

module/cmd-find/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-module</artifactId>
-        <version>1.20-R0.2-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-module-cmd-find</artifactId>
-    <version>1.20-R0.2-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>cmd_find</name>

module/cmd-find/src/main/java/net/md_5/bungee/module/cmd/find/CommandFind.java

@@ -1,12 +1,7 @@
 package net.md_5.bungee.module.cmd.find;
 
-import java.util.Collections;
 import net.md_5.bungee.api.CommandSender;
 import net.md_5.bungee.api.ProxyServer;
-import net.md_5.bungee.api.chat.ClickEvent;
-import net.md_5.bungee.api.chat.ComponentBuilder;
-import net.md_5.bungee.api.chat.HoverEvent;
-import net.md_5.bungee.api.config.ServerInfo;
 import net.md_5.bungee.api.connection.ProxiedPlayer;
 import net.md_5.bungee.command.PlayerCommand;
 
@@ -32,27 +27,8 @@ public class CommandFind extends PlayerCommand
                 sender.sendMessage( ProxyServer.getInstance().getTranslation( "user_not_online" ) );
             } else
             {
-                boolean moduleLoaded = ProxyServer.getInstance().getPluginManager().getPlugin( "cmd_server" ) != null;
-                ServerInfo server = player.getServer().getInfo();
-                ComponentBuilder componentBuilder = new ComponentBuilder().appendLegacy( ProxyServer.getInstance().getTranslation( "user_online_at", player.getName(), server.getName() ) );
-
-                if ( moduleLoaded && server.canAccess( sender ) )
-                {
-                    componentBuilder.event( new HoverEvent(
-                            HoverEvent.Action.SHOW_TEXT,
-                            new ComponentBuilder().appendLegacy( ProxyServer.getInstance().getTranslation( "click_to_connect" ) ).create() )
-                    );
-                    componentBuilder.event( new ClickEvent( ClickEvent.Action.RUN_COMMAND, "/server " + server.getName() ) );
-                }
-
-                sender.sendMessage( componentBuilder.create() );
+                sender.sendMessage( ProxyServer.getInstance().getTranslation( "user_online_at", player.getName(), player.getServer().getInfo().getName() ) );
             }
         }
     }
-
-    @Override
-    public Iterable<String> onTabComplete(CommandSender sender, String[] args)
-    {
-        return args.length == 1 ? super.onTabComplete( sender, args ) : Collections.emptyList();
-    }
 }

module/cmd-kick/nb-configuration.xml

@@ -1,31 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<project-shared-configuration>
-    <!--
-    This file contains additional configuration written by modules in the NetBeans IDE.
-    The configuration is intended to be shared among all the users of project and
-    therefore it is assumed to be part of version control checkout.
-    Without this configuration present, some functionality in the IDE may be limited or fail altogether.
-    -->
-    <properties xmlns="http://www.netbeans.org/ns/maven-properties-data/1">
-        <!--
-        Properties that influence various parts of the IDE, especially code formatting and the like. 
-        You can copy and paste the single properties, into the pom.xml file and the IDE will pick them up.
-        That way multiple projects can share the same settings (useful for formatting rules for example).
-        Any value defined here will override the pom.xml file value but is only applicable to the current project.
-        -->
-        <org-netbeans-modules-editor-indent.CodeStyle.usedProfile>project</org-netbeans-modules-editor-indent.CodeStyle.usedProfile>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.classDeclBracePlacement>NEW_LINE</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.classDeclBracePlacement>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.otherBracePlacement>NEW_LINE</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.otherBracePlacement>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.methodDeclBracePlacement>NEW_LINE</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.methodDeclBracePlacement>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinMethodCallParens>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinMethodCallParens>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinSwitchParens>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinSwitchParens>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinCatchParens>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinCatchParens>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinTryParens>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinTryParens>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinSynchronizedParens>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinSynchronizedParens>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinArrayInitBrackets>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinArrayInitBrackets>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinParens>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinParens>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinWhileParens>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinWhileParens>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinIfParens>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinIfParens>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinForParens>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinForParens>
-    </properties>
-</project-shared-configuration>

module/cmd-kick/pom.xml

@@ -1,20 +0,0 @@
-
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
-    <modelVersion>4.0.0</modelVersion>
-
-    <parent>
-        <groupId>net.md-5</groupId>
-        <artifactId>bungeecord-module</artifactId>
-        <version>1.20-R0.2-SNAPSHOT</version>
-        <relativePath>../pom.xml</relativePath>
-    </parent>
-
-    <groupId>net.md-5</groupId>
-    <artifactId>bungeecord-module-cmd-kick</artifactId>
-    <version>1.20-R0.2-SNAPSHOT</version>
-    <packaging>jar</packaging>
-
-    <name>cmd_kick</name>
-    <description>Provides the gkick command</description>
-</project>

module/cmd-kick/src/main/java/net/md_5/bungee/module/cmd/kick/CommandKick.java

@@ -1,72 +0,0 @@
-package net.md_5.bungee.module.cmd.kick;
-
-import com.google.common.base.Joiner;
-import com.google.common.collect.ImmutableSet;
-import java.util.HashSet;
-import java.util.Locale;
-import java.util.Set;
-import net.md_5.bungee.api.ChatColor;
-import net.md_5.bungee.api.CommandSender;
-import net.md_5.bungee.api.ProxyServer;
-import net.md_5.bungee.api.chat.TextComponent;
-import net.md_5.bungee.api.connection.ProxiedPlayer;
-import net.md_5.bungee.api.plugin.Command;
-import net.md_5.bungee.api.plugin.TabExecutor;
-
-public class CommandKick extends Command implements TabExecutor
-{
-
-    public CommandKick()
-    {
-        super( "gkick", "bungeecord.command.kick" );
-    }
-
-    @Override
-    public void execute(CommandSender sender, String[] args)
-    {
-        if ( args.length == 0 )
-        {
-            sender.sendMessage( ProxyServer.getInstance().getTranslation( "username_needed" ) );
-        } else
-        {
-            ProxiedPlayer player = ProxyServer.getInstance().getPlayer( args[0] );
-
-            if ( player == null )
-            {
-                sender.sendMessage( TextComponent.fromLegacyText( ProxyServer.getInstance().getTranslation( "user_not_online" ) ) );
-                return;
-            }
-
-            if ( args.length == 1 )
-            {
-                player.disconnect( TextComponent.fromLegacyText( ProxyServer.getInstance().getTranslation( "kick_message" ) ) );
-            } else
-            {
-                String[] reason = new String[ args.length - 1 ];
-                System.arraycopy( args, 1, reason, 0, reason.length );
-                player.disconnect( TextComponent.fromLegacyText( ChatColor.translateAlternateColorCodes( '&', Joiner.on( ' ' ).join( reason ) ) ) );
-            }
-        }
-    }
-
-    @Override
-    public Iterable<String> onTabComplete(CommandSender sender, String[] args)
-    {
-        if ( args.length == 1 )
-        {
-            Set<String> matches = new HashSet<>();
-            String search = args[0].toLowerCase( Locale.ROOT );
-            for ( ProxiedPlayer player : ProxyServer.getInstance().getPlayers() )
-            {
-                if ( player.getName().toLowerCase( Locale.ROOT ).startsWith( search ) )
-                {
-                    matches.add( player.getName() );
-                }
-            }
-            return matches;
-        } else
-        {
-            return ImmutableSet.of();
-        }
-    }
-}

module/cmd-kick/src/main/java/net/md_5/bungee/module/cmd/kick/PluginKick.java

@@ -1,13 +0,0 @@
-package net.md_5.bungee.module.cmd.kick;
-
-import net.md_5.bungee.api.plugin.Plugin;
-
-public class PluginKick extends Plugin
-{
-
-    @Override
-    public void onEnable()
-    {
-        getProxy().getPluginManager().registerCommand( this, new CommandKick() );
-    }
-}

module/cmd-kick/src/main/resources/plugin.yml

@@ -1,5 +0,0 @@
-name: ${project.name}
-main: net.md_5.bungee.module.cmd.kick.PluginKick
-version: ${describe}
-description: ${project.description}
-author: ${module.author}

module/cmd-list/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-module</artifactId>
-        <version>1.20-R0.2-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-module-cmd-list</artifactId>
-    <version>1.20-R0.2-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>cmd_list</name>

module/cmd-list/src/main/java/net/md_5/bungee/module/cmd/list/CommandList.java

@@ -1,21 +1,20 @@
 package net.md_5.bungee.module.cmd.list;
 
 import java.util.ArrayList;
-import java.util.Collection;
 import java.util.Collections;
 import java.util.List;
+import net.md_5.bungee.Util;
 import net.md_5.bungee.api.ChatColor;
 import net.md_5.bungee.api.CommandSender;
 import net.md_5.bungee.api.ProxyServer;
 import net.md_5.bungee.api.config.ServerInfo;
 import net.md_5.bungee.api.connection.ProxiedPlayer;
 import net.md_5.bungee.api.plugin.Command;
-import net.md_5.bungee.api.plugin.TabExecutor;
 
 /**
  * Command to list all players connected to the proxy.
  */
-public class CommandList extends Command implements TabExecutor
+public class CommandList extends Command
 {
 
     public CommandList()
@@ -26,8 +25,6 @@ public class CommandList extends Command implements TabExecutor
     @Override
     public void execute(CommandSender sender, String[] args)
     {
-        boolean hideEmptyServers = ( args.length == 0 ) || !args[0].equalsIgnoreCase( "all" );
-
         for ( ServerInfo server : ProxyServer.getInstance().getServers().values() )
         {
             if ( !server.canAccess( sender ) )
@@ -35,28 +32,16 @@ public class CommandList extends Command implements TabExecutor
                 continue;
             }
 
-            Collection<ProxiedPlayer> serverPlayers = server.getPlayers();
-            if ( hideEmptyServers && serverPlayers.isEmpty() )
-            {
-                continue;
-            }
-
             List<String> players = new ArrayList<>();
-            for ( ProxiedPlayer player : serverPlayers )
+            for ( ProxiedPlayer player : server.getPlayers() )
             {
                 players.add( player.getDisplayName() );
             }
             Collections.sort( players, String.CASE_INSENSITIVE_ORDER );
 
-            sender.sendMessage( ProxyServer.getInstance().getTranslation( "command_list", server.getName(), players.size(), String.join( ChatColor.RESET + ", ", players ) ) );
+            sender.sendMessage( ProxyServer.getInstance().getTranslation( "command_list", server.getName(), server.getPlayers().size(), Util.format( players, ChatColor.RESET + ", " ) ) );
         }
 
         sender.sendMessage( ProxyServer.getInstance().getTranslation( "total_players", ProxyServer.getInstance().getOnlineCount() ) );
     }
-
-    @Override
-    public Iterable<String> onTabComplete(CommandSender sender, String[] args)
-    {
-        return ( args.length > 1 ) ? Collections.emptyList() : Collections.singletonList( "all" );
-    }
 }

module/cmd-send/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-module</artifactId>
-        <version>1.20-R0.2-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-module-cmd-send</artifactId>
-    <version>1.20-R0.2-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>cmd_send</name>

module/cmd-server/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-module</artifactId>
-        <version>1.20-R0.2-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-module-cmd-server</artifactId>
-    <version>1.20-R0.2-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>cmd_server</name>

module/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-parent</artifactId>
-        <version>1.20-R0.2-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-module</artifactId>
-    <version>1.20-R0.2-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>pom</packaging>
 
     <name>BungeeCord Modules</name>
@@ -21,7 +21,6 @@
     <modules>
         <module>cmd-alert</module>
         <module>cmd-find</module>
-        <module>cmd-kick</module>
         <module>cmd-list</module>
         <module>cmd-send</module>
         <module>cmd-server</module>

module/reconnect-yaml/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-module</artifactId>
-        <version>1.20-R0.2-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-module-reconnect-yaml</artifactId>
-    <version>1.20-R0.2-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>reconnect_yaml</name>

native/compile-native.sh

@@ -1,14 +1,6 @@
 #!/bin/sh
 
-set -eu
+CXX="g++ -shared -fPIC -O3 -Wall -Werror -I$JAVA_HOME/include/ -I$JAVA_HOME/include/linux/"
 
-echo "Compiling mbedtls"
-(cd mbedtls && make no_test)
-
-echo "Compiling zlib"
-(cd zlib && CFLAGS=-fPIC ./configure --static && make)
-
-CXX="g++ -shared -fPIC -Wl,--wrap=memcpy -O3 -Wall -Werror -I$JAVA_HOME/include/ -I$JAVA_HOME/include/linux/"
-
-$CXX -Imbedtls/include src/main/c/NativeCipherImpl.cpp -o src/main/resources/native-cipher.so mbedtls/library/libmbedcrypto.a
-$CXX -Izlib src/main/c/NativeCompressImpl.cpp -o src/main/resources/native-compress.so zlib/libz.a
+$CXX src/main/c/NativeCipherImpl.cpp -o src/main/resources/native-cipher.so -lcrypto
+$CXX src/main/c/NativeCompressImpl.cpp -o src/main/resources/native-compress.so -lz

native/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-parent</artifactId>
-        <version>1.20-R0.2-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-native</artifactId>
-    <version>1.20-R0.2-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>BungeeCord-Native</name>
@@ -22,6 +22,7 @@
         <dependency>
             <groupId>io.netty</groupId>
             <artifactId>netty-transport</artifactId>
+            <version>${netty.version}</version>
             <scope>compile</scope>
         </dependency>
     </dependencies>

native/src/main/c/NativeCipherImpl.cpp

@@ -1,15 +1,12 @@
+// Support for CentOS 6
+__asm__(".symver memcpy,memcpy@GLIBC_2.2.5");
+
 #include <stdlib.h>
 #include <string.h>
 
 #include <mbedtls/aes.h>
 #include "net_md_5_bungee_jni_cipher_NativeCipherImpl.h"
 
-// Support for CentOS 6
-__asm__(".symver memcpy,memcpy@GLIBC_2.2.5");
-extern "C" void *__wrap_memcpy(void *dest, const void *src, size_t n) {
-    return memcpy(dest, src, n);
-}
-
 typedef unsigned char byte;
 
 struct crypto_context {

native/src/main/c/NativeCompressImpl.cpp

@@ -1,15 +1,7 @@
 #include <stdlib.h>
-#include <string.h>
-
 #include <zlib.h>
 #include "net_md_5_bungee_jni_zlib_NativeCompressImpl.h"
 
-// Support for CentOS 6
-__asm__(".symver memcpy,memcpy@GLIBC_2.2.5");
-extern "C" void *__wrap_memcpy(void *dest, const void *src, size_t n) {
-    return memcpy(dest, src, n);
-}
-
 typedef unsigned char byte;
 
 static jfieldID consumedID;

native/src/main/java/net/md_5/bungee/jni/NativeCode.java

@@ -6,19 +6,18 @@ import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
-import java.util.function.Supplier;
 import net.md_5.bungee.jni.cipher.BungeeCipher;
 
 public final class NativeCode<T>
 {
 
     private final String name;
-    private final Supplier<? extends T> javaImpl;
-    private final Supplier<? extends T> nativeImpl;
+    private final Class<? extends T> javaImpl;
+    private final Class<? extends T> nativeImpl;
     //
     private boolean loaded;
 
-    public NativeCode(String name, Supplier<? extends T> javaImpl, Supplier<? extends T> nativeImpl)
+    public NativeCode(String name, Class<? extends T> javaImpl, Class<? extends T> nativeImpl)
     {
         this.name = name;
         this.javaImpl = javaImpl;
@@ -27,7 +26,13 @@ public final class NativeCode<T>
 
     public T newInstance()
     {
-        return ( loaded ) ? nativeImpl.get() : javaImpl.get();
+        try
+        {
+            return ( loaded ) ? nativeImpl.getDeclaredConstructor().newInstance() : javaImpl.getDeclaredConstructor().newInstance();
+        } catch ( ReflectiveOperationException ex )
+        {
+            throw new RuntimeException( "Error getting instance", ex );
+        }
     }
 
     public boolean load()

native/src/main/java/net/md_5/bungee/jni/cipher/JavaCipher.java

@@ -25,15 +25,9 @@ public class JavaCipher implements BungeeCipher
         }
     }
 
-    public JavaCipher()
+    public JavaCipher() throws GeneralSecurityException
     {
-        try
-        {
-            this.cipher = Cipher.getInstance( "AES/CFB8/NoPadding" );
-        } catch ( GeneralSecurityException ex )
-        {
-            throw new RuntimeException( ex );
-        }
+        this.cipher = Cipher.getInstance( "AES/CFB8/NoPadding" );
     }
 
     @Override

native/src/test/java/net/md_5/bungee/NativeCipherTest.java

@@ -1,6 +1,5 @@
 package net.md_5.bungee;
 
-import static org.junit.jupiter.api.Assertions.*;
 import io.netty.buffer.ByteBuf;
 import io.netty.buffer.Unpooled;
 import java.util.Random;
@@ -10,11 +9,12 @@ import net.md_5.bungee.jni.NativeCode;
 import net.md_5.bungee.jni.cipher.BungeeCipher;
 import net.md_5.bungee.jni.cipher.JavaCipher;
 import net.md_5.bungee.jni.cipher.NativeCipher;
-import org.junit.jupiter.api.MethodOrderer;
-import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.TestMethodOrder;
+import org.junit.Assert;
+import org.junit.FixMethodOrder;
+import org.junit.Test;
+import org.junit.runners.MethodSorters;
 
-@TestMethodOrder(MethodOrderer.MethodName.class)
+@FixMethodOrder(MethodSorters.NAME_ASCENDING)
 public class NativeCipherTest
 {
 
@@ -26,7 +26,7 @@ public class NativeCipherTest
     private final SecretKey secret = new SecretKeySpec( new byte[ 16 ], "AES" );
     private static final int BENCHMARK_COUNT = 4096;
     //
-    private static final NativeCode<BungeeCipher> factory = new NativeCode<>( "native-cipher", JavaCipher::new, NativeCipher::new );
+    private static final NativeCode<BungeeCipher> factory = new NativeCode<>( "native-cipher", JavaCipher.class, NativeCipher.class );
 
     @Test
     public void testNative() throws Exception
@@ -34,7 +34,7 @@ public class NativeCipherTest
         if ( NativeCode.isSupported() )
         {
             boolean loaded = factory.load();
-            assertTrue( loaded, "Native cipher failed to load!" );
+            Assert.assertTrue( "Native cipher failed to load!", loaded );
 
             NativeCipher cipher = new NativeCipher();
             System.out.println( "Testing native cipher..." );
@@ -48,7 +48,7 @@ public class NativeCipherTest
         if ( NativeCode.isSupported() )
         {
             boolean loaded = factory.load();
-            assertTrue( loaded, "Native cipher failed to load!" );
+            Assert.assertTrue( "Native cipher failed to load!", loaded );
 
             NativeCipher cipher = new NativeCipher();
 
@@ -98,7 +98,7 @@ public class NativeCipherTest
         // Encrypt
         cipher.init( true, secret );
         cipher.cipher( nativePlain, out );
-        assertEquals( nativeCiphered, out );
+        Assert.assertEquals( nativeCiphered, out );
 
         out.clear();
 
@@ -106,7 +106,7 @@ public class NativeCipherTest
         cipher.init( false, secret );
         cipher.cipher( nativeCiphered, out );
         nativePlain.resetReaderIndex();
-        assertEquals( nativePlain, out );
+        Assert.assertEquals( nativePlain, out );
 
         System.out.println( "This cipher works correctly!" );
     }

native/src/test/java/net/md_5/bungee/NativeZlibTest.java

@@ -1,6 +1,5 @@
 package net.md_5.bungee;
 
-import static org.junit.jupiter.api.Assertions.*;
 import io.netty.buffer.ByteBuf;
 import io.netty.buffer.Unpooled;
 import java.util.Arrays;
@@ -10,19 +9,20 @@ import net.md_5.bungee.jni.NativeCode;
 import net.md_5.bungee.jni.zlib.BungeeZlib;
 import net.md_5.bungee.jni.zlib.JavaZlib;
 import net.md_5.bungee.jni.zlib.NativeZlib;
-import org.junit.jupiter.api.Test;
+import org.junit.Assert;
+import org.junit.Test;
 
 public class NativeZlibTest
 {
 
-    private final NativeCode<BungeeZlib> factory = new NativeCode<>( "native-compress", JavaZlib::new, NativeZlib::new );
+    private final NativeCode<BungeeZlib> factory = new NativeCode<>( "native-compress", JavaZlib.class, NativeZlib.class );
 
     @Test
     public void doTest() throws DataFormatException
     {
         if ( NativeCode.isSupported() )
         {
-            assertTrue( factory.load(), "Native code failed to load!" );
+            Assert.assertTrue( "Native code failed to load!", factory.load() );
             test( factory.newInstance() );
         }
         test( new JavaZlib() );
@@ -64,6 +64,6 @@ public class NativeZlibTest
         long elapsed = System.currentTimeMillis() - start;
         System.out.println( "Took: " + elapsed + "ms" );
 
-        assertTrue( Arrays.equals( dataBuf, check ), "Results do not match" );
+        Assert.assertTrue( "Results do not match", Arrays.equals( dataBuf, check ) );
     }
 }

pom.xml

@@ -5,7 +5,7 @@
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-parent</artifactId>
-    <version>1.20-R0.2-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>pom</packaging>
 
     <name>BungeeCord-Parent</name>
@@ -41,7 +41,6 @@
         <module>protocol</module>
         <module>proxy</module>
         <module>query</module>
-        <module>slf4j</module>
         <module>native</module>
     </modules>
 
@@ -72,34 +71,23 @@
 
     <properties>
         <build.number>unknown</build.number>
-        <lombok.version>1.18.30</lombok.version>
+        <netty.version>4.1.53.Final</netty.version>
         <maven.compiler.source>1.8</maven.compiler.source>
         <maven.compiler.target>1.8</maven.compiler.target>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     </properties>
 
-    <dependencyManagement>
-        <dependencies>
-            <dependency>
-                <groupId>io.netty</groupId>
-                <artifactId>netty-bom</artifactId>
-                <version>4.1.97.Final</version>
-                <type>pom</type>
-                <scope>import</scope>
-            </dependency>
-        </dependencies>
-    </dependencyManagement>
     <dependencies>
         <dependency>
-            <groupId>org.junit.jupiter</groupId>
-            <artifactId>junit-jupiter</artifactId>
-            <version>5.10.0</version>
+            <groupId>junit</groupId>
+            <artifactId>junit</artifactId>
+            <version>4.13.1</version>
             <scope>test</scope>
         </dependency>
         <dependency>
             <groupId>com.google.guava</groupId>
             <artifactId>guava</artifactId>
-            <version>32.1.2-jre</version>
+            <version>21.0</version>
             <scope>compile</scope>
         </dependency>
         <dependency>
@@ -111,26 +99,17 @@
         <dependency>
             <groupId>org.projectlombok</groupId>
             <artifactId>lombok</artifactId>
-            <version>${lombok.version}</version>
+            <version>1.18.10</version>
             <scope>provided</scope>
         </dependency>
     </dependencies>
 
     <build>
-        <pluginManagement>
-            <plugins>
-                <plugin>
-                    <groupId>org.apache.maven.plugins</groupId>
-                    <artifactId>maven-javadoc-plugin</artifactId>
-                    <version>3.6.0</version>
-                </plugin>
-            </plugins>
-        </pluginManagement>
         <plugins>
             <plugin>
                 <groupId>net.md-5</groupId>
                 <artifactId>scriptus</artifactId>
-                <version>0.5.0</version>
+                <version>0.4.1</version>
                 <configuration>
                     <format>git:${project.name}:${project.version}:%s:${build.number}</format>
                 </configuration>
@@ -143,15 +122,10 @@
                     </execution>
                 </executions>
             </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-compiler-plugin</artifactId>
-                <version>3.11.0</version>
-            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
-                <version>3.3.0</version>
+                <version>3.1.1</version>
                 <executions>
                     <execution>
                         <phase>process-classes</phase>
@@ -169,14 +143,14 @@
                     <dependency>
                         <groupId>com.puppycrawl.tools</groupId>
                         <artifactId>checkstyle</artifactId>
-                        <version>8.45.1</version>
+                        <version>8.36.2</version>
                     </dependency>
                 </dependencies>
             </plugin>
             <plugin>
                 <groupId>org.codehaus.mojo</groupId>
                 <artifactId>animal-sniffer-maven-plugin</artifactId>
-                <version>1.23</version>
+                <version>1.19</version>
                 <executions>
                     <execution>
                         <phase>process-classes</phase>
@@ -193,82 +167,10 @@
                     </signature>
                 </configuration>
             </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-enforcer-plugin</artifactId>
-                <version>3.4.1</version>
-                <executions>
-                    <execution>
-                        <id>enforce</id>
-                        <configuration>
-                            <rules>
-                                <dependencyConvergence>
-                                    <excludes>
-                                        <!-- org.apache.maven:maven-resolver-provider is inconsistent -->
-                                        <exclude>org.apache.commons:commons-lang3</exclude>
-                                        <!-- org.apache.maven:maven-resolver-transport-http is inconsistent -->
-                                        <exclude>org.apache.httpcomponents:httpcore</exclude>
-                                    </excludes>
-                                </dependencyConvergence>
-                            </rules>
-                        </configuration>
-                        <goals>
-                            <!--<goal>enforce</goal>--> <!-- Disabled until maven-resolver is upgraded again. -->
-                        </goals>
-                    </execution>
-                </executions>
-            </plugin>
         </plugins>
     </build>
 
     <profiles>
-        <profile>
-            <id>jdk-9-release</id>
-            <activation>
-                <jdk>[9,)</jdk>
-            </activation>
-            <properties>
-                <maven.compiler.release>8</maven.compiler.release>
-            </properties>
-        </profile>
-        <profile>
-            <id>jdk-9-javadoc</id>
-            <activation>
-                <jdk>[9,)</jdk>
-            </activation>
-            <build>
-                <pluginManagement>
-                    <plugins>
-                        <plugin>
-                            <groupId>org.apache.maven.plugins</groupId>
-                            <artifactId>maven-javadoc-plugin</artifactId>
-                            <configuration>
-                                <additionalOptions>-html5</additionalOptions>
-                            </configuration>
-                        </plugin>
-                    </plugins>
-                </pluginManagement>
-            </build>
-        </profile>
-        <profile>
-            <id>jdk-15-javadoc</id>
-            <activation>
-                <jdk>[15,)</jdk>
-            </activation>
-            <build>
-                <pluginManagement>
-                    <plugins>
-                        <plugin>
-                            <groupId>org.apache.maven.plugins</groupId>
-                            <artifactId>maven-javadoc-plugin</artifactId>
-                            <configuration>
-                                <doclint>none</doclint>
-                            </configuration>
-                        </plugin>
-                    </plugins>
-                </pluginManagement>
-            </build>
-        </profile>
         <profile>
             <id>dist</id>
             <build>
@@ -276,7 +178,7 @@
                     <plugin>
                         <groupId>org.apache.maven.plugins</groupId>
                         <artifactId>maven-source-plugin</artifactId>
-                        <version>3.3.0</version>
+                        <version>3.2.1</version>
                         <executions>
                             <execution>
                                 <phase>package</phase>
@@ -289,7 +191,7 @@
                     <plugin>
                         <groupId>org.projectlombok</groupId>
                         <artifactId>lombok-maven-plugin</artifactId>
-                        <version>1.18.20.0</version>
+                        <version>1.18.10.0</version>
                         <executions>
                             <execution>
                                 <phase>package</phase>
@@ -303,17 +205,11 @@
                             <outputDirectory>${project.build.directory}/delombok</outputDirectory>
                             <sourceDirectory>${project.build.sourceDirectory}</sourceDirectory>
                         </configuration>
-                        <dependencies>
-                            <dependency>
-                                <groupId>org.projectlombok</groupId>
-                                <artifactId>lombok</artifactId>
-                                <version>${lombok.version}</version>
-                            </dependency>
-                        </dependencies>
                     </plugin>
                     <plugin>
                         <groupId>org.apache.maven.plugins</groupId>
                         <artifactId>maven-javadoc-plugin</artifactId>
+                        <version>3.2.0</version>
                         <executions>
                             <!-- Execute Javadoc once normally to catch any warnings -->
                             <execution>
@@ -351,7 +247,7 @@
                     <plugin>
                         <groupId>org.apache.maven.plugins</groupId>
                         <artifactId>maven-gpg-plugin</artifactId>
-                        <version>3.1.0</version>
+                        <version>1.6</version>
                         <executions>
                             <execution>
                                 <phase>verify</phase>

protocol/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-parent</artifactId>
-        <version>1.20-R0.2-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-protocol</artifactId>
-    <version>1.20-R0.2-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>BungeeCord-Protocol</name>
@@ -49,6 +49,7 @@
         <dependency>
             <groupId>io.netty</groupId>
             <artifactId>netty-codec</artifactId>
+            <version>${netty.version}</version>
             <scope>compile</scope>
         </dependency>
         <dependency>

protocol/src/main/java/net/md_5/bungee/protocol/AbstractPacketHandler.java

@@ -2,16 +2,12 @@ package net.md_5.bungee.protocol;
 
 import net.md_5.bungee.protocol.packet.BossBar;
 import net.md_5.bungee.protocol.packet.Chat;
-import net.md_5.bungee.protocol.packet.ClearTitles;
-import net.md_5.bungee.protocol.packet.ClientChat;
-import net.md_5.bungee.protocol.packet.ClientCommand;
 import net.md_5.bungee.protocol.packet.ClientSettings;
 import net.md_5.bungee.protocol.packet.ClientStatus;
 import net.md_5.bungee.protocol.packet.Commands;
 import net.md_5.bungee.protocol.packet.EncryptionRequest;
 import net.md_5.bungee.protocol.packet.EncryptionResponse;
 import net.md_5.bungee.protocol.packet.EntityStatus;
-import net.md_5.bungee.protocol.packet.FinishConfiguration;
 import net.md_5.bungee.protocol.packet.GameState;
 import net.md_5.bungee.protocol.packet.Handshake;
 import net.md_5.bungee.protocol.packet.KeepAlive;
@@ -19,7 +15,6 @@ import net.md_5.bungee.protocol.packet.Kick;
 import net.md_5.bungee.protocol.packet.LegacyHandshake;
 import net.md_5.bungee.protocol.packet.LegacyPing;
 import net.md_5.bungee.protocol.packet.Login;
-import net.md_5.bungee.protocol.packet.LoginAcknowledged;
 import net.md_5.bungee.protocol.packet.LoginPayloadRequest;
 import net.md_5.bungee.protocol.packet.LoginPayloadResponse;
 import net.md_5.bungee.protocol.packet.LoginRequest;
@@ -27,25 +22,18 @@ import net.md_5.bungee.protocol.packet.LoginSuccess;
 import net.md_5.bungee.protocol.packet.PingPacket;
 import net.md_5.bungee.protocol.packet.PlayerListHeaderFooter;
 import net.md_5.bungee.protocol.packet.PlayerListItem;
-import net.md_5.bungee.protocol.packet.PlayerListItemRemove;
-import net.md_5.bungee.protocol.packet.PlayerListItemUpdate;
 import net.md_5.bungee.protocol.packet.PluginMessage;
 import net.md_5.bungee.protocol.packet.Respawn;
 import net.md_5.bungee.protocol.packet.ScoreboardDisplay;
 import net.md_5.bungee.protocol.packet.ScoreboardObjective;
 import net.md_5.bungee.protocol.packet.ScoreboardScore;
-import net.md_5.bungee.protocol.packet.ServerData;
 import net.md_5.bungee.protocol.packet.SetCompression;
-import net.md_5.bungee.protocol.packet.StartConfiguration;
 import net.md_5.bungee.protocol.packet.StatusRequest;
 import net.md_5.bungee.protocol.packet.StatusResponse;
-import net.md_5.bungee.protocol.packet.Subtitle;
-import net.md_5.bungee.protocol.packet.SystemChat;
 import net.md_5.bungee.protocol.packet.TabCompleteRequest;
 import net.md_5.bungee.protocol.packet.TabCompleteResponse;
 import net.md_5.bungee.protocol.packet.Team;
 import net.md_5.bungee.protocol.packet.Title;
-import net.md_5.bungee.protocol.packet.TitleTimes;
 import net.md_5.bungee.protocol.packet.ViewDistance;
 
 public abstract class AbstractPacketHandler
@@ -87,18 +75,6 @@ public abstract class AbstractPacketHandler
     {
     }
 
-    public void handle(ClientChat chat) throws Exception
-    {
-    }
-
-    public void handle(SystemChat chat) throws Exception
-    {
-    }
-
-    public void handle(ClientCommand command) throws Exception
-    {
-    }
-
     public void handle(Respawn respawn) throws Exception
     {
     }
@@ -119,14 +95,6 @@ public abstract class AbstractPacketHandler
     {
     }
 
-    public void handle(PlayerListItemRemove playerListItem) throws Exception
-    {
-    }
-
-    public void handle(PlayerListItemUpdate playerListItem) throws Exception
-    {
-    }
-
     public void handle(PlayerListHeaderFooter playerListHeaderFooter) throws Exception
     {
     }
@@ -159,18 +127,6 @@ public abstract class AbstractPacketHandler
     {
     }
 
-    public void handle(Subtitle title) throws Exception
-    {
-    }
-
-    public void handle(TitleTimes title) throws Exception
-    {
-    }
-
-    public void handle(ClearTitles title) throws Exception
-    {
-    }
-
     public void handle(PluginMessage pluginMessage) throws Exception
     {
     }
@@ -222,20 +178,4 @@ public abstract class AbstractPacketHandler
     public void handle(GameState gameState) throws Exception
     {
     }
-
-    public void handle(ServerData serverData) throws Exception
-    {
-    }
-
-    public void handle(LoginAcknowledged loginAcknowledged) throws Exception
-    {
-    }
-
-    public void handle(StartConfiguration startConfiguration) throws Exception
-    {
-    }
-
-    public void handle(FinishConfiguration finishConfiguration) throws Exception
-    {
-    }
 }

protocol/src/main/java/net/md_5/bungee/protocol/ChatChain.java

@@ -1,82 +0,0 @@
-package net.md_5.bungee.protocol;
-
-import com.google.common.base.Preconditions;
-import io.netty.buffer.ByteBuf;
-import java.util.LinkedList;
-import java.util.List;
-import java.util.UUID;
-import lombok.AllArgsConstructor;
-import lombok.Data;
-import lombok.EqualsAndHashCode;
-import lombok.NoArgsConstructor;
-
-@Data
-@NoArgsConstructor
-@AllArgsConstructor
-@EqualsAndHashCode(callSuper = false)
-public class ChatChain extends DefinedPacket
-{
-
-    private List<ChainLink> seen;
-    private List<ChainLink> received;
-
-    @Override
-    public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        seen = readLinks( buf );
-        if ( buf.readBoolean() )
-        {
-            received = readLinks( buf );
-        }
-    }
-
-    private static List<ChainLink> readLinks(ByteBuf buf)
-    {
-        int cnt = readVarInt( buf );
-        Preconditions.checkArgument( cnt <= 5, "Too many entries" );
-        List<ChainLink> chain = new LinkedList<>();
-        for ( int i = 0; i < cnt; i++ )
-        {
-            chain.add( new ChainLink( readUUID( buf ), readArray( buf ) ) );
-        }
-        return chain;
-    }
-
-    @Override
-    public void write(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        writeLinks( seen, buf );
-        if ( received != null )
-        {
-            buf.writeBoolean( true );
-            writeLinks( received, buf );
-        } else
-        {
-            buf.writeBoolean( false );
-        }
-    }
-
-    private static void writeLinks(List<ChainLink> links, ByteBuf buf)
-    {
-        writeVarInt( links.size(), buf );
-        for ( ChainLink link : links )
-        {
-            writeUUID( link.sender, buf );
-            writeArray( link.signature, buf );
-        }
-    }
-
-    @Override
-    public void handle(AbstractPacketHandler handler) throws Exception
-    {
-        throw new UnsupportedOperationException( "Not supported." );
-    }
-
-    @Data
-    public static class ChainLink
-    {
-
-        private final UUID sender;
-        private final byte[] signature;
-    }
-}

protocol/src/main/java/net/md_5/bungee/protocol/DefinedPacket.java

@@ -9,15 +9,10 @@ import java.io.DataInputStream;
 import java.io.DataOutputStream;
 import java.io.IOException;
 import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.BitSet;
-import java.util.EnumSet;
 import java.util.List;
 import java.util.UUID;
 import lombok.RequiredArgsConstructor;
-import se.llbit.nbt.ErrorTag;
 import se.llbit.nbt.NamedTag;
-import se.llbit.nbt.SpecificTag;
 import se.llbit.nbt.Tag;
 
 @RequiredArgsConstructor
@@ -26,55 +21,35 @@ public abstract class DefinedPacket
 
     public static void writeString(String s, ByteBuf buf)
     {
-        writeString( s, buf, Short.MAX_VALUE );
-    }
-
-    public static void writeString(String s, ByteBuf buf, int maxLength)
-    {
-        if ( s.length() > maxLength )
+        if ( s.length() > Short.MAX_VALUE )
         {
-            throw new OverflowPacketException( "Cannot send string longer than " + maxLength + " (got " + s.length() + " characters)" );
+            throw new OverflowPacketException( String.format( "Cannot send string longer than Short.MAX_VALUE (got %s characters)", s.length() ) );
         }
 
         byte[] b = s.getBytes( Charsets.UTF_8 );
-        if ( b.length > maxLength * 3 )
-        {
-            throw new OverflowPacketException( "Cannot send string longer than " + ( maxLength * 3 ) + " (got " + b.length + " bytes)" );
-        }
-
         writeVarInt( b.length, buf );
         buf.writeBytes( b );
     }
 
     public static String readString(ByteBuf buf)
-    {
-        return readString( buf, Short.MAX_VALUE );
-    }
-
-    public static String readString(ByteBuf buf, int maxLen)
     {
         int len = readVarInt( buf );
-        if ( len > maxLen * 3 )
+        if ( len > Short.MAX_VALUE )
         {
-            throw new OverflowPacketException( "Cannot receive string longer than " + maxLen * 3 + " (got " + len + " bytes)" );
+            throw new OverflowPacketException( String.format( "Cannot receive string longer than Short.MAX_VALUE (got %s characters)", len ) );
         }
 
-        String s = buf.toString( buf.readerIndex(), len, Charsets.UTF_8 );
-        buf.readerIndex( buf.readerIndex() + len );
+        byte[] b = new byte[ len ];
+        buf.readBytes( b );
 
-        if ( s.length() > maxLen )
-        {
-            throw new OverflowPacketException( "Cannot receive string longer than " + maxLen + " (got " + s.length() + " characters)" );
-        }
-
-        return s;
+        return new String( b, Charsets.UTF_8 );
     }
 
     public static void writeArray(byte[] b, ByteBuf buf)
     {
         if ( b.length > Short.MAX_VALUE )
         {
-            throw new OverflowPacketException( "Cannot send byte array longer than Short.MAX_VALUE (got " + b.length + " bytes)" );
+            throw new OverflowPacketException( String.format( "Cannot send byte array longer than Short.MAX_VALUE (got %s bytes)", b.length ) );
         }
         writeVarInt( b.length, buf );
         buf.writeBytes( b );
@@ -98,7 +73,7 @@ public abstract class DefinedPacket
         int len = readVarInt( buf );
         if ( len > limit )
         {
-            throw new OverflowPacketException( "Cannot receive byte array longer than " + limit + " (got " + len + " bytes)" );
+            throw new OverflowPacketException( String.format( "Cannot receive byte array longer than %s (got %s bytes)", limit, len ) );
         }
         byte[] ret = new byte[ len ];
         buf.readBytes( ret );
@@ -228,102 +203,14 @@ public abstract class DefinedPacket
         return new UUID( input.readLong(), input.readLong() );
     }
 
-    public static void writeProperties(Property[] properties, ByteBuf buf)
+    public static Tag readTag(ByteBuf input)
     {
-        if ( properties == null )
-        {
-            writeVarInt( 0, buf );
-            return;
-        }
-
-        writeVarInt( properties.length, buf );
-        for ( Property prop : properties )
-        {
-            writeString( prop.getName(), buf );
-            writeString( prop.getValue(), buf );
-            if ( prop.getSignature() != null )
-            {
-                buf.writeBoolean( true );
-                writeString( prop.getSignature(), buf );
-            } else
-            {
-                buf.writeBoolean( false );
-            }
-        }
-    }
-
-    public static Property[] readProperties(ByteBuf buf)
-    {
-        Property[] properties = new Property[ DefinedPacket.readVarInt( buf ) ];
-        for ( int j = 0; j < properties.length; j++ )
-        {
-            String name = readString( buf );
-            String value = readString( buf );
-            if ( buf.readBoolean() )
-            {
-                properties[j] = new Property( name, value, DefinedPacket.readString( buf ) );
-            } else
-            {
-                properties[j] = new Property( name, value );
-            }
-        }
-
-        return properties;
-    }
-
-    public static void writePublicKey(PlayerPublicKey publicKey, ByteBuf buf)
-    {
-        if ( publicKey != null )
-        {
-            buf.writeBoolean( true );
-            buf.writeLong( publicKey.getExpiry() );
-            writeArray( publicKey.getKey(), buf );
-            writeArray( publicKey.getSignature(), buf );
-        } else
-        {
-            buf.writeBoolean( false );
-        }
-    }
-
-    public static PlayerPublicKey readPublicKey(ByteBuf buf)
-    {
-        if ( buf.readBoolean() )
-        {
-            return new PlayerPublicKey( buf.readLong(), readArray( buf, 512 ), readArray( buf, 4096 ) );
-        }
-
-        return null;
-    }
-
-    public static Tag readTag(ByteBuf input, int protocolVersion)
-    {
-        DataInputStream in = new DataInputStream( new ByteBufInputStream( input ) );
-        Tag tag;
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_20_2 )
-        {
-            try
-            {
-                byte type = in.readByte();
-                if ( type == 0 )
-                {
-                    return Tag.END;
-                } else
-                {
-                    tag = SpecificTag.read( type, in );
-                }
-            } catch ( IOException ex )
-            {
-                tag = new ErrorTag( "IOException while reading tag type:\n" + ex.getMessage() );
-            }
-        } else
-        {
-            tag = NamedTag.read( in );
-        }
+        Tag tag = NamedTag.read( new DataInputStream( new ByteBufInputStream( input ) ) );
         Preconditions.checkArgument( !tag.isError(), "Error reading tag: %s", tag.error() );
         return tag;
     }
 
-    public static void writeTag(Tag tag, ByteBuf output, int protocolVersion)
+    public static void writeTag(Tag tag, ByteBuf output)
     {
         try
         {
@@ -334,53 +221,6 @@ public abstract class DefinedPacket
         }
     }
 
-    public static <E extends Enum<E>> void writeEnumSet(EnumSet<E> enumset, Class<E> oclass, ByteBuf buf)
-    {
-        E[] enums = oclass.getEnumConstants();
-        BitSet bits = new BitSet( enums.length );
-
-        for ( int i = 0; i < enums.length; ++i )
-        {
-            bits.set( i, enumset.contains( enums[i] ) );
-        }
-
-        writeFixedBitSet( bits, enums.length, buf );
-    }
-
-    public static <E extends Enum<E>> EnumSet<E> readEnumSet(Class<E> oclass, ByteBuf buf)
-    {
-        E[] enums = oclass.getEnumConstants();
-        BitSet bits = readFixedBitSet( enums.length, buf );
-        EnumSet<E> set = EnumSet.noneOf( oclass );
-
-        for ( int i = 0; i < enums.length; ++i )
-        {
-            if ( bits.get( i ) )
-            {
-                set.add( enums[i] );
-            }
-        }
-
-        return set;
-    }
-
-    public static BitSet readFixedBitSet(int i, ByteBuf buf)
-    {
-        byte[] bits = new byte[ ( i + 8 ) >> 3 ];
-        buf.readBytes( bits );
-
-        return BitSet.valueOf( bits );
-    }
-
-    public static void writeFixedBitSet(BitSet bits, int size, ByteBuf buf)
-    {
-        if ( bits.length() > size )
-        {
-            throw new OverflowPacketException( "BitSet too large (expected " + size + " got " + bits.size() + ")" );
-        }
-        buf.writeBytes( Arrays.copyOf( bits.toByteArray(), ( size + 8 ) >> 3 ) );
-    }
-
     public void read(ByteBuf buf)
     {
         throw new UnsupportedOperationException( "Packet must implement read method" );
@@ -401,11 +241,6 @@ public abstract class DefinedPacket
         write( buf );
     }
 
-    public Protocol nextProtocol()
-    {
-        return null;
-    }
-
     public abstract void handle(AbstractPacketHandler handler) throws Exception;
 
     @Override

protocol/src/main/java/net/md_5/bungee/protocol/Location.java

@@ -1,11 +0,0 @@
-package net.md_5.bungee.protocol;
-
-import lombok.Data;
-
-@Data
-public class Location
-{
-
-    private final String dimension;
-    private final long pos;
-}

protocol/src/main/java/net/md_5/bungee/protocol/MinecraftDecoder.java

@@ -5,14 +5,12 @@ import io.netty.channel.ChannelHandlerContext;
 import io.netty.handler.codec.MessageToMessageDecoder;
 import java.util.List;
 import lombok.AllArgsConstructor;
-import lombok.Getter;
 import lombok.Setter;
 
 @AllArgsConstructor
 public class MinecraftDecoder extends MessageToMessageDecoder<ByteBuf>
 {
 
-    @Getter
     @Setter
     private Protocol protocol;
     private final boolean server;
@@ -43,7 +41,7 @@ public class MinecraftDecoder extends MessageToMessageDecoder<ByteBuf>
 
                 if ( in.isReadable() )
                 {
-                    throw new BadPacketException( "Packet " + protocol + ":" + prot.getDirection() + "/" + packetId + " (" + packet.getClass().getSimpleName() + ") larger than expected, extra bytes: " + in.readableBytes() );
+                    throw new BadPacketException( "Did not read all bytes from packet " + packet.getClass() + " " + packetId + " Protocol " + protocol + " Direction " + prot.getDirection() );
                 }
             } else
             {

protocol/src/main/java/net/md_5/bungee/protocol/MinecraftEncoder.java

@@ -4,18 +4,15 @@ import io.netty.buffer.ByteBuf;
 import io.netty.channel.ChannelHandlerContext;
 import io.netty.handler.codec.MessageToByteEncoder;
 import lombok.AllArgsConstructor;
-import lombok.Getter;
 import lombok.Setter;
 
 @AllArgsConstructor
 public class MinecraftEncoder extends MessageToByteEncoder<DefinedPacket>
 {
 
-    @Getter
     @Setter
     private Protocol protocol;
     private boolean server;
-    @Getter
     @Setter
     private int protocolVersion;
 

protocol/src/main/java/net/md_5/bungee/protocol/PlayerPublicKey.java

@@ -1,12 +0,0 @@
-package net.md_5.bungee.protocol;
-
-import lombok.Data;
-
-@Data
-public class PlayerPublicKey
-{
-
-    private final long expiry;
-    private final byte[] key;
-    private final byte[] signature;
-}

protocol/src/main/java/net/md_5/bungee/protocol/Property.java

@@ -1,19 +0,0 @@
-package net.md_5.bungee.protocol;
-
-import lombok.AllArgsConstructor;
-import lombok.Data;
-
-@Data
-@AllArgsConstructor
-public class Property
-{
-
-    private String name;
-    private String value;
-    private String signature;
-
-    public Property(String name, String value)
-    {
-        this( name, value, null );
-    }
-}

protocol/src/main/java/net/md_5/bungee/protocol/Protocol.java

@@ -6,26 +6,21 @@ import gnu.trove.map.TIntObjectMap;
 import gnu.trove.map.TObjectIntMap;
 import gnu.trove.map.hash.TIntObjectHashMap;
 import gnu.trove.map.hash.TObjectIntHashMap;
-import java.util.function.Supplier;
+import java.lang.reflect.Constructor;
 import lombok.Data;
 import lombok.Getter;
 import net.md_5.bungee.protocol.packet.BossBar;
 import net.md_5.bungee.protocol.packet.Chat;
-import net.md_5.bungee.protocol.packet.ClearTitles;
-import net.md_5.bungee.protocol.packet.ClientChat;
-import net.md_5.bungee.protocol.packet.ClientCommand;
 import net.md_5.bungee.protocol.packet.ClientSettings;
 import net.md_5.bungee.protocol.packet.Commands;
 import net.md_5.bungee.protocol.packet.EncryptionRequest;
 import net.md_5.bungee.protocol.packet.EncryptionResponse;
 import net.md_5.bungee.protocol.packet.EntityStatus;
-import net.md_5.bungee.protocol.packet.FinishConfiguration;
 import net.md_5.bungee.protocol.packet.GameState;
 import net.md_5.bungee.protocol.packet.Handshake;
 import net.md_5.bungee.protocol.packet.KeepAlive;
 import net.md_5.bungee.protocol.packet.Kick;
 import net.md_5.bungee.protocol.packet.Login;
-import net.md_5.bungee.protocol.packet.LoginAcknowledged;
 import net.md_5.bungee.protocol.packet.LoginPayloadRequest;
 import net.md_5.bungee.protocol.packet.LoginPayloadResponse;
 import net.md_5.bungee.protocol.packet.LoginRequest;
@@ -33,25 +28,18 @@ import net.md_5.bungee.protocol.packet.LoginSuccess;
 import net.md_5.bungee.protocol.packet.PingPacket;
 import net.md_5.bungee.protocol.packet.PlayerListHeaderFooter;
 import net.md_5.bungee.protocol.packet.PlayerListItem;
-import net.md_5.bungee.protocol.packet.PlayerListItemRemove;
-import net.md_5.bungee.protocol.packet.PlayerListItemUpdate;
 import net.md_5.bungee.protocol.packet.PluginMessage;
 import net.md_5.bungee.protocol.packet.Respawn;
 import net.md_5.bungee.protocol.packet.ScoreboardDisplay;
 import net.md_5.bungee.protocol.packet.ScoreboardObjective;
 import net.md_5.bungee.protocol.packet.ScoreboardScore;
-import net.md_5.bungee.protocol.packet.ServerData;
 import net.md_5.bungee.protocol.packet.SetCompression;
-import net.md_5.bungee.protocol.packet.StartConfiguration;
 import net.md_5.bungee.protocol.packet.StatusRequest;
 import net.md_5.bungee.protocol.packet.StatusResponse;
-import net.md_5.bungee.protocol.packet.Subtitle;
-import net.md_5.bungee.protocol.packet.SystemChat;
 import net.md_5.bungee.protocol.packet.TabCompleteRequest;
 import net.md_5.bungee.protocol.packet.TabCompleteResponse;
 import net.md_5.bungee.protocol.packet.Team;
 import net.md_5.bungee.protocol.packet.Title;
-import net.md_5.bungee.protocol.packet.TitleTimes;
 import net.md_5.bungee.protocol.packet.ViewDistance;
 
 public enum Protocol
@@ -64,7 +52,6 @@ public enum Protocol
         {
             TO_SERVER.registerPacket(
                     Handshake.class,
-                    Handshake::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x00 )
             );
         }
@@ -76,50 +63,33 @@ public enum Protocol
         {
             TO_CLIENT.registerPacket(
                     KeepAlive.class,
-                    KeepAlive::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x00 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x1F ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x21 ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x20 ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x21 ),
                     map( ProtocolConstants.MINECRAFT_1_16, 0x20 ),
-                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x1F ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x21 ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x1E ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x20 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x1F ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x23 ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x24 )
+                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x1F )
             );
             TO_CLIENT.registerPacket(
                     Login.class,
-                    Login::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x01 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x23 ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x25 ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x26 ),
                     map( ProtocolConstants.MINECRAFT_1_16, 0x25 ),
-                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x24 ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x26 ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x23 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x25 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x24 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x28 ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x29 )
+                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x24 )
             );
-            TO_CLIENT.registerPacket( Chat.class,
-                    Chat::new,
+            TO_CLIENT.registerPacket(
+                    Chat.class,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x02 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x0F ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x0E ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x0F ),
-                    map( ProtocolConstants.MINECRAFT_1_16, 0x0E ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x0F ),
-                    map( ProtocolConstants.MINECRAFT_1_19, -1 )
+                    map( ProtocolConstants.MINECRAFT_1_16, 0x0E )
             );
             TO_CLIENT.registerPacket(
                     Respawn.class,
-                    Respawn::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x07 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x33 ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x34 ),
@@ -128,28 +98,16 @@ public enum Protocol
                     map( ProtocolConstants.MINECRAFT_1_14, 0x3A ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x3B ),
                     map( ProtocolConstants.MINECRAFT_1_16, 0x3A ),
-                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x39 ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x3D ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x3B ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x3E ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x3D ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x41 ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x43 )
+                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x39 )
             );
             TO_CLIENT.registerPacket(
                     BossBar.class,
-                    BossBar::new,
                     map( ProtocolConstants.MINECRAFT_1_9, 0x0C ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x0D ),
-                    map( ProtocolConstants.MINECRAFT_1_16, 0x0C ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x0D ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x0A ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x0B ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x0A )
+                    map( ProtocolConstants.MINECRAFT_1_16, 0x0C )
             );
             TO_CLIENT.registerPacket(
                     PlayerListItem.class, // PlayerInfo
-                    PlayerListItem::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x38 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x2D ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x2E ),
@@ -157,183 +115,89 @@ public enum Protocol
                     map( ProtocolConstants.MINECRAFT_1_14, 0x33 ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x34 ),
                     map( ProtocolConstants.MINECRAFT_1_16, 0x33 ),
-                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x32 ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x36 ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x34 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x37 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, -1 )
+                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x32 )
             );
             TO_CLIENT.registerPacket(
                     TabCompleteResponse.class,
-                    TabCompleteResponse::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x3A ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x0E ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x10 ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x11 ),
                     map( ProtocolConstants.MINECRAFT_1_16, 0x10 ),
-                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x0F ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x11 ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x0E ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x0D ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x0F ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x10 )
+                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x0F )
             );
             TO_CLIENT.registerPacket(
                     ScoreboardObjective.class,
-                    ScoreboardObjective::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x3B ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x3F ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x41 ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x42 ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x45 ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x49 ),
-                    map( ProtocolConstants.MINECRAFT_1_15, 0x4A ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x53 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x56 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x54 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x58 ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x5A )
+                    map( ProtocolConstants.MINECRAFT_1_15, 0x4A )
             );
             TO_CLIENT.registerPacket(
                     ScoreboardScore.class,
-                    ScoreboardScore::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x3C ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x42 ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x44 ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x45 ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x48 ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x4C ),
-                    map( ProtocolConstants.MINECRAFT_1_15, 0x4D ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x56 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x59 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x57 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x5B ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x5D )
+                    map( ProtocolConstants.MINECRAFT_1_15, 0x4D )
             );
             TO_CLIENT.registerPacket(
                     ScoreboardDisplay.class,
-                    ScoreboardDisplay::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x3D ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x38 ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x3A ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x3B ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x3E ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x42 ),
-                    map( ProtocolConstants.MINECRAFT_1_15, 0x43 ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x4C ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x4F ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x4D ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x51 ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x53 )
+                    map( ProtocolConstants.MINECRAFT_1_15, 0x43 )
             );
             TO_CLIENT.registerPacket(
                     Team.class,
-                    Team::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x3E ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x41 ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x43 ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x44 ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x47 ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x4B ),
-                    map( ProtocolConstants.MINECRAFT_1_15, 0x4C ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x55 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x58 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x56 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x5A ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x5C )
+                    map( ProtocolConstants.MINECRAFT_1_15, 0x4C )
             );
             TO_CLIENT.registerPacket(
                     PluginMessage.class,
-                    PluginMessage::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x3F ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x18 ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x19 ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x18 ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x19 ),
                     map( ProtocolConstants.MINECRAFT_1_16, 0x18 ),
-                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x17 ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x18 ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x15 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x16 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x15 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x17 ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x18 )
+                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x17 )
             );
             TO_CLIENT.registerPacket(
                     Kick.class,
-                    Kick::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x40 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x1A ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x1B ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x1A ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x1B ),
                     map( ProtocolConstants.MINECRAFT_1_16, 0x1A ),
-                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x19 ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x1A ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x17 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x19 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x17 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x1A ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x1B )
+                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x19 )
             );
             TO_CLIENT.registerPacket(
                     Title.class,
-                    Title::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x45 ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x47 ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x48 ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x4B ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x4F ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x50 ),
-                    map( ProtocolConstants.MINECRAFT_1_16, 0x4F ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x59 ),
-                    map( ProtocolConstants.MINECRAFT_1_18, 0x5A ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x5D ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x5B ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x5F ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x61 )
-            );
-            TO_CLIENT.registerPacket(
-                    ClearTitles.class,
-                    ClearTitles::new,
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x10 ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x0D ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x0C ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x0E ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x0F )
-            );
-            TO_CLIENT.registerPacket(
-                    Subtitle.class,
-                    Subtitle::new,
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x57 ),
-                    map( ProtocolConstants.MINECRAFT_1_18, 0x58 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x5B ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x59 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x5D ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x5F )
-            );
-            TO_CLIENT.registerPacket(
-                    TitleTimes.class,
-                    TitleTimes::new,
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x5A ),
-                    map( ProtocolConstants.MINECRAFT_1_18, 0x5B ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x5E ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x5C ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x60 ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x62 )
-            );
-            TO_CLIENT.registerPacket(
-                    SystemChat.class,
-                    SystemChat::new,
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x5F ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x62 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x60 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x64 ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x67 )
+                    map( ProtocolConstants.MINECRAFT_1_16, 0x4F )
             );
             TO_CLIENT.registerPacket(
                     PlayerListHeaderFooter.class,
-                    PlayerListHeaderFooter::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x47 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x48 ),
                     map( ProtocolConstants.MINECRAFT_1_9_4, 0x47 ),
@@ -342,187 +206,81 @@ public enum Protocol
                     map( ProtocolConstants.MINECRAFT_1_13, 0x4E ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x53 ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x54 ),
-                    map( ProtocolConstants.MINECRAFT_1_16, 0x53 ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x5E ),
-                    map( ProtocolConstants.MINECRAFT_1_18, 0x5F ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x60 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x63 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x61 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x65 ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x68 )
+                    map( ProtocolConstants.MINECRAFT_1_16, 0x53 )
             );
             TO_CLIENT.registerPacket(
                     EntityStatus.class,
-                    EntityStatus::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x1A ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x1B ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x1C ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x1B ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x1C ),
                     map( ProtocolConstants.MINECRAFT_1_16, 0x1B ),
-                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x1A ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x1B ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x18 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x1A ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x19 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x1C ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x1D )
+                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x1A )
             );
             TO_CLIENT.registerPacket(
                     Commands.class,
-                    Commands::new,
                     map( ProtocolConstants.MINECRAFT_1_13, 0x11 ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x12 ),
                     map( ProtocolConstants.MINECRAFT_1_16, 0x11 ),
-                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x10 ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x12 ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x0F ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x0E ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x10 ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x11 )
+                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x10 )
             );
             TO_CLIENT.registerPacket(
                     GameState.class,
-                    GameState::new,
                     map( ProtocolConstants.MINECRAFT_1_15, 0x1F ),
                     map( ProtocolConstants.MINECRAFT_1_16, 0x1E ),
-                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x1D ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x1E ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x1B ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x1D ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x1C ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x1F ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x20 )
+                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x1D )
             );
             TO_CLIENT.registerPacket(
                     ViewDistance.class,
-                    ViewDistance::new,
                     map( ProtocolConstants.MINECRAFT_1_14, 0x41 ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x42 ),
-                    map( ProtocolConstants.MINECRAFT_1_16, 0x41 ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x4A ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x49 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x4C ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x4B ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x4F ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x51 )
-            );
-            TO_CLIENT.registerPacket(
-                    ServerData.class,
-                    ServerData::new,
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x3F ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x42 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x41 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x45 ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x47 )
-            );
-            TO_CLIENT.registerPacket(
-                    PlayerListItemRemove.class,
-                    PlayerListItemRemove::new,
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x35 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x39 ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x3B )
-            );
-            TO_CLIENT.registerPacket(
-                    PlayerListItemUpdate.class,
-                    PlayerListItemUpdate::new,
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x36 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x3A ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x3C )
-            );
-            TO_CLIENT.registerPacket(
-                    StartConfiguration.class,
-                    StartConfiguration::new,
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x65 )
+                    map( ProtocolConstants.MINECRAFT_1_16, 0x41 )
             );
 
             TO_SERVER.registerPacket(
                     KeepAlive.class,
-                    KeepAlive::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x00 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x0B ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x0C ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x0B ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x0E ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x0F ),
-                    map( ProtocolConstants.MINECRAFT_1_16, 0x10 ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x0F ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x11 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x12 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x11 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x12 ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x14 )
+                    map( ProtocolConstants.MINECRAFT_1_16, 0x10 )
             );
-            TO_SERVER.registerPacket( Chat.class,
-                    Chat::new,
+            TO_SERVER.registerPacket(
+                    Chat.class,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x01 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x02 ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x03 ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x02 ),
-                    map( ProtocolConstants.MINECRAFT_1_14, 0x03 ),
-                    map( ProtocolConstants.MINECRAFT_1_19, -1 )
-            );
-            TO_SERVER.registerPacket(
-                    ClientCommand.class,
-                    ClientCommand::new,
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x03 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x04 )
-            );
-            TO_SERVER.registerPacket(
-                    ClientChat.class,
-                    ClientChat::new,
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x04 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x05 )
+                    map( ProtocolConstants.MINECRAFT_1_14, 0x03 )
             );
             TO_SERVER.registerPacket(
                     TabCompleteRequest.class,
-                    TabCompleteRequest::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x14 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x01 ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x02 ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x01 ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x05 ),
-                    map( ProtocolConstants.MINECRAFT_1_14, 0x06 ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x08 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x09 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x08 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x09 ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x0A )
+                    map( ProtocolConstants.MINECRAFT_1_14, 0x06 )
             );
             TO_SERVER.registerPacket(
                     ClientSettings.class,
-                    ClientSettings::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x15 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x04 ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x05 ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x04 ),
-                    map( ProtocolConstants.MINECRAFT_1_14, 0x05 ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x07 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x08 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x07 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x08 ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x09 )
+                    map( ProtocolConstants.MINECRAFT_1_14, 0x05 )
             );
             TO_SERVER.registerPacket(
                     PluginMessage.class,
-                    PluginMessage::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x17 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x09 ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x0A ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x09 ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x0A ),
-                    map( ProtocolConstants.MINECRAFT_1_14, 0x0B ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x0A ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x0C ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x0D ),
-                    map( ProtocolConstants.MINECRAFT_1_19_3, 0x0C ),
-                    map( ProtocolConstants.MINECRAFT_1_19_4, 0x0D ),
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x0F )
-            );
-            TO_SERVER.registerPacket(
-                    StartConfiguration.class,
-                    StartConfiguration::new,
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x0B )
+                    map( ProtocolConstants.MINECRAFT_1_14, 0x0B )
             );
         }
     },
@@ -533,23 +291,19 @@ public enum Protocol
         {
             TO_CLIENT.registerPacket(
                     StatusResponse.class,
-                    StatusResponse::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x00 )
             );
             TO_CLIENT.registerPacket(
                     PingPacket.class,
-                    PingPacket::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x01 )
             );
 
             TO_SERVER.registerPacket(
                     StatusRequest.class,
-                    StatusRequest::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x00 )
             );
             TO_SERVER.registerPacket(
                     PingPacket.class,
-                    PingPacket::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x01 )
             );
         }
@@ -561,105 +315,44 @@ public enum Protocol
         {
             TO_CLIENT.registerPacket(
                     Kick.class,
-                    Kick::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x00 )
             );
             TO_CLIENT.registerPacket(
                     EncryptionRequest.class,
-                    EncryptionRequest::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x01 )
             );
             TO_CLIENT.registerPacket(
                     LoginSuccess.class,
-                    LoginSuccess::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x02 )
             );
             TO_CLIENT.registerPacket(
                     SetCompression.class,
-                    SetCompression::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x03 )
             );
             TO_CLIENT.registerPacket(
                     LoginPayloadRequest.class,
-                    LoginPayloadRequest::new,
                     map( ProtocolConstants.MINECRAFT_1_13, 0x04 )
             );
 
             TO_SERVER.registerPacket(
                     LoginRequest.class,
-                    LoginRequest::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x00 )
             );
             TO_SERVER.registerPacket(
                     EncryptionResponse.class,
-                    EncryptionResponse::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x01 )
             );
             TO_SERVER.registerPacket(
                     LoginPayloadResponse.class,
-                    LoginPayloadResponse::new,
                     map( ProtocolConstants.MINECRAFT_1_13, 0x02 )
             );
-            TO_SERVER.registerPacket(
-                    LoginAcknowledged.class,
-                    LoginAcknowledged::new,
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x03 )
-            );
-        }
-    },
-    // 3
-    CONFIGURATION
-    {
-
-        {
-            TO_CLIENT.registerPacket(
-                    PluginMessage.class,
-                    PluginMessage::new,
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x00 )
-            );
-            TO_CLIENT.registerPacket(
-                    Kick.class,
-                    Kick::new,
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x01 )
-            );
-            TO_CLIENT.registerPacket(
-                    FinishConfiguration.class,
-                    FinishConfiguration::new,
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x02 )
-            );
-            TO_CLIENT.registerPacket(
-                    KeepAlive.class,
-                    KeepAlive::new,
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x03 )
-            );
-
-            TO_SERVER.registerPacket(
-                    ClientSettings.class,
-                    ClientSettings::new,
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x00 )
-            );
-            TO_SERVER.registerPacket(
-                    PluginMessage.class,
-                    PluginMessage::new,
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x01 )
-            );
-            TO_SERVER.registerPacket(
-                    FinishConfiguration.class,
-                    FinishConfiguration::new,
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x02 )
-            );
-            TO_SERVER.registerPacket(
-                    KeepAlive.class,
-                    KeepAlive::new,
-                    map( ProtocolConstants.MINECRAFT_1_20_2, 0x03 )
-            );
         }
     };
     /*========================================================================*/
     public static final int MAX_PACKET_ID = 0xFF;
     /*========================================================================*/
-    public final DirectionData TO_SERVER = new DirectionData( this, ProtocolConstants.Direction.TO_SERVER );
-    public final DirectionData TO_CLIENT = new DirectionData( this, ProtocolConstants.Direction.TO_CLIENT );
+    final DirectionData TO_SERVER = new DirectionData( this, ProtocolConstants.Direction.TO_SERVER );
+    final DirectionData TO_CLIENT = new DirectionData( this, ProtocolConstants.Direction.TO_CLIENT );
 
     public static void main(String[] args)
     {
@@ -701,8 +394,7 @@ public enum Protocol
 
         private final int protocolVersion;
         private final TObjectIntMap<Class<? extends DefinedPacket>> packetMap = new TObjectIntHashMap<>( MAX_PACKET_ID );
-        @SuppressWarnings("unchecked")
-        private final Supplier<? extends DefinedPacket>[] packetConstructors = new Supplier[ MAX_PACKET_ID ];
+        private final Constructor<? extends DefinedPacket>[] packetConstructors = new Constructor[ MAX_PACKET_ID ];
     }
 
     @Data
@@ -719,7 +411,7 @@ public enum Protocol
         return new ProtocolMapping( protocol, id );
     }
 
-    public static final class DirectionData
+    static final class DirectionData
     {
 
         private final TIntObjectMap<ProtocolData> protocols = new TIntObjectHashMap<>();
@@ -756,61 +448,58 @@ public enum Protocol
             {
                 throw new BadPacketException( "Unsupported protocol version " + version );
             }
-            if ( id > MAX_PACKET_ID || id < 0 )
+            if ( id > MAX_PACKET_ID )
             {
-                throw new BadPacketException( "Packet with id " + id + " outside of range" );
+                throw new BadPacketException( "Packet with id " + id + " outside of range " );
             }
 
-            Supplier<? extends DefinedPacket> constructor = protocolData.packetConstructors[id];
-            return ( constructor == null ) ? null : constructor.get();
+            Constructor<? extends DefinedPacket> constructor = protocolData.packetConstructors[id];
+            try
+            {
+                return ( constructor == null ) ? null : constructor.newInstance();
+            } catch ( ReflectiveOperationException ex )
+            {
+                throw new BadPacketException( "Could not construct packet with id " + id, ex );
+            }
         }
 
-        private void registerPacket(Class<? extends DefinedPacket> packetClass, Supplier<? extends DefinedPacket> constructor, ProtocolMapping... mappings)
+        private void registerPacket(Class<? extends DefinedPacket> packetClass, ProtocolMapping... mappings)
         {
-            int mappingIndex = 0;
-            ProtocolMapping mapping = mappings[mappingIndex];
-            for ( int protocol : ProtocolConstants.SUPPORTED_VERSION_IDS )
+            try
             {
-                if ( protocol < mapping.protocolVersion )
-                {
-                    // This is a new packet, skip it till we reach the next protocol
-                    continue;
-                }
+                Constructor<? extends DefinedPacket> constructor = packetClass.getDeclaredConstructor();
 
-                if ( mapping.protocolVersion < protocol && mappingIndex + 1 < mappings.length )
+                int mappingIndex = 0;
+                ProtocolMapping mapping = mappings[mappingIndex];
+                for ( int protocol : ProtocolConstants.SUPPORTED_VERSION_IDS )
                 {
-                    // Mapping is non current, but the next one may be ok
-                    ProtocolMapping nextMapping = mappings[mappingIndex + 1];
-
-                    if ( nextMapping.protocolVersion == protocol )
+                    if ( protocol < mapping.protocolVersion )
                     {
-                        Preconditions.checkState( nextMapping.packetID != mapping.packetID, "Duplicate packet mapping (%s, %s)", mapping.protocolVersion, nextMapping.protocolVersion );
-
-                        mapping = nextMapping;
-                        mappingIndex++;
+                        // This is a new packet, skip it till we reach the next protocol
+                        continue;
                     }
+
+                    if ( mapping.protocolVersion < protocol && mappingIndex + 1 < mappings.length )
+                    {
+                        // Mapping is non current, but the next one may be ok
+                        ProtocolMapping nextMapping = mappings[mappingIndex + 1];
+                        if ( nextMapping.protocolVersion == protocol )
+                        {
+                            Preconditions.checkState( nextMapping.packetID != mapping.packetID, "Duplicate packet mapping (%s, %s)", mapping.protocolVersion, nextMapping.protocolVersion );
+
+                            mapping = nextMapping;
+                            mappingIndex++;
+                        }
+                    }
+
+                    ProtocolData data = protocols.get( protocol );
+                    data.packetMap.put( packetClass, mapping.packetID );
+                    data.packetConstructors[mapping.packetID] = constructor;
                 }
-
-                if ( mapping.packetID < 0 )
-                {
-                    break;
-                }
-
-                ProtocolData data = protocols.get( protocol );
-                data.packetMap.put( packetClass, mapping.packetID );
-                data.packetConstructors[mapping.packetID] = constructor;
-            }
-        }
-
-        public boolean hasPacket(Class<? extends DefinedPacket> packet, int version)
-        {
-            ProtocolData protocolData = getProtocolData( version );
-            if ( protocolData == null )
+            } catch ( NoSuchMethodException ex )
             {
-                throw new BadPacketException( "Unsupported protocol version" );
+                throw new BadPacketException( "No NoArgsConstructor for packet class " + packetClass );
             }
-
-            return protocolData.packetMap.containsKey( packet );
         }
 
         final int getId(Class<? extends DefinedPacket> packet, int version)

protocol/src/main/java/net/md_5/bungee/protocol/ProtocolConstants.java

@@ -1,12 +1,11 @@
 package net.md_5.bungee.protocol;
 
-import com.google.common.collect.ImmutableList;
+import java.util.Arrays;
 import java.util.List;
 
 public class ProtocolConstants
 {
 
-    private static final boolean SNAPSHOT_SUPPORT = Boolean.getBoolean( "net.md_5.bungee.protocol.snapshot" );
     public static final int MINECRAFT_1_8 = 47;
     public static final int MINECRAFT_1_9 = 107;
     public static final int MINECRAFT_1_9_1 = 108;
@@ -34,85 +33,46 @@ public class ProtocolConstants
     public static final int MINECRAFT_1_16_2 = 751;
     public static final int MINECRAFT_1_16_3 = 753;
     public static final int MINECRAFT_1_16_4 = 754;
-    public static final int MINECRAFT_1_17 = 755;
-    public static final int MINECRAFT_1_17_1 = 756;
-    public static final int MINECRAFT_1_18 = 757;
-    public static final int MINECRAFT_1_18_2 = 758;
-    public static final int MINECRAFT_1_19 = 759;
-    public static final int MINECRAFT_1_19_1 = 760;
-    public static final int MINECRAFT_1_19_3 = 761;
-    public static final int MINECRAFT_1_19_4 = 762;
-    public static final int MINECRAFT_1_20 = 763;
-    public static final int MINECRAFT_1_20_2 = 764;
-    public static final List<String> SUPPORTED_VERSIONS;
-    public static final List<Integer> SUPPORTED_VERSION_IDS;
-
-    static
-    {
-        ImmutableList.Builder<String> supportedVersions = ImmutableList.<String>builder().add(
-                "1.8.x",
-                "1.9.x",
-                "1.10.x",
-                "1.11.x",
-                "1.12.x",
-                "1.13.x",
-                "1.14.x",
-                "1.15.x",
-                "1.16.x",
-                "1.17.x",
-                "1.18.x",
-                "1.19.x",
-                "1.20.x"
-        );
-        ImmutableList.Builder<Integer> supportedVersionIds = ImmutableList.<Integer>builder().add(
-                ProtocolConstants.MINECRAFT_1_8,
-                ProtocolConstants.MINECRAFT_1_9,
-                ProtocolConstants.MINECRAFT_1_9_1,
-                ProtocolConstants.MINECRAFT_1_9_2,
-                ProtocolConstants.MINECRAFT_1_9_4,
-                ProtocolConstants.MINECRAFT_1_10,
-                ProtocolConstants.MINECRAFT_1_11,
-                ProtocolConstants.MINECRAFT_1_11_1,
-                ProtocolConstants.MINECRAFT_1_12,
-                ProtocolConstants.MINECRAFT_1_12_1,
-                ProtocolConstants.MINECRAFT_1_12_2,
-                ProtocolConstants.MINECRAFT_1_13,
-                ProtocolConstants.MINECRAFT_1_13_1,
-                ProtocolConstants.MINECRAFT_1_13_2,
-                ProtocolConstants.MINECRAFT_1_14,
-                ProtocolConstants.MINECRAFT_1_14_1,
-                ProtocolConstants.MINECRAFT_1_14_2,
-                ProtocolConstants.MINECRAFT_1_14_3,
-                ProtocolConstants.MINECRAFT_1_14_4,
-                ProtocolConstants.MINECRAFT_1_15,
-                ProtocolConstants.MINECRAFT_1_15_1,
-                ProtocolConstants.MINECRAFT_1_15_2,
-                ProtocolConstants.MINECRAFT_1_16,
-                ProtocolConstants.MINECRAFT_1_16_1,
-                ProtocolConstants.MINECRAFT_1_16_2,
-                ProtocolConstants.MINECRAFT_1_16_3,
-                ProtocolConstants.MINECRAFT_1_16_4,
-                ProtocolConstants.MINECRAFT_1_17,
-                ProtocolConstants.MINECRAFT_1_17_1,
-                ProtocolConstants.MINECRAFT_1_18,
-                ProtocolConstants.MINECRAFT_1_18_2,
-                ProtocolConstants.MINECRAFT_1_19,
-                ProtocolConstants.MINECRAFT_1_19_1,
-                ProtocolConstants.MINECRAFT_1_19_3,
-                ProtocolConstants.MINECRAFT_1_19_4,
-                ProtocolConstants.MINECRAFT_1_20,
-                ProtocolConstants.MINECRAFT_1_20_2
-        );
-
-        if ( SNAPSHOT_SUPPORT )
-        {
-            // supportedVersions.add( "1.20.x" );
-            // supportedVersionIds.add( ProtocolConstants.MINECRAFT_1_20_2 );
-        }
-
-        SUPPORTED_VERSIONS = supportedVersions.build();
-        SUPPORTED_VERSION_IDS = supportedVersionIds.build();
-    }
+    public static final List<String> SUPPORTED_VERSIONS = Arrays.asList(
+            "1.8.x",
+            "1.9.x",
+            "1.10.x",
+            "1.11.x",
+            "1.12.x",
+            "1.13.x",
+            "1.14.x",
+            "1.15.x",
+            "1.16.x"
+    );
+    public static final List<Integer> SUPPORTED_VERSION_IDS = Arrays.asList(
+            ProtocolConstants.MINECRAFT_1_8,
+            ProtocolConstants.MINECRAFT_1_9,
+            ProtocolConstants.MINECRAFT_1_9_1,
+            ProtocolConstants.MINECRAFT_1_9_2,
+            ProtocolConstants.MINECRAFT_1_9_4,
+            ProtocolConstants.MINECRAFT_1_10,
+            ProtocolConstants.MINECRAFT_1_11,
+            ProtocolConstants.MINECRAFT_1_11_1,
+            ProtocolConstants.MINECRAFT_1_12,
+            ProtocolConstants.MINECRAFT_1_12_1,
+            ProtocolConstants.MINECRAFT_1_12_2,
+            ProtocolConstants.MINECRAFT_1_13,
+            ProtocolConstants.MINECRAFT_1_13_1,
+            ProtocolConstants.MINECRAFT_1_13_2,
+            ProtocolConstants.MINECRAFT_1_14,
+            ProtocolConstants.MINECRAFT_1_14_1,
+            ProtocolConstants.MINECRAFT_1_14_2,
+            ProtocolConstants.MINECRAFT_1_14_3,
+            ProtocolConstants.MINECRAFT_1_14_4,
+            ProtocolConstants.MINECRAFT_1_15,
+            ProtocolConstants.MINECRAFT_1_15_1,
+            ProtocolConstants.MINECRAFT_1_15_2,
+            ProtocolConstants.MINECRAFT_1_16,
+            ProtocolConstants.MINECRAFT_1_16_1,
+            ProtocolConstants.MINECRAFT_1_16_2,
+            ProtocolConstants.MINECRAFT_1_16_3,
+            ProtocolConstants.MINECRAFT_1_16_4
+    );
 
     public enum Direction
     {

protocol/src/main/java/net/md_5/bungee/protocol/SeenMessages.java

@@ -1,39 +0,0 @@
-package net.md_5.bungee.protocol;
-
-import io.netty.buffer.ByteBuf;
-import java.util.BitSet;
-import lombok.AllArgsConstructor;
-import lombok.Data;
-import lombok.EqualsAndHashCode;
-import lombok.NoArgsConstructor;
-
-@Data
-@NoArgsConstructor
-@AllArgsConstructor
-@EqualsAndHashCode(callSuper = false)
-public class SeenMessages extends DefinedPacket
-{
-
-    private int offset;
-    private BitSet acknowledged;
-
-    @Override
-    public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        offset = DefinedPacket.readVarInt( buf );
-        acknowledged = DefinedPacket.readFixedBitSet( 20, buf );
-    }
-
-    @Override
-    public void write(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        DefinedPacket.writeVarInt( offset, buf );
-        DefinedPacket.writeFixedBitSet( acknowledged, 20, buf );
-    }
-
-    @Override
-    public void handle(AbstractPacketHandler handler) throws Exception
-    {
-        throw new UnsupportedOperationException( "Not supported." );
-    }
-}

protocol/src/main/java/net/md_5/bungee/protocol/Varint21FrameDecoder.java

@@ -53,7 +53,8 @@ public class Varint21FrameDecoder extends ByteToMessageDecoder
                 {
                     if ( in.hasMemoryAddress() )
                     {
-                        out.add( in.readRetainedSlice( length ) );
+                        out.add( in.slice( in.readerIndex(), length ).retain() );
+                        in.skipBytes( length );
                     } else
                     {
                         if ( !DIRECT_WARNING )

protocol/src/main/java/net/md_5/bungee/protocol/Varint21LengthFieldExtraBufPrepender.java

@@ -1,25 +0,0 @@
-package net.md_5.bungee.protocol;
-
-import io.netty.buffer.ByteBuf;
-import io.netty.channel.ChannelHandler;
-import io.netty.channel.ChannelHandlerContext;
-import io.netty.handler.codec.MessageToMessageEncoder;
-import java.util.List;
-
-/**
- * Prepend length of the message as a Varint21 using an extra buffer for the length, avoiding copying packet data
- */
-@ChannelHandler.Sharable
-public class Varint21LengthFieldExtraBufPrepender extends MessageToMessageEncoder<ByteBuf>
-{
-
-    @Override
-    protected void encode(ChannelHandlerContext ctx, ByteBuf msg, List<Object> out) throws Exception
-    {
-        int bodyLen = msg.readableBytes();
-        ByteBuf lenBuf = ctx.alloc().ioBuffer( Varint21LengthFieldPrepender.varintSize( bodyLen ) );
-        DefinedPacket.writeVarInt( bodyLen, lenBuf );
-        out.add( lenBuf );
-        out.add( msg.retain() );
-    }
-}

protocol/src/main/java/net/md_5/bungee/protocol/Varint21LengthFieldPrepender.java

@@ -5,9 +5,6 @@ import io.netty.channel.ChannelHandler;
 import io.netty.channel.ChannelHandlerContext;
 import io.netty.handler.codec.MessageToByteEncoder;
 
-/**
- * Prepend length of the message as a Varint21 by writing length and data to a new buffer
- */
 @ChannelHandler.Sharable
 public class Varint21LengthFieldPrepender extends MessageToByteEncoder<ByteBuf>
 {
@@ -23,7 +20,7 @@ public class Varint21LengthFieldPrepender extends MessageToByteEncoder<ByteBuf>
         out.writeBytes( msg );
     }
 
-    static int varintSize(int paramInt)
+    private static int varintSize(int paramInt)
     {
         if ( ( paramInt & 0xFFFFFF80 ) == 0 )
         {

protocol/src/main/java/net/md_5/bungee/protocol/packet/Chat.java

@@ -40,7 +40,7 @@ public class Chat extends DefinedPacket
     @Override
     public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
     {
-        message = readString( buf, ( direction == ProtocolConstants.Direction.TO_CLIENT ) ? 262144 : ( protocolVersion >= ProtocolConstants.MINECRAFT_1_11 ? 256 : 100 ) );
+        message = readString( buf );
         if ( direction == ProtocolConstants.Direction.TO_CLIENT )
         {
             position = buf.readByte();
@@ -54,7 +54,7 @@ public class Chat extends DefinedPacket
     @Override
     public void write(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
     {
-        writeString( message, buf, ( direction == ProtocolConstants.Direction.TO_CLIENT ) ? 262144 : ( protocolVersion >= ProtocolConstants.MINECRAFT_1_11 ? 256 : 100 ) );
+        writeString( message, buf );
         if ( direction == ProtocolConstants.Direction.TO_CLIENT )
         {
             buf.writeByte( position );

protocol/src/main/java/net/md_5/bungee/protocol/packet/ClearTitles.java

@@ -1,38 +0,0 @@
-package net.md_5.bungee.protocol.packet;
-
-import io.netty.buffer.ByteBuf;
-import lombok.AllArgsConstructor;
-import lombok.Data;
-import lombok.EqualsAndHashCode;
-import lombok.NoArgsConstructor;
-import net.md_5.bungee.protocol.AbstractPacketHandler;
-import net.md_5.bungee.protocol.DefinedPacket;
-import net.md_5.bungee.protocol.ProtocolConstants;
-
-@Data
-@NoArgsConstructor
-@AllArgsConstructor
-@EqualsAndHashCode(callSuper = false)
-public class ClearTitles extends DefinedPacket
-{
-
-    private boolean reset;
-
-    @Override
-    public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        reset = buf.readBoolean();
-    }
-
-    @Override
-    public void write(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        buf.writeBoolean( reset );
-    }
-
-    @Override
-    public void handle(AbstractPacketHandler handler) throws Exception
-    {
-        handler.handle( this );
-    }
-}

protocol/src/main/java/net/md_5/bungee/protocol/packet/ClientChat.java

@@ -1,97 +0,0 @@
-package net.md_5.bungee.protocol.packet;
-
-import io.netty.buffer.ByteBuf;
-import lombok.AllArgsConstructor;
-import lombok.Data;
-import lombok.EqualsAndHashCode;
-import lombok.NoArgsConstructor;
-import net.md_5.bungee.protocol.AbstractPacketHandler;
-import net.md_5.bungee.protocol.ChatChain;
-import net.md_5.bungee.protocol.DefinedPacket;
-import net.md_5.bungee.protocol.ProtocolConstants;
-import net.md_5.bungee.protocol.SeenMessages;
-
-@Data
-@NoArgsConstructor
-@AllArgsConstructor
-@EqualsAndHashCode(callSuper = false)
-public class ClientChat extends DefinedPacket
-{
-
-    private String message;
-    private long timestamp;
-    private long salt;
-    private byte[] signature;
-    private boolean signedPreview;
-    private ChatChain chain;
-    private SeenMessages seenMessages;
-
-    @Override
-    public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        message = readString( buf, 256 );
-        timestamp = buf.readLong();
-        salt = buf.readLong();
-
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19_3 )
-        {
-            if ( buf.readBoolean() )
-            {
-                signature = new byte[ 256 ];
-                buf.readBytes( signature );
-            }
-        } else
-        {
-            signature = readArray( buf );
-        }
-        if ( protocolVersion < ProtocolConstants.MINECRAFT_1_19_3 )
-        {
-            signedPreview = buf.readBoolean();
-        }
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19_3 )
-        {
-            seenMessages = new SeenMessages();
-            seenMessages.read( buf, direction, protocolVersion );
-        } else if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19_1 )
-        {
-            chain = new ChatChain();
-            chain.read( buf, direction, protocolVersion );
-        }
-    }
-
-    @Override
-    public void write(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        writeString( message, buf );
-        buf.writeLong( timestamp );
-        buf.writeLong( salt );
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19_3 )
-        {
-            buf.writeBoolean( signature != null );
-            if ( signature != null )
-            {
-                buf.writeBytes( signature );
-            }
-        } else
-        {
-            writeArray( signature, buf );
-        }
-        if ( protocolVersion < ProtocolConstants.MINECRAFT_1_19_3 )
-        {
-            buf.writeBoolean( signedPreview );
-        }
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19_3 )
-        {
-            seenMessages.write( buf, direction, protocolVersion );
-        } else if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19_1 )
-        {
-            chain.write( buf, direction, protocolVersion );
-        }
-    }
-
-    @Override
-    public void handle(AbstractPacketHandler handler) throws Exception
-    {
-        handler.handle( this );
-    }
-}

protocol/src/main/java/net/md_5/bungee/protocol/packet/ClientCommand.java

@@ -1,111 +0,0 @@
-package net.md_5.bungee.protocol.packet;
-
-import com.google.common.base.Preconditions;
-import io.netty.buffer.ByteBuf;
-import java.util.HashMap;
-import java.util.Map;
-import lombok.AllArgsConstructor;
-import lombok.Data;
-import lombok.EqualsAndHashCode;
-import lombok.NoArgsConstructor;
-import net.md_5.bungee.protocol.AbstractPacketHandler;
-import net.md_5.bungee.protocol.ChatChain;
-import net.md_5.bungee.protocol.DefinedPacket;
-import net.md_5.bungee.protocol.ProtocolConstants;
-import net.md_5.bungee.protocol.SeenMessages;
-
-@Data
-@NoArgsConstructor
-@AllArgsConstructor
-@EqualsAndHashCode(callSuper = false)
-public class ClientCommand extends DefinedPacket
-{
-
-    private String command;
-    private long timestamp;
-    private long salt;
-    private Map<String, byte[]> signatures;
-    private boolean signedPreview;
-    private ChatChain chain;
-    private SeenMessages seenMessages;
-
-    @Override
-    public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        command = readString( buf, 256 );
-        timestamp = buf.readLong();
-        salt = buf.readLong();
-
-        int cnt = readVarInt( buf );
-        Preconditions.checkArgument( cnt <= 8, "Too many signatures" );
-        signatures = new HashMap<>( cnt );
-        for ( int i = 0; i < cnt; i++ )
-        {
-            String name = readString( buf, 16 );
-            byte[] signature;
-
-            if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19_3 )
-            {
-                signature = new byte[ 256 ];
-                buf.readBytes( signature );
-            } else
-            {
-                signature = readArray( buf );
-            }
-            signatures.put( name, signature );
-        }
-
-        if ( protocolVersion < ProtocolConstants.MINECRAFT_1_19_3 )
-        {
-            signedPreview = buf.readBoolean();
-        }
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19_3 )
-        {
-            seenMessages = new SeenMessages();
-            seenMessages.read( buf, direction, protocolVersion );
-        } else if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19_1 )
-        {
-            chain = new ChatChain();
-            chain.read( buf, direction, protocolVersion );
-        }
-    }
-
-    @Override
-    public void write(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        writeString( command, buf );
-        buf.writeLong( timestamp );
-        buf.writeLong( salt );
-
-        writeVarInt( signatures.size(), buf );
-        for ( Map.Entry<String, byte[]> entry : signatures.entrySet() )
-        {
-            writeString( entry.getKey(), buf );
-            if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19_3 )
-            {
-                buf.writeBytes( entry.getValue() );
-            } else
-            {
-                writeArray( entry.getValue(), buf );
-            }
-        }
-
-        if ( protocolVersion < ProtocolConstants.MINECRAFT_1_19_3 )
-        {
-            buf.writeBoolean( signedPreview );
-        }
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19_3 )
-        {
-            seenMessages.write( buf, direction, protocolVersion );
-        } else if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19_1 )
-        {
-            chain.write( buf, direction, protocolVersion );
-        }
-    }
-
-    @Override
-    public void handle(AbstractPacketHandler handler) throws Exception
-    {
-        handler.handle( this );
-    }
-}

protocol/src/main/java/net/md_5/bungee/protocol/packet/ClientSettings.java

@@ -23,13 +23,11 @@ public class ClientSettings extends DefinedPacket
     private byte difficulty;
     private byte skinParts;
     private int mainHand;
-    private boolean disableTextFiltering;
-    private boolean allowServerListing;
 
     @Override
     public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
     {
-        locale = readString( buf, 16 );
+        locale = readString( buf );
         viewDistance = buf.readByte();
         chatFlags = protocolVersion >= ProtocolConstants.MINECRAFT_1_9 ? DefinedPacket.readVarInt( buf ) : buf.readUnsignedByte();
         chatColours = buf.readBoolean();
@@ -38,14 +36,6 @@ public class ClientSettings extends DefinedPacket
         {
             mainHand = DefinedPacket.readVarInt( buf );
         }
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_17 )
-        {
-            disableTextFiltering = buf.readBoolean();
-        }
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_18 )
-        {
-            allowServerListing = buf.readBoolean();
-        }
     }
 
     @Override
@@ -66,14 +56,6 @@ public class ClientSettings extends DefinedPacket
         {
             DefinedPacket.writeVarInt( mainHand, buf );
         }
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_17 )
-        {
-            buf.writeBoolean( disableTextFiltering );
-        }
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_18 )
-        {
-            buf.writeBoolean( allowServerListing );
-        }
     }
 
     @Override