Add CommandsDeclareEvent to declare commands with brigadier API

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -1,63 +0,0 @@
-name: Bug inside BungeeCord
-description: Create a bug report about a problem inside BungeeCord.
-body:
-  - type: markdown
-    attributes:
-      value: |
-        #### Report a bug inside bungeecord
-        Issues happening with forks of BungeeCord should **not** be reported here.
-  - type: input
-    id: bungee-version
-    attributes:
-      label: Bungeecord version
-      description: The output of the /bungee command (or just the bungee build number) (execute in bungeecord console for easy text copy)
-      placeholder: e.g. git:BungeeCord-Bootstrap:1.xx-SNAPSHOT:xxxxxxx:xxxx
-    validations:
-      required: true
-  - type: input
-    id: server-version
-    attributes:
-      label: Server version
-      description: The output of the /version command (execute in server console for easy text copy)
-      placeholder: "e.g. git-Spigot-xxxxxxx-xxxxxxx (MC: 1.x.x)"
-  - type: input
-    id: client-version
-    attributes:
-      label: Client version
-      description: Minecraft Client Version
-      placeholder: e.g. 1.18.2
-  - type: textarea
-    id: bungee-plugins
-    attributes:
-      label: Bungeecord plugins
-      description: Please list all BungeeCord plugins you are using.
-    validations:
-      required: true
-  - type: textarea
-    id: the-bug
-    attributes:
-      label: The bug
-      description: Please describe the bug. Include **details** you find neccessary. If you just have a question, please ask it in [SpigotMC Forums](https://www.spigotmc.org) and not here.
-    validations:
-      required: true
-  - type: textarea
-    id: logs
-    attributes:
-      label: Log output (links)
-      description: Please put your log output inbetween three backticks (```` ``` ````). Upload your log files to [gist.github.com](https://gist.github.com) and put them in here.
-      placeholder: |
-        ```
-        log output
-        ```
-  - type: checkboxes
-    id: checkboxes
-    attributes:
-      label: Checking
-      options:
-        - label: I am using BungeeCord and **not a fork**. Issues with forks should not be reported here.
-          required: true
-        - label: I think this is **not** an issue with a bungeecord plugin.
-          required: true
-        - label: I have not read these checkboxes and therefore I just ticked them all.
-        - label: This is not a question or plugin creation help request.
-          required: true

.github/ISSUE_TEMPLATE/config.yml

@@ -1,14 +0,0 @@
-blank_issues_enabled: false
-contact_links:
-  - name: Configuration help
-    url: https://www.spigotmc.org/forums/bungeecord-help.70/create-thread
-    about: Help for configuring bungeecord will only be answered in spigotmc.org forums.
-  - name: I have a problem with a bungee plugin
-    url: https://www.spigotmc.org/forums/bungeecord-plugin-help.71/create-thread
-    about: Help about plugins can be recieved in spigotmc.org forums.
-  - name: Questions and discussions
-    url: https://www.spigotmc.org/forums/bungeecord-discussion.21/create-thread
-    about: spigotmc.org forums are the best place to ask your questions regarding bungeecord.
-  - name: Plugin creation help
-    url: https://www.spigotmc.org/forums/bungeecord-plugin-development.23/create-thread
-    about: Plugin creation help for bungee plugins can be recieved in spigotmc.org forums.

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -1,36 +0,0 @@
-name: Feature request
-description: Suggest a feature which bungeecord should include.
-body:
-  - type: textarea
-    id: the-feature
-    attributes:
-      label: Feature description
-      description: Please describe your feature or improvement. Please include **details**.
-    validations:
-      required: true
-  - type: textarea
-    id: goal
-    attributes:
-      label: Goal of the feature
-      description: What is the goal of your feature?
-    validations:
-      required: true
-  - type: textarea
-    id: alternatives
-    attributes:
-      label: Unfitting alternatives
-      description: What alternatives have you considered and why are they not sufficient for your use case?
-    validations:
-      required: true
-  - type: checkboxes
-    id: checkboxes
-    attributes:
-      label: Checking
-      options:
-        - label: This is not a question or plugin creation help request.
-          required: true
-        - label: This is a **feature or improvement request**.
-          required: true
-        - label: I have not read these checkboxes and therefore I just ticked them all.
-        - label: I did not use this form to report a bug.
-          required: true

.github/workflows/maven.yml

@@ -4,12 +4,11 @@ on: [push, pull_request]
 
 jobs:
   build:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
 
     strategy:
-      fail-fast: false
       matrix:
-        java: [8, 11, 17]
+        java: [8, 11]
 
     name: Java ${{ matrix.java }}
 

.gitmodules

@@ -1,6 +0,0 @@
-[submodule "native/mbedtls"]
-	path = native/mbedtls
-	url = https://github.com/ARMmbed/mbedtls.git
-[submodule "native/zlib"]
-	path = native/zlib
-	url = https://github.com/cloudflare/zlib.git

README.md

@@ -23,4 +23,4 @@ Binaries
 --------
 Precompiled binaries are available for end users on [Jenkins](https://www.spigotmc.org/go/bungeecord-dl).
 
-(c) 2012-2022 SpigotMC Pty. Ltd.
+(c) 2012-2020 SpigotMC Pty. Ltd.

api/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-parent</artifactId>
-        <version>1.19-R0.1-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-api</artifactId>
-    <version>1.19-R0.1-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>BungeeCord-API</name>
@@ -49,31 +49,10 @@
             <version>${netty.version}</version>
             <scope>compile</scope>
         </dependency>
-        <dependency>
-            <groupId>org.apache.maven</groupId>
-            <artifactId>maven-resolver-provider</artifactId>
-            <version>3.8.5</version>
-            <!-- not part of the API proper -->
-            <scope>provided</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.apache.maven.resolver</groupId>
-            <artifactId>maven-resolver-connector-basic</artifactId>
-            <version>1.7.3</version>
-            <!-- not part of the API proper -->
-            <scope>provided</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.apache.maven.resolver</groupId>
-            <artifactId>maven-resolver-transport-http</artifactId>
-            <version>1.7.3</version>
-            <!-- not part of the API proper -->
-            <scope>provided</scope>
-        </dependency>
         <dependency>
             <groupId>org.yaml</groupId>
             <artifactId>snakeyaml</artifactId>
-            <version>1.30</version>
+            <version>1.26</version>
             <scope>compile</scope>
         </dependency>
     </dependencies>

api/src/main/java/net/md_5/bungee/Util.java

@@ -7,7 +7,6 @@ import java.net.InetSocketAddress;
 import java.net.SocketAddress;
 import java.net.URI;
 import java.net.URISyntaxException;
-import java.util.Locale;
 import java.util.UUID;
 
 /**
@@ -69,17 +68,6 @@ public class Util
         return String.format( "0x%02X", i );
     }
 
-    /**
-     * Formats an char as a unicode value.
-     *
-     * @param c the character to format
-     * @return the unicode representation of the character
-     */
-    public static String unicode(char c)
-    {
-        return "\\u" + String.format( "%04x", (int) c ).toUpperCase( Locale.ROOT );
-    }
-
     /**
      * Constructs a pretty one line version of a {@link Throwable}. Useful for
      * debugging.
@@ -88,24 +76,11 @@ public class Util
      * @return a string representing information about the {@link Throwable}
      */
     public static String exception(Throwable t)
-    {
-        return exception( t, true );
-    }
-
-    /**
-     * Constructs a pretty one line version of a {@link Throwable}. Useful for
-     * debugging.
-     *
-     * @param t the {@link Throwable} to format.
-     * @param includeLineNumbers whether to include line numbers
-     * @return a string representing information about the {@link Throwable}
-     */
-    public static String exception(Throwable t, boolean includeLineNumbers)
     {
         // TODO: We should use clear manually written exceptions
         StackTraceElement[] trace = t.getStackTrace();
         return t.getClass().getSimpleName() + " : " + t.getMessage()
-                + ( ( includeLineNumbers && trace.length > 0 ) ? " @ " + t.getStackTrace()[0].getClassName() + ":" + t.getStackTrace()[0].getLineNumber() : "" );
+                + ( ( trace.length > 0 ) ? " @ " + t.getStackTrace()[0].getClassName() + ":" + t.getStackTrace()[0].getLineNumber() : "" );
     }
 
     public static String csv(Iterable<?> objects)

api/src/main/java/net/md_5/bungee/api/AbstractReconnectHandler.java

@@ -28,13 +28,18 @@ public abstract class AbstractReconnectHandler implements ReconnectHandler
 
     public static ServerInfo getForcedHost(PendingConnection con)
     {
-        String forced = ( con.getVirtualHost() == null ) ? null : con.getListener().getForcedHosts().get( con.getVirtualHost().getHostString() );
+        if ( con.getVirtualHost() == null )
+        {
+            return null;
+        }
+
+        String forced = con.getListener().getForcedHosts().get( con.getVirtualHost().getHostString() );
 
         if ( forced == null && con.getListener().isForceDefault() )
         {
             forced = con.getListener().getDefaultServer();
         }
-        return ( forced == null ) ? null : ProxyServer.getInstance().getServerInfo( forced );
+        return ProxyServer.getInstance().getServerInfo( forced );
     }
 
     protected abstract ServerInfo getStoredServer(ProxiedPlayer player);

api/src/main/java/net/md_5/bungee/api/connection/ProxiedPlayer.java

@@ -57,7 +57,8 @@ public interface ProxiedPlayer extends Connection, CommandSender
     String getDisplayName();
 
     /**
-     * Sets this player's display name to be used by proxy commands and plugins.
+     * Sets this players display name to be used as their nametag and tab list
+     * name.
      *
      * @param name the name to set
      */

api/src/main/java/net/md_5/bungee/api/event/CommandsDeclareEvent.java

@@ -0,0 +1,157 @@
+package net.md_5.bungee.api.event;
+
+import com.mojang.brigadier.arguments.ArgumentType;
+import com.mojang.brigadier.arguments.IntegerArgumentType;
+import com.mojang.brigadier.arguments.StringArgumentType;
+import com.mojang.brigadier.builder.ArgumentBuilder;
+import com.mojang.brigadier.builder.RequiredArgumentBuilder;
+import com.mojang.brigadier.suggestion.SuggestionProvider;
+import com.mojang.brigadier.tree.CommandNode;
+import com.mojang.brigadier.tree.RootCommandNode;
+import lombok.AccessLevel;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+import lombok.Setter;
+import lombok.ToString;
+import net.md_5.bungee.api.CommandSender;
+import net.md_5.bungee.api.connection.Connection;
+import net.md_5.bungee.api.plugin.Command;
+import net.md_5.bungee.api.plugin.Plugin;
+import net.md_5.bungee.api.plugin.PluginManager;
+import net.md_5.bungee.api.plugin.TabExecutor;
+
+/**
+ * Event called when a downstream server (on 1.13+) sends the command structure
+ * to a player, but before BungeeCord adds the dummy command nodes of
+ * registered commands.
+ * <p>
+ * BungeeCord will not overwrite the modifications made by the listeners.
+ *
+ * <h2>Usage example</h2>
+ * Here is a usage example of this event, to declare a command structure.
+ * This illustrates the commands /server and /send of Bungee.
+ * <pre>
+ * event.getRoot().addChild( LiteralArgumentBuilder.&lt;CommandSender&gt;literal( "server" )
+ *         .requires( sender -&gt; sender.hasPermission( "bungeecord.command.server" ) )
+ *         .executes( a -&gt; 0 )
+ *         .then( RequiredArgumentBuilder.argument( "serverName", StringArgumentType.greedyString() )
+ *                 .suggests( SuggestionRegistry.ASK_SERVER )
+ *         )
+ *         .build()
+ * );
+ * event.getRoot().addChild( LiteralArgumentBuilder.&lt;CommandSender&gt;literal( "send" )
+ *         .requires( sender -&gt; sender.hasPermission( "bungeecord.command.send" ) )
+ *         .then( RequiredArgumentBuilder.argument( "playerName", StringArgumentType.word() )
+ *                 .suggests( SuggestionRegistry.ASK_SERVER )
+ *                 .then( RequiredArgumentBuilder.argument( "serverName", StringArgumentType.greedyString() )
+ *                         .suggests( SuggestionRegistry.ASK_SERVER )
+ *                 )
+ *         )
+ *         .build()
+ * );
+ * </pre>
+ *
+ * <h2>Flag a {@link CommandNode} as executable or not</h2>
+ * The implementation of a {@link com.mojang.brigadier.Command Command} used in
+ * {@link ArgumentBuilder#executes(com.mojang.brigadier.Command)} will never be
+ * executed. This will only tell to the client if the current node is
+ * executable or not.
+ * <ul>
+ *     <li>
+ *         {@code builder.executes(null)} (default) to mark the node as not
+ *         executable.
+ *     </li>
+ *     <li>
+ *         {@code builder.executes(a -> 0)}, or any non null argument, to mark
+ *         the node as executable (the child arguments are displayed as
+ *         optional).
+ *     </li>
+ * </ul>
+ *
+ * <h2>{@link CommandNode}’s suggestions management</h2>
+ * The implementation of a SuggestionProvider used in
+ * {@link RequiredArgumentBuilder#suggests(SuggestionProvider)} will never be
+ * executed. This will only tell to the client how to deal with the
+ * auto-completion of the argument.
+ * <ul>
+ *     <li>
+ *         {@code builder.suggests(null)} (default) to disable auto-completion
+ *         for this argument.
+ *     </li>
+ *     <li>
+ *         {@code builder.suggests(SuggestionRegistry.ALL_RECIPES)} to suggest
+ *         Minecraft’s recipes.
+ *     </li>
+ *     <li>
+ *         {@code builder.suggests(SuggestionRegistry.AVAILABLE_SOUNDS)} to
+ *         suggest Minecraft’s default sound identifiers.
+ *     </li>
+ *     <li>
+ *         {@code builder.suggests(SuggestionRegistry.SUMMONABLE_ENTITIES)} to
+ *         suggest Minecraft’s default summonable entities identifiers.
+ *     </li>
+ *     <li>
+ *         {@code builder.suggests(SuggestionRegistry.ASK_SERVER)}, or any
+ *         other non null argument, to make the Minecraft client ask
+ *         auto-completion to the server. Any specified implementation of
+ *         {@link SuggestionProvider} will never be executed.
+ *     </li>
+ * </ul>
+ *
+ * <h2>Argument types</h2>
+ * When building a new argument command node using
+ * {@link RequiredArgumentBuilder#argument(String, ArgumentType)}, you have to
+ * specify an {@link ArgumentType}. You can use all subclasses of
+ * {@link ArgumentType} provided with brigadier (for instance,
+ * {@link StringArgumentType} or {@link IntegerArgumentType}), or call any
+ * {@code ArgumentRegistry.minecraft*()} methods to use a {@code minecraft:*}
+ * argument type.
+ *
+ * <h2>Limitations with brigadier API</h2>
+ * This event is only used for the client to show command syntax, suggest
+ * sub-commands and color the arguments in the chat box. The command execution
+ * needs to be implemented using {@link PluginManager#registerCommand(Plugin,
+ * Command)} and the server-side tab-completion using {@link TabCompleteEvent}
+ * or {@link TabExecutor}.
+ */
+@Data
+@ToString(callSuper = true)
+@EqualsAndHashCode(callSuper = true)
+public class CommandsDeclareEvent extends TargetedEvent
+{
+    /**
+     * Wether or not the command tree is modified by this event.
+     *
+     * If this value is set to true, BungeeCord will ensure that the
+     * modifications made in the command tree, will be sent to the player.
+     * If this is false, the modifications may not be taken into account.
+     *
+     * When calling {@link #getRoot()}, this value is automatically set
+     * to true.
+     */
+    @Setter(value = AccessLevel.NONE)
+    private boolean modified = false;
+
+    /**
+     * The root command node of the command structure that will be send to the
+     * player.
+     */
+    private final RootCommandNode<CommandSender> root;
+
+    public CommandsDeclareEvent(Connection sender, Connection receiver, RootCommandNode<CommandSender> root)
+    {
+        super( sender, receiver );
+        this.root = root;
+    }
+
+    /**
+     * The root command node of the command structure that will be send to the
+     * player.
+     * @return The root command node
+     */
+    public RootCommandNode<CommandSender> getRoot()
+    {
+        modified = true;
+        return root;
+    }
+}

api/src/main/java/net/md_5/bungee/api/plugin/LibraryLoader.java

@@ -1,123 +0,0 @@
-package net.md_5.bungee.api.plugin;
-
-import java.io.File;
-import java.net.MalformedURLException;
-import java.net.URL;
-import java.net.URLClassLoader;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.List;
-import java.util.logging.Level;
-import java.util.logging.Logger;
-import org.apache.maven.repository.internal.MavenRepositorySystemUtils;
-import org.eclipse.aether.DefaultRepositorySystemSession;
-import org.eclipse.aether.RepositorySystem;
-import org.eclipse.aether.artifact.Artifact;
-import org.eclipse.aether.artifact.DefaultArtifact;
-import org.eclipse.aether.collection.CollectRequest;
-import org.eclipse.aether.connector.basic.BasicRepositoryConnectorFactory;
-import org.eclipse.aether.graph.Dependency;
-import org.eclipse.aether.impl.DefaultServiceLocator;
-import org.eclipse.aether.repository.LocalRepository;
-import org.eclipse.aether.repository.RemoteRepository;
-import org.eclipse.aether.repository.RepositoryPolicy;
-import org.eclipse.aether.resolution.ArtifactResult;
-import org.eclipse.aether.resolution.DependencyRequest;
-import org.eclipse.aether.resolution.DependencyResolutionException;
-import org.eclipse.aether.resolution.DependencyResult;
-import org.eclipse.aether.spi.connector.RepositoryConnectorFactory;
-import org.eclipse.aether.spi.connector.transport.TransporterFactory;
-import org.eclipse.aether.transfer.AbstractTransferListener;
-import org.eclipse.aether.transfer.TransferCancelledException;
-import org.eclipse.aether.transfer.TransferEvent;
-import org.eclipse.aether.transport.http.HttpTransporterFactory;
-
-class LibraryLoader
-{
-
-    private final Logger logger;
-    private final RepositorySystem repository;
-    private final DefaultRepositorySystemSession session;
-    private final List<RemoteRepository> repositories;
-
-    public LibraryLoader(Logger logger)
-    {
-        this.logger = logger;
-
-        DefaultServiceLocator locator = MavenRepositorySystemUtils.newServiceLocator();
-        locator.addService( RepositoryConnectorFactory.class, BasicRepositoryConnectorFactory.class );
-        locator.addService( TransporterFactory.class, HttpTransporterFactory.class );
-
-        this.repository = locator.getService( RepositorySystem.class );
-        this.session = MavenRepositorySystemUtils.newSession();
-
-        session.setChecksumPolicy( RepositoryPolicy.CHECKSUM_POLICY_FAIL );
-        session.setLocalRepositoryManager( repository.newLocalRepositoryManager( session, new LocalRepository( "libraries" ) ) );
-        session.setTransferListener( new AbstractTransferListener()
-        {
-            @Override
-            public void transferStarted(TransferEvent event) throws TransferCancelledException
-            {
-                logger.log( Level.INFO, "Downloading {0}", event.getResource().getRepositoryUrl() + event.getResource().getResourceName() );
-            }
-        } );
-        session.setReadOnly();
-
-        this.repositories = repository.newResolutionRepositories( session, Arrays.asList( new RemoteRepository.Builder( "central", "default", "https://repo.maven.apache.org/maven2" ).build() ) );
-    }
-
-    public ClassLoader createLoader(PluginDescription desc)
-    {
-        if ( desc.getLibraries().isEmpty() )
-        {
-            return null;
-        }
-        logger.log( Level.INFO, "[{0}] Loading {1} libraries... please wait", new Object[]
-        {
-            desc.getName(), desc.getLibraries().size()
-        } );
-
-        List<Dependency> dependencies = new ArrayList<>();
-        for ( String library : desc.getLibraries() )
-        {
-            Artifact artifact = new DefaultArtifact( library );
-            Dependency dependency = new Dependency( artifact, null );
-
-            dependencies.add( dependency );
-        }
-
-        DependencyResult result;
-        try
-        {
-            result = repository.resolveDependencies( session, new DependencyRequest( new CollectRequest( (Dependency) null, dependencies, repositories ), null ) );
-        } catch ( DependencyResolutionException ex )
-        {
-            throw new RuntimeException( "Error resolving libraries", ex );
-        }
-
-        List<URL> jarFiles = new ArrayList<>();
-        for ( ArtifactResult artifact : result.getArtifactResults() )
-        {
-            File file = artifact.getArtifact().getFile();
-
-            URL url;
-            try
-            {
-                url = file.toURI().toURL();
-            } catch ( MalformedURLException ex )
-            {
-                throw new AssertionError( ex );
-            }
-
-            jarFiles.add( url );
-            logger.log( Level.INFO, "[{0}] Loaded library {1}", new Object[]
-            {
-                desc.getName(), file
-            } );
-        }
-
-        URLClassLoader loader = new URLClassLoader( jarFiles.toArray( new URL[ 0 ] ) );
-
-        return loader;
-    }
-}

api/src/main/java/net/md_5/bungee/api/plugin/PluginClassloader.java

@@ -1,23 +1,12 @@
 package net.md_5.bungee.api.plugin;
 
 import com.google.common.base.Preconditions;
-import com.google.common.io.ByteStreams;
-import java.io.File;
-import java.io.IOException;
-import java.io.InputStream;
 import java.net.URL;
 import java.net.URLClassLoader;
-import java.security.CodeSigner;
-import java.security.CodeSource;
 import java.util.Set;
 import java.util.concurrent.CopyOnWriteArraySet;
-import java.util.jar.JarEntry;
-import java.util.jar.JarFile;
-import java.util.jar.Manifest;
-import lombok.ToString;
 import net.md_5.bungee.api.ProxyServer;
 
-@ToString(of = "desc")
 final class PluginClassloader extends URLClassLoader
 {
 
@@ -25,10 +14,6 @@ final class PluginClassloader extends URLClassLoader
     //
     private final ProxyServer proxy;
     private final PluginDescription desc;
-    private final JarFile jar;
-    private final Manifest manifest;
-    private final URL url;
-    private final ClassLoader libraryLoader;
     //
     private Plugin plugin;
 
@@ -37,18 +22,11 @@ final class PluginClassloader extends URLClassLoader
         ClassLoader.registerAsParallelCapable();
     }
 
-    public PluginClassloader(ProxyServer proxy, PluginDescription desc, File file, ClassLoader libraryLoader) throws IOException
+    public PluginClassloader(ProxyServer proxy, PluginDescription desc, URL[] urls)
     {
-        super( new URL[]
-        {
-            file.toURI().toURL()
-        } );
+        super( urls );
         this.proxy = proxy;
         this.desc = desc;
-        this.jar = new JarFile( file );
-        this.manifest = jar.getManifest();
-        this.url = file.toURI().toURL();
-        this.libraryLoader = libraryLoader;
 
         allLoaders.add( this );
     }
@@ -56,34 +34,17 @@ final class PluginClassloader extends URLClassLoader
     @Override
     protected Class<?> loadClass(String name, boolean resolve) throws ClassNotFoundException
     {
-        return loadClass0( name, resolve, true, true );
+        return loadClass0( name, resolve, true );
     }
 
-    private Class<?> loadClass0(String name, boolean resolve, boolean checkOther, boolean checkLibraries) throws ClassNotFoundException
+    private Class<?> loadClass0(String name, boolean resolve, boolean checkOther) throws ClassNotFoundException
     {
         try
         {
-            Class<?> result = super.loadClass( name, resolve );
-
-            // SPIGOT-6749: Library classes will appear in the above, but we don't want to return them to other plugins
-            if ( checkOther || result.getClassLoader() == this )
-            {
-                return result;
-            }
+            return super.loadClass( name, resolve );
         } catch ( ClassNotFoundException ex )
         {
         }
-
-        if ( checkLibraries && libraryLoader != null )
-        {
-            try
-            {
-                return libraryLoader.loadClass( name );
-            } catch ( ClassNotFoundException ex )
-            {
-            }
-        }
-
         if ( checkOther )
         {
             for ( PluginClassloader loader : allLoaders )
@@ -92,81 +53,16 @@ final class PluginClassloader extends URLClassLoader
                 {
                     try
                     {
-                        return loader.loadClass0( name, resolve, false, proxy.getPluginManager().isTransitiveDepend( desc, loader.desc ) );
+                        return loader.loadClass0( name, resolve, false );
                     } catch ( ClassNotFoundException ex )
                     {
                     }
                 }
             }
         }
-
         throw new ClassNotFoundException( name );
     }
 
-    @Override
-    protected Class<?> findClass(String name) throws ClassNotFoundException
-    {
-        String path = name.replace( '.', '/' ).concat( ".class" );
-        JarEntry entry = jar.getJarEntry( path );
-
-        if ( entry != null )
-        {
-            byte[] classBytes;
-
-            try ( InputStream is = jar.getInputStream( entry ) )
-            {
-                classBytes = ByteStreams.toByteArray( is );
-            } catch ( IOException ex )
-            {
-                throw new ClassNotFoundException( name, ex );
-            }
-
-            int dot = name.lastIndexOf( '.' );
-            if ( dot != -1 )
-            {
-                String pkgName = name.substring( 0, dot );
-                if ( getPackage( pkgName ) == null )
-                {
-                    try
-                    {
-                        if ( manifest != null )
-                        {
-                            definePackage( pkgName, manifest, url );
-                        } else
-                        {
-                            definePackage( pkgName, null, null, null, null, null, null, null );
-                        }
-                    } catch ( IllegalArgumentException ex )
-                    {
-                        if ( getPackage( pkgName ) == null )
-                        {
-                            throw new IllegalStateException( "Cannot find package " + pkgName );
-                        }
-                    }
-                }
-            }
-
-            CodeSigner[] signers = entry.getCodeSigners();
-            CodeSource source = new CodeSource( url, signers );
-
-            return defineClass( name, classBytes, 0, classBytes.length, source );
-        }
-
-        return super.findClass( name );
-    }
-
-    @Override
-    public void close() throws IOException
-    {
-        try
-        {
-            super.close();
-        } finally
-        {
-            jar.close();
-        }
-    }
-
     void init(Plugin plugin)
     {
         Preconditions.checkArgument( plugin != null, "plugin" );

api/src/main/java/net/md_5/bungee/api/plugin/PluginDescription.java

@@ -2,8 +2,6 @@ package net.md_5.bungee.api.plugin;
 
 import java.io.File;
 import java.util.HashSet;
-import java.util.LinkedList;
-import java.util.List;
 import java.util.Set;
 import lombok.AllArgsConstructor;
 import lombok.Data;
@@ -50,8 +48,4 @@ public class PluginDescription
      * Optional description.
      */
     private String description = null;
-    /**
-     * Optional libraries.
-     */
-    private List<String> libraries = new LinkedList<>();
 }

api/src/main/java/net/md_5/bungee/api/plugin/PluginManager.java

@@ -4,12 +4,10 @@ import com.google.common.base.Preconditions;
 import com.google.common.collect.ArrayListMultimap;
 import com.google.common.collect.Multimap;
 import com.google.common.eventbus.Subscribe;
-import com.google.common.graph.GraphBuilder;
-import com.google.common.graph.Graphs;
-import com.google.common.graph.MutableGraph;
 import java.io.File;
 import java.io.InputStream;
 import java.lang.reflect.Method;
+import java.net.URL;
 import java.net.URLClassLoader;
 import java.util.Arrays;
 import java.util.Collection;
@@ -51,8 +49,6 @@ public final class PluginManager
     private final Yaml yaml;
     private final EventBus eventBus;
     private final Map<String, Plugin> plugins = new LinkedHashMap<>();
-    private final MutableGraph<String> dependencyGraph = GraphBuilder.directed().build();
-    private final LibraryLoader libraryLoader;
     private final Map<String, Command> commandMap = new HashMap<>();
     private Map<String, PluginDescription> toLoad = new HashMap<>();
     private final Multimap<Plugin, Command> commandsByPlugin = ArrayListMultimap.create();
@@ -71,17 +67,6 @@ public final class PluginManager
         yaml = new Yaml( yamlConstructor );
 
         eventBus = new EventBus( proxy.getLogger() );
-
-        LibraryLoader libraryLoader = null;
-        try
-        {
-            libraryLoader = new LibraryLoader( proxy.getLogger() );
-        } catch ( NoClassDefFoundError ex )
-        {
-            // Provided depends were not added back
-            proxy.getLogger().warning( "Could not initialize LibraryLoader (missing dependencies?)" );
-        }
-        this.libraryLoader = libraryLoader;
     }
 
     /**
@@ -324,7 +309,6 @@ public final class PluginManager
                 status = false;
             }
 
-            dependencyGraph.putEdge( plugin.getName(), dependName );
             if ( !status )
             {
                 break;
@@ -336,7 +320,10 @@ public final class PluginManager
         {
             try
             {
-                URLClassLoader loader = new PluginClassloader( proxy, plugin, plugin.getFile(), ( libraryLoader != null ) ? libraryLoader.createLoader( plugin ) : null );
+                URLClassLoader loader = new PluginClassloader( proxy, plugin, new URL[]
+                {
+                    plugin.getFile().toURI().toURL()
+                } );
                 Class<?> main = loader.loadClass( plugin.getMain() );
                 Plugin clazz = (Plugin) main.getDeclaredConstructor().newInstance();
 
@@ -348,7 +335,7 @@ public final class PluginManager
                 } );
             } catch ( Throwable t )
             {
-                proxy.getLogger().log( Level.WARNING, "Error loading plugin " + plugin.getName(), t );
+                proxy.getLogger().log( Level.WARNING, "Error enabling plugin " + plugin.getName(), t );
             }
         }
 
@@ -476,19 +463,4 @@ public final class PluginManager
     {
         return Collections.unmodifiableCollection( commandMap.entrySet() );
     }
-
-    boolean isTransitiveDepend(PluginDescription plugin, PluginDescription depend)
-    {
-        Preconditions.checkArgument( plugin != null, "plugin" );
-        Preconditions.checkArgument( depend != null, "depend" );
-
-        if ( dependencyGraph.nodes().contains( plugin.getName() ) )
-        {
-            if ( Graphs.reachableNodes( dependencyGraph, plugin.getName() ).contains( depend.getName() ) )
-            {
-                return true;
-            }
-        }
-        return false;
-    }
 }

bootstrap/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-parent</artifactId>
-        <version>1.19-R0.1-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-bootstrap</artifactId>
-    <version>1.19-R0.1-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>BungeeCord-Bootstrap</name>
@@ -79,25 +79,4 @@
             </plugin>
         </plugins>
     </build>
-
-    <profiles>
-        <profile>
-            <id>jdk-9-release</id>
-            <activation>
-                <jdk>[9,)</jdk>
-            </activation>
-            <properties>
-                <maven.compiler.release>6</maven.compiler.release>
-            </properties>
-        </profile>
-        <profile>
-            <id>jdk-12-release</id>
-            <activation>
-                <jdk>[12,)</jdk>
-            </activation>
-            <properties>
-                <maven.compiler.release>7</maven.compiler.release>
-            </properties>
-        </profile>
-    </profiles>
 </project>

chat/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-parent</artifactId>
-        <version>1.19-R0.1-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-chat</artifactId>
-    <version>1.19-R0.1-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>BungeeCord-Chat</name>
@@ -22,7 +22,7 @@
         <dependency>
             <groupId>com.google.code.gson</groupId>
             <artifactId>gson</artifactId>
-            <version>2.8.9</version>
+            <version>2.8.0</version>
             <scope>compile</scope>
         </dependency>
     </dependencies>

chat/src/main/java/net/md_5/bungee/api/ChatColor.java

@@ -300,7 +300,7 @@ public final class ChatColor
     @Deprecated
     public static ChatColor[] values()
     {
-        return BY_CHAR.values().toArray( new ChatColor[ 0 ] );
+        return BY_CHAR.values().toArray( new ChatColor[ BY_CHAR.values().size() ] );
     }
 
     /**

chat/src/main/java/net/md_5/bungee/api/chat/BaseComponent.java

@@ -78,12 +78,6 @@ public abstract class BaseComponent
     @Getter
     private HoverEvent hoverEvent;
 
-    /**
-     * Whether this component rejects previous formatting
-     */
-    @Getter
-    private transient boolean reset;
-
     /**
      * Default constructor.
      *

chat/src/main/java/net/md_5/bungee/api/chat/ComponentBuilder.java

@@ -57,7 +57,7 @@ public final class ComponentBuilder
      */
     public ComponentBuilder(ComponentBuilder original)
     {
-        this( original.parts.toArray( new BaseComponent[ 0 ] ) );
+        this( original.parts.toArray( new BaseComponent[ original.parts.size() ] ) );
     }
 
     /**
@@ -161,7 +161,7 @@ public final class ComponentBuilder
             previous = dummy;
             dummy = null;
         }
-        if ( previous != null && !component.isReset() )
+        if ( previous != null )
         {
             component.copyFormatting( previous, retention, false );
         }

chat/src/main/java/net/md_5/bungee/api/chat/TextComponent.java

@@ -44,7 +44,7 @@ public final class TextComponent extends BaseComponent
      */
     public static BaseComponent[] fromLegacyText(String message, ChatColor defaultColor)
     {
-        ArrayList<BaseComponent> components = new ArrayList<>();
+        ArrayList<BaseComponent> components = new ArrayList<BaseComponent>();
         StringBuilder builder = new StringBuilder();
         TextComponent component = new TextComponent();
         Matcher matcher = url.matcher( message );
@@ -111,15 +111,15 @@ public final class TextComponent extends BaseComponent
                 } else if ( format == ChatColor.MAGIC )
                 {
                     component.setObfuscated( true );
-                } else
+                } else if ( format == ChatColor.RESET )
+                {
+                    format = defaultColor;
+                    component = new TextComponent();
+                    component.setColor( format );
+                } else
                 {
-                    if ( format == ChatColor.RESET )
-                    {
-                        format = defaultColor;
-                    }
                     component = new TextComponent();
                     component.setColor( format );
-                    component.setReset( true );
                 }
                 continue;
             }
@@ -157,7 +157,7 @@ public final class TextComponent extends BaseComponent
         component.setText( builder.toString() );
         components.add( component );
 
-        return components.toArray( new BaseComponent[ 0 ] );
+        return components.toArray( new BaseComponent[ components.size() ] );
     }
 
     /**
@@ -230,6 +230,6 @@ public final class TextComponent extends BaseComponent
     @Override
     public String toString()
     {
-        return "TextComponent{text=" + text + ", " + super.toString() + '}';
+        return String.format( "TextComponent{text=%s, %s}", text, super.toString() );
     }
 }

chat/src/main/java/net/md_5/bungee/chat/BaseComponentSerializer.java

@@ -22,6 +22,14 @@ public class BaseComponentSerializer
 
     protected void deserialize(JsonObject object, BaseComponent component, JsonDeserializationContext context)
     {
+        if ( object.has( "color" ) )
+        {
+            component.setColor( ChatColor.of( object.get( "color" ).getAsString() ) );
+        }
+        if ( object.has( "font" ) )
+        {
+            component.setFont( object.get( "font" ).getAsString() );
+        }
         if ( object.has( "bold" ) )
         {
             component.setBold( object.get( "bold" ).getAsBoolean() );
@@ -42,14 +50,14 @@ public class BaseComponentSerializer
         {
             component.setObfuscated( object.get( "obfuscated" ).getAsBoolean() );
         }
-        if ( object.has( "color" ) )
-        {
-            component.setColor( ChatColor.of( object.get( "color" ).getAsString() ) );
-        }
         if ( object.has( "insertion" ) )
         {
             component.setInsertion( object.get( "insertion" ).getAsString() );
         }
+        if ( object.has( "extra" ) )
+        {
+            component.setExtra( Arrays.asList( context.<BaseComponent[]>deserialize( object.get( "extra" ), BaseComponent[].class ) ) );
+        }
 
         //Events
         if ( object.has( "clickEvent" ) )
@@ -85,7 +93,7 @@ public class BaseComponentSerializer
                     {
                         components = new BaseComponent[]
                         {
-                            context.deserialize( contents, BaseComponent.class )
+                                context.deserialize( contents, BaseComponent.class )
                         };
                     }
                     hoverEvent = new HoverEvent( action, components );
@@ -113,15 +121,6 @@ public class BaseComponentSerializer
                 component.setHoverEvent( hoverEvent );
             }
         }
-
-        if ( object.has( "font" ) )
-        {
-            component.setFont( object.get( "font" ).getAsString() );
-        }
-        if ( object.has( "extra" ) )
-        {
-            component.setExtra( Arrays.asList( context.<BaseComponent[]>deserialize( object.get( "extra" ), BaseComponent[].class ) ) );
-        }
     }
 
     protected void serialize(JsonObject object, BaseComponent component, JsonSerializationContext context)
@@ -136,6 +135,14 @@ public class BaseComponentSerializer
         {
             Preconditions.checkArgument( !ComponentSerializer.serializedComponents.get().contains( component ), "Component loop" );
             ComponentSerializer.serializedComponents.get().add( component );
+            if ( component.getColorRaw() != null )
+            {
+                object.addProperty( "color", component.getColorRaw().getName() );
+            }
+            if ( component.getFontRaw() != null )
+            {
+                object.addProperty( "font", component.getFontRaw() );
+            }
             if ( component.isBoldRaw() != null )
             {
                 object.addProperty( "bold", component.isBoldRaw() );
@@ -156,15 +163,16 @@ public class BaseComponentSerializer
             {
                 object.addProperty( "obfuscated", component.isObfuscatedRaw() );
             }
-            if ( component.getColorRaw() != null )
-            {
-                object.addProperty( "color", component.getColorRaw().getName() );
-            }
             if ( component.getInsertion() != null )
             {
                 object.addProperty( "insertion", component.getInsertion() );
             }
 
+            if ( component.getExtra() != null )
+            {
+                object.add( "extra", context.serialize( component.getExtra() ) );
+            }
+
             //Events
             if ( component.getClickEvent() != null )
             {
@@ -187,15 +195,6 @@ public class BaseComponentSerializer
                 }
                 object.add( "hoverEvent", hoverEvent );
             }
-
-            if ( component.getFontRaw() != null )
-            {
-                object.addProperty( "font", component.getFontRaw() );
-            }
-            if ( component.getExtra() != null )
-            {
-                object.add( "extra", context.serialize( component.getExtra() ) );
-            }
         } finally
         {
             ComponentSerializer.serializedComponents.get().remove( component );

chat/src/main/java/net/md_5/bungee/chat/TextComponentSerializer.java

@@ -8,6 +8,8 @@ import com.google.gson.JsonParseException;
 import com.google.gson.JsonSerializationContext;
 import com.google.gson.JsonSerializer;
 import java.lang.reflect.Type;
+import java.util.List;
+import net.md_5.bungee.api.chat.BaseComponent;
 import net.md_5.bungee.api.chat.TextComponent;
 
 public class TextComponentSerializer extends BaseComponentSerializer implements JsonSerializer<TextComponent>, JsonDeserializer<TextComponent>
@@ -30,9 +32,13 @@ public class TextComponentSerializer extends BaseComponentSerializer implements
     @Override
     public JsonElement serialize(TextComponent src, Type typeOfSrc, JsonSerializationContext context)
     {
+        List<BaseComponent> extra = src.getExtra();
         JsonObject object = new JsonObject();
-        serialize( object, src, context );
         object.addProperty( "text", src.getText() );
+        if ( src.hasFormatting() || ( extra != null && !extra.isEmpty() ) )
+        {
+            serialize( object, src, context );
+        }
         return object;
     }
 }

chat/src/test/java/net/md_5/bungee/api/chat/ComponentsTest.java

@@ -41,7 +41,7 @@ public class ComponentsTest
         {
             textComponent
         } );
-        json = "{\"hoverEvent\":{\"action\":\"show_item\",\"value\":[{\"text\":\"{id:\\\"minecraft:netherrack\\\",Count:47b}\"}]},\"text\":\"Test\"}";
+        json = "{\"text\":\"Test\",\"hoverEvent\":{\"action\":\"show_item\",\"value\":[{\"text\":\"{id:\\\"minecraft:netherrack\\\",Count:47b}\"}]}}";
         testDissembleReassemble( json );
         //////////
         String hoverVal = "{\"text\":\"{id:\\\"minecraft:dirt\\\",Count:1b}\"}";
@@ -572,37 +572,7 @@ public class ComponentsTest
         Assert.assertArrayEquals( hexColored, reColored );
     }
 
-    /**
-     * In legacy chat, colors and reset both reset all formatting.
-     * Make sure it works in combination with ComponentBuilder.
-     */
-    @Test
-    public void testLegacyResetInBuilder()
-    {
-        ComponentBuilder builder = new ComponentBuilder();
-        BaseComponent[] a = TextComponent.fromLegacyText( "§4§n44444§rdd§6§l6666" );
-
-        String expected = "{\"extra\":[{\"underlined\":true,\"color\":\"dark_red\",\"text\":\"44444\"},{\"color\":"
-                + "\"white\",\"text\":\"dd\"},{\"bold\":true,\"color\":\"gold\",\"text\":\"6666\"}],\"text\":\"\"}";
-        Assert.assertEquals( expected, ComponentSerializer.toString( a ) );
-
-        builder.append( a );
-
-        String test1 = ComponentSerializer.toString( builder.create() );
-        Assert.assertEquals( expected, test1 );
-
-        BaseComponent[] b = TextComponent.fromLegacyText( "§rrrrr" );
-        builder.append( b );
-
-        String test2 = ComponentSerializer.toString( builder.create() );
-        Assert.assertEquals(
-                "{\"extra\":[{\"underlined\":true,\"color\":\"dark_red\",\"text\":\"44444\"},"
-                        + "{\"color\":\"white\",\"text\":\"dd\"},{\"bold\":true,\"color\":\"gold\",\"text\":\"6666\"},"
-                        + "{\"color\":\"white\",\"text\":\"rrrr\"}],\"text\":\"\"}",
-                test2 );
-    }
-
-    private static String fromAndToLegacyText(String legacyText)
+    private String fromAndToLegacyText(String legacyText)
     {
         return BaseComponent.toLegacyText( TextComponent.fromLegacyText( legacyText ) );
     }

checkstyle.xml

@@ -33,7 +33,6 @@
 
         <!-- See http://checkstyle.sourceforge.net/config_filters.html -->
         <module name="SuppressionCommentFilter"/>
-        <module name="SuppressWarningsHolder"/>
 
         <!-- See http://checkstyle.sourceforge.net/config_imports.html -->
         <module name="AvoidStarImport"/>
@@ -55,11 +54,11 @@
         <module name="OperatorWrap"/>
         <module name="ParenPad">
             <property name="option" value="nospace"/>
-            <property name="tokens" value="ANNOTATION, CTOR_DEF, METHOD_DEF, LAMBDA"/>
+            <property name="tokens" value="ANNOTATION, CTOR_DEF, METHOD_DEF"/>
         </module>
         <module name="ParenPad">
             <property name="option" value="space"/>
-            <property name="tokens" value="ANNOTATION_FIELD_DEF, CTOR_CALL, DOT, ENUM_CONSTANT_DEF, EXPR, LITERAL_CATCH, LITERAL_DO, LITERAL_FOR, LITERAL_IF, LITERAL_NEW, LITERAL_SWITCH, LITERAL_SYNCHRONIZED, LITERAL_WHILE, METHOD_CALL, QUESTION, RESOURCE_SPECIFICATION, SUPER_CTOR_CALL, RECORD_DEF"/>
+            <property name="tokens" value="ANNOTATION_FIELD_DEF, CTOR_CALL, DOT, ENUM_CONSTANT_DEF, EXPR, LITERAL_CATCH, LITERAL_DO, LITERAL_FOR, LITERAL_IF, LITERAL_NEW, LITERAL_SWITCH, LITERAL_SYNCHRONIZED, LITERAL_WHILE, METHOD_CALL, QUESTION, RESOURCE_SPECIFICATION, SUPER_CTOR_CALL, LAMBDA"/>
         </module>
         <module name="SingleSpaceSeparator"/>
         <module name="TypecastParenPad"/>
@@ -85,6 +84,4 @@
         <module name="Indentation"/>
         <module name="UpperEll"/>
     </module>
-
-    <module name="SuppressWarningsFilter"/>
 </module>

config/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-parent</artifactId>
-        <version>1.19-R0.1-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-config</artifactId>
-    <version>1.19-R0.1-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>BungeeCord-Config</name>
@@ -22,14 +22,14 @@
         <dependency>
             <groupId>com.google.code.gson</groupId>
             <artifactId>gson</artifactId>
-            <version>2.8.9</version>
+            <version>2.8.0</version>
             <scope>compile</scope>
             <optional>true</optional>
         </dependency>
         <dependency>
             <groupId>org.yaml</groupId>
             <artifactId>snakeyaml</artifactId>
-            <version>1.30</version>
+            <version>1.26</version>
             <scope>compile</scope>
             <optional>true</optional>
         </dependency>

event/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-parent</artifactId>
-        <version>1.19-R0.1-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-event</artifactId>
-    <version>1.19-R0.1-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>BungeeCord-Event</name>

event/src/main/java/net/md_5/bungee/event/EventBus.java

@@ -1,6 +1,5 @@
 package net.md_5.bungee.event;
 
-import com.google.common.collect.ImmutableSet;
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
 import java.text.MessageFormat;
@@ -42,8 +41,6 @@ public class EventBus
         {
             for ( EventHandlerMethod method : handlers )
             {
-                long start = System.nanoTime();
-
                 try
                 {
                     method.invoke( event );
@@ -57,15 +54,6 @@ public class EventBus
                 {
                     logger.log( Level.WARNING, MessageFormat.format( "Error dispatching event {0} to listener {1}", event, method.getListener() ), ex.getCause() );
                 }
-
-                long elapsed = System.nanoTime() - start;
-                if ( elapsed > 50000000 )
-                {
-                    logger.log( Level.WARNING, "Plugin listener {0} took {1}ms to process event {2}!", new Object[]
-                    {
-                        method.getListener().getClass().getName(), elapsed / 1000000, event
-                    } );
-                }
             }
         }
     }
@@ -73,8 +61,7 @@ public class EventBus
     private Map<Class<?>, Map<Byte, Set<Method>>> findHandlers(Object listener)
     {
         Map<Class<?>, Map<Byte, Set<Method>>> handler = new HashMap<>();
-        Set<Method> methods = ImmutableSet.<Method>builder().add( listener.getClass().getMethods() ).add( listener.getClass().getDeclaredMethods() ).build();
-        for ( final Method m : methods )
+        for ( Method m : listener.getClass().getDeclaredMethods() )
         {
             EventHandler annotation = m.getAnnotation( EventHandler.class );
             if ( annotation != null )
@@ -88,8 +75,18 @@ public class EventBus
                     } );
                     continue;
                 }
-                Map<Byte, Set<Method>> prioritiesMap = handler.computeIfAbsent( params[0], k -> new HashMap<>() );
-                Set<Method> priority = prioritiesMap.computeIfAbsent( annotation.priority(), k -> new HashSet<>() );
+                Map<Byte, Set<Method>> prioritiesMap = handler.get( params[0] );
+                if ( prioritiesMap == null )
+                {
+                    prioritiesMap = new HashMap<>();
+                    handler.put( params[0], prioritiesMap );
+                }
+                Set<Method> priority = prioritiesMap.get( annotation.priority() );
+                if ( priority == null )
+                {
+                    priority = new HashSet<>();
+                    prioritiesMap.put( annotation.priority(), priority );
+                }
                 priority.add( m );
             }
         }
@@ -104,11 +101,22 @@ public class EventBus
         {
             for ( Map.Entry<Class<?>, Map<Byte, Set<Method>>> e : handler.entrySet() )
             {
-                Map<Byte, Map<Object, Method[]>> prioritiesMap = byListenerAndPriority.computeIfAbsent( e.getKey(), k -> new HashMap<>() );
+                Map<Byte, Map<Object, Method[]>> prioritiesMap = byListenerAndPriority.get( e.getKey() );
+                if ( prioritiesMap == null )
+                {
+                    prioritiesMap = new HashMap<>();
+                    byListenerAndPriority.put( e.getKey(), prioritiesMap );
+                }
                 for ( Map.Entry<Byte, Set<Method>> entry : e.getValue().entrySet() )
                 {
-                    Map<Object, Method[]> currentPriorityMap = prioritiesMap.computeIfAbsent( entry.getKey(), k -> new HashMap<>() );
-                    currentPriorityMap.put( listener, entry.getValue().toArray( new Method[ 0 ] ) );
+                    Map<Object, Method[]> currentPriorityMap = prioritiesMap.get( entry.getKey() );
+                    if ( currentPriorityMap == null )
+                    {
+                        currentPriorityMap = new HashMap<>();
+                        prioritiesMap.put( entry.getKey(), currentPriorityMap );
+                    }
+                    Method[] baked = new Method[ entry.getValue().size() ];
+                    currentPriorityMap.put( listener, entry.getValue().toArray( baked ) );
                 }
                 bakeHandlers( e.getKey() );
             }
@@ -186,7 +194,7 @@ public class EventBus
                     }
                 }
             } while ( value++ < Byte.MAX_VALUE );
-            byEventBaked.put( eventClass, handlersList.toArray( new EventHandlerMethod[ 0 ] ) );
+            byEventBaked.put( eventClass, handlersList.toArray( new EventHandlerMethod[ handlersList.size() ] ) );
         } else
         {
             byEventBaked.remove( eventClass );

event/src/test/java/net/md_5/bungee/event/SubclassTest.java

@@ -1,26 +0,0 @@
-package net.md_5.bungee.event;
-
-import java.util.concurrent.CountDownLatch;
-import org.junit.Assert;
-import org.junit.Test;
-
-public class SubclassTest extends EventBusTest
-{
-
-    private final CountDownLatch latch = new CountDownLatch( 1 );
-
-    @Test
-    @Override
-    public void testNestedEvents()
-    {
-        super.testNestedEvents();
-        Assert.assertEquals( 0, latch.getCount() );
-    }
-
-    @EventHandler
-    protected void extraListener(FirstEvent event)
-    {
-        Assert.assertEquals( 1, latch.getCount() );
-        latch.countDown();
-    }
-}

log/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-parent</artifactId>
-        <version>1.19-R0.1-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-log</artifactId>
-    <version>1.19-R0.1-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>BungeeCord-Log</name>

log/src/main/java/net/md_5/bungee/log/BungeeLogger.java

@@ -13,12 +13,10 @@ public class BungeeLogger extends Logger
 
     private final LogDispatcher dispatcher = new LogDispatcher( this );
 
-    // CHECKSTYLE:OFF
     @SuppressWarnings(
             {
                 "CallToPrintStackTrace", "CallToThreadStartDuringObjectConstruction"
             })
-    // CHECKSTYLE:ON
     @SuppressFBWarnings("SC_START_IN_CTOR")
     public BungeeLogger(String loggerName, String filePattern, ConsoleReader reader)
     {
@@ -28,7 +26,6 @@ public class BungeeLogger extends Logger
         try
         {
             FileHandler fileHandler = new FileHandler( filePattern, 1 << 24, 8, true );
-            fileHandler.setLevel( Level.parse( System.getProperty( "net.md_5.bungee.file-log-level", "INFO" ) ) );
             fileHandler.setFormatter( new ConciseFormatter( false ) );
             addHandler( fileHandler );
 

module/cmd-alert/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-module</artifactId>
-        <version>1.19-R0.1-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-module-cmd-alert</artifactId>
-    <version>1.19-R0.1-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>cmd_alert</name>

module/cmd-find/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-module</artifactId>
-        <version>1.19-R0.1-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-module-cmd-find</artifactId>
-    <version>1.19-R0.1-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>cmd_find</name>

module/cmd-kick/nb-configuration.xml

@@ -1,31 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<project-shared-configuration>
-    <!--
-    This file contains additional configuration written by modules in the NetBeans IDE.
-    The configuration is intended to be shared among all the users of project and
-    therefore it is assumed to be part of version control checkout.
-    Without this configuration present, some functionality in the IDE may be limited or fail altogether.
-    -->
-    <properties xmlns="http://www.netbeans.org/ns/maven-properties-data/1">
-        <!--
-        Properties that influence various parts of the IDE, especially code formatting and the like. 
-        You can copy and paste the single properties, into the pom.xml file and the IDE will pick them up.
-        That way multiple projects can share the same settings (useful for formatting rules for example).
-        Any value defined here will override the pom.xml file value but is only applicable to the current project.
-        -->
-        <org-netbeans-modules-editor-indent.CodeStyle.usedProfile>project</org-netbeans-modules-editor-indent.CodeStyle.usedProfile>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.classDeclBracePlacement>NEW_LINE</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.classDeclBracePlacement>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.otherBracePlacement>NEW_LINE</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.otherBracePlacement>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.methodDeclBracePlacement>NEW_LINE</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.methodDeclBracePlacement>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinMethodCallParens>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinMethodCallParens>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinSwitchParens>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinSwitchParens>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinCatchParens>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinCatchParens>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinTryParens>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinTryParens>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinSynchronizedParens>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinSynchronizedParens>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinArrayInitBrackets>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinArrayInitBrackets>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinParens>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinParens>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinWhileParens>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinWhileParens>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinIfParens>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinIfParens>
-        <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinForParens>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.spaceWithinForParens>
-    </properties>
-</project-shared-configuration>

module/cmd-kick/pom.xml

@@ -1,20 +0,0 @@
-
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
-    <modelVersion>4.0.0</modelVersion>
-
-    <parent>
-        <groupId>net.md-5</groupId>
-        <artifactId>bungeecord-module</artifactId>
-        <version>1.19-R0.1-SNAPSHOT</version>
-        <relativePath>../pom.xml</relativePath>
-    </parent>
-
-    <groupId>net.md-5</groupId>
-    <artifactId>bungeecord-module-cmd-kick</artifactId>
-    <version>1.19-R0.1-SNAPSHOT</version>
-    <packaging>jar</packaging>
-
-    <name>cmd_kick</name>
-    <description>Provides the gkick command</description>
-</project>

module/cmd-kick/src/main/java/net/md_5/bungee/module/cmd/kick/CommandKick.java

@@ -1,72 +0,0 @@
-package net.md_5.bungee.module.cmd.kick;
-
-import com.google.common.base.Joiner;
-import com.google.common.collect.ImmutableSet;
-import java.util.HashSet;
-import java.util.Locale;
-import java.util.Set;
-import net.md_5.bungee.api.ChatColor;
-import net.md_5.bungee.api.CommandSender;
-import net.md_5.bungee.api.ProxyServer;
-import net.md_5.bungee.api.chat.TextComponent;
-import net.md_5.bungee.api.connection.ProxiedPlayer;
-import net.md_5.bungee.api.plugin.Command;
-import net.md_5.bungee.api.plugin.TabExecutor;
-
-public class CommandKick extends Command implements TabExecutor
-{
-
-    public CommandKick()
-    {
-        super( "gkick", "bungeecord.command.kick" );
-    }
-
-    @Override
-    public void execute(CommandSender sender, String[] args)
-    {
-        if ( args.length == 0 )
-        {
-            sender.sendMessage( ProxyServer.getInstance().getTranslation( "username_needed" ) );
-        } else
-        {
-            ProxiedPlayer player = ProxyServer.getInstance().getPlayer( args[0] );
-
-            if ( player == null )
-            {
-                sender.sendMessage( TextComponent.fromLegacyText( ProxyServer.getInstance().getTranslation( "user_not_online" ) ) );
-                return;
-            }
-
-            if ( args.length == 1 )
-            {
-                player.disconnect( TextComponent.fromLegacyText( ProxyServer.getInstance().getTranslation( "kick_message" ) ) );
-            } else
-            {
-                String[] reason = new String[ args.length - 1 ];
-                System.arraycopy( args, 1, reason, 0, reason.length );
-                player.disconnect( TextComponent.fromLegacyText( ChatColor.translateAlternateColorCodes( '&', Joiner.on( ' ' ).join( reason ) ) ) );
-            }
-        }
-    }
-
-    @Override
-    public Iterable<String> onTabComplete(CommandSender sender, String[] args)
-    {
-        if ( args.length == 1 )
-        {
-            Set<String> matches = new HashSet<>();
-            String search = args[0].toLowerCase( Locale.ROOT );
-            for ( ProxiedPlayer player : ProxyServer.getInstance().getPlayers() )
-            {
-                if ( player.getName().toLowerCase( Locale.ROOT ).startsWith( search ) )
-                {
-                    matches.add( player.getName() );
-                }
-            }
-            return matches;
-        } else
-        {
-            return ImmutableSet.of();
-        }
-    }
-}

module/cmd-kick/src/main/java/net/md_5/bungee/module/cmd/kick/PluginKick.java

@@ -1,13 +0,0 @@
-package net.md_5.bungee.module.cmd.kick;
-
-import net.md_5.bungee.api.plugin.Plugin;
-
-public class PluginKick extends Plugin
-{
-
-    @Override
-    public void onEnable()
-    {
-        getProxy().getPluginManager().registerCommand( this, new CommandKick() );
-    }
-}

module/cmd-kick/src/main/resources/plugin.yml

@@ -1,5 +0,0 @@
-name: ${project.name}
-main: net.md_5.bungee.module.cmd.kick.PluginKick
-version: ${describe}
-description: ${project.description}
-author: ${module.author}

module/cmd-list/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-module</artifactId>
-        <version>1.19-R0.1-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-module-cmd-list</artifactId>
-    <version>1.19-R0.1-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>cmd_list</name>

module/cmd-send/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-module</artifactId>
-        <version>1.19-R0.1-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-module-cmd-send</artifactId>
-    <version>1.19-R0.1-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>cmd_send</name>

module/cmd-server/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-module</artifactId>
-        <version>1.19-R0.1-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-module-cmd-server</artifactId>
-    <version>1.19-R0.1-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>cmd_server</name>

module/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-parent</artifactId>
-        <version>1.19-R0.1-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-module</artifactId>
-    <version>1.19-R0.1-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>pom</packaging>
 
     <name>BungeeCord Modules</name>
@@ -21,7 +21,6 @@
     <modules>
         <module>cmd-alert</module>
         <module>cmd-find</module>
-        <module>cmd-kick</module>
         <module>cmd-list</module>
         <module>cmd-send</module>
         <module>cmd-server</module>

module/reconnect-yaml/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-module</artifactId>
-        <version>1.19-R0.1-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-module-reconnect-yaml</artifactId>
-    <version>1.19-R0.1-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>reconnect_yaml</name>

native/compile-native.sh

@@ -1,14 +1,6 @@
 #!/bin/sh
 
-set -eu
+CXX="g++ -shared -fPIC -O3 -Wall -Werror -I$JAVA_HOME/include/ -I$JAVA_HOME/include/linux/"
 
-echo "Compiling mbedtls"
-(cd mbedtls && make no_test)
-
-echo "Compiling zlib"
-(cd zlib && CFLAGS=-fPIC ./configure --static && make)
-
-CXX="g++ -shared -fPIC -Wl,--wrap=memcpy -O3 -Wall -Werror -I$JAVA_HOME/include/ -I$JAVA_HOME/include/linux/"
-
-$CXX -Imbedtls/include src/main/c/NativeCipherImpl.cpp -o src/main/resources/native-cipher.so mbedtls/library/libmbedcrypto.a
-$CXX -Izlib src/main/c/NativeCompressImpl.cpp -o src/main/resources/native-compress.so zlib/libz.a
+$CXX src/main/c/NativeCipherImpl.cpp -o src/main/resources/native-cipher.so -lcrypto
+$CXX src/main/c/NativeCompressImpl.cpp -o src/main/resources/native-compress.so -lz

native/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-parent</artifactId>
-        <version>1.19-R0.1-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-native</artifactId>
-    <version>1.19-R0.1-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>BungeeCord-Native</name>

native/src/main/c/NativeCipherImpl.cpp

@@ -1,15 +1,12 @@
+// Support for CentOS 6
+__asm__(".symver memcpy,memcpy@GLIBC_2.2.5");
+
 #include <stdlib.h>
 #include <string.h>
 
 #include <mbedtls/aes.h>
 #include "net_md_5_bungee_jni_cipher_NativeCipherImpl.h"
 
-// Support for CentOS 6
-__asm__(".symver memcpy,memcpy@GLIBC_2.2.5");
-extern "C" void *__wrap_memcpy(void *dest, const void *src, size_t n) {
-    return memcpy(dest, src, n);
-}
-
 typedef unsigned char byte;
 
 struct crypto_context {

native/src/main/c/NativeCompressImpl.cpp

@@ -1,15 +1,7 @@
 #include <stdlib.h>
-#include <string.h>
-
 #include <zlib.h>
 #include "net_md_5_bungee_jni_zlib_NativeCompressImpl.h"
 
-// Support for CentOS 6
-__asm__(".symver memcpy,memcpy@GLIBC_2.2.5");
-extern "C" void *__wrap_memcpy(void *dest, const void *src, size_t n) {
-    return memcpy(dest, src, n);
-}
-
 typedef unsigned char byte;
 
 static jfieldID consumedID;

native/src/main/java/net/md_5/bungee/jni/NativeCode.java

@@ -6,19 +6,18 @@ import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
-import java.util.function.Supplier;
 import net.md_5.bungee.jni.cipher.BungeeCipher;
 
 public final class NativeCode<T>
 {
 
     private final String name;
-    private final Supplier<? extends T> javaImpl;
-    private final Supplier<? extends T> nativeImpl;
+    private final Class<? extends T> javaImpl;
+    private final Class<? extends T> nativeImpl;
     //
     private boolean loaded;
 
-    public NativeCode(String name, Supplier<? extends T> javaImpl, Supplier<? extends T> nativeImpl)
+    public NativeCode(String name, Class<? extends T> javaImpl, Class<? extends T> nativeImpl)
     {
         this.name = name;
         this.javaImpl = javaImpl;
@@ -27,7 +26,13 @@ public final class NativeCode<T>
 
     public T newInstance()
     {
-        return ( loaded ) ? nativeImpl.get() : javaImpl.get();
+        try
+        {
+            return ( loaded ) ? nativeImpl.getDeclaredConstructor().newInstance() : javaImpl.getDeclaredConstructor().newInstance();
+        } catch ( ReflectiveOperationException ex )
+        {
+            throw new RuntimeException( "Error getting instance", ex );
+        }
     }
 
     public boolean load()

native/src/main/java/net/md_5/bungee/jni/cipher/JavaCipher.java

@@ -25,15 +25,9 @@ public class JavaCipher implements BungeeCipher
         }
     }
 
-    public JavaCipher()
+    public JavaCipher() throws GeneralSecurityException
     {
-        try
-        {
-            this.cipher = Cipher.getInstance( "AES/CFB8/NoPadding" );
-        } catch ( GeneralSecurityException ex )
-        {
-            throw new RuntimeException( ex );
-        }
+        this.cipher = Cipher.getInstance( "AES/CFB8/NoPadding" );
     }
 
     @Override

native/src/test/java/net/md_5/bungee/NativeCipherTest.java

@@ -26,7 +26,7 @@ public class NativeCipherTest
     private final SecretKey secret = new SecretKeySpec( new byte[ 16 ], "AES" );
     private static final int BENCHMARK_COUNT = 4096;
     //
-    private static final NativeCode<BungeeCipher> factory = new NativeCode<>( "native-cipher", JavaCipher::new, NativeCipher::new );
+    private static final NativeCode<BungeeCipher> factory = new NativeCode<>( "native-cipher", JavaCipher.class, NativeCipher.class );
 
     @Test
     public void testNative() throws Exception

native/src/test/java/net/md_5/bungee/NativeZlibTest.java

@@ -15,7 +15,7 @@ import org.junit.Test;
 public class NativeZlibTest
 {
 
-    private final NativeCode<BungeeZlib> factory = new NativeCode<>( "native-compress", JavaZlib::new, NativeZlib::new );
+    private final NativeCode<BungeeZlib> factory = new NativeCode<>( "native-compress", JavaZlib.class, NativeZlib.class );
 
     @Test
     public void doTest() throws DataFormatException

pom.xml

@@ -5,7 +5,7 @@
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-parent</artifactId>
-    <version>1.19-R0.1-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>pom</packaging>
 
     <name>BungeeCord-Parent</name>
@@ -41,7 +41,6 @@
         <module>protocol</module>
         <module>proxy</module>
         <module>query</module>
-        <module>slf4j</module>
         <module>native</module>
     </modules>
 
@@ -72,8 +71,7 @@
 
     <properties>
         <build.number>unknown</build.number>
-        <lombok.version>1.18.22</lombok.version>
-        <netty.version>4.1.77.Final</netty.version>
+        <netty.version>4.1.53.Final</netty.version>
         <maven.compiler.source>1.8</maven.compiler.source>
         <maven.compiler.target>1.8</maven.compiler.target>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
@@ -83,13 +81,13 @@
         <dependency>
             <groupId>junit</groupId>
             <artifactId>junit</artifactId>
-            <version>4.13.2</version>
+            <version>4.13.1</version>
             <scope>test</scope>
         </dependency>
         <dependency>
             <groupId>com.google.guava</groupId>
             <artifactId>guava</artifactId>
-            <version>31.0.1-jre</version>
+            <version>21.0</version>
             <scope>compile</scope>
         </dependency>
         <dependency>
@@ -101,7 +99,7 @@
         <dependency>
             <groupId>org.projectlombok</groupId>
             <artifactId>lombok</artifactId>
-            <version>${lombok.version}</version>
+            <version>1.18.10</version>
             <scope>provided</scope>
         </dependency>
     </dependencies>
@@ -124,15 +122,10 @@
                     </execution>
                 </executions>
             </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-compiler-plugin</artifactId>
-                <version>3.8.1</version>
-            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
-                <version>3.1.2</version>
+                <version>3.1.1</version>
                 <executions>
                     <execution>
                         <phase>process-classes</phase>
@@ -150,14 +143,14 @@
                     <dependency>
                         <groupId>com.puppycrawl.tools</groupId>
                         <artifactId>checkstyle</artifactId>
-                        <version>8.45.1</version>
+                        <version>8.36.2</version>
                     </dependency>
                 </dependencies>
             </plugin>
             <plugin>
                 <groupId>org.codehaus.mojo</groupId>
                 <artifactId>animal-sniffer-maven-plugin</artifactId>
-                <version>1.20</version>
+                <version>1.19</version>
                 <executions>
                     <execution>
                         <phase>process-classes</phase>
@@ -178,53 +171,6 @@
     </build>
 
     <profiles>
-        <profile>
-            <id>jdk-9-release</id>
-            <activation>
-                <jdk>[9,)</jdk>
-            </activation>
-            <properties>
-                <maven.compiler.release>8</maven.compiler.release>
-            </properties>
-        </profile>
-        <profile>
-            <id>jdk-9-javadoc</id>
-            <activation>
-                <jdk>[9,)</jdk>
-            </activation>
-            <build>
-                <pluginManagement>
-                    <plugins>
-                        <plugin>
-                            <groupId>org.apache.maven.plugins</groupId>
-                            <artifactId>maven-javadoc-plugin</artifactId>
-                            <configuration>
-                                <additionalOptions>-html5</additionalOptions>
-                            </configuration>
-                        </plugin>
-                    </plugins>
-                </pluginManagement>
-            </build>
-        </profile>
-        <profile>
-            <id>jdk-15-javadoc</id>
-            <activation>
-                <jdk>[15,)</jdk>
-            </activation>
-            <build>
-                <pluginManagement>
-                    <plugins>
-                        <plugin>
-                            <groupId>org.apache.maven.plugins</groupId>
-                            <artifactId>maven-javadoc-plugin</artifactId>
-                            <configuration>
-                                <doclint>none</doclint>
-                            </configuration>
-                        </plugin>
-                    </plugins>
-                </pluginManagement>
-            </build>
-        </profile>
         <profile>
             <id>dist</id>
             <build>
@@ -245,7 +191,7 @@
                     <plugin>
                         <groupId>org.projectlombok</groupId>
                         <artifactId>lombok-maven-plugin</artifactId>
-                        <version>1.18.20.0</version>
+                        <version>1.18.10.0</version>
                         <executions>
                             <execution>
                                 <phase>package</phase>
@@ -259,13 +205,6 @@
                             <outputDirectory>${project.build.directory}/delombok</outputDirectory>
                             <sourceDirectory>${project.build.sourceDirectory}</sourceDirectory>
                         </configuration>
-                        <dependencies>
-                            <dependency>
-                                <groupId>org.projectlombok</groupId>
-                                <artifactId>lombok</artifactId>
-                                <version>${lombok.version}</version>
-                            </dependency>
-                        </dependencies>
                     </plugin>
                     <plugin>
                         <groupId>org.apache.maven.plugins</groupId>

protocol/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-parent</artifactId>
-        <version>1.19-R0.1-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-protocol</artifactId>
-    <version>1.19-R0.1-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>BungeeCord-Protocol</name>

protocol/src/main/java/net/md_5/bungee/protocol/AbstractPacketHandler.java

@@ -2,9 +2,6 @@ package net.md_5.bungee.protocol;
 
 import net.md_5.bungee.protocol.packet.BossBar;
 import net.md_5.bungee.protocol.packet.Chat;
-import net.md_5.bungee.protocol.packet.ClearTitles;
-import net.md_5.bungee.protocol.packet.ClientChat;
-import net.md_5.bungee.protocol.packet.ClientCommand;
 import net.md_5.bungee.protocol.packet.ClientSettings;
 import net.md_5.bungee.protocol.packet.ClientStatus;
 import net.md_5.bungee.protocol.packet.Commands;
@@ -33,13 +30,10 @@ import net.md_5.bungee.protocol.packet.ScoreboardScore;
 import net.md_5.bungee.protocol.packet.SetCompression;
 import net.md_5.bungee.protocol.packet.StatusRequest;
 import net.md_5.bungee.protocol.packet.StatusResponse;
-import net.md_5.bungee.protocol.packet.Subtitle;
-import net.md_5.bungee.protocol.packet.SystemChat;
 import net.md_5.bungee.protocol.packet.TabCompleteRequest;
 import net.md_5.bungee.protocol.packet.TabCompleteResponse;
 import net.md_5.bungee.protocol.packet.Team;
 import net.md_5.bungee.protocol.packet.Title;
-import net.md_5.bungee.protocol.packet.TitleTimes;
 import net.md_5.bungee.protocol.packet.ViewDistance;
 
 public abstract class AbstractPacketHandler
@@ -81,18 +75,6 @@ public abstract class AbstractPacketHandler
     {
     }
 
-    public void handle(ClientChat chat) throws Exception
-    {
-    }
-
-    public void handle(SystemChat chat) throws Exception
-    {
-    }
-
-    public void handle(ClientCommand command) throws Exception
-    {
-    }
-
     public void handle(Respawn respawn) throws Exception
     {
     }
@@ -145,18 +127,6 @@ public abstract class AbstractPacketHandler
     {
     }
 
-    public void handle(Subtitle title) throws Exception
-    {
-    }
-
-    public void handle(TitleTimes title) throws Exception
-    {
-    }
-
-    public void handle(ClearTitles title) throws Exception
-    {
-    }
-
     public void handle(PluginMessage pluginMessage) throws Exception
     {
     }

protocol/src/main/java/net/md_5/bungee/protocol/ChatChain.java

@@ -1,82 +0,0 @@
-package net.md_5.bungee.protocol;
-
-import com.google.common.base.Preconditions;
-import io.netty.buffer.ByteBuf;
-import java.util.LinkedList;
-import java.util.List;
-import java.util.UUID;
-import lombok.AllArgsConstructor;
-import lombok.Data;
-import lombok.EqualsAndHashCode;
-import lombok.NoArgsConstructor;
-
-@Data
-@NoArgsConstructor
-@AllArgsConstructor
-@EqualsAndHashCode(callSuper = false)
-public class ChatChain extends DefinedPacket
-{
-
-    private List<ChainLink> seen;
-    private List<ChainLink> received;
-
-    @Override
-    public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        seen = readLinks( buf );
-        if ( buf.readBoolean() )
-        {
-            received = readLinks( buf );
-        }
-    }
-
-    private static List<ChainLink> readLinks(ByteBuf buf)
-    {
-        int cnt = readVarInt( buf );
-        Preconditions.checkArgument( cnt <= 5, "Too many entries" );
-        List<ChainLink> chain = new LinkedList<>();
-        for ( int i = 0; i < cnt; i++ )
-        {
-            chain.add( new ChainLink( readUUID( buf ), readArray( buf ) ) );
-        }
-        return chain;
-    }
-
-    @Override
-    public void write(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        writeLinks( seen, buf );
-        if ( received != null )
-        {
-            buf.writeBoolean( true );
-            writeLinks( received, buf );
-        } else
-        {
-            buf.writeBoolean( false );
-        }
-    }
-
-    private static void writeLinks(List<ChainLink> links, ByteBuf buf)
-    {
-        writeVarInt( links.size(), buf );
-        for ( ChainLink link : links )
-        {
-            writeUUID( link.sender, buf );
-            writeArray( link.signature, buf );
-        }
-    }
-
-    @Override
-    public void handle(AbstractPacketHandler handler) throws Exception
-    {
-        throw new UnsupportedOperationException( "Not supported." );
-    }
-
-    @Data
-    public static class ChainLink
-    {
-
-        private final UUID sender;
-        private final byte[] signature;
-    }
-}

protocol/src/main/java/net/md_5/bungee/protocol/DefinedPacket.java

@@ -23,7 +23,7 @@ public abstract class DefinedPacket
     {
         if ( s.length() > Short.MAX_VALUE )
         {
-            throw new OverflowPacketException( "Cannot send string longer than Short.MAX_VALUE (got " + s.length() + " characters)" );
+            throw new OverflowPacketException( String.format( "Cannot send string longer than Short.MAX_VALUE (got %s characters)", s.length() ) );
         }
 
         byte[] b = s.getBytes( Charsets.UTF_8 );
@@ -32,35 +32,24 @@ public abstract class DefinedPacket
     }
 
     public static String readString(ByteBuf buf)
-    {
-        return readString( buf, Short.MAX_VALUE );
-    }
-
-    public static String readString(ByteBuf buf, int maxLen)
     {
         int len = readVarInt( buf );
-        if ( len > maxLen * 4 )
+        if ( len > Short.MAX_VALUE )
         {
-            throw new OverflowPacketException( "Cannot receive string longer than " + maxLen * 4 + " (got " + len + " bytes)" );
+            throw new OverflowPacketException( String.format( "Cannot receive string longer than Short.MAX_VALUE (got %s characters)", len ) );
         }
 
         byte[] b = new byte[ len ];
         buf.readBytes( b );
 
-        String s = new String( b, Charsets.UTF_8 );
-        if ( s.length() > maxLen )
-        {
-            throw new OverflowPacketException( "Cannot receive string longer than " + maxLen + " (got " + s.length() + " characters)" );
-        }
-
-        return s;
+        return new String( b, Charsets.UTF_8 );
     }
 
     public static void writeArray(byte[] b, ByteBuf buf)
     {
         if ( b.length > Short.MAX_VALUE )
         {
-            throw new OverflowPacketException( "Cannot send byte array longer than Short.MAX_VALUE (got " + b.length + " bytes)" );
+            throw new OverflowPacketException( String.format( "Cannot send byte array longer than Short.MAX_VALUE (got %s bytes)", b.length ) );
         }
         writeVarInt( b.length, buf );
         buf.writeBytes( b );
@@ -84,7 +73,7 @@ public abstract class DefinedPacket
         int len = readVarInt( buf );
         if ( len > limit )
         {
-            throw new OverflowPacketException( "Cannot receive byte array longer than " + limit + " (got " + len + " bytes)" );
+            throw new OverflowPacketException( String.format( "Cannot receive byte array longer than %s (got %s bytes)", limit, len ) );
         }
         byte[] ret = new byte[ len ];
         buf.readBytes( ret );
@@ -214,73 +203,6 @@ public abstract class DefinedPacket
         return new UUID( input.readLong(), input.readLong() );
     }
 
-    public static void writeProperties(Property[] properties, ByteBuf buf)
-    {
-        if ( properties == null )
-        {
-            writeVarInt( 0, buf );
-            return;
-        }
-
-        writeVarInt( properties.length, buf );
-        for ( Property prop : properties )
-        {
-            writeString( prop.getName(), buf );
-            writeString( prop.getValue(), buf );
-            if ( prop.getSignature() != null )
-            {
-                buf.writeBoolean( true );
-                writeString( prop.getSignature(), buf );
-            } else
-            {
-                buf.writeBoolean( false );
-            }
-        }
-    }
-
-    public static Property[] readProperties(ByteBuf buf)
-    {
-        Property[] properties = new Property[ DefinedPacket.readVarInt( buf ) ];
-        for ( int j = 0; j < properties.length; j++ )
-        {
-            String name = readString( buf );
-            String value = readString( buf );
-            if ( buf.readBoolean() )
-            {
-                properties[j] = new Property( name, value, DefinedPacket.readString( buf ) );
-            } else
-            {
-                properties[j] = new Property( name, value );
-            }
-        }
-
-        return properties;
-    }
-
-    public static void writePublicKey(PlayerPublicKey publicKey, ByteBuf buf)
-    {
-        if ( publicKey != null )
-        {
-            buf.writeBoolean( true );
-            buf.writeLong( publicKey.getExpiry() );
-            writeArray( publicKey.getKey(), buf );
-            writeArray( publicKey.getSignature(), buf );
-        } else
-        {
-            buf.writeBoolean( false );
-        }
-    }
-
-    public static PlayerPublicKey readPublicKey(ByteBuf buf)
-    {
-        if ( buf.readBoolean() )
-        {
-            return new PlayerPublicKey( buf.readLong(), readArray( buf ), readArray( buf ) );
-        }
-
-        return null;
-    }
-
     public static Tag readTag(ByteBuf input)
     {
         Tag tag = NamedTag.read( new DataInputStream( new ByteBufInputStream( input ) ) );

protocol/src/main/java/net/md_5/bungee/protocol/Location.java

@@ -1,11 +0,0 @@
-package net.md_5.bungee.protocol;
-
-import lombok.Data;
-
-@Data
-public class Location
-{
-
-    private final String dimension;
-    private final long pos;
-}

protocol/src/main/java/net/md_5/bungee/protocol/MinecraftDecoder.java

@@ -41,7 +41,7 @@ public class MinecraftDecoder extends MessageToMessageDecoder<ByteBuf>
 
                 if ( in.isReadable() )
                 {
-                    throw new BadPacketException( "Packet " + protocol + ":" + prot.getDirection() + "/" + packetId + " (" + packet.getClass().getSimpleName() + ") larger than expected, extra bytes: " + in.readableBytes() );
+                    throw new BadPacketException( "Did not read all bytes from packet " + packet.getClass() + " " + packetId + " Protocol " + protocol + " Direction " + prot.getDirection() );
                 }
             } else
             {

protocol/src/main/java/net/md_5/bungee/protocol/PlayerPublicKey.java

@@ -1,12 +0,0 @@
-package net.md_5.bungee.protocol;
-
-import lombok.Data;
-
-@Data
-public class PlayerPublicKey
-{
-
-    private final long expiry;
-    private final byte[] key;
-    private final byte[] signature;
-}

protocol/src/main/java/net/md_5/bungee/protocol/Property.java

@@ -1,19 +0,0 @@
-package net.md_5.bungee.protocol;
-
-import lombok.AllArgsConstructor;
-import lombok.Data;
-
-@Data
-@AllArgsConstructor
-public class Property
-{
-
-    private String name;
-    private String value;
-    private String signature;
-
-    public Property(String name, String value)
-    {
-        this( name, value, null );
-    }
-}

protocol/src/main/java/net/md_5/bungee/protocol/Protocol.java

@@ -6,14 +6,11 @@ import gnu.trove.map.TIntObjectMap;
 import gnu.trove.map.TObjectIntMap;
 import gnu.trove.map.hash.TIntObjectHashMap;
 import gnu.trove.map.hash.TObjectIntHashMap;
-import java.util.function.Supplier;
+import java.lang.reflect.Constructor;
 import lombok.Data;
 import lombok.Getter;
 import net.md_5.bungee.protocol.packet.BossBar;
 import net.md_5.bungee.protocol.packet.Chat;
-import net.md_5.bungee.protocol.packet.ClearTitles;
-import net.md_5.bungee.protocol.packet.ClientChat;
-import net.md_5.bungee.protocol.packet.ClientCommand;
 import net.md_5.bungee.protocol.packet.ClientSettings;
 import net.md_5.bungee.protocol.packet.Commands;
 import net.md_5.bungee.protocol.packet.EncryptionRequest;
@@ -39,13 +36,10 @@ import net.md_5.bungee.protocol.packet.ScoreboardScore;
 import net.md_5.bungee.protocol.packet.SetCompression;
 import net.md_5.bungee.protocol.packet.StatusRequest;
 import net.md_5.bungee.protocol.packet.StatusResponse;
-import net.md_5.bungee.protocol.packet.Subtitle;
-import net.md_5.bungee.protocol.packet.SystemChat;
 import net.md_5.bungee.protocol.packet.TabCompleteRequest;
 import net.md_5.bungee.protocol.packet.TabCompleteResponse;
 import net.md_5.bungee.protocol.packet.Team;
 import net.md_5.bungee.protocol.packet.Title;
-import net.md_5.bungee.protocol.packet.TitleTimes;
 import net.md_5.bungee.protocol.packet.ViewDistance;
 
 public enum Protocol
@@ -58,7 +52,6 @@ public enum Protocol
         {
             TO_SERVER.registerPacket(
                     Handshake.class,
-                    Handshake::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x00 )
             );
         }
@@ -70,44 +63,33 @@ public enum Protocol
         {
             TO_CLIENT.registerPacket(
                     KeepAlive.class,
-                    KeepAlive::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x00 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x1F ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x21 ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x20 ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x21 ),
                     map( ProtocolConstants.MINECRAFT_1_16, 0x20 ),
-                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x1F ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x21 ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x1E ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x20 )
+                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x1F )
             );
             TO_CLIENT.registerPacket(
                     Login.class,
-                    Login::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x01 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x23 ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x25 ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x26 ),
                     map( ProtocolConstants.MINECRAFT_1_16, 0x25 ),
-                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x24 ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x26 ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x23 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x25 )
+                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x24 )
             );
-            TO_CLIENT.registerPacket( Chat.class,
-                    Chat::new,
+            TO_CLIENT.registerPacket(
+                    Chat.class,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x02 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x0F ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x0E ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x0F ),
-                    map( ProtocolConstants.MINECRAFT_1_16, 0x0E ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x0F ),
-                    map( ProtocolConstants.MINECRAFT_1_19, -1 )
+                    map( ProtocolConstants.MINECRAFT_1_16, 0x0E )
             );
             TO_CLIENT.registerPacket(
                     Respawn.class,
-                    Respawn::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x07 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x33 ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x34 ),
@@ -116,23 +98,16 @@ public enum Protocol
                     map( ProtocolConstants.MINECRAFT_1_14, 0x3A ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x3B ),
                     map( ProtocolConstants.MINECRAFT_1_16, 0x3A ),
-                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x39 ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x3D ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x3B ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x3E )
+                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x39 )
             );
             TO_CLIENT.registerPacket(
                     BossBar.class,
-                    BossBar::new,
                     map( ProtocolConstants.MINECRAFT_1_9, 0x0C ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x0D ),
-                    map( ProtocolConstants.MINECRAFT_1_16, 0x0C ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x0D ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x0A )
+                    map( ProtocolConstants.MINECRAFT_1_16, 0x0C )
             );
             TO_CLIENT.registerPacket(
                     PlayerListItem.class, // PlayerInfo
-                    PlayerListItem::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x38 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x2D ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x2E ),
@@ -140,146 +115,89 @@ public enum Protocol
                     map( ProtocolConstants.MINECRAFT_1_14, 0x33 ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x34 ),
                     map( ProtocolConstants.MINECRAFT_1_16, 0x33 ),
-                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x32 ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x36 ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x34 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x37 )
+                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x32 )
             );
             TO_CLIENT.registerPacket(
                     TabCompleteResponse.class,
-                    TabCompleteResponse::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x3A ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x0E ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x10 ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x11 ),
                     map( ProtocolConstants.MINECRAFT_1_16, 0x10 ),
-                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x0F ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x11 ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x0E )
+                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x0F )
             );
             TO_CLIENT.registerPacket(
                     ScoreboardObjective.class,
-                    ScoreboardObjective::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x3B ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x3F ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x41 ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x42 ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x45 ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x49 ),
-                    map( ProtocolConstants.MINECRAFT_1_15, 0x4A ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x53 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x56 )
+                    map( ProtocolConstants.MINECRAFT_1_15, 0x4A )
             );
             TO_CLIENT.registerPacket(
                     ScoreboardScore.class,
-                    ScoreboardScore::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x3C ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x42 ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x44 ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x45 ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x48 ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x4C ),
-                    map( ProtocolConstants.MINECRAFT_1_15, 0x4D ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x56 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x59 )
+                    map( ProtocolConstants.MINECRAFT_1_15, 0x4D )
             );
             TO_CLIENT.registerPacket(
                     ScoreboardDisplay.class,
-                    ScoreboardDisplay::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x3D ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x38 ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x3A ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x3B ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x3E ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x42 ),
-                    map( ProtocolConstants.MINECRAFT_1_15, 0x43 ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x4C ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x4F )
+                    map( ProtocolConstants.MINECRAFT_1_15, 0x43 )
             );
             TO_CLIENT.registerPacket(
                     Team.class,
-                    Team::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x3E ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x41 ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x43 ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x44 ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x47 ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x4B ),
-                    map( ProtocolConstants.MINECRAFT_1_15, 0x4C ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x55 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x58 )
+                    map( ProtocolConstants.MINECRAFT_1_15, 0x4C )
             );
             TO_CLIENT.registerPacket(
                     PluginMessage.class,
-                    PluginMessage::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x3F ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x18 ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x19 ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x18 ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x19 ),
                     map( ProtocolConstants.MINECRAFT_1_16, 0x18 ),
-                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x17 ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x18 ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x15 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x16 )
+                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x17 )
             );
             TO_CLIENT.registerPacket(
                     Kick.class,
-                    Kick::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x40 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x1A ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x1B ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x1A ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x1B ),
                     map( ProtocolConstants.MINECRAFT_1_16, 0x1A ),
-                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x19 ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x1A ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x17 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x19 )
+                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x19 )
             );
             TO_CLIENT.registerPacket(
                     Title.class,
-                    Title::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x45 ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x47 ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x48 ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x4B ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x4F ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x50 ),
-                    map( ProtocolConstants.MINECRAFT_1_16, 0x4F ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x59 ),
-                    map( ProtocolConstants.MINECRAFT_1_18, 0x5A ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x5D )
-            );
-            TO_CLIENT.registerPacket(
-                    ClearTitles.class,
-                    ClearTitles::new,
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x10 ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x0D )
-            );
-            TO_CLIENT.registerPacket(
-                    Subtitle.class,
-                    Subtitle::new,
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x57 ),
-                    map( ProtocolConstants.MINECRAFT_1_18, 0x58 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x5B )
-            );
-            TO_CLIENT.registerPacket(
-                    TitleTimes.class,
-                    TitleTimes::new,
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x5A ),
-                    map( ProtocolConstants.MINECRAFT_1_18, 0x5B ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x5E )
-            );
-            TO_CLIENT.registerPacket(
-                    SystemChat.class,
-                    SystemChat::new,
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x5F ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x62 )
+                    map( ProtocolConstants.MINECRAFT_1_16, 0x4F )
             );
             TO_CLIENT.registerPacket(
                     PlayerListHeaderFooter.class,
-                    PlayerListHeaderFooter::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x47 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x48 ),
                     map( ProtocolConstants.MINECRAFT_1_9_4, 0x47 ),
@@ -288,127 +206,81 @@ public enum Protocol
                     map( ProtocolConstants.MINECRAFT_1_13, 0x4E ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x53 ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x54 ),
-                    map( ProtocolConstants.MINECRAFT_1_16, 0x53 ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x5E ),
-                    map( ProtocolConstants.MINECRAFT_1_18, 0x5F ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x60 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x63 )
+                    map( ProtocolConstants.MINECRAFT_1_16, 0x53 )
             );
             TO_CLIENT.registerPacket(
                     EntityStatus.class,
-                    EntityStatus::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x1A ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x1B ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x1C ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x1B ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x1C ),
                     map( ProtocolConstants.MINECRAFT_1_16, 0x1B ),
-                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x1A ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x1B ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x18 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x1A )
+                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x1A )
             );
             TO_CLIENT.registerPacket(
                     Commands.class,
-                    Commands::new,
                     map( ProtocolConstants.MINECRAFT_1_13, 0x11 ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x12 ),
                     map( ProtocolConstants.MINECRAFT_1_16, 0x11 ),
-                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x10 ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x12 ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x0F )
+                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x10 )
             );
             TO_CLIENT.registerPacket(
                     GameState.class,
-                    GameState::new,
                     map( ProtocolConstants.MINECRAFT_1_15, 0x1F ),
                     map( ProtocolConstants.MINECRAFT_1_16, 0x1E ),
-                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x1D ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x1E ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x1B ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x1D )
+                    map( ProtocolConstants.MINECRAFT_1_16_2, 0x1D )
             );
             TO_CLIENT.registerPacket(
                     ViewDistance.class,
-                    ViewDistance::new,
                     map( ProtocolConstants.MINECRAFT_1_14, 0x41 ),
                     map( ProtocolConstants.MINECRAFT_1_15, 0x42 ),
-                    map( ProtocolConstants.MINECRAFT_1_16, 0x41 ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x4A ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x49 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x4C )
+                    map( ProtocolConstants.MINECRAFT_1_16, 0x41 )
             );
 
             TO_SERVER.registerPacket(
                     KeepAlive.class,
-                    KeepAlive::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x00 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x0B ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x0C ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x0B ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x0E ),
                     map( ProtocolConstants.MINECRAFT_1_14, 0x0F ),
-                    map( ProtocolConstants.MINECRAFT_1_16, 0x10 ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x0F ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x11 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x12 )
+                    map( ProtocolConstants.MINECRAFT_1_16, 0x10 )
             );
-            TO_SERVER.registerPacket( Chat.class,
-                    Chat::new,
+            TO_SERVER.registerPacket(
+                    Chat.class,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x01 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x02 ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x03 ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x02 ),
-                    map( ProtocolConstants.MINECRAFT_1_14, 0x03 ),
-                    map( ProtocolConstants.MINECRAFT_1_19, -1 )
-            );
-            TO_SERVER.registerPacket(
-                    ClientCommand.class,
-                    ClientCommand::new,
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x03 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x04 )
-            );
-            TO_SERVER.registerPacket(
-                    ClientChat.class,
-                    ClientChat::new,
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x04 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x05 )
+                    map( ProtocolConstants.MINECRAFT_1_14, 0x03 )
             );
             TO_SERVER.registerPacket(
                     TabCompleteRequest.class,
-                    TabCompleteRequest::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x14 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x01 ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x02 ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x01 ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x05 ),
-                    map( ProtocolConstants.MINECRAFT_1_14, 0x06 ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x08 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x09 )
+                    map( ProtocolConstants.MINECRAFT_1_14, 0x06 )
             );
             TO_SERVER.registerPacket(
                     ClientSettings.class,
-                    ClientSettings::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x15 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x04 ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x05 ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x04 ),
-                    map( ProtocolConstants.MINECRAFT_1_14, 0x05 ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x07 ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x08 )
+                    map( ProtocolConstants.MINECRAFT_1_14, 0x05 )
             );
             TO_SERVER.registerPacket(
                     PluginMessage.class,
-                    PluginMessage::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x17 ),
                     map( ProtocolConstants.MINECRAFT_1_9, 0x09 ),
                     map( ProtocolConstants.MINECRAFT_1_12, 0x0A ),
                     map( ProtocolConstants.MINECRAFT_1_12_1, 0x09 ),
                     map( ProtocolConstants.MINECRAFT_1_13, 0x0A ),
-                    map( ProtocolConstants.MINECRAFT_1_14, 0x0B ),
-                    map( ProtocolConstants.MINECRAFT_1_17, 0x0A ),
-                    map( ProtocolConstants.MINECRAFT_1_19, 0x0C ),
-                    map( ProtocolConstants.MINECRAFT_1_19_1, 0x0D )
+                    map( ProtocolConstants.MINECRAFT_1_14, 0x0B )
             );
         }
     },
@@ -419,23 +291,19 @@ public enum Protocol
         {
             TO_CLIENT.registerPacket(
                     StatusResponse.class,
-                    StatusResponse::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x00 )
             );
             TO_CLIENT.registerPacket(
                     PingPacket.class,
-                    PingPacket::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x01 )
             );
 
             TO_SERVER.registerPacket(
                     StatusRequest.class,
-                    StatusRequest::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x00 )
             );
             TO_SERVER.registerPacket(
                     PingPacket.class,
-                    PingPacket::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x01 )
             );
         }
@@ -447,43 +315,35 @@ public enum Protocol
         {
             TO_CLIENT.registerPacket(
                     Kick.class,
-                    Kick::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x00 )
             );
             TO_CLIENT.registerPacket(
                     EncryptionRequest.class,
-                    EncryptionRequest::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x01 )
             );
             TO_CLIENT.registerPacket(
                     LoginSuccess.class,
-                    LoginSuccess::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x02 )
             );
             TO_CLIENT.registerPacket(
                     SetCompression.class,
-                    SetCompression::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x03 )
             );
             TO_CLIENT.registerPacket(
                     LoginPayloadRequest.class,
-                    LoginPayloadRequest::new,
                     map( ProtocolConstants.MINECRAFT_1_13, 0x04 )
             );
 
             TO_SERVER.registerPacket(
                     LoginRequest.class,
-                    LoginRequest::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x00 )
             );
             TO_SERVER.registerPacket(
                     EncryptionResponse.class,
-                    EncryptionResponse::new,
                     map( ProtocolConstants.MINECRAFT_1_8, 0x01 )
             );
             TO_SERVER.registerPacket(
                     LoginPayloadResponse.class,
-                    LoginPayloadResponse::new,
                     map( ProtocolConstants.MINECRAFT_1_13, 0x02 )
             );
         }
@@ -534,8 +394,7 @@ public enum Protocol
 
         private final int protocolVersion;
         private final TObjectIntMap<Class<? extends DefinedPacket>> packetMap = new TObjectIntHashMap<>( MAX_PACKET_ID );
-        @SuppressWarnings("unchecked")
-        private final Supplier<? extends DefinedPacket>[] packetConstructors = new Supplier[ MAX_PACKET_ID ];
+        private final Constructor<? extends DefinedPacket>[] packetConstructors = new Constructor[ MAX_PACKET_ID ];
     }
 
     @Data
@@ -589,49 +448,57 @@ public enum Protocol
             {
                 throw new BadPacketException( "Unsupported protocol version " + version );
             }
-            if ( id > MAX_PACKET_ID || id < 0 )
+            if ( id > MAX_PACKET_ID )
             {
-                throw new BadPacketException( "Packet with id " + id + " outside of range" );
+                throw new BadPacketException( "Packet with id " + id + " outside of range " );
             }
 
-            Supplier<? extends DefinedPacket> constructor = protocolData.packetConstructors[id];
-            return ( constructor == null ) ? null : constructor.get();
+            Constructor<? extends DefinedPacket> constructor = protocolData.packetConstructors[id];
+            try
+            {
+                return ( constructor == null ) ? null : constructor.newInstance();
+            } catch ( ReflectiveOperationException ex )
+            {
+                throw new BadPacketException( "Could not construct packet with id " + id, ex );
+            }
         }
 
-        private void registerPacket(Class<? extends DefinedPacket> packetClass, Supplier<? extends DefinedPacket> constructor, ProtocolMapping... mappings)
+        private void registerPacket(Class<? extends DefinedPacket> packetClass, ProtocolMapping... mappings)
         {
-            int mappingIndex = 0;
-            ProtocolMapping mapping = mappings[mappingIndex];
-            for ( int protocol : ProtocolConstants.SUPPORTED_VERSION_IDS )
+            try
             {
-                if ( protocol < mapping.protocolVersion )
-                {
-                    // This is a new packet, skip it till we reach the next protocol
-                    continue;
-                }
+                Constructor<? extends DefinedPacket> constructor = packetClass.getDeclaredConstructor();
 
-                if ( mapping.protocolVersion < protocol && mappingIndex + 1 < mappings.length )
+                int mappingIndex = 0;
+                ProtocolMapping mapping = mappings[mappingIndex];
+                for ( int protocol : ProtocolConstants.SUPPORTED_VERSION_IDS )
                 {
-                    // Mapping is non current, but the next one may be ok
-                    ProtocolMapping nextMapping = mappings[mappingIndex + 1];
-
-                    if ( nextMapping.protocolVersion == protocol )
+                    if ( protocol < mapping.protocolVersion )
                     {
-                        Preconditions.checkState( nextMapping.packetID != mapping.packetID, "Duplicate packet mapping (%s, %s)", mapping.protocolVersion, nextMapping.protocolVersion );
-
-                        mapping = nextMapping;
-                        mappingIndex++;
+                        // This is a new packet, skip it till we reach the next protocol
+                        continue;
                     }
-                }
 
-                if ( mapping.packetID < 0 )
-                {
-                    break;
-                }
+                    if ( mapping.protocolVersion < protocol && mappingIndex + 1 < mappings.length )
+                    {
+                        // Mapping is non current, but the next one may be ok
+                        ProtocolMapping nextMapping = mappings[mappingIndex + 1];
+                        if ( nextMapping.protocolVersion == protocol )
+                        {
+                            Preconditions.checkState( nextMapping.packetID != mapping.packetID, "Duplicate packet mapping (%s, %s)", mapping.protocolVersion, nextMapping.protocolVersion );
 
-                ProtocolData data = protocols.get( protocol );
-                data.packetMap.put( packetClass, mapping.packetID );
-                data.packetConstructors[mapping.packetID] = constructor;
+                            mapping = nextMapping;
+                            mappingIndex++;
+                        }
+                    }
+
+                    ProtocolData data = protocols.get( protocol );
+                    data.packetMap.put( packetClass, mapping.packetID );
+                    data.packetConstructors[mapping.packetID] = constructor;
+                }
+            } catch ( NoSuchMethodException ex )
+            {
+                throw new BadPacketException( "No NoArgsConstructor for packet class " + packetClass );
             }
         }
 

protocol/src/main/java/net/md_5/bungee/protocol/ProtocolConstants.java

@@ -1,12 +1,11 @@
 package net.md_5.bungee.protocol;
 
-import com.google.common.collect.ImmutableList;
+import java.util.Arrays;
 import java.util.List;
 
 public class ProtocolConstants
 {
 
-    private static final boolean SNAPSHOT_SUPPORT = Boolean.getBoolean( "net.md_5.bungee.protocol.snapshot" );
     public static final int MINECRAFT_1_8 = 47;
     public static final int MINECRAFT_1_9 = 107;
     public static final int MINECRAFT_1_9_1 = 108;
@@ -34,76 +33,46 @@ public class ProtocolConstants
     public static final int MINECRAFT_1_16_2 = 751;
     public static final int MINECRAFT_1_16_3 = 753;
     public static final int MINECRAFT_1_16_4 = 754;
-    public static final int MINECRAFT_1_17 = 755;
-    public static final int MINECRAFT_1_17_1 = 756;
-    public static final int MINECRAFT_1_18 = 757;
-    public static final int MINECRAFT_1_18_2 = 758;
-    public static final int MINECRAFT_1_19 = 759;
-    public static final int MINECRAFT_1_19_1 = 760;
-    public static final List<String> SUPPORTED_VERSIONS;
-    public static final List<Integer> SUPPORTED_VERSION_IDS;
-
-    static
-    {
-        ImmutableList.Builder<String> supportedVersions = ImmutableList.<String>builder().add(
-                "1.8.x",
-                "1.9.x",
-                "1.10.x",
-                "1.11.x",
-                "1.12.x",
-                "1.13.x",
-                "1.14.x",
-                "1.15.x",
-                "1.16.x",
-                "1.17.x",
-                "1.18.x",
-                "1.19.x"
-        );
-        ImmutableList.Builder<Integer> supportedVersionIds = ImmutableList.<Integer>builder().add(
-                ProtocolConstants.MINECRAFT_1_8,
-                ProtocolConstants.MINECRAFT_1_9,
-                ProtocolConstants.MINECRAFT_1_9_1,
-                ProtocolConstants.MINECRAFT_1_9_2,
-                ProtocolConstants.MINECRAFT_1_9_4,
-                ProtocolConstants.MINECRAFT_1_10,
-                ProtocolConstants.MINECRAFT_1_11,
-                ProtocolConstants.MINECRAFT_1_11_1,
-                ProtocolConstants.MINECRAFT_1_12,
-                ProtocolConstants.MINECRAFT_1_12_1,
-                ProtocolConstants.MINECRAFT_1_12_2,
-                ProtocolConstants.MINECRAFT_1_13,
-                ProtocolConstants.MINECRAFT_1_13_1,
-                ProtocolConstants.MINECRAFT_1_13_2,
-                ProtocolConstants.MINECRAFT_1_14,
-                ProtocolConstants.MINECRAFT_1_14_1,
-                ProtocolConstants.MINECRAFT_1_14_2,
-                ProtocolConstants.MINECRAFT_1_14_3,
-                ProtocolConstants.MINECRAFT_1_14_4,
-                ProtocolConstants.MINECRAFT_1_15,
-                ProtocolConstants.MINECRAFT_1_15_1,
-                ProtocolConstants.MINECRAFT_1_15_2,
-                ProtocolConstants.MINECRAFT_1_16,
-                ProtocolConstants.MINECRAFT_1_16_1,
-                ProtocolConstants.MINECRAFT_1_16_2,
-                ProtocolConstants.MINECRAFT_1_16_3,
-                ProtocolConstants.MINECRAFT_1_16_4,
-                ProtocolConstants.MINECRAFT_1_17,
-                ProtocolConstants.MINECRAFT_1_17_1,
-                ProtocolConstants.MINECRAFT_1_18,
-                ProtocolConstants.MINECRAFT_1_18_2,
-                ProtocolConstants.MINECRAFT_1_19,
-                ProtocolConstants.MINECRAFT_1_19_1
-        );
-
-        if ( SNAPSHOT_SUPPORT )
-        {
-            // supportedVersions.add( "1.19.x" );
-            // supportedVersionIds.add( ProtocolConstants.MINECRAFT_1_19 );
-        }
-
-        SUPPORTED_VERSIONS = supportedVersions.build();
-        SUPPORTED_VERSION_IDS = supportedVersionIds.build();
-    }
+    public static final List<String> SUPPORTED_VERSIONS = Arrays.asList(
+            "1.8.x",
+            "1.9.x",
+            "1.10.x",
+            "1.11.x",
+            "1.12.x",
+            "1.13.x",
+            "1.14.x",
+            "1.15.x",
+            "1.16.x"
+    );
+    public static final List<Integer> SUPPORTED_VERSION_IDS = Arrays.asList(
+            ProtocolConstants.MINECRAFT_1_8,
+            ProtocolConstants.MINECRAFT_1_9,
+            ProtocolConstants.MINECRAFT_1_9_1,
+            ProtocolConstants.MINECRAFT_1_9_2,
+            ProtocolConstants.MINECRAFT_1_9_4,
+            ProtocolConstants.MINECRAFT_1_10,
+            ProtocolConstants.MINECRAFT_1_11,
+            ProtocolConstants.MINECRAFT_1_11_1,
+            ProtocolConstants.MINECRAFT_1_12,
+            ProtocolConstants.MINECRAFT_1_12_1,
+            ProtocolConstants.MINECRAFT_1_12_2,
+            ProtocolConstants.MINECRAFT_1_13,
+            ProtocolConstants.MINECRAFT_1_13_1,
+            ProtocolConstants.MINECRAFT_1_13_2,
+            ProtocolConstants.MINECRAFT_1_14,
+            ProtocolConstants.MINECRAFT_1_14_1,
+            ProtocolConstants.MINECRAFT_1_14_2,
+            ProtocolConstants.MINECRAFT_1_14_3,
+            ProtocolConstants.MINECRAFT_1_14_4,
+            ProtocolConstants.MINECRAFT_1_15,
+            ProtocolConstants.MINECRAFT_1_15_1,
+            ProtocolConstants.MINECRAFT_1_15_2,
+            ProtocolConstants.MINECRAFT_1_16,
+            ProtocolConstants.MINECRAFT_1_16_1,
+            ProtocolConstants.MINECRAFT_1_16_2,
+            ProtocolConstants.MINECRAFT_1_16_3,
+            ProtocolConstants.MINECRAFT_1_16_4
+    );
 
     public enum Direction
     {

protocol/src/main/java/net/md_5/bungee/protocol/packet/Chat.java

@@ -40,7 +40,7 @@ public class Chat extends DefinedPacket
     @Override
     public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
     {
-        message = readString( buf, ( direction == ProtocolConstants.Direction.TO_CLIENT ) ? 262144 : ( protocolVersion >= ProtocolConstants.MINECRAFT_1_11 ? 256 : 100 ) );
+        message = readString( buf );
         if ( direction == ProtocolConstants.Direction.TO_CLIENT )
         {
             position = buf.readByte();

protocol/src/main/java/net/md_5/bungee/protocol/packet/ClearTitles.java

@@ -1,38 +0,0 @@
-package net.md_5.bungee.protocol.packet;
-
-import io.netty.buffer.ByteBuf;
-import lombok.AllArgsConstructor;
-import lombok.Data;
-import lombok.EqualsAndHashCode;
-import lombok.NoArgsConstructor;
-import net.md_5.bungee.protocol.AbstractPacketHandler;
-import net.md_5.bungee.protocol.DefinedPacket;
-import net.md_5.bungee.protocol.ProtocolConstants;
-
-@Data
-@NoArgsConstructor
-@AllArgsConstructor
-@EqualsAndHashCode(callSuper = false)
-public class ClearTitles extends DefinedPacket
-{
-
-    private boolean reset;
-
-    @Override
-    public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        reset = buf.readBoolean();
-    }
-
-    @Override
-    public void write(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        buf.writeBoolean( reset );
-    }
-
-    @Override
-    public void handle(AbstractPacketHandler handler) throws Exception
-    {
-        handler.handle( this );
-    }
-}

protocol/src/main/java/net/md_5/bungee/protocol/packet/ClientChat.java

@@ -1,61 +0,0 @@
-package net.md_5.bungee.protocol.packet;
-
-import io.netty.buffer.ByteBuf;
-import lombok.AllArgsConstructor;
-import lombok.Data;
-import lombok.EqualsAndHashCode;
-import lombok.NoArgsConstructor;
-import net.md_5.bungee.protocol.AbstractPacketHandler;
-import net.md_5.bungee.protocol.ChatChain;
-import net.md_5.bungee.protocol.DefinedPacket;
-import net.md_5.bungee.protocol.ProtocolConstants;
-
-@Data
-@NoArgsConstructor
-@AllArgsConstructor
-@EqualsAndHashCode(callSuper = false)
-public class ClientChat extends DefinedPacket
-{
-
-    private String message;
-    private long timestamp;
-    private long salt;
-    private byte[] signature;
-    private boolean signedPreview;
-    private ChatChain chain;
-
-    @Override
-    public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        message = readString( buf, 256 );
-        timestamp = buf.readLong();
-        salt = buf.readLong();
-        signature = readArray( buf );
-        signedPreview = buf.readBoolean();
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19_1 )
-        {
-            chain = new ChatChain();
-            chain.read( buf, direction, protocolVersion );
-        }
-    }
-
-    @Override
-    public void write(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        writeString( message, buf );
-        buf.writeLong( timestamp );
-        buf.writeLong( salt );
-        writeArray( signature, buf );
-        buf.writeBoolean( signedPreview );
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19_1 )
-        {
-            chain.write( buf );
-        }
-    }
-
-    @Override
-    public void handle(AbstractPacketHandler handler) throws Exception
-    {
-        handler.handle( this );
-    }
-}

protocol/src/main/java/net/md_5/bungee/protocol/packet/ClientCommand.java

@@ -1,79 +0,0 @@
-package net.md_5.bungee.protocol.packet;
-
-import com.google.common.base.Preconditions;
-import io.netty.buffer.ByteBuf;
-import java.util.HashMap;
-import java.util.Map;
-import lombok.AllArgsConstructor;
-import lombok.Data;
-import lombok.EqualsAndHashCode;
-import lombok.NoArgsConstructor;
-import net.md_5.bungee.protocol.AbstractPacketHandler;
-import net.md_5.bungee.protocol.ChatChain;
-import net.md_5.bungee.protocol.DefinedPacket;
-import net.md_5.bungee.protocol.ProtocolConstants;
-
-@Data
-@NoArgsConstructor
-@AllArgsConstructor
-@EqualsAndHashCode(callSuper = false)
-public class ClientCommand extends DefinedPacket
-{
-
-    private String command;
-    private long timestamp;
-    private long salt;
-    private Map<String, byte[]> signatures;
-    private boolean signedPreview;
-    private ChatChain chain;
-
-    @Override
-    public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        command = readString( buf );
-        timestamp = buf.readLong();
-        salt = buf.readLong();
-
-        int cnt = readVarInt( buf );
-        Preconditions.checkArgument( cnt <= 8, "Too many signatures" );
-        signatures = new HashMap<>( cnt );
-        for ( int i = 0; i < cnt; i++ )
-        {
-            signatures.put( readString( buf, 16 ), readArray( buf ) );
-        }
-
-        signedPreview = buf.readBoolean();
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19_1 )
-        {
-            chain = new ChatChain();
-            chain.read( buf, direction, protocolVersion );
-        }
-    }
-
-    @Override
-    public void write(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        writeString( command, buf );
-        buf.writeLong( timestamp );
-        buf.writeLong( salt );
-
-        writeVarInt( signatures.size(), buf );
-        for ( Map.Entry<String, byte[]> entry : signatures.entrySet() )
-        {
-            writeString( entry.getKey(), buf );
-            writeArray( entry.getValue(), buf );
-        }
-
-        buf.writeBoolean( signedPreview );
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19_1 )
-        {
-            chain.write( buf );
-        }
-    }
-
-    @Override
-    public void handle(AbstractPacketHandler handler) throws Exception
-    {
-        handler.handle( this );
-    }
-}

protocol/src/main/java/net/md_5/bungee/protocol/packet/ClientSettings.java

@@ -23,13 +23,11 @@ public class ClientSettings extends DefinedPacket
     private byte difficulty;
     private byte skinParts;
     private int mainHand;
-    private boolean disableTextFiltering;
-    private boolean allowServerListing;
 
     @Override
     public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
     {
-        locale = readString( buf, 16 );
+        locale = readString( buf );
         viewDistance = buf.readByte();
         chatFlags = protocolVersion >= ProtocolConstants.MINECRAFT_1_9 ? DefinedPacket.readVarInt( buf ) : buf.readUnsignedByte();
         chatColours = buf.readBoolean();
@@ -38,14 +36,6 @@ public class ClientSettings extends DefinedPacket
         {
             mainHand = DefinedPacket.readVarInt( buf );
         }
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_17 )
-        {
-            disableTextFiltering = buf.readBoolean();
-        }
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_18 )
-        {
-            allowServerListing = buf.readBoolean();
-        }
     }
 
     @Override
@@ -66,14 +56,6 @@ public class ClientSettings extends DefinedPacket
         {
             DefinedPacket.writeVarInt( mainHand, buf );
         }
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_17 )
-        {
-            buf.writeBoolean( disableTextFiltering );
-        }
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_18 )
-        {
-            buf.writeBoolean( allowServerListing );
-        }
     }
 
     @Override

protocol/src/main/java/net/md_5/bungee/protocol/packet/Commands.java

@@ -4,6 +4,7 @@ import com.google.common.base.Preconditions;
 import com.mojang.brigadier.Command;
 import com.mojang.brigadier.StringReader;
 import com.mojang.brigadier.arguments.ArgumentType;
+import com.mojang.brigadier.arguments.BoolArgumentType;
 import com.mojang.brigadier.arguments.DoubleArgumentType;
 import com.mojang.brigadier.arguments.FloatArgumentType;
 import com.mojang.brigadier.arguments.IntegerArgumentType;
@@ -23,13 +24,11 @@ import com.mojang.brigadier.tree.LiteralCommandNode;
 import com.mojang.brigadier.tree.RootCommandNode;
 import io.netty.buffer.ByteBuf;
 import java.util.ArrayDeque;
-import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Deque;
 import java.util.HashMap;
 import java.util.Iterator;
 import java.util.LinkedHashMap;
-import java.util.List;
 import java.util.Map;
 import java.util.concurrent.CompletableFuture;
 import lombok.AllArgsConstructor;
@@ -59,7 +58,7 @@ public class Commands extends DefinedPacket
     private RootCommandNode root;
 
     @Override
-    public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
+    public void read(ByteBuf buf)
     {
         int nodeCount = readVarInt( buf );
         NetworkNode[] nodes = new NetworkNode[ nodeCount ];
@@ -82,7 +81,9 @@ public class Commands extends DefinedPacket
                     break;
                 case NODE_ARGUMENT:
                     String name = readString( buf );
-                    argumentBuilder = RequiredArgumentBuilder.argument( name, ArgumentRegistry.read( buf, protocolVersion ) );
+                    String parser = readString( buf );
+
+                    argumentBuilder = RequiredArgumentBuilder.argument( name, ArgumentRegistry.read( parser, buf ) );
 
                     if ( ( flags & FLAG_SUGGESTIONS ) != 0 )
                     {
@@ -305,12 +306,12 @@ public class Commands extends DefinedPacket
     }
 
     @Data
-    private static class ArgumentRegistry
+    public static class ArgumentRegistry
     {
 
         private static final Map<String, ArgumentSerializer> PROVIDERS = new HashMap<>();
-        private static final List<ArgumentSerializer> PROVIDER_LIST = new ArrayList<>();
         private static final Map<Class<?>, ProperArgumentSerializer<?>> PROPER_PROVIDERS = new HashMap<>();
+        private static final Map<String, ProtocolConversionProvider> CONVERSION_PROVIDERS = new HashMap<>();
         //
         private static final ArgumentSerializer<Void> VOID = new ArgumentSerializer<Void>()
         {
@@ -325,18 +326,23 @@ public class Commands extends DefinedPacket
             {
             }
         };
-        private static final ArgumentSerializer<Boolean> BOOLEAN = new ArgumentSerializer<Boolean>()
+        private static final ProperArgumentSerializer<BoolArgumentType> BOOLEAN = new ProperArgumentSerializer<BoolArgumentType>()
         {
             @Override
-            protected Boolean read(ByteBuf buf)
+            protected BoolArgumentType read(ByteBuf buf)
             {
-                return buf.readBoolean();
+                return BoolArgumentType.bool();
             }
 
             @Override
-            protected void write(ByteBuf buf, Boolean t)
+            protected void write(ByteBuf buf, BoolArgumentType t)
             {
-                buf.writeBoolean( t );
+            }
+
+            @Override
+            protected String getKey()
+            {
+                return "brigadier:bool";
             }
         };
         private static final ArgumentSerializer<Byte> BYTE = new ArgumentSerializer<Byte>()
@@ -353,7 +359,7 @@ public class Commands extends DefinedPacket
                 buf.writeByte( t );
             }
         };
-        private static final ArgumentSerializer<FloatArgumentType> FLOAT = new ArgumentSerializer<FloatArgumentType>()
+        private static final ProperArgumentSerializer<FloatArgumentType> FLOAT = new ProperArgumentSerializer<FloatArgumentType>()
         {
             @Override
             protected FloatArgumentType read(ByteBuf buf)
@@ -381,8 +387,14 @@ public class Commands extends DefinedPacket
                     buf.writeFloat( t.getMaximum() );
                 }
             }
+
+            @Override
+            protected String getKey()
+            {
+                return "brigadier:float";
+            }
         };
-        private static final ArgumentSerializer<DoubleArgumentType> DOUBLE = new ArgumentSerializer<DoubleArgumentType>()
+        private static final ProperArgumentSerializer<DoubleArgumentType> DOUBLE = new ProperArgumentSerializer<DoubleArgumentType>()
         {
             @Override
             protected DoubleArgumentType read(ByteBuf buf)
@@ -410,8 +422,14 @@ public class Commands extends DefinedPacket
                     buf.writeDouble( t.getMaximum() );
                 }
             }
+
+            @Override
+            protected String getKey()
+            {
+                return "brigadier:double";
+            }
         };
-        private static final ArgumentSerializer<IntegerArgumentType> INTEGER = new ArgumentSerializer<IntegerArgumentType>()
+        private static final ProperArgumentSerializer<IntegerArgumentType> INTEGER = new ProperArgumentSerializer<IntegerArgumentType>()
         {
             @Override
             protected IntegerArgumentType read(ByteBuf buf)
@@ -439,8 +457,14 @@ public class Commands extends DefinedPacket
                     buf.writeInt( t.getMaximum() );
                 }
             }
+
+            @Override
+            protected String getKey()
+            {
+                return "brigadier:integer";
+            }
         };
-        private static final ArgumentSerializer<LongArgumentType> LONG = new ArgumentSerializer<LongArgumentType>()
+        private static final ProperArgumentSerializer<LongArgumentType> LONG = new ProperArgumentSerializer<LongArgumentType>()
         {
             @Override
             protected LongArgumentType read(ByteBuf buf)
@@ -468,6 +492,12 @@ public class Commands extends DefinedPacket
                     buf.writeLong( t.getMaximum() );
                 }
             }
+
+            @Override
+            protected String getKey()
+            {
+                return "brigadier:long";
+            }
         };
         private static final ProperArgumentSerializer<StringArgumentType> STRING = new ProperArgumentSerializer<StringArgumentType>()
         {
@@ -494,111 +524,524 @@ public class Commands extends DefinedPacket
                 writeVarInt( t.getType().ordinal(), buf );
             }
 
-            @Override
-            protected int getIntKey()
-            {
-                return 5;
-            }
-
             @Override
             protected String getKey()
             {
                 return "brigadier:string";
             }
         };
-        private static final ArgumentSerializer<String> RAW_STRING = new ArgumentSerializer<String>()
-        {
-            @Override
-            protected String read(ByteBuf buf)
-            {
-                return DefinedPacket.readString( buf );
-            }
-
-            @Override
-            protected void write(ByteBuf buf, String t)
-            {
-                DefinedPacket.writeString( t, buf );
-            }
-        };
 
         static
         {
-            register( "brigadier:bool", VOID );
-            register( "brigadier:float", FLOAT );
-            register( "brigadier:double", DOUBLE );
-            register( "brigadier:integer", INTEGER );
-            register( "brigadier:long", LONG );
+            PROVIDERS.put( "brigadier:bool", BOOLEAN );
+            PROPER_PROVIDERS.put( BoolArgumentType.class, BOOLEAN );
 
-            register( "brigadier:string", STRING );
+            PROVIDERS.put( "brigadier:float", FLOAT );
+            PROPER_PROVIDERS.put( FloatArgumentType.class, FLOAT );
+
+            PROVIDERS.put( "brigadier:double", DOUBLE );
+            PROPER_PROVIDERS.put( DoubleArgumentType.class, DOUBLE );
+
+            PROVIDERS.put( "brigadier:integer", INTEGER );
+            PROPER_PROVIDERS.put( IntegerArgumentType.class, INTEGER );
+
+            PROVIDERS.put( "brigadier:long", LONG ); // 1.14+
+            PROPER_PROVIDERS.put( LongArgumentType.class, LONG );
+            CONVERSION_PROVIDERS.put( "brigadier:long", ( originalType, protocolVersion ) ->
+            {
+                if ( protocolVersion < ProtocolConstants.MINECRAFT_1_14 )
+                {
+                    LongArgumentType type = (LongArgumentType) originalType;
+                    int min = (int) Math.max( Integer.MIN_VALUE, Math.min( Integer.MAX_VALUE, type.getMinimum() ) );
+                    int max = (int) Math.max( Integer.MIN_VALUE, Math.min( Integer.MAX_VALUE, type.getMaximum() ) );
+                    return IntegerArgumentType.integer( min, max );
+                }
+                return originalType;
+            } );
+
+            PROVIDERS.put( "brigadier:string", STRING );
             PROPER_PROVIDERS.put( StringArgumentType.class, STRING );
 
-            register( "minecraft:entity", BYTE );
-            register( "minecraft:game_profile", VOID );
-            register( "minecraft:block_pos", VOID );
-            register( "minecraft:column_pos", VOID );
-            register( "minecraft:vec3", VOID );
-            register( "minecraft:vec2", VOID );
-            register( "minecraft:block_state", VOID );
-            register( "minecraft:block_predicate", VOID );
-            register( "minecraft:item_stack", VOID );
-            register( "minecraft:item_predicate", VOID );
-            register( "minecraft:color", VOID );
-            register( "minecraft:component", VOID );
-            register( "minecraft:message", VOID );
-            register( "minecraft:nbt_compound_tag", VOID ); // 1.14
-            register( "minecraft:nbt_tag", VOID ); // 1.14
-            register( "minecraft:nbt_path", VOID );
-            register( "minecraft:objective", VOID );
-            register( "minecraft:objective_criteria", VOID );
-            register( "minecraft:operation", VOID );
-            register( "minecraft:particle", VOID );
-            register( "minecraft:angle", VOID ); // 1.16.2
-            register( "minecraft:rotation", VOID );
-            register( "minecraft:scoreboard_slot", VOID );
-            register( "minecraft:score_holder", BYTE );
-            register( "minecraft:swizzle", VOID );
-            register( "minecraft:team", VOID );
-            register( "minecraft:item_slot", VOID );
-            register( "minecraft:resource_location", VOID );
-            register( "minecraft:mob_effect", VOID );
-            register( "minecraft:function", VOID );
-            register( "minecraft:entity_anchor", VOID );
-            register( "minecraft:int_range", VOID );
-            register( "minecraft:float_range", VOID );
-            register( "minecraft:item_enchantment", VOID );
-            register( "minecraft:entity_summon", VOID );
-            register( "minecraft:dimension", VOID );
-            register( "minecraft:time", VOID ); // 1.14
-            register( "minecraft:resource_or_tag", RAW_STRING ); // 1.18.2
-            register( "minecraft:resource", RAW_STRING ); // 1.18.2
-            register( "minecraft:template_mirror", VOID ); // 1.19
-            register( "minecraft:template_rotation", VOID ); // 1.19
-            register( "minecraft:uuid", VOID ); // 1.16
+            PROVIDERS.put( "minecraft:entity", BYTE );
+            PROVIDERS.put( "minecraft:game_profile", VOID );
+            PROVIDERS.put( "minecraft:block_pos", VOID );
+            PROVIDERS.put( "minecraft:column_pos", VOID );
+            PROVIDERS.put( "minecraft:vec3", VOID );
+            PROVIDERS.put( "minecraft:vec2", VOID );
+            PROVIDERS.put( "minecraft:block_state", VOID );
+            PROVIDERS.put( "minecraft:block_predicate", VOID );
+            PROVIDERS.put( "minecraft:item_stack", VOID );
+            PROVIDERS.put( "minecraft:item_predicate", VOID );
+            PROVIDERS.put( "minecraft:color", VOID );
+            PROVIDERS.put( "minecraft:component", VOID );
+            PROVIDERS.put( "minecraft:message", VOID );
 
-            register( "minecraft:nbt", VOID ); // 1.13 // removed
+            PROVIDERS.put( "minecraft:nbt_compound_tag", VOID ); // 1.14+, replaces minecraft:nbt
+            CONVERSION_PROVIDERS.put( "minecraft:nbt_compound_tag", ( originalType, protocolVersion ) ->
+            {
+                if ( protocolVersion < ProtocolConstants.MINECRAFT_1_14 )
+                {
+                    return minecraftNBT();
+                }
+                return originalType;
+            } );
+
+            PROVIDERS.put( "minecraft:nbt_tag", VOID ); // 1.14+
+            CONVERSION_PROVIDERS.put( "minecraft:nbt_tag", ( originalType, protocolVersion ) ->
+            {
+                if ( protocolVersion < ProtocolConstants.MINECRAFT_1_14 )
+                {
+                    return minecraftNBT();
+                }
+                return originalType;
+            } );
+
+            PROVIDERS.put( "minecraft:nbt", VOID ); // 1.13
+            CONVERSION_PROVIDERS.put( "minecraft:nbt", ( originalType, protocolVersion ) ->
+            {
+                if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_14 )
+                {
+                    return minecraftNBTCompoundTag();
+                }
+                return originalType;
+            } );
+
+            PROVIDERS.put( "minecraft:nbt_path", VOID );
+            PROVIDERS.put( "minecraft:objective", VOID );
+            PROVIDERS.put( "minecraft:objective_criteria", VOID );
+            PROVIDERS.put( "minecraft:operation", VOID );
+            PROVIDERS.put( "minecraft:particle", VOID );
+            PROVIDERS.put( "minecraft:rotation", VOID );
+            PROVIDERS.put( "minecraft:scoreboard_slot", VOID );
+            PROVIDERS.put( "minecraft:score_holder", BYTE );
+            PROVIDERS.put( "minecraft:swizzle", VOID );
+            PROVIDERS.put( "minecraft:team", VOID );
+            PROVIDERS.put( "minecraft:item_slot", VOID );
+            PROVIDERS.put( "minecraft:resource_location", VOID );
+            PROVIDERS.put( "minecraft:mob_effect", VOID );
+            PROVIDERS.put( "minecraft:function", VOID );
+            PROVIDERS.put( "minecraft:entity_anchor", VOID );
+            PROVIDERS.put( "minecraft:int_range", VOID );
+            PROVIDERS.put( "minecraft:float_range", VOID );
+            PROVIDERS.put( "minecraft:item_enchantment", VOID );
+            PROVIDERS.put( "minecraft:entity_summon", VOID );
+            PROVIDERS.put( "minecraft:dimension", VOID );
+
+            PROVIDERS.put( "minecraft:time", VOID ); // 1.14+
+            CONVERSION_PROVIDERS.put( "minecraft:time", ( originalType, protocolVersion ) ->
+            {
+                if ( protocolVersion < ProtocolConstants.MINECRAFT_1_14 )
+                {
+                    return StringArgumentType.word();
+                }
+                return originalType;
+            } );
+
+            PROVIDERS.put( "minecraft:uuid", VOID ); // 1.16+
+            CONVERSION_PROVIDERS.put( "minecraft:uuid", ( originalType, protocolVersion ) ->
+            {
+                if ( protocolVersion < ProtocolConstants.MINECRAFT_1_16 )
+                {
+                    return StringArgumentType.word();
+                }
+                return originalType;
+            } );
+
+            PROVIDERS.put( "minecraft:test_argument", VOID ); // 1.16+, debug
+            PROVIDERS.put( "minecraft:test_class", VOID ); // 1.16+, debug
+
+            PROVIDERS.put( "minecraft:angle", VOID ); // 1.16.2+
+            CONVERSION_PROVIDERS.put( "minecraft:angle", ( originalType, protocolVersion ) ->
+            {
+                if ( protocolVersion < ProtocolConstants.MINECRAFT_1_16_2 )
+                {
+                    return FloatArgumentType.floatArg();
+                }
+                return originalType;
+            } );
         }
 
-        private static void register(String name, ArgumentSerializer serializer)
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:entity}.
+         * @param singleEntity if the argument restrict to only one entity
+         * @param onlyPlayers if the argument restrict to players only
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftEntity(boolean singleEntity, boolean onlyPlayers)
         {
-            PROVIDERS.put( name, serializer );
-            PROVIDER_LIST.add( serializer );
-        }
-
-        private static ArgumentType<?> read(ByteBuf buf, int protocolVersion)
-        {
-            Object key;
-            ArgumentSerializer reader;
-
-            if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19 )
+            byte flags = 0;
+            if ( singleEntity )
             {
-                key = readVarInt( buf );
-                reader = PROVIDER_LIST.get( (Integer) key );
-            } else
+                flags |= 1;
+            }
+            if ( onlyPlayers )
             {
-                key = readString( buf );
-                reader = PROVIDERS.get( (String) key );
+                flags |= 2;
             }
 
+            return minecraftArgumentType( "minecraft:entity", flags );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:game_profile}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftGameProfile()
+        {
+            return minecraftArgumentType( "minecraft:game_profile", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:block_pos}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftBlockPos()
+        {
+            return minecraftArgumentType( "minecraft:block_pos", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:column_pos}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftColumnPos()
+        {
+            return minecraftArgumentType( "minecraft:column_pos", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:vec3}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftVec3()
+        {
+            return minecraftArgumentType( "minecraft:vec3", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:vec2}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftVec2()
+        {
+            return minecraftArgumentType( "minecraft:vec2", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:block_state}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftBlockState()
+        {
+            return minecraftArgumentType( "minecraft:block_state", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:block_predicate}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftBlockPredicate()
+        {
+            return minecraftArgumentType( "minecraft:block_predicate", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:item_stack}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftItemStack()
+        {
+            return minecraftArgumentType( "minecraft:item_stack", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:item_predicate}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftItemPredicate()
+        {
+            return minecraftArgumentType( "minecraft:item_predicate", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:color}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftColor()
+        {
+            return minecraftArgumentType( "minecraft:color", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:component}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftComponent()
+        {
+            return minecraftArgumentType( "minecraft:component", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:message}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftMessage()
+        {
+            return minecraftArgumentType( "minecraft:message", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:nbt_compound_tag}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftNBTCompoundTag()
+        {
+            return minecraftArgumentType( "minecraft:nbt_compound_tag", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:nbt_tag}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftNBTTag()
+        {
+            return minecraftArgumentType( "minecraft:nbt_tag", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:nbt}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftNBT()
+        {
+            return minecraftArgumentType( "minecraft:nbt", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:nbt_path}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftNBTPath()
+        {
+            return minecraftArgumentType( "minecraft:nbt_path", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:objective}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftObjective()
+        {
+            return minecraftArgumentType( "minecraft:objective", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:objective_criteria}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftObjectiveCriteria()
+        {
+            return minecraftArgumentType( "minecraft:objective_criteria", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:operation}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftOperation()
+        {
+            return minecraftArgumentType( "minecraft:operation", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:particle}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftParticle()
+        {
+            return minecraftArgumentType( "minecraft:particle", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:rotation}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftRotation()
+        {
+            return minecraftArgumentType( "minecraft:rotation", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:scoreboard_slot}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftScoreboardSlot()
+        {
+            return minecraftArgumentType( "minecraft:scoreboard_slot", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:score_holder}.
+         * @param allowMultiple if the argument allows multiple entities
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftScoreHolder(boolean allowMultiple)
+        {
+            byte flags = 0;
+            if ( allowMultiple )
+            {
+                flags |= 1;
+            }
+
+            return minecraftArgumentType( "minecraft:score_holder", flags );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:swizzle}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftSwizzle()
+        {
+            return minecraftArgumentType( "minecraft:swizzle", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:team}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftTeam()
+        {
+            return minecraftArgumentType( "minecraft:team", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:item_slot}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftItemSlot()
+        {
+            return minecraftArgumentType( "minecraft:item_slot", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:resource_location}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftResourceLocation()
+        {
+            return minecraftArgumentType( "minecraft:resource_location", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:mob_effect}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftMobEffect()
+        {
+            return minecraftArgumentType( "minecraft:mob_effect", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:function}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftFunction()
+        {
+            return minecraftArgumentType( "minecraft:function", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:entity_anchor}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftEntityAnchor()
+        {
+            return minecraftArgumentType( "minecraft:entity_anchor", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:int_range}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftIntRange()
+        {
+            return minecraftArgumentType( "minecraft:int_range", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:float_range}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftFloatRange()
+        {
+            return minecraftArgumentType( "minecraft:float_range", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:item_enchantment}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftItemEnchantment()
+        {
+            return minecraftArgumentType( "minecraft:item_enchantment", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:entity_summon}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftEntitySummon()
+        {
+            return minecraftArgumentType( "minecraft:entity_summon", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:dimension}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftDimension()
+        {
+            return minecraftArgumentType( "minecraft:dimension", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:time}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftTime()
+        {
+            return minecraftArgumentType( "minecraft:time", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:uuid}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftUUID()
+        {
+            return minecraftArgumentType( "minecraft:uuid", null );
+        }
+
+        /**
+         * Returns the Minecraft ArgumentType {@code minecraft:angle}.
+         * @return an ArgumentType instance
+         */
+        public static ArgumentType<?> minecraftAngle()
+        {
+            return minecraftArgumentType( "minecraft:angle", null );
+        }
+
+        private static ArgumentType<?> minecraftArgumentType(String key, Object rawValue)
+        {
+            ArgumentSerializer reader = PROVIDERS.get( key );
+            Preconditions.checkArgument( reader != null, "No provider for argument " + key );
+
+            return new DummyType( key, reader, rawValue );
+        }
+
+        private static ArgumentType<?> read(String key, ByteBuf buf)
+        {
+            ArgumentSerializer reader = PROVIDERS.get( key );
             Preconditions.checkArgument( reader != null, "No provider for argument " + key );
 
             Object val = reader.read( buf );
@@ -607,38 +1050,56 @@ public class Commands extends DefinedPacket
 
         private static void write(ArgumentType<?> arg, ByteBuf buf, int protocolVersion)
         {
+            arg = convertToVersion( arg, protocolVersion );
+
             ProperArgumentSerializer proper = PROPER_PROVIDERS.get( arg.getClass() );
             if ( proper != null )
             {
-                if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19 )
-                {
-                    writeVarInt( proper.getIntKey(), buf );
-                } else
-                {
-                    writeString( proper.getKey(), buf );
-                }
+                writeString( proper.getKey(), buf );
                 proper.write( buf, arg );
             } else
             {
                 Preconditions.checkArgument( arg instanceof DummyType, "Non dummy arg " + arg.getClass() );
 
                 DummyType dummy = (DummyType) arg;
-                if ( dummy.key instanceof Integer )
-                {
-                    writeVarInt( (Integer) dummy.key, buf );
-                } else
-                {
-                    writeString( (String) dummy.key, buf );
-                }
+                writeString( dummy.key, buf );
                 dummy.serializer.write( buf, dummy.value );
             }
         }
 
+        // Convert the provided argument type to a new one compatible with the provided protocol version
+        private static ArgumentType<?> convertToVersion(ArgumentType<?> arg, int protocolVersion)
+        {
+            ProperArgumentSerializer proper = PROPER_PROVIDERS.get( arg.getClass() );
+            String key;
+            if ( proper != null )
+            {
+                key = proper.getKey();
+            } else
+            {
+                Preconditions.checkArgument( arg instanceof DummyType, "Non dummy arg " + arg.getClass() );
+                key = ( (DummyType) arg ).key;
+            }
+
+            ProtocolConversionProvider converter = CONVERSION_PROVIDERS.get( key );
+
+            if ( converter != null )
+            {
+                return converter.convert( arg, protocolVersion );
+            }
+            return arg;
+        }
+
+        private interface ProtocolConversionProvider
+        {
+            public ArgumentType<?> convert(ArgumentType<?> originalType, int protocolVersion);
+        }
+
         @Data
         private static class DummyType<T> implements ArgumentType<T>
         {
 
-            private final Object key;
+            private final String key;
             private final ArgumentSerializer<T> serializer;
             private final T value;
 
@@ -660,8 +1121,6 @@ public class Commands extends DefinedPacket
         private abstract static class ProperArgumentSerializer<T> extends ArgumentSerializer<T>
         {
 
-            protected abstract int getIntKey();
-
             protected abstract String getKey();
         }
     }
@@ -669,17 +1128,39 @@ public class Commands extends DefinedPacket
     @Data
     public static class SuggestionRegistry
     {
-
+        /**
+         * Tells the client to ask suggestions to the server.
+         */
         public static final SuggestionProvider ASK_SERVER = new DummyProvider( "minecraft:ask_server" );
+
+        /**
+         * Tells the client to suggest all the available recipes. The suggestions are stored client side.
+         */
+        public static final SuggestionProvider ALL_RECIPES = new DummyProvider( "minecraft:all_recipes" );
+
+        /**
+         * Tells the client to suggest all the available sounds. The suggestions are stored client side.
+         */
+        public static final SuggestionProvider AVAILABLE_SOUNDS = new DummyProvider( "minecraft:available_sounds" );
+
+        /**
+         * Tells the client to suggest all the available biomes. The suggestions are stored client side.
+         */
+        public static final SuggestionProvider AVAILABLE_BIOMES = new DummyProvider( "minecraft:available_biomes" );
+
+        /**
+         * Tells the client to suggest all the available entities. The suggestions are stored client side.
+         */
+        public static final SuggestionProvider SUMMONABLE_ENTITIES = new DummyProvider( "minecraft:summonable_entities" );
         private static final Map<String, SuggestionProvider<DummyProvider>> PROVIDERS = new HashMap<>();
 
         static
         {
             PROVIDERS.put( "minecraft:ask_server", ASK_SERVER );
-            registerDummy( "minecraft:all_recipes" );
-            registerDummy( "minecraft:available_sounds" );
-            registerDummy( "minecraft:available_biomes" );
-            registerDummy( "minecraft:summonable_entities" );
+            PROVIDERS.put( "minecraft:all_recipes", ALL_RECIPES );
+            PROVIDERS.put( "minecraft:available_sounds", AVAILABLE_SOUNDS );
+            PROVIDERS.put( "minecraft:available_biomes", AVAILABLE_BIOMES );
+            PROVIDERS.put( "minecraft:summonable_entities", SUMMONABLE_ENTITIES );
         }
 
         private static void registerDummy(String name)
@@ -697,9 +1178,13 @@ public class Commands extends DefinedPacket
 
         private static String getKey(SuggestionProvider<DummyProvider> provider)
         {
-            Preconditions.checkArgument( provider instanceof DummyProvider, "Non dummy provider " + provider );
+            Preconditions.checkNotNull( provider );
+            if ( provider instanceof DummyProvider )
+            {
+                return ( (DummyProvider) provider ).key;
+            }
 
-            return ( (DummyProvider) provider ).key;
+            return ( (DummyProvider) ASK_SERVER ).key;
         }
 
         @Data

protocol/src/main/java/net/md_5/bungee/protocol/packet/EncryptionResponse.java

@@ -18,36 +18,19 @@ public class EncryptionResponse extends DefinedPacket
 
     private byte[] sharedSecret;
     private byte[] verifyToken;
-    private EncryptionData encryptionData;
 
+    @Override
     public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
     {
         sharedSecret = readArray( buf, 128 );
-        if ( protocolVersion < ProtocolConstants.MINECRAFT_1_19 || buf.readBoolean() )
-        {
-            verifyToken = readArray( buf, 128 );
-        } else
-        {
-            encryptionData = new EncryptionData( buf.readLong(), readArray( buf ) );
-        }
+        verifyToken = readArray( buf, 128 );
     }
 
     @Override
     public void write(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
     {
         writeArray( sharedSecret, buf );
-        if ( verifyToken != null )
-        {
-            if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19 )
-            {
-                buf.writeBoolean( true );
-            }
-            writeArray( verifyToken, buf );
-        } else
-        {
-            buf.writeLong( encryptionData.getSalt() );
-            writeArray( encryptionData.getSignature(), buf );
-        }
+        writeArray( verifyToken, buf );
     }
 
     @Override
@@ -55,12 +38,4 @@ public class EncryptionResponse extends DefinedPacket
     {
         handler.handle( this );
     }
-
-    @Data
-    public static class EncryptionData
-    {
-
-        private final long salt;
-        private final byte[] signature;
-    }
 }

protocol/src/main/java/net/md_5/bungee/protocol/packet/Handshake.java

@@ -24,7 +24,7 @@ public class Handshake extends DefinedPacket
     public void read(ByteBuf buf)
     {
         protocolVersion = readVarInt( buf );
-        host = readString( buf, 255 );
+        host = readString( buf );
         port = buf.readUnsignedShort();
         requestedProtocol = readVarInt( buf );
     }

protocol/src/main/java/net/md_5/bungee/protocol/packet/Login.java

@@ -1,5 +1,6 @@
 package net.md_5.bungee.protocol.packet;
 
+import com.google.common.base.Preconditions;
 import io.netty.buffer.ByteBuf;
 import java.util.HashSet;
 import java.util.Set;
@@ -9,7 +10,6 @@ import lombok.EqualsAndHashCode;
 import lombok.NoArgsConstructor;
 import net.md_5.bungee.protocol.AbstractPacketHandler;
 import net.md_5.bungee.protocol.DefinedPacket;
-import net.md_5.bungee.protocol.Location;
 import net.md_5.bungee.protocol.ProtocolConstants;
 import se.llbit.nbt.Tag;
 
@@ -33,12 +33,10 @@ public class Login extends DefinedPacket
     private int maxPlayers;
     private String levelType;
     private int viewDistance;
-    private int simulationDistance;
     private boolean reducedDebugInfo;
     private boolean normalRespawn;
     private boolean debug;
     private boolean flat;
-    private Location deathLocation;
 
     @Override
     public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
@@ -55,6 +53,8 @@ public class Login extends DefinedPacket
 
             worldNames = new HashSet<>();
             int worldCount = readVarInt( buf );
+            Preconditions.checkArgument( worldCount < 128, "Too many worlds %s", worldCount );
+
             for ( int i = 0; i < worldCount; i++ )
             {
                 worldNames.add( readString( buf ) );
@@ -65,7 +65,7 @@ public class Login extends DefinedPacket
 
         if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_16 )
         {
-            if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_16_2 && protocolVersion < ProtocolConstants.MINECRAFT_1_19 )
+            if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_16_2 )
             {
                 dimension = readTag( buf );
             } else
@@ -103,10 +103,6 @@ public class Login extends DefinedPacket
         {
             viewDistance = readVarInt( buf );
         }
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_18 )
-        {
-            simulationDistance = readVarInt( buf );
-        }
         if ( protocolVersion >= 29 )
         {
             reducedDebugInfo = buf.readBoolean();
@@ -120,13 +116,6 @@ public class Login extends DefinedPacket
             debug = buf.readBoolean();
             flat = buf.readBoolean();
         }
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19 )
-        {
-            if ( buf.readBoolean() )
-            {
-                deathLocation = new Location( readString( buf ), buf.readLong() );
-            }
-        }
     }
 
     @Override
@@ -153,7 +142,7 @@ public class Login extends DefinedPacket
 
         if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_16 )
         {
-            if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_16_2 && protocolVersion < ProtocolConstants.MINECRAFT_1_19 )
+            if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_16_2 )
             {
                 writeTag( (Tag) dimension, buf );
             } else
@@ -191,10 +180,6 @@ public class Login extends DefinedPacket
         {
             writeVarInt( viewDistance, buf );
         }
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_18 )
-        {
-            writeVarInt( simulationDistance, buf );
-        }
         if ( protocolVersion >= 29 )
         {
             buf.writeBoolean( reducedDebugInfo );
@@ -208,18 +193,6 @@ public class Login extends DefinedPacket
             buf.writeBoolean( debug );
             buf.writeBoolean( flat );
         }
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19 )
-        {
-            if ( deathLocation != null )
-            {
-                buf.writeBoolean( true );
-                writeString( deathLocation.getDimension(), buf );
-                buf.writeLong( deathLocation.getPos() );
-            } else
-            {
-                buf.writeBoolean( false );
-            }
-        }
     }
 
     @Override

protocol/src/main/java/net/md_5/bungee/protocol/packet/LoginRequest.java

@@ -1,15 +1,16 @@
+/*
+ * To change this template, choose Tools | Templates
+ * and open the template in the editor.
+ */
 package net.md_5.bungee.protocol.packet;
 
 import io.netty.buffer.ByteBuf;
-import java.util.UUID;
 import lombok.AllArgsConstructor;
 import lombok.Data;
 import lombok.EqualsAndHashCode;
 import lombok.NoArgsConstructor;
 import net.md_5.bungee.protocol.AbstractPacketHandler;
 import net.md_5.bungee.protocol.DefinedPacket;
-import net.md_5.bungee.protocol.PlayerPublicKey;
-import net.md_5.bungee.protocol.ProtocolConstants;
 
 @Data
 @NoArgsConstructor
@@ -19,45 +20,17 @@ public class LoginRequest extends DefinedPacket
 {
 
     private String data;
-    private PlayerPublicKey publicKey;
-    private UUID uuid;
 
     @Override
-    public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
+    public void read(ByteBuf buf)
     {
-        data = readString( buf, 16 );
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19 )
-        {
-            publicKey = readPublicKey( buf );
-        }
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19_1 )
-        {
-            if ( buf.readBoolean() )
-            {
-                uuid = readUUID( buf );
-            }
-        }
+        data = readString( buf );
     }
 
     @Override
-    public void write(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
+    public void write(ByteBuf buf)
     {
         writeString( data, buf );
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19 )
-        {
-            writePublicKey( publicKey, buf );
-        }
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19_1 )
-        {
-            if ( uuid != null )
-            {
-                buf.writeBoolean( true );
-                writeUUID( uuid, buf );
-            } else
-            {
-                buf.writeBoolean( false );
-            }
-        }
     }
 
     @Override

protocol/src/main/java/net/md_5/bungee/protocol/packet/LoginSuccess.java

@@ -8,7 +8,6 @@ import lombok.EqualsAndHashCode;
 import lombok.NoArgsConstructor;
 import net.md_5.bungee.protocol.AbstractPacketHandler;
 import net.md_5.bungee.protocol.DefinedPacket;
-import net.md_5.bungee.protocol.Property;
 import net.md_5.bungee.protocol.ProtocolConstants;
 
 @Data
@@ -20,7 +19,6 @@ public class LoginSuccess extends DefinedPacket
 
     private UUID uuid;
     private String username;
-    private Property[] properties;
 
     @Override
     public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
@@ -33,10 +31,6 @@ public class LoginSuccess extends DefinedPacket
             uuid = UUID.fromString( readString( buf ) );
         }
         username = readString( buf );
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19 )
-        {
-            properties = readProperties( buf );
-        }
     }
 
     @Override
@@ -50,10 +44,6 @@ public class LoginSuccess extends DefinedPacket
             writeString( uuid.toString(), buf );
         }
         writeString( username, buf );
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19 )
-        {
-            writeProperties( properties, buf );
-        }
     }
 
     @Override

protocol/src/main/java/net/md_5/bungee/protocol/packet/PlayerListItem.java

@@ -7,8 +7,6 @@ import lombok.EqualsAndHashCode;
 import lombok.NoArgsConstructor;
 import net.md_5.bungee.protocol.AbstractPacketHandler;
 import net.md_5.bungee.protocol.DefinedPacket;
-import net.md_5.bungee.protocol.PlayerPublicKey;
-import net.md_5.bungee.protocol.Property;
 import net.md_5.bungee.protocol.ProtocolConstants;
 
 @Data
@@ -33,17 +31,31 @@ public class PlayerListItem extends DefinedPacket
             {
                 case ADD_PLAYER:
                     item.username = DefinedPacket.readString( buf );
-                    item.properties = DefinedPacket.readProperties( buf );
+                    item.properties = new String[ DefinedPacket.readVarInt( buf ) ][];
+                    for ( int j = 0; j < item.properties.length; j++ )
+                    {
+                        String name = DefinedPacket.readString( buf );
+                        String value = DefinedPacket.readString( buf );
+                        if ( buf.readBoolean() )
+                        {
+                            item.properties[j] = new String[]
+                            {
+                                name, value, DefinedPacket.readString( buf )
+                            };
+                        } else
+                        {
+                            item.properties[j] = new String[]
+                            {
+                                name, value
+                            };
+                        }
+                    }
                     item.gamemode = DefinedPacket.readVarInt( buf );
                     item.ping = DefinedPacket.readVarInt( buf );
                     if ( buf.readBoolean() )
                     {
                         item.displayName = DefinedPacket.readString( buf );
                     }
-                    if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19 )
-                    {
-                        item.publicKey = readPublicKey( buf );
-                    }
                     break;
                 case UPDATE_GAMEMODE:
                     item.gamemode = DefinedPacket.readVarInt( buf );
@@ -72,7 +84,20 @@ public class PlayerListItem extends DefinedPacket
             {
                 case ADD_PLAYER:
                     DefinedPacket.writeString( item.username, buf );
-                    DefinedPacket.writeProperties( item.properties, buf );
+                    DefinedPacket.writeVarInt( item.properties.length, buf );
+                    for ( String[] prop : item.properties )
+                    {
+                        DefinedPacket.writeString( prop[0], buf );
+                        DefinedPacket.writeString( prop[1], buf );
+                        if ( prop.length >= 3 )
+                        {
+                            buf.writeBoolean( true );
+                            DefinedPacket.writeString( prop[2], buf );
+                        } else
+                        {
+                            buf.writeBoolean( false );
+                        }
+                    }
                     DefinedPacket.writeVarInt( item.gamemode, buf );
                     DefinedPacket.writeVarInt( item.ping, buf );
                     buf.writeBoolean( item.displayName != null );
@@ -80,10 +105,6 @@ public class PlayerListItem extends DefinedPacket
                     {
                         DefinedPacket.writeString( item.displayName, buf );
                     }
-                    if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19 )
-                    {
-                        writePublicKey( item.publicKey, buf );
-                    }
                     break;
                 case UPDATE_GAMEMODE:
                     DefinedPacket.writeVarInt( item.gamemode, buf );
@@ -127,8 +148,7 @@ public class PlayerListItem extends DefinedPacket
 
         // ADD_PLAYER
         private String username;
-        private Property[] properties;
-        private PlayerPublicKey publicKey;
+        private String[][] properties;
 
         // ADD_PLAYER & UPDATE_GAMEMODE
         private int gamemode;

protocol/src/main/java/net/md_5/bungee/protocol/packet/PluginMessage.java

@@ -2,6 +2,7 @@ package net.md_5.bungee.protocol.packet;
 
 import com.google.common.base.Function;
 import com.google.common.base.Preconditions;
+import com.google.common.base.Predicate;
 import io.netty.buffer.ByteBuf;
 import java.io.ByteArrayInputStream;
 import java.io.DataInput;
@@ -47,6 +48,14 @@ public class PluginMessage extends DefinedPacket
             return "legacy:" + tag.toLowerCase( Locale.ROOT );
         }
     };
+    public static final Predicate<PluginMessage> SHOULD_RELAY = new Predicate<PluginMessage>()
+    {
+        @Override
+        public boolean apply(PluginMessage input)
+        {
+            return ( input.getTag().equals( "REGISTER" ) || input.getTag().equals( "minecraft:register" ) || input.getTag().equals( "MC|Brand" ) || input.getTag().equals( "minecraft:brand" ) ) && input.getData().length < Byte.MAX_VALUE;
+        }
+    };
     //
     private String tag;
     private byte[] data;
@@ -59,9 +68,9 @@ public class PluginMessage extends DefinedPacket
     @Override
     public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
     {
-        tag = ( protocolVersion >= ProtocolConstants.MINECRAFT_1_13 ) ? MODERNISE.apply( readString( buf ) ) : readString( buf, 20 );
-        int maxSize = ( direction == ProtocolConstants.Direction.TO_SERVER ) ? Short.MAX_VALUE : 0x100000;
-        Preconditions.checkArgument( buf.readableBytes() <= maxSize, "Payload too large" );
+        tag = ( protocolVersion >= ProtocolConstants.MINECRAFT_1_13 ) ? MODERNISE.apply( readString( buf ) ) : readString( buf );
+        int maxSize = direction == ProtocolConstants.Direction.TO_SERVER ? Short.MAX_VALUE : 0x100000;
+        Preconditions.checkArgument( buf.readableBytes() < maxSize );
         data = new byte[ buf.readableBytes() ];
         buf.readBytes( data );
     }

protocol/src/main/java/net/md_5/bungee/protocol/packet/Respawn.java

@@ -7,7 +7,6 @@ import lombok.EqualsAndHashCode;
 import lombok.NoArgsConstructor;
 import net.md_5.bungee.protocol.AbstractPacketHandler;
 import net.md_5.bungee.protocol.DefinedPacket;
-import net.md_5.bungee.protocol.Location;
 import net.md_5.bungee.protocol.ProtocolConstants;
 import se.llbit.nbt.Tag;
 
@@ -28,14 +27,13 @@ public class Respawn extends DefinedPacket
     private boolean debug;
     private boolean flat;
     private boolean copyMeta;
-    private Location deathLocation;
 
     @Override
     public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
     {
         if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_16 )
         {
-            if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_16_2 && protocolVersion < ProtocolConstants.MINECRAFT_1_19 )
+            if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_16_2 )
             {
                 dimension = readTag( buf );
             } else
@@ -66,13 +64,6 @@ public class Respawn extends DefinedPacket
         {
             levelType = readString( buf );
         }
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19 )
-        {
-            if ( buf.readBoolean() )
-            {
-                deathLocation = new Location( readString( buf ), buf.readLong() );
-            }
-        }
     }
 
     @Override
@@ -80,7 +71,7 @@ public class Respawn extends DefinedPacket
     {
         if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_16 )
         {
-            if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_16_2 && protocolVersion < ProtocolConstants.MINECRAFT_1_19 )
+            if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_16_2 )
             {
                 writeTag( (Tag) dimension, buf );
             } else
@@ -111,18 +102,6 @@ public class Respawn extends DefinedPacket
         {
             writeString( levelType, buf );
         }
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19 )
-        {
-            if ( deathLocation != null )
-            {
-                buf.writeBoolean( true );
-                writeString( deathLocation.getDimension(), buf );
-                buf.writeLong( deathLocation.getPos() );
-            } else
-            {
-                buf.writeBoolean( false );
-            }
-        }
     }
 
     @Override

protocol/src/main/java/net/md_5/bungee/protocol/packet/Subtitle.java

@@ -1,36 +0,0 @@
-package net.md_5.bungee.protocol.packet;
-
-import io.netty.buffer.ByteBuf;
-import lombok.Data;
-import lombok.EqualsAndHashCode;
-import lombok.NoArgsConstructor;
-import net.md_5.bungee.protocol.AbstractPacketHandler;
-import net.md_5.bungee.protocol.DefinedPacket;
-import net.md_5.bungee.protocol.ProtocolConstants;
-
-@Data
-@NoArgsConstructor
-@EqualsAndHashCode(callSuper = false)
-public class Subtitle extends DefinedPacket
-{
-
-    private String text;
-
-    @Override
-    public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        text = readString( buf );
-    }
-
-    @Override
-    public void write(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        writeString( text, buf );
-    }
-
-    @Override
-    public void handle(AbstractPacketHandler handler) throws Exception
-    {
-        handler.handle( this );
-    }
-}

protocol/src/main/java/net/md_5/bungee/protocol/packet/SystemChat.java

@@ -1,48 +0,0 @@
-package net.md_5.bungee.protocol.packet;
-
-import io.netty.buffer.ByteBuf;
-import lombok.AllArgsConstructor;
-import lombok.Data;
-import lombok.EqualsAndHashCode;
-import lombok.NoArgsConstructor;
-import net.md_5.bungee.api.ChatMessageType;
-import net.md_5.bungee.protocol.AbstractPacketHandler;
-import net.md_5.bungee.protocol.DefinedPacket;
-import net.md_5.bungee.protocol.ProtocolConstants;
-
-@Data
-@NoArgsConstructor
-@AllArgsConstructor
-@EqualsAndHashCode(callSuper = false)
-public class SystemChat extends DefinedPacket
-{
-
-    private String message;
-    private int position;
-
-    @Override
-    public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        message = readString( buf, 262144 );
-        position = ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19_1 ) ? ( ( buf.readBoolean() ) ? ChatMessageType.ACTION_BAR.ordinal() : 0 ) : readVarInt( buf );
-    }
-
-    @Override
-    public void write(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        writeString( message, buf );
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_19_1 )
-        {
-            buf.writeBoolean( position == ChatMessageType.ACTION_BAR.ordinal() );
-        } else
-        {
-            writeVarInt( position, buf );
-        }
-    }
-
-    @Override
-    public void handle(AbstractPacketHandler handler) throws Exception
-    {
-        handler.handle( this );
-    }
-}

protocol/src/main/java/net/md_5/bungee/protocol/packet/TabCompleteRequest.java

@@ -41,7 +41,7 @@ public class TabCompleteRequest extends DefinedPacket
         {
             transactionId = readVarInt( buf );
         }
-        cursor = readString( buf, ( protocolVersion > ProtocolConstants.MINECRAFT_1_13 ? 32500 : ( protocolVersion == ProtocolConstants.MINECRAFT_1_13 ? 256 : 32767 ) ) );
+        cursor = readString( buf );
 
         if ( protocolVersion < ProtocolConstants.MINECRAFT_1_13 )
         {

protocol/src/main/java/net/md_5/bungee/protocol/packet/TabCompleteResponse.java

@@ -57,7 +57,9 @@ public class TabCompleteResponse extends DefinedPacket
             }
 
             suggestions = new Suggestions( range, matches );
-        } else
+        }
+
+        if ( protocolVersion < ProtocolConstants.MINECRAFT_1_13 )
         {
             commands = readStringArray( buf );
         }
@@ -82,7 +84,9 @@ public class TabCompleteResponse extends DefinedPacket
                     writeString( suggestion.getTooltip().getString(), buf );
                 }
             }
-        } else
+        }
+
+        if ( protocolVersion < ProtocolConstants.MINECRAFT_1_13 )
         {
             writeStringArray( commands, buf );
         }

protocol/src/main/java/net/md_5/bungee/protocol/packet/Title.java

@@ -24,20 +24,9 @@ public class Title extends DefinedPacket
     private int stay;
     private int fadeOut;
 
-    public Title(Action action)
-    {
-        this.action = action;
-    }
-
     @Override
     public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
     {
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_17 )
-        {
-            text = readString( buf );
-            return;
-        }
-
         int index = readVarInt( buf );
 
         // If we're working on 1.10 or lower, increment the value of the index so we pull out the correct value.
@@ -65,12 +54,6 @@ public class Title extends DefinedPacket
     @Override
     public void write(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
     {
-        if ( protocolVersion >= ProtocolConstants.MINECRAFT_1_17 )
-        {
-            writeString( text, buf );
-            return;
-        }
-
         int index = action.ordinal();
 
         // If we're working on 1.10 or lower, increment the value of the index so we pull out the correct value.

protocol/src/main/java/net/md_5/bungee/protocol/packet/TitleTimes.java

@@ -1,42 +0,0 @@
-package net.md_5.bungee.protocol.packet;
-
-import io.netty.buffer.ByteBuf;
-import lombok.Data;
-import lombok.EqualsAndHashCode;
-import lombok.NoArgsConstructor;
-import net.md_5.bungee.protocol.AbstractPacketHandler;
-import net.md_5.bungee.protocol.DefinedPacket;
-import net.md_5.bungee.protocol.ProtocolConstants;
-
-@Data
-@NoArgsConstructor
-@EqualsAndHashCode(callSuper = false)
-public class TitleTimes extends DefinedPacket
-{
-
-    private int fadeIn;
-    private int stay;
-    private int fadeOut;
-
-    @Override
-    public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        fadeIn = buf.readInt();
-        stay = buf.readInt();
-        fadeOut = buf.readInt();
-    }
-
-    @Override
-    public void write(ByteBuf buf, ProtocolConstants.Direction direction, int protocolVersion)
-    {
-        buf.writeInt( fadeIn );
-        buf.writeInt( stay );
-        buf.writeInt( fadeOut );
-    }
-
-    @Override
-    public void handle(AbstractPacketHandler handler) throws Exception
-    {
-        handler.handle( this );
-    }
-}

proxy/pom.xml

@@ -6,13 +6,13 @@
     <parent>
         <groupId>net.md-5</groupId>
         <artifactId>bungeecord-parent</artifactId>
-        <version>1.19-R0.1-SNAPSHOT</version>
+        <version>1.16-R0.4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 
     <groupId>net.md-5</groupId>
     <artifactId>bungeecord-proxy</artifactId>
-    <version>1.19-R0.1-SNAPSHOT</version>
+    <version>1.16-R0.4-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>BungeeCord-Proxy</name>
@@ -49,13 +49,6 @@
             <classifier>linux-x86_64</classifier>
             <scope>compile</scope>
         </dependency>
-        <dependency>
-            <groupId>io.netty</groupId>
-            <artifactId>netty-transport-native-epoll</artifactId>
-            <version>${netty.version}</version>
-            <classifier>linux-aarch_64</classifier>
-            <scope>compile</scope>
-        </dependency>
         <dependency>
             <groupId>net.md-5</groupId>
             <artifactId>bungeecord-api</artifactId>
@@ -86,12 +79,6 @@
             <version>${project.version}</version>
             <scope>compile</scope>
         </dependency>
-        <dependency>
-            <groupId>net.md-5</groupId>
-            <artifactId>bungeecord-slf4j</artifactId>
-            <version>${project.version}</version>
-            <scope>compile</scope>
-        </dependency>
         <dependency>
             <groupId>net.sf.jopt-simple</groupId>
             <artifactId>jopt-simple</artifactId>
@@ -101,27 +88,17 @@
         <dependency>
             <groupId>mysql</groupId>
             <artifactId>mysql-connector-java</artifactId>
-            <version>8.0.29</version>
-            <scope>runtime</scope>
-        </dependency>
-        <!-- add these back in as they are not exposed by the API -->
-        <dependency>
-            <groupId>org.apache.maven</groupId>
-            <artifactId>maven-resolver-provider</artifactId>
-            <version>3.8.5</version>
-            <scope>runtime</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.apache.maven.resolver</groupId>
-            <artifactId>maven-resolver-connector-basic</artifactId>
-            <version>1.7.3</version>
-            <scope>runtime</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.apache.maven.resolver</groupId>
-            <artifactId>maven-resolver-transport-http</artifactId>
-            <version>1.7.3</version>
+            <version>5.1.48</version>
             <scope>runtime</scope>
         </dependency>
     </dependencies>
+
+    <build>
+        <resources>
+            <resource>
+                <directory>src/main/resources</directory>
+                <filtering>true</filtering>
+            </resource>
+        </resources>
+    </build>
 </project>

proxy/src/main/java/net/md_5/bungee/BungeeCord.java

@@ -95,7 +95,6 @@ import net.md_5.bungee.query.RemoteQuery;
 import net.md_5.bungee.scheduler.BungeeScheduler;
 import net.md_5.bungee.util.CaseInsensitiveMap;
 import org.fusesource.jansi.AnsiConsole;
-import org.slf4j.impl.JDK14LoggerFactory;
 
 /**
  * Main BungeeCord proxy class.
@@ -189,6 +188,8 @@ public class BungeeCord extends ProxyServer
         // Java uses ! to indicate a resource inside of a jar/zip/other container. Running Bungee from within a directory that has a ! will cause this to muck up.
         Preconditions.checkState( new File( "." ).getAbsolutePath().indexOf( '!' ) == -1, "Cannot use BungeeCord in directory with ! in path." );
 
+        System.setSecurityManager( new BungeeSecurityManager() );
+
         try
         {
             baseBundle = ResourceBundle.getBundle( "messages" );
@@ -214,7 +215,6 @@ public class BungeeCord extends ProxyServer
         consoleReader.addCompleter( new ConsoleCommandCompleter( this ) );
 
         logger = new BungeeLogger( "BungeeCord", "proxy.log", consoleReader );
-        JDK14LoggerFactory.LOGGER = logger;
         System.setErr( new PrintStream( new LoggingOutputStream( logger, Level.SEVERE ), true ) );
         System.setOut( new PrintStream( new LoggingOutputStream( logger, Level.INFO ), true ) );
 
@@ -254,7 +254,7 @@ public class BungeeCord extends ProxyServer
     public void start() throws Exception
     {
         System.setProperty( "io.netty.selectorAutoRebuildThreshold", "0" ); // Seems to cause Bungee to stop accepting connections
-        if ( System.getProperty( "io.netty.leakDetectionLevel" ) == null && System.getProperty( "io.netty.leakDetection.level" ) == null )
+        if ( System.getProperty( "io.netty.leakDetectionLevel" ) == null )
         {
             ResourceLeakDetector.setLevel( ResourceLeakDetector.Level.DISABLED ); // Eats performance
         }

proxy/src/main/java/net/md_5/bungee/BungeeCordLauncher.java

@@ -20,11 +20,6 @@ public class BungeeCordLauncher
     {
         Security.setProperty( "networkaddress.cache.ttl", "30" );
         Security.setProperty( "networkaddress.cache.negative.ttl", "10" );
-        // For JDK9+ we force-enable multi-release jar file support #3087
-        if ( System.getProperty( "jdk.util.jar.enableMultiRelease" ) == null )
-        {
-            System.setProperty( "jdk.util.jar.enableMultiRelease", "force" );
-        }
 
         OptionParser parser = new OptionParser();
         parser.allowsUnrecognizedOptions();

proxy/src/main/java/net/md_5/bungee/BungeeSecurityManager.java

@@ -0,0 +1,78 @@
+package net.md_5.bungee;
+
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.security.AccessControlException;
+import java.security.Permission;
+import java.util.HashSet;
+import java.util.Set;
+import java.util.logging.Level;
+import net.md_5.bungee.api.ProxyServer;
+import net.md_5.bungee.api.scheduler.GroupedThreadFactory;
+
+public class BungeeSecurityManager extends SecurityManager
+{
+
+    private static final boolean ENFORCE = false;
+    private final Set<String> seen = new HashSet<>();
+
+    private void checkRestricted(String text)
+    {
+        Class[] context = getClassContext();
+        for ( int i = 2; i < context.length; i++ )
+        {
+            ClassLoader loader = context[i].getClassLoader();
+
+            // Bungee / system can do everything
+            if ( loader == ClassLoader.getSystemClassLoader() || loader == null )
+            {
+                break;
+            }
+
+            AccessControlException ex = new AccessControlException( "Plugin violation: " + text );
+            if ( ENFORCE )
+            {
+                throw ex;
+            }
+
+            StringWriter stack = new StringWriter();
+            ex.printStackTrace( new PrintWriter( stack ) );
+            if ( seen.add( stack.toString() ) )
+            {
+                ProxyServer.getInstance().getLogger().log( Level.WARNING, "Plugin performed restricted action, please inform them to use proper API methods: " + text, ex );
+            }
+            break;
+        }
+    }
+
+    @Override
+    public void checkExit(int status)
+    {
+        checkRestricted( "Exit: Cannot close VM" );
+    }
+
+    @Override
+    public void checkAccess(ThreadGroup g)
+    {
+        if ( !( g instanceof GroupedThreadFactory.BungeeGroup ) )
+        {
+            checkRestricted( "Illegal thread group access" );
+        }
+    }
+
+    @Override
+    public void checkPermission(Permission perm, Object context)
+    {
+        checkPermission( perm );
+    }
+
+    @Override
+    public void checkPermission(Permission perm)
+    {
+        switch ( perm.getName() )
+        {
+            case "setSecurityManager":
+                throw new AccessControlException( "Restricted Action", perm );
+        }
+    }
+}

proxy/src/main/java/net/md_5/bungee/BungeeServerInfo.java

@@ -154,7 +154,7 @@ public class BungeeServerInfo implements ServerInfo
         Preconditions.checkNotNull( callback, "callback" );
 
         int pingCache = ProxyServer.getInstance().getConfig().getRemotePingCache();
-        if ( pingCache > 0 && cachedPing != null && ( System.currentTimeMillis() - lastPing ) > pingCache )
+        if ( pingCache > 0 && cachedPing != null && ( lastPing - System.currentTimeMillis() ) > pingCache )
         {
             cachedPing = null;
         }

proxy/src/main/java/net/md_5/bungee/BungeeTitle.java

@@ -1,46 +1,29 @@
 package net.md_5.bungee;
 
-import lombok.Data;
 import net.md_5.bungee.api.Title;
 import net.md_5.bungee.api.chat.BaseComponent;
 import net.md_5.bungee.api.connection.ProxiedPlayer;
 import net.md_5.bungee.chat.ComponentSerializer;
 import net.md_5.bungee.protocol.DefinedPacket;
-import net.md_5.bungee.protocol.ProtocolConstants;
-import net.md_5.bungee.protocol.packet.ClearTitles;
-import net.md_5.bungee.protocol.packet.Subtitle;
 import net.md_5.bungee.protocol.packet.Title.Action;
-import net.md_5.bungee.protocol.packet.TitleTimes;
 
 public class BungeeTitle implements Title
 {
 
-    private TitlePacketHolder<net.md_5.bungee.protocol.packet.Title> title;
-    private TitlePacketHolder<Subtitle> subtitle;
-    private TitlePacketHolder<TitleTimes> times;
-    private TitlePacketHolder<ClearTitles> clear;
-    private TitlePacketHolder<ClearTitles> reset;
+    private net.md_5.bungee.protocol.packet.Title title, subtitle, times, clear, reset;
 
-    @Data
-    private static class TitlePacketHolder<T extends DefinedPacket>
+    private static net.md_5.bungee.protocol.packet.Title createPacket(Action action)
     {
+        net.md_5.bungee.protocol.packet.Title title = new net.md_5.bungee.protocol.packet.Title();
+        title.setAction( action );
 
-        private final net.md_5.bungee.protocol.packet.Title oldPacket;
-        private final T newPacket;
-    }
-
-    private static TitlePacketHolder<TitleTimes> createAnimationPacket()
-    {
-        TitlePacketHolder<TitleTimes> title = new TitlePacketHolder<>( new net.md_5.bungee.protocol.packet.Title( Action.TIMES ), new TitleTimes() );
-
-        title.oldPacket.setFadeIn( 20 );
-        title.oldPacket.setStay( 60 );
-        title.oldPacket.setFadeOut( 20 );
-
-        title.newPacket.setFadeIn( 20 );
-        title.newPacket.setStay( 60 );
-        title.newPacket.setFadeOut( 20 );
-
+        if ( action == Action.TIMES )
+        {
+            // Set packet to default values first
+            title.setFadeIn( 20 );
+            title.setStay( 60 );
+            title.setFadeOut( 20 );
+        }
         return title;
     }
 
@@ -49,11 +32,10 @@ public class BungeeTitle implements Title
     {
         if ( title == null )
         {
-            net.md_5.bungee.protocol.packet.Title packet = new net.md_5.bungee.protocol.packet.Title( Action.TITLE );
-            title = new TitlePacketHolder<>( packet, packet );
+            title = createPacket( Action.TITLE );
         }
 
-        title.oldPacket.setText( ComponentSerializer.toString( text ) ); // = newPacket
+        title.setText( ComponentSerializer.toString( text ) );
         return this;
     }
 
@@ -62,11 +44,10 @@ public class BungeeTitle implements Title
     {
         if ( title == null )
         {
-            net.md_5.bungee.protocol.packet.Title packet = new net.md_5.bungee.protocol.packet.Title( Action.TITLE );
-            title = new TitlePacketHolder<>( packet, packet );
+            title = createPacket( Action.TITLE );
         }
 
-        title.oldPacket.setText( ComponentSerializer.toString( text ) ); // = newPacket
+        title.setText( ComponentSerializer.toString( text ) );
         return this;
     }
 
@@ -75,12 +56,10 @@ public class BungeeTitle implements Title
     {
         if ( subtitle == null )
         {
-            subtitle = new TitlePacketHolder<>( new net.md_5.bungee.protocol.packet.Title( Action.SUBTITLE ), new Subtitle() );
+            subtitle = createPacket( Action.SUBTITLE );
         }
 
-        String serialized = ComponentSerializer.toString( text );
-        subtitle.oldPacket.setText( serialized );
-        subtitle.newPacket.setText( serialized );
+        subtitle.setText( ComponentSerializer.toString( text ) );
         return this;
     }
 
@@ -89,12 +68,10 @@ public class BungeeTitle implements Title
     {
         if ( subtitle == null )
         {
-            subtitle = new TitlePacketHolder<>( new net.md_5.bungee.protocol.packet.Title( Action.SUBTITLE ), new Subtitle() );
+            subtitle = createPacket( Action.SUBTITLE );
         }
 
-        String serialized = ComponentSerializer.toString( text );
-        subtitle.oldPacket.setText( serialized );
-        subtitle.newPacket.setText( serialized );
+        subtitle.setText( ComponentSerializer.toString( text ) );
         return this;
     }
 
@@ -103,11 +80,10 @@ public class BungeeTitle implements Title
     {
         if ( times == null )
         {
-            times = createAnimationPacket();
+            times = createPacket( Action.TIMES );
         }
 
-        times.oldPacket.setFadeIn( ticks );
-        times.newPacket.setFadeIn( ticks );
+        times.setFadeIn( ticks );
         return this;
     }
 
@@ -116,11 +92,10 @@ public class BungeeTitle implements Title
     {
         if ( times == null )
         {
-            times = createAnimationPacket();
+            times = createPacket( Action.TIMES );
         }
 
-        times.oldPacket.setStay( ticks );
-        times.newPacket.setStay( ticks );
+        times.setStay( ticks );
         return this;
     }
 
@@ -129,11 +104,10 @@ public class BungeeTitle implements Title
     {
         if ( times == null )
         {
-            times = createAnimationPacket();
+            times = createPacket( Action.TIMES );
         }
 
-        times.oldPacket.setFadeOut( ticks );
-        times.newPacket.setFadeOut( ticks );
+        times.setFadeOut( ticks );
         return this;
     }
 
@@ -142,7 +116,7 @@ public class BungeeTitle implements Title
     {
         if ( clear == null )
         {
-            clear = new TitlePacketHolder<>( new net.md_5.bungee.protocol.packet.Title( Action.CLEAR ), new ClearTitles() );
+            clear = createPacket( Action.CLEAR );
         }
 
         title = null; // No need to send title if we clear it after that again
@@ -155,7 +129,7 @@ public class BungeeTitle implements Title
     {
         if ( reset == null )
         {
-            reset = new TitlePacketHolder<>( new net.md_5.bungee.protocol.packet.Title( Action.RESET ), new ClearTitles( true ) );
+            reset = createPacket( Action.RESET );
         }
 
         // No need to send these packets if we reset them later
@@ -166,17 +140,11 @@ public class BungeeTitle implements Title
         return this;
     }
 
-    private static void sendPacket(ProxiedPlayer player, TitlePacketHolder packet)
+    private static void sendPacket(ProxiedPlayer player, DefinedPacket packet)
     {
         if ( packet != null )
         {
-            if ( player.getPendingConnection().getVersion() >= ProtocolConstants.MINECRAFT_1_17 )
-            {
-                player.unsafe().sendPacket( packet.newPacket );
-            } else
-            {
-                player.unsafe().sendPacket( packet.oldPacket );
-            }
+            player.unsafe().sendPacket( packet );
         }
     }
 

proxy/src/main/java/net/md_5/bungee/EncryptionUtil.java

@@ -1,11 +1,5 @@
 package net.md_5.bungee;
 
-import com.google.common.io.ByteStreams;
-import com.google.common.primitives.Longs;
-import java.io.IOException;
-import java.nio.ByteBuffer;
-import java.nio.ByteOrder;
-import java.nio.charset.StandardCharsets;
 import java.security.GeneralSecurityException;
 import java.security.Key;
 import java.security.KeyFactory;
@@ -13,13 +7,9 @@ import java.security.KeyPair;
 import java.security.KeyPairGenerator;
 import java.security.NoSuchAlgorithmException;
 import java.security.PublicKey;
-import java.security.Signature;
-import java.security.spec.InvalidKeySpecException;
 import java.security.spec.X509EncodedKeySpec;
 import java.util.Arrays;
-import java.util.Base64;
 import java.util.Random;
-import java.util.UUID;
 import javax.crypto.Cipher;
 import javax.crypto.SecretKey;
 import javax.crypto.spec.SecretKeySpec;
@@ -28,7 +18,6 @@ import net.md_5.bungee.jni.NativeCode;
 import net.md_5.bungee.jni.cipher.BungeeCipher;
 import net.md_5.bungee.jni.cipher.JavaCipher;
 import net.md_5.bungee.jni.cipher.NativeCipher;
-import net.md_5.bungee.protocol.PlayerPublicKey;
 import net.md_5.bungee.protocol.packet.EncryptionRequest;
 import net.md_5.bungee.protocol.packet.EncryptionResponse;
 
@@ -39,12 +28,10 @@ public class EncryptionUtil
 {
 
     private static final Random random = new Random();
-    private static final Base64.Encoder MIME_ENCODER = Base64.getMimeEncoder( 76, "\n".getBytes( StandardCharsets.UTF_8 ) );
     public static final KeyPair keys;
     @Getter
     private static final SecretKey secret = new SecretKeySpec( new byte[ 16 ], "AES" );
-    public static final NativeCode<BungeeCipher> nativeFactory = new NativeCode<>( "native-cipher", JavaCipher::new, NativeCipher::new );
-    private static final PublicKey MOJANG_KEY;
+    public static final NativeCode<BungeeCipher> nativeFactory = new NativeCode<>( "native-cipher", JavaCipher.class, NativeCipher.class );
 
     static
     {
@@ -57,14 +44,6 @@ public class EncryptionUtil
         {
             throw new ExceptionInInitializerError( ex );
         }
-
-        try
-        {
-            MOJANG_KEY = KeyFactory.getInstance( "RSA" ).generatePublic( new X509EncodedKeySpec( ByteStreams.toByteArray( EncryptionUtil.class.getResourceAsStream( "/yggdrasil_session_pubkey.der" ) ) ) );
-        } catch ( IOException | NoSuchAlgorithmException | InvalidKeySpecException ex )
-        {
-            throw new ExceptionInInitializerError( ex );
-        }
     }
 
     public static EncryptionRequest encryptRequest()
@@ -76,51 +55,17 @@ public class EncryptionUtil
         return new EncryptionRequest( hash, pubKey, verify );
     }
 
-    public static boolean check(PlayerPublicKey publicKey, UUID uuid) throws GeneralSecurityException
-    {
-        Signature signature = Signature.getInstance( "SHA1withRSA" );
-        signature.initVerify( MOJANG_KEY );
-
-        byte[] check;
-        if ( uuid != null )
-        {
-            byte[] encoded = getPubkey( publicKey.getKey() ).getEncoded();
-            check = new byte[ 24 + encoded.length ];
-
-            ByteBuffer.wrap( check ).order( ByteOrder.BIG_ENDIAN ).putLong( uuid.getMostSignificantBits() ).putLong( uuid.getLeastSignificantBits() ).putLong( publicKey.getExpiry() ).put( encoded );
-        } else
-        {
-            check = ( publicKey.getExpiry() + "-----BEGIN RSA PUBLIC KEY-----\n" + MIME_ENCODER.encodeToString( getPubkey( publicKey.getKey() ).getEncoded() ) + "\n-----END RSA PUBLIC KEY-----\n" ).getBytes( StandardCharsets.US_ASCII );
-        }
-        signature.update( check );
-
-        return signature.verify( publicKey.getSignature() );
-    }
-
-    public static boolean check(PlayerPublicKey publicKey, EncryptionResponse resp, EncryptionRequest request) throws GeneralSecurityException
-    {
-        if ( publicKey != null )
-        {
-            Signature signature = Signature.getInstance( "SHA256withRSA" );
-            signature.initVerify( getPubkey( publicKey.getKey() ) );
-
-            signature.update( request.getVerifyToken() );
-            signature.update( Longs.toByteArray( resp.getEncryptionData().getSalt() ) );
-
-            return signature.verify( resp.getEncryptionData().getSignature() );
-        } else
-        {
-            Cipher cipher = Cipher.getInstance( "RSA" );
-            cipher.init( Cipher.DECRYPT_MODE, keys.getPrivate() );
-            byte[] decrypted = cipher.doFinal( resp.getVerifyToken() );
-
-            return Arrays.equals( request.getVerifyToken(), decrypted );
-        }
-    }
-
     public static SecretKey getSecret(EncryptionResponse resp, EncryptionRequest request) throws GeneralSecurityException
     {
         Cipher cipher = Cipher.getInstance( "RSA" );
+        cipher.init( Cipher.DECRYPT_MODE, keys.getPrivate() );
+        byte[] decrypted = cipher.doFinal( resp.getVerifyToken() );
+
+        if ( !Arrays.equals( request.getVerifyToken(), decrypted ) )
+        {
+            throw new IllegalStateException( "Key pairs do not match!" );
+        }
+
         cipher.init( Cipher.DECRYPT_MODE, keys.getPrivate() );
         return new SecretKeySpec( cipher.doFinal( resp.getSharedSecret() ), "AES" );
     }
@@ -135,12 +80,7 @@ public class EncryptionUtil
 
     public static PublicKey getPubkey(EncryptionRequest request) throws GeneralSecurityException
     {
-        return getPubkey( request.getPublicKey() );
-    }
-
-    private static PublicKey getPubkey(byte[] b) throws GeneralSecurityException
-    {
-        return KeyFactory.getInstance( "RSA" ).generatePublic( new X509EncodedKeySpec( b ) );
+        return KeyFactory.getInstance( "RSA" ).generatePublic( new X509EncodedKeySpec( request.getPublicKey() ) );
     }
 
     public static byte[] encrypt(Key key, byte[] b) throws GeneralSecurityException

proxy/src/main/java/net/md_5/bungee/ServerConnector.java

@@ -1,11 +1,9 @@
 package net.md_5.bungee;
 
-import com.google.common.base.Joiner;
 import com.google.common.base.Preconditions;
 import io.netty.buffer.ByteBuf;
 import io.netty.buffer.ByteBufAllocator;
 import java.net.InetSocketAddress;
-import java.nio.charset.StandardCharsets;
 import java.util.Locale;
 import java.util.Queue;
 import java.util.Set;
@@ -43,8 +41,6 @@ import net.md_5.bungee.protocol.packet.GameState;
 import net.md_5.bungee.protocol.packet.Handshake;
 import net.md_5.bungee.protocol.packet.Kick;
 import net.md_5.bungee.protocol.packet.Login;
-import net.md_5.bungee.protocol.packet.LoginPayloadRequest;
-import net.md_5.bungee.protocol.packet.LoginPayloadResponse;
 import net.md_5.bungee.protocol.packet.LoginRequest;
 import net.md_5.bungee.protocol.packet.LoginSuccess;
 import net.md_5.bungee.protocol.packet.PluginMessage;
@@ -53,7 +49,6 @@ import net.md_5.bungee.protocol.packet.ScoreboardObjective;
 import net.md_5.bungee.protocol.packet.ScoreboardScore;
 import net.md_5.bungee.protocol.packet.SetCompression;
 import net.md_5.bungee.protocol.packet.ViewDistance;
-import net.md_5.bungee.util.AddressUtil;
 import net.md_5.bungee.util.BufUtil;
 import net.md_5.bungee.util.QuietException;
 
@@ -105,7 +100,7 @@ public class ServerConnector extends PacketHandler
 
         if ( BungeeCord.getInstance().config.isIpForward() && user.getSocketAddress() instanceof InetSocketAddress )
         {
-            String newHost = copiedHandshake.getHost() + "\00" + AddressUtil.sanitizeAddress( user.getAddress() ) + "\00" + user.getUUID();
+            String newHost = copiedHandshake.getHost() + "\00" + user.getAddress().getHostString() + "\00" + user.getUUID();
 
             LoginResult profile = user.getPendingConnection().getLoginProfile();
             if ( profile != null && profile.getProperties() != null && profile.getProperties().length > 0 )
@@ -123,7 +118,7 @@ public class ServerConnector extends PacketHandler
         channel.write( copiedHandshake );
 
         channel.setProtocol( Protocol.LOGIN );
-        channel.write( new LoginRequest( user.getName(), null, user.getUniqueId() ) );
+        channel.write( new LoginRequest( user.getName() ) );
     }
 
     @Override
@@ -195,16 +190,9 @@ public class ServerConnector extends PacketHandler
             }
         }
 
-        PluginMessage brandMessage = user.getPendingConnection().getBrandMessage();
-        if ( brandMessage != null )
+        for ( PluginMessage message : user.getPendingConnection().getRelayMessages() )
         {
-            ch.write( brandMessage );
-        }
-
-        Set<String> registeredChannels = user.getPendingConnection().getRegisteredChannels();
-        if ( !registeredChannels.isEmpty() )
-        {
-            ch.write( new PluginMessage( user.getPendingConnection().getVersion() >= ProtocolConstants.MINECRAFT_1_13 ? "minecraft:register" : "REGISTER", Joiner.on( "\0" ).join( registeredChannels ).getBytes( StandardCharsets.UTF_8 ), false ) );
+            ch.write( message );
         }
 
         if ( user.getSettings() != null )
@@ -225,7 +213,7 @@ public class ServerConnector extends PacketHandler
 
             // Set tab list size, TODO: what shall we do about packet mutability
             Login modLogin = new Login( login.getEntityId(), login.isHardcore(), login.getGameMode(), login.getPreviousGameMode(), login.getWorldNames(), login.getDimensions(), login.getDimension(), login.getWorldName(), login.getSeed(), login.getDifficulty(),
-                    (byte) user.getPendingConnection().getListener().getTabListSize(), login.getLevelType(), login.getViewDistance(), login.getSimulationDistance(), login.isReducedDebugInfo(), login.isNormalRespawn(), login.isDebug(), login.isFlat(), login.getDeathLocation() );
+                    (byte) user.getPendingConnection().getListener().getTabListSize(), login.getLevelType(), login.getViewDistance(), login.isReducedDebugInfo(), login.isNormalRespawn(), login.isDebug(), login.isFlat() );
 
             user.unsafe().sendPacket( modLogin );
 
@@ -243,7 +231,7 @@ public class ServerConnector extends PacketHandler
                 }
                 user.getSentBossBars().clear();
 
-                user.unsafe().sendPacket( new Respawn( login.getDimension(), login.getWorldName(), login.getSeed(), login.getDifficulty(), login.getGameMode(), login.getPreviousGameMode(), login.getLevelType(), login.isDebug(), login.isFlat(), false, login.getDeathLocation() ) );
+                user.unsafe().sendPacket( new Respawn( login.getDimension(), login.getWorldName(), login.getSeed(), login.getDifficulty(), login.getGameMode(), login.getPreviousGameMode(), login.getLevelType(), login.isDebug(), login.isFlat(), false ) );
                 user.getServer().disconnect( "Quitting" );
             } else
             {
@@ -292,11 +280,11 @@ public class ServerConnector extends PacketHandler
             user.setDimensionChange( true );
             if ( login.getDimension() == user.getDimension() )
             {
-                user.unsafe().sendPacket( new Respawn( (Integer) login.getDimension() >= 0 ? -1 : 0, login.getWorldName(), login.getSeed(), login.getDifficulty(), login.getGameMode(), login.getPreviousGameMode(), login.getLevelType(), login.isDebug(), login.isFlat(), false, login.getDeathLocation() ) );
+                user.unsafe().sendPacket( new Respawn( (Integer) login.getDimension() >= 0 ? -1 : 0, login.getWorldName(), login.getSeed(), login.getDifficulty(), login.getGameMode(), login.getPreviousGameMode(), login.getLevelType(), login.isDebug(), login.isFlat(), false ) );
             }
 
             user.setServerEntityId( login.getEntityId() );
-            user.unsafe().sendPacket( new Respawn( login.getDimension(), login.getWorldName(), login.getSeed(), login.getDifficulty(), login.getGameMode(), login.getPreviousGameMode(), login.getLevelType(), login.isDebug(), login.isFlat(), false, login.getDeathLocation() ) );
+            user.unsafe().sendPacket( new Respawn( login.getDimension(), login.getWorldName(), login.getSeed(), login.getDifficulty(), login.getGameMode(), login.getPreviousGameMode(), login.getLevelType(), login.isDebug(), login.isFlat(), false ) );
             if ( user.getPendingConnection().getVersion() >= ProtocolConstants.MINECRAFT_1_14 )
             {
                 user.unsafe().sendPacket( new ViewDistance( login.getViewDistance() ) );
@@ -418,12 +406,6 @@ public class ServerConnector extends PacketHandler
         user.unsafe().sendPacket( pluginMessage );
     }
 
-    @Override
-    public void handle(LoginPayloadRequest loginPayloadRequest)
-    {
-        ch.write( new LoginPayloadResponse( loginPayloadRequest.getId(), null ) );
-    }
-
     @Override
     public String toString()
     {

proxy/src/main/java/net/md_5/bungee/UserConnection.java

@@ -59,7 +59,6 @@ import net.md_5.bungee.protocol.packet.Kick;
 import net.md_5.bungee.protocol.packet.PlayerListHeaderFooter;
 import net.md_5.bungee.protocol.packet.PluginMessage;
 import net.md_5.bungee.protocol.packet.SetCompression;
-import net.md_5.bungee.protocol.packet.SystemChat;
 import net.md_5.bungee.tab.ServerUnique;
 import net.md_5.bungee.tab.TabList;
 import net.md_5.bungee.util.CaseInsensitiveSet;
@@ -349,10 +348,10 @@ public final class UserConnection implements ProxiedPlayer
                         connect( def, null, true, ServerConnectEvent.Reason.LOBBY_FALLBACK );
                     } else if ( dimensionChange )
                     {
-                        disconnect( bungee.getTranslation( "fallback_kick", connectionFailMessage( future.cause() ) ) );
+                        disconnect( bungee.getTranslation( "fallback_kick", future.cause().getClass().getName() ) );
                     } else
                     {
-                        sendMessage( bungee.getTranslation( "fallback_kick", connectionFailMessage( future.cause() ) ) );
+                        sendMessage( bungee.getTranslation( "fallback_kick", future.cause().getClass().getName() ) );
                     }
                 }
             }
@@ -371,11 +370,6 @@ public final class UserConnection implements ProxiedPlayer
         b.connect().addListener( listener );
     }
 
-    private String connectionFailMessage(Throwable cause)
-    {
-        return groups.contains( "admin" ) ? Util.exception( cause, false ) : cause.getClass().getName();
-    }
-
     @Override
     public void disconnect(String reason)
     {
@@ -417,10 +411,6 @@ public final class UserConnection implements ProxiedPlayer
     public void chat(String message)
     {
         Preconditions.checkState( server != null, "Not connected to server" );
-        if ( getPendingConnection().getVersion() >= ProtocolConstants.MINECRAFT_1_19 )
-        {
-            throw new UnsupportedOperationException( "Cannot spoof chat on this client version!" );
-        }
         server.getCh().write( new Chat( message ) );
     }
 
@@ -477,19 +467,7 @@ public final class UserConnection implements ProxiedPlayer
 
     private void sendMessage(ChatMessageType position, UUID sender, String message)
     {
-        if ( getPendingConnection().getVersion() >= ProtocolConstants.MINECRAFT_1_19 )
-        {
-            // Align with Spigot and remove client side formatting for now
-            if ( position == ChatMessageType.CHAT )
-            {
-                position = ChatMessageType.SYSTEM;
-            }
-
-            unsafe().sendPacket( new SystemChat( message, position.ordinal() ) );
-        } else
-        {
-            unsafe().sendPacket( new Chat( message, (byte) position.ordinal(), sender ) );
-        }
+        unsafe().sendPacket( new Chat( message, (byte) position.ordinal(), sender ) );
     }
 
     private void sendMessage(ChatMessageType position, UUID sender, BaseComponent... message)
@@ -497,7 +475,7 @@ public final class UserConnection implements ProxiedPlayer
         // transform score components
         message = ChatComponentTransformer.getInstance().transform( this, true, message );
 
-        if ( position == ChatMessageType.ACTION_BAR && getPendingConnection().getVersion() < ProtocolConstants.MINECRAFT_1_17 )
+        if ( position == ChatMessageType.ACTION_BAR )
         {
             // Versions older than 1.11 cannot send the Action bar with the new JSON formattings
             // Fix by converting to a legacy message, see https://bugs.mojang.com/browse/MC-119145

proxy/src/main/java/net/md_5/bungee/command/CommandEnd.java

@@ -2,7 +2,6 @@ package net.md_5.bungee.command;
 
 import com.google.common.base.Joiner;
 import net.md_5.bungee.BungeeCord;
-import net.md_5.bungee.api.ChatColor;
 import net.md_5.bungee.api.CommandSender;
 import net.md_5.bungee.api.plugin.Command;
 
@@ -26,7 +25,7 @@ public class CommandEnd extends Command
             BungeeCord.getInstance().stop();
         } else
         {
-            BungeeCord.getInstance().stop( ChatColor.translateAlternateColorCodes( '&', Joiner.on( ' ' ).join( args ) ) );
+            BungeeCord.getInstance().stop( Joiner.on( ' ' ).join( args ) );
         }
     }
 }

proxy/src/main/java/net/md_5/bungee/command/ConsoleCommandCompleter.java

@@ -2,9 +2,6 @@ package net.md_5.bungee.command;
 
 import java.util.ArrayList;
 import java.util.List;
-import java.util.Locale;
-import java.util.Map;
-import java.util.stream.Collectors;
 import jline.console.completer.Completer;
 import lombok.RequiredArgsConstructor;
 import net.md_5.bungee.api.ProxyServer;
@@ -18,21 +15,11 @@ public class ConsoleCommandCompleter implements Completer
     @Override
     public int complete(String buffer, int cursor, List<CharSequence> candidates)
     {
-        int lastSpace = buffer.lastIndexOf( ' ' );
-        if ( lastSpace == -1 )
-        {
-            String lowerCase = buffer.toLowerCase( Locale.ROOT );
-            candidates.addAll( proxy.getPluginManager().getCommands().stream()
-                    .map( Map.Entry::getKey )
-                    .filter( (name) -> name.toLowerCase( Locale.ROOT ).startsWith( lowerCase ) )
-                    .collect( Collectors.toList() ) );
-        } else
-        {
-            List<String> suggestions = new ArrayList<>();
-            proxy.getPluginManager().dispatchCommand( proxy.getConsole(), buffer, suggestions );
-            candidates.addAll( suggestions );
-        }
+        List<String> suggestions = new ArrayList<>();
+        proxy.getPluginManager().dispatchCommand( proxy.getConsole(), buffer, suggestions );
+        candidates.addAll( suggestions );
 
+        int lastSpace = buffer.lastIndexOf( ' ' );
         return ( lastSpace == -1 ) ? cursor - buffer.length() : cursor - ( buffer.length() - lastSpace - 1 );
     }
 }

proxy/src/main/java/net/md_5/bungee/compress/CompressFactory.java

@@ -8,5 +8,5 @@ import net.md_5.bungee.jni.zlib.NativeZlib;
 public class CompressFactory
 {
 
-    public static final NativeCode<BungeeZlib> zlib = new NativeCode<>( "native-compress", JavaZlib::new, NativeZlib::new );
+    public static final NativeCode<BungeeZlib> zlib = new NativeCode<>( "native-compress", JavaZlib.class, NativeZlib.class );
 }

proxy/src/main/java/net/md_5/bungee/compress/PacketDecompressor.java

@@ -31,7 +31,8 @@ public class PacketDecompressor extends MessageToMessageDecoder<ByteBuf>
         int size = DefinedPacket.readVarInt( in );
         if ( size == 0 )
         {
-            out.add( in.retain() );
+            out.add( in.slice().retain() );
+            in.skipBytes( in.readableBytes() );
         } else
         {
             ByteBuf decompressed = ctx.alloc().directBuffer();

proxy/src/main/java/net/md_5/bungee/conf/Configuration.java

@@ -47,10 +47,6 @@ public class Configuration implements ProxyConfig
      * Should we check minecraft.net auth.
      */
     private boolean onlineMode = true;
-    /**
-     * Whether to check the authentication server public key.
-     */
-    private boolean enforceSecureProfile;
     /**
      * Whether we log proxy commands to the proxy log
      */
@@ -90,7 +86,6 @@ public class Configuration implements ProxyConfig
         timeout = adapter.getInt( "timeout", timeout );
         uuid = adapter.getString( "stats", uuid );
         onlineMode = adapter.getBoolean( "online_mode", onlineMode );
-        enforceSecureProfile = adapter.getBoolean( "enforce_secure_profile", enforceSecureProfile );
         logCommands = adapter.getBoolean( "log_commands", logCommands );
         logPings = adapter.getBoolean( "log_pings", logPings );
         remotePingCache = adapter.getInt( "remote_ping_cache", remotePingCache );