PandacubeFr/PandaLib
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't call System.exit() from shutdown hook thread

Browse Source
This commit is contained in:
Marc Baloup 2023-10-08 01:02:14 +02:00
parent 8b6fe63df1
commit 728961d19f
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pandalib-cli/src/main/java/fr/pandacube/lib/cli/CLIApplication.java
View File

@ -52,7 +52,7 @@ public abstract class CLIApplication {
new CommandAdmin();
new CommandStop();
Runtime.getRuntime().addShutdownHook(new Thread(this::stop));
Runtime.getRuntime().addShutdownHook(shutdownThread);
cli.start(); // actually starts the CLI thread
@ -71,12 +71,13 @@ public abstract class CLIApplication {
}
private final Thread shutdownThread = new Thread(this::stop);
private final AtomicBoolean stopping = new AtomicBoolean(false);
/**
* Stops this application.
*/
@SuppressWarnings("finally")
public final void stop() {
synchronized (stopping) {
if (stopping.get())
@ -88,10 +89,10 @@ public abstract class CLIApplication {
end();
} catch (Throwable t) {
Log.severe("Error stopping application " + getName() + " version " + getClass().getPackage().getImplementationVersion(), t);
System.exit(1);
} finally {
Log.info("Bye bye.");
System.exit(0);
if (!Thread.currentThread().equals(shutdownThread))
System.exit(0);
}
}